Mercurial > hg > truffle
annotate src/share/vm/opto/locknode.hpp @ 452:00b023ae2d78
6722113: CMS: Incorrect overflow handling during precleaning of Reference lists
Summary: When we encounter marking stack overflow during precleaning of Reference lists, we were using the overflow list mechanism, which can cause problems on account of mutating the mark word of the header because of conflicts with mutator accesses and updates of that field. Instead we should use the usual mechanism for overflow handling in concurrent phases, namely dirtying of the card on which the overflowed object lies. Since precleaning effectively does a form of discovered list processing, albeit with discovery enabled, we needed to adjust some code to be correct in the face of interleaved processing and discovery.
Reviewed-by: apetrusenko, jcoomes
| author | ysr |
|---|---|
| date | Thu, 20 Nov 2008 12:27:41 -0800 |
| parents | d1605aabd0a1 |
| children | 424f9bfe6b96 |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 196 | 2 * Copyright 1999-2008 Sun Microsystems, Inc. All Rights Reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
| 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, | |
| 20 * CA 95054 USA or visit www.sun.com if you need additional information or | |
| 21 * have any questions. | |
| 22 * | |
| 23 */ | |
| 24 | |
| 25 //------------------------------BoxLockNode------------------------------------ | |
| 26 class BoxLockNode : public Node { | |
| 27 public: | |
| 28 const int _slot; | |
| 29 RegMask _inmask; | |
|
66
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
30 bool _is_eliminated; // indicates this lock was safely eliminated |
| 0 | 31 |
| 32 BoxLockNode( int lock ); | |
| 33 virtual int Opcode() const; | |
| 34 virtual void emit(CodeBuffer &cbuf, PhaseRegAlloc *ra_) const; | |
| 35 virtual uint size(PhaseRegAlloc *ra_) const; | |
| 36 virtual const RegMask &in_RegMask(uint) const; | |
| 37 virtual const RegMask &out_RegMask() const; | |
| 38 virtual uint size_of() const; | |
| 39 virtual uint hash() const { return Node::hash() + _slot; } | |
| 40 virtual uint cmp( const Node &n ) const; | |
| 41 virtual const class Type *bottom_type() const { return TypeRawPtr::BOTTOM; } | |
| 42 virtual uint ideal_reg() const { return Op_RegP; } | |
| 43 | |
| 44 static OptoReg::Name stack_slot(Node* box_node); | |
| 45 | |
|
66
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
46 bool is_eliminated() { return _is_eliminated; } |
|
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
47 // mark lock as eliminated. |
|
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
48 void set_eliminated() { _is_eliminated = true; } |
|
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
49 |
| 0 | 50 #ifndef PRODUCT |
| 51 virtual void format( PhaseRegAlloc *, outputStream *st ) const; | |
| 52 virtual void dump_spec(outputStream *st) const { st->print(" Lock %d",_slot); } | |
| 53 #endif | |
| 54 }; | |
| 55 | |
| 56 //------------------------------FastLockNode----------------------------------- | |
| 57 class FastLockNode: public CmpNode { | |
| 58 private: | |
| 59 BiasedLockingCounters* _counters; | |
| 60 | |
| 61 public: | |
| 62 FastLockNode(Node *ctrl, Node *oop, Node *box) : CmpNode(oop,box) { | |
| 63 init_req(0,ctrl); | |
| 64 init_class_id(Class_FastLock); | |
| 65 _counters = NULL; | |
| 66 } | |
| 67 Node* obj_node() const { return in(1); } | |
| 68 Node* box_node() const { return in(2); } | |
| 69 | |
| 70 // FastLock and FastUnlockNode do not hash, we need one for each correspoding | |
| 71 // LockNode/UnLockNode to avoid creating Phi's. | |
| 72 virtual uint hash() const ; // { return NO_HASH; } | |
| 73 virtual uint cmp( const Node &n ) const ; // Always fail, except on self | |
| 74 virtual int Opcode() const; | |
| 75 virtual const Type *Value( PhaseTransform *phase ) const { return TypeInt::CC; } | |
| 76 const Type *sub(const Type *t1, const Type *t2) const { return TypeInt::CC;} | |
| 77 | |
| 78 void create_lock_counter(JVMState* s); | |
| 79 BiasedLockingCounters* counters() const { return _counters; } | |
| 80 }; | |
| 81 | |
| 82 | |
| 83 //------------------------------FastUnlockNode--------------------------------- | |
| 84 class FastUnlockNode: public CmpNode { | |
| 85 public: | |
| 86 FastUnlockNode(Node *ctrl, Node *oop, Node *box) : CmpNode(oop,box) { | |
| 87 init_req(0,ctrl); | |
| 88 init_class_id(Class_FastUnlock); | |
| 89 } | |
| 90 Node* obj_node() const { return in(1); } | |
| 91 Node* box_node() const { return in(2); } | |
| 92 | |
| 93 | |
| 94 // FastLock and FastUnlockNode do not hash, we need one for each correspoding | |
| 95 // LockNode/UnLockNode to avoid creating Phi's. | |
| 96 virtual uint hash() const ; // { return NO_HASH; } | |
| 97 virtual uint cmp( const Node &n ) const ; // Always fail, except on self | |
| 98 virtual int Opcode() const; | |
| 99 virtual const Type *Value( PhaseTransform *phase ) const { return TypeInt::CC; } | |
| 100 const Type *sub(const Type *t1, const Type *t2) const { return TypeInt::CC;} | |
| 101 | |
| 102 }; |