Mercurial > hg > truffle
annotate src/share/vm/interpreter/rewriter.cpp @ 7090:05ce1defa4f9
Common out some parts of UnsafeLoad/Store in UnsafeAccess
author | Gilles Duboscq <duboscq@ssw.jku.at> |
---|---|
date | Thu, 29 Nov 2012 13:24:08 +0100 |
parents | e522a00b91aa |
children | 5d0bb7d52783 |
rev | line source |
---|---|
0 | 1 /* |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
2 * Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "interpreter/bytecodes.hpp" | |
27 #include "interpreter/interpreter.hpp" | |
28 #include "interpreter/rewriter.hpp" | |
29 #include "memory/gcLocker.hpp" | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
30 #include "memory/metadataFactory.hpp" |
1972 | 31 #include "memory/oopFactory.hpp" |
32 #include "memory/resourceArea.hpp" | |
33 #include "oops/generateOopMap.hpp" | |
34 #include "oops/objArrayOop.hpp" | |
35 #include "oops/oop.inline.hpp" | |
36 #include "prims/methodComparator.hpp" | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
37 #include "prims/methodHandles.hpp" |
0 | 38 |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
39 // Computes a CPC map (new_index -> original_index) for constant pool entries |
0 | 40 // that are referred to by the interpreter at runtime via the constant pool cache. |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
41 // Also computes a CP map (original_index -> new_index). |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
42 // Marks entries in CP which require additional processing. |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
43 void Rewriter::compute_index_maps() { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
44 const int length = _pool->length(); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
45 init_maps(length); |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
46 bool saw_mh_symbol = false; |
0 | 47 for (int i = 0; i < length; i++) { |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
48 int tag = _pool->tag_at(i).value(); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
49 switch (tag) { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
50 case JVM_CONSTANT_InterfaceMethodref: |
0 | 51 case JVM_CONSTANT_Fieldref : // fall through |
52 case JVM_CONSTANT_Methodref : // fall through | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
53 add_cp_cache_entry(i); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
54 break; |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
55 case JVM_CONSTANT_String: |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
56 case JVM_CONSTANT_Object: |
1602 | 57 case JVM_CONSTANT_MethodHandle : // fall through |
58 case JVM_CONSTANT_MethodType : // fall through | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
59 add_resolved_references_entry(i); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
60 break; |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
61 case JVM_CONSTANT_Utf8: |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
62 if (_pool->symbol_at(i) == vmSymbols::java_lang_invoke_MethodHandle()) |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
63 saw_mh_symbol = true; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
64 break; |
0 | 65 } |
66 } | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
67 |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
68 // Record limits of resolved reference map for constant pool cache indices |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
69 record_map_limits(); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
70 |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
71 guarantee((int)_cp_cache_map.length()-1 <= (int)((u2)-1), |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
72 "all cp cache indexes fit in a u2"); |
1660
083fde3b838e
6964498: JSR 292 invokedynamic sites need local bootstrap methods
jrose
parents:
1602
diff
changeset
|
73 |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
74 if (saw_mh_symbol) |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
75 _method_handle_invokers.initialize(length, (int)0); |
0 | 76 } |
77 | |
3404 | 78 // Unrewrite the bytecodes if an error occurs. |
79 void Rewriter::restore_bytecodes() { | |
80 int len = _methods->length(); | |
81 | |
82 for (int i = len-1; i >= 0; i--) { | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
83 Method* method = _methods->at(i); |
3404 | 84 scan_method(method, true); |
85 } | |
86 } | |
0 | 87 |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
88 // Creates a constant pool cache given a CPC map |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
89 void Rewriter::make_constant_pool_cache(TRAPS) { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
90 const int length = _cp_cache_map.length(); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
91 ClassLoaderData* loader_data = _pool->pool_holder()->class_loader_data(); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
92 ConstantPoolCache* cache = |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
93 ConstantPoolCache::allocate(loader_data, length, CHECK); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
94 |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
95 // initialize object cache in constant pool |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
96 _pool->initialize_resolved_references(loader_data, _resolved_references_map, |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
97 _resolved_reference_limit, |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
98 CHECK); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
99 |
2226
c5a923563727
6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1),"Missing Printezis bit?")
ysr
parents:
2142
diff
changeset
|
100 No_Safepoint_Verifier nsv; |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
101 cache->initialize(_cp_cache_map, _invokedynamic_references_map); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
102 _pool->set_cache(cache); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
103 cache->set_constant_pool(_pool()); |
0 | 104 } |
105 | |
106 | |
107 | |
108 // The new finalization semantics says that registration of | |
109 // finalizable objects must be performed on successful return from the | |
110 // Object.<init> constructor. We could implement this trivially if | |
111 // <init> were never rewritten but since JVMTI allows this to occur, a | |
112 // more complicated solution is required. A special return bytecode | |
113 // is used only by Object.<init> to signal the finalization | |
114 // registration point. Additionally local 0 must be preserved so it's | |
115 // available to pass to the registration function. For simplicty we | |
116 // require that local 0 is never overwritten so it's available as an | |
117 // argument for registration. | |
118 | |
119 void Rewriter::rewrite_Object_init(methodHandle method, TRAPS) { | |
120 RawBytecodeStream bcs(method); | |
121 while (!bcs.is_last_bytecode()) { | |
122 Bytecodes::Code opcode = bcs.raw_next(); | |
123 switch (opcode) { | |
4559
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
124 case Bytecodes::_return: |
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
125 #ifndef GRAAL |
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
126 *bcs.bcp() = Bytecodes::_return_register_finalizer; |
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
127 #endif |
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
128 break; |
0 | 129 |
130 case Bytecodes::_istore: | |
131 case Bytecodes::_lstore: | |
132 case Bytecodes::_fstore: | |
133 case Bytecodes::_dstore: | |
134 case Bytecodes::_astore: | |
135 if (bcs.get_index() != 0) continue; | |
136 | |
137 // fall through | |
138 case Bytecodes::_istore_0: | |
139 case Bytecodes::_lstore_0: | |
140 case Bytecodes::_fstore_0: | |
141 case Bytecodes::_dstore_0: | |
142 case Bytecodes::_astore_0: | |
143 THROW_MSG(vmSymbols::java_lang_IncompatibleClassChangeError(), | |
144 "can't overwrite local 0 in Object.<init>"); | |
145 break; | |
146 } | |
147 } | |
148 } | |
149 | |
150 | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
151 // Rewrite a classfile-order CP index into a native-order CPC index. |
3404 | 152 void Rewriter::rewrite_member_reference(address bcp, int offset, bool reverse) { |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
153 address p = bcp + offset; |
3404 | 154 if (!reverse) { |
155 int cp_index = Bytes::get_Java_u2(p); | |
156 int cache_index = cp_entry_to_cp_cache(cp_index); | |
157 Bytes::put_native_u2(p, cache_index); | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
158 if (!_method_handle_invokers.is_empty()) |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
159 maybe_rewrite_invokehandle(p - 1, cp_index, cache_index, reverse); |
3404 | 160 } else { |
161 int cache_index = Bytes::get_native_u2(p); | |
162 int pool_index = cp_cache_entry_pool_index(cache_index); | |
163 Bytes::put_Java_u2(p, pool_index); | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
164 if (!_method_handle_invokers.is_empty()) |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
165 maybe_rewrite_invokehandle(p - 1, pool_index, cache_index, reverse); |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
166 } |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
167 } |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
168 |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
169 |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
170 // Adjust the invocation bytecode for a signature-polymorphic method (MethodHandle.invoke, etc.) |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
171 void Rewriter::maybe_rewrite_invokehandle(address opc, int cp_index, int cache_index, bool reverse) { |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
172 if (!reverse) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
173 if ((*opc) == (u1)Bytecodes::_invokevirtual || |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
174 // allow invokespecial as an alias, although it would be very odd: |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
175 (*opc) == (u1)Bytecodes::_invokespecial) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
176 assert(_pool->tag_at(cp_index).is_method(), "wrong index"); |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
177 // Determine whether this is a signature-polymorphic method. |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
178 if (cp_index >= _method_handle_invokers.length()) return; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
179 int status = _method_handle_invokers[cp_index]; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
180 assert(status >= -1 && status <= 1, "oob tri-state"); |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
181 if (status == 0) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
182 if (_pool->klass_ref_at_noresolve(cp_index) == vmSymbols::java_lang_invoke_MethodHandle() && |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
183 MethodHandles::is_signature_polymorphic_name(SystemDictionary::MethodHandle_klass(), |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
184 _pool->name_ref_at(cp_index))) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
185 // we may need a resolved_refs entry for the appendix |
6822
f6b0eb4e44cf
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
6725
diff
changeset
|
186 add_invokedynamic_resolved_references_entries(cp_index, cache_index); |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
187 status = +1; |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
188 } else { |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
189 status = -1; |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
190 } |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
191 _method_handle_invokers[cp_index] = status; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
192 } |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
193 // We use a special internal bytecode for such methods (if non-static). |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
194 // The basic reason for this is that such methods need an extra "appendix" argument |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
195 // to transmit the call site's intended call type. |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
196 if (status > 0) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
197 (*opc) = (u1)Bytecodes::_invokehandle; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
198 } |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
199 } |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
200 } else { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
201 // Do not need to look at cp_index. |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
202 if ((*opc) == (u1)Bytecodes::_invokehandle) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
203 (*opc) = (u1)Bytecodes::_invokevirtual; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
204 // Ignore corner case of original _invokespecial instruction. |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
205 // This is safe because (a) the signature polymorphic method was final, and |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
206 // (b) the implementation of MethodHandle will not call invokespecial on it. |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
207 } |
3404 | 208 } |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
209 } |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
210 |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
211 |
3404 | 212 void Rewriter::rewrite_invokedynamic(address bcp, int offset, bool reverse) { |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
213 address p = bcp + offset; |
3404 | 214 assert(p[-1] == Bytecodes::_invokedynamic, "not invokedynamic bytecode"); |
215 if (!reverse) { | |
216 int cp_index = Bytes::get_Java_u2(p); | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
217 int cache_index = add_invokedynamic_cp_cache_entry(cp_index); |
6822
f6b0eb4e44cf
7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path
twisti
parents:
6725
diff
changeset
|
218 add_invokedynamic_resolved_references_entries(cp_index, cache_index); |
3404 | 219 // Replace the trailing four bytes with a CPC index for the dynamic |
220 // call site. Unlike other CPC entries, there is one per bytecode, | |
221 // not just one per distinct CP entry. In other words, the | |
222 // CPC-to-CP relation is many-to-one for invokedynamic entries. | |
223 // This means we must use a larger index size than u2 to address | |
224 // all these entries. That is the main reason invokedynamic | |
225 // must have a five-byte instruction format. (Of course, other JVM | |
226 // implementations can use the bytes for other purposes.) | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
227 Bytes::put_native_u4(p, ConstantPool::encode_invokedynamic_index(cache_index)); |
3404 | 228 // Note: We use native_u4 format exclusively for 4-byte indexes. |
229 } else { | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
230 // callsite index |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
231 int cache_index = ConstantPool::decode_invokedynamic_index( |
3404 | 232 Bytes::get_native_u4(p)); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
233 int cp_index = cp_cache_entry_pool_index(cache_index); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
234 assert(_pool->tag_at(cp_index).is_invoke_dynamic(), "wrong index"); |
3404 | 235 // zero out 4 bytes |
236 Bytes::put_Java_u4(p, 0); | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
237 Bytes::put_Java_u2(p, cp_index); |
3404 | 238 } |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
239 } |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
240 |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
241 |
1602 | 242 // Rewrite some ldc bytecodes to _fast_aldc |
3404 | 243 void Rewriter::maybe_rewrite_ldc(address bcp, int offset, bool is_wide, |
244 bool reverse) { | |
245 if (!reverse) { | |
246 assert((*bcp) == (is_wide ? Bytecodes::_ldc_w : Bytecodes::_ldc), "not ldc bytecode"); | |
247 address p = bcp + offset; | |
248 int cp_index = is_wide ? Bytes::get_Java_u2(p) : (u1)(*p); | |
249 constantTag tag = _pool->tag_at(cp_index).value(); | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
250 if (tag.is_method_handle() || tag.is_method_type() || tag.is_string() || tag.is_object()) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
251 int ref_index = cp_entry_to_resolved_references(cp_index); |
3404 | 252 if (is_wide) { |
253 (*bcp) = Bytecodes::_fast_aldc_w; | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
254 assert(ref_index == (u2)ref_index, "index overflow"); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
255 Bytes::put_native_u2(p, ref_index); |
3404 | 256 } else { |
257 (*bcp) = Bytecodes::_fast_aldc; | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
258 assert(ref_index == (u1)ref_index, "index overflow"); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
259 (*p) = (u1)ref_index; |
3404 | 260 } |
261 } | |
262 } else { | |
263 Bytecodes::Code rewritten_bc = | |
264 (is_wide ? Bytecodes::_fast_aldc_w : Bytecodes::_fast_aldc); | |
265 if ((*bcp) == rewritten_bc) { | |
266 address p = bcp + offset; | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
267 int ref_index = is_wide ? Bytes::get_native_u2(p) : (u1)(*p); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
268 int pool_index = resolved_references_entry_to_pool_index(ref_index); |
3404 | 269 if (is_wide) { |
270 (*bcp) = Bytecodes::_ldc_w; | |
271 assert(pool_index == (u2)pool_index, "index overflow"); | |
272 Bytes::put_Java_u2(p, pool_index); | |
273 } else { | |
274 (*bcp) = Bytecodes::_ldc; | |
275 assert(pool_index == (u1)pool_index, "index overflow"); | |
276 (*p) = (u1)pool_index; | |
277 } | |
1602 | 278 } |
279 } | |
280 } | |
281 | |
282 | |
0 | 283 // Rewrites a method given the index_map information |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
284 void Rewriter::scan_method(Method* method, bool reverse) { |
0 | 285 |
286 int nof_jsrs = 0; | |
287 bool has_monitor_bytecodes = false; | |
288 | |
289 { | |
290 // We cannot tolerate a GC in this block, because we've | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
291 // cached the bytecodes in 'code_base'. If the Method* |
0 | 292 // moves, the bytecodes will also move. |
293 No_Safepoint_Verifier nsv; | |
294 Bytecodes::Code c; | |
295 | |
296 // Bytecodes and their length | |
297 const address code_base = method->code_base(); | |
298 const int code_length = method->code_size(); | |
299 | |
300 int bc_length; | |
301 for (int bci = 0; bci < code_length; bci += bc_length) { | |
302 address bcp = code_base + bci; | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
303 int prefix_length = 0; |
0 | 304 c = (Bytecodes::Code)(*bcp); |
305 | |
306 // Since we have the code, see if we can get the length | |
307 // directly. Some more complicated bytecodes will report | |
308 // a length of zero, meaning we need to make another method | |
309 // call to calculate the length. | |
310 bc_length = Bytecodes::length_for(c); | |
311 if (bc_length == 0) { | |
2142 | 312 bc_length = Bytecodes::length_at(method, bcp); |
0 | 313 |
314 // length_at will put us at the bytecode after the one modified | |
315 // by 'wide'. We don't currently examine any of the bytecodes | |
316 // modified by wide, but in case we do in the future... | |
317 if (c == Bytecodes::_wide) { | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
318 prefix_length = 1; |
0 | 319 c = (Bytecodes::Code)bcp[1]; |
320 } | |
321 } | |
322 | |
323 assert(bc_length != 0, "impossible bytecode length"); | |
324 | |
325 switch (c) { | |
326 case Bytecodes::_lookupswitch : { | |
327 #ifndef CC_INTERP | |
4559
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
328 #ifndef GRAAL |
2181 | 329 Bytecode_lookupswitch bc(method, bcp); |
1930 | 330 (*bcp) = ( |
2181 | 331 bc.number_of_pairs() < BinarySwitchThreshold |
1423
760213a60e8b
* rewrite of the code installation
Lukas Stadler <lukas.stadler@oracle.com>
parents:
1138
diff
changeset
|
332 ? Bytecodes::_fast_linearswitch |
760213a60e8b
* rewrite of the code installation
Lukas Stadler <lukas.stadler@oracle.com>
parents:
1138
diff
changeset
|
333 : Bytecodes::_fast_binaryswitch |
760213a60e8b
* rewrite of the code installation
Lukas Stadler <lukas.stadler@oracle.com>
parents:
1138
diff
changeset
|
334 ); |
4559
723df37192d6
Make it possible again to build a real client libjvm, drop the UseGraal flag.
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
4138
diff
changeset
|
335 #endif |
0 | 336 #endif |
337 break; | |
338 } | |
3404 | 339 case Bytecodes::_fast_linearswitch: |
340 case Bytecodes::_fast_binaryswitch: { | |
341 #ifndef CC_INTERP | |
342 (*bcp) = Bytecodes::_lookupswitch; | |
343 #endif | |
344 break; | |
345 } | |
0 | 346 case Bytecodes::_getstatic : // fall through |
347 case Bytecodes::_putstatic : // fall through | |
348 case Bytecodes::_getfield : // fall through | |
349 case Bytecodes::_putfield : // fall through | |
350 case Bytecodes::_invokevirtual : // fall through | |
351 case Bytecodes::_invokespecial : // fall through | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
352 case Bytecodes::_invokestatic : |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
353 case Bytecodes::_invokeinterface: |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
354 case Bytecodes::_invokehandle : // if reverse=true |
3404 | 355 rewrite_member_reference(bcp, prefix_length+1, reverse); |
0 | 356 break; |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
357 case Bytecodes::_invokedynamic: |
3404 | 358 rewrite_invokedynamic(bcp, prefix_length+1, reverse); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
359 break; |
1602 | 360 case Bytecodes::_ldc: |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
361 case Bytecodes::_fast_aldc: // if reverse=true |
3404 | 362 maybe_rewrite_ldc(bcp, prefix_length+1, false, reverse); |
1602 | 363 break; |
364 case Bytecodes::_ldc_w: | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
3404
diff
changeset
|
365 case Bytecodes::_fast_aldc_w: // if reverse=true |
3404 | 366 maybe_rewrite_ldc(bcp, prefix_length+1, true, reverse); |
1602 | 367 break; |
0 | 368 case Bytecodes::_jsr : // fall through |
369 case Bytecodes::_jsr_w : nof_jsrs++; break; | |
370 case Bytecodes::_monitorenter : // fall through | |
371 case Bytecodes::_monitorexit : has_monitor_bytecodes = true; break; | |
372 } | |
373 } | |
374 } | |
375 | |
376 // Update access flags | |
377 if (has_monitor_bytecodes) { | |
378 method->set_has_monitor_bytecodes(); | |
379 } | |
380 | |
381 // The present of a jsr bytecode implies that the method might potentially | |
382 // have to be rewritten, so we run the oopMapGenerator on the method | |
383 if (nof_jsrs > 0) { | |
384 method->set_has_jsrs(); | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
385 // Second pass will revisit this method. |
3404 | 386 assert(method->has_jsrs(), "didn't we just set this?"); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
387 } |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
388 } |
0 | 389 |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
390 // After constant pool is created, revisit methods containing jsrs. |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
391 methodHandle Rewriter::rewrite_jsrs(methodHandle method, TRAPS) { |
3404 | 392 ResourceMark rm(THREAD); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
393 ResolveOopMapConflicts romc(method); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
394 methodHandle original_method = method; |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
395 method = romc.do_potential_rewrite(CHECK_(methodHandle())); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
396 // Update monitor matching info. |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
397 if (romc.monitor_safe()) { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
398 method->set_guaranteed_monitor_matching(); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
399 } |
0 | 400 |
401 return method; | |
402 } | |
403 | |
404 void Rewriter::rewrite(instanceKlassHandle klass, TRAPS) { | |
405 ResourceMark rm(THREAD); | |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
406 Rewriter rw(klass, klass->constants(), klass->methods(), CHECK); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
407 // (That's all, folks.) |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
408 } |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
409 |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
410 |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
411 void Rewriter::rewrite(instanceKlassHandle klass, constantPoolHandle cpool, Array<Method*>* methods, TRAPS) { |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
412 ResourceMark rm(THREAD); |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
413 Rewriter rw(klass, cpool, methods, CHECK); |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
414 // (That's all, folks.) |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
415 } |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
416 |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
417 |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
418 Rewriter::Rewriter(instanceKlassHandle klass, constantPoolHandle cpool, Array<Method*>* methods, TRAPS) |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
419 : _klass(klass), |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
420 _pool(cpool), |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1059
diff
changeset
|
421 _methods(methods) |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
422 { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
423 assert(_pool->cache() == NULL, "constant pool cache must not be set yet"); |
0 | 424 |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
425 // determine index maps for Method* rewriting |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
426 compute_index_maps(); |
0 | 427 |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
428 if (RegisterFinalizersAtInit && _klass->name() == vmSymbols::java_lang_Object()) { |
856
75596850f863
6862576: vmIntrinsics needs cleanup in order to support JSR 292 intrinsics
jrose
parents:
726
diff
changeset
|
429 bool did_rewrite = false; |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
430 int i = _methods->length(); |
0 | 431 while (i-- > 0) { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
432 Method* method = _methods->at(i); |
0 | 433 if (method->intrinsic_id() == vmIntrinsics::_Object_init) { |
434 // rewrite the return bytecodes of Object.<init> to register the | |
435 // object for finalization if needed. | |
436 methodHandle m(THREAD, method); | |
437 rewrite_Object_init(m, CHECK); | |
856
75596850f863
6862576: vmIntrinsics needs cleanup in order to support JSR 292 intrinsics
jrose
parents:
726
diff
changeset
|
438 did_rewrite = true; |
0 | 439 break; |
440 } | |
441 } | |
856
75596850f863
6862576: vmIntrinsics needs cleanup in order to support JSR 292 intrinsics
jrose
parents:
726
diff
changeset
|
442 assert(did_rewrite, "must find Object::<init> to rewrite it"); |
0 | 443 } |
444 | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
445 // rewrite methods, in two passes |
3404 | 446 int len = _methods->length(); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
447 |
3404 | 448 for (int i = len-1; i >= 0; i--) { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
449 Method* method = _methods->at(i); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
450 scan_method(method); |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
451 } |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
452 |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
453 // allocate constant pool cache, now that we've seen all the bytecodes |
3404 | 454 make_constant_pool_cache(THREAD); |
455 | |
456 // Restore bytecodes to their unrewritten state if there are exceptions | |
457 // rewriting bytecodes or allocating the cpCache | |
458 if (HAS_PENDING_EXCEPTION) { | |
459 restore_bytecodes(); | |
460 return; | |
461 } | |
462 } | |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
463 |
3404 | 464 // Relocate jsr/rets in a method. This can't be done with the rewriter |
465 // stage because it can throw other exceptions, leaving the bytecodes | |
466 // pointing at constant pool cache entries. | |
467 // Link and check jvmti dependencies while we're iterating over the methods. | |
468 // JSR292 code calls with a different set of methods, so two entry points. | |
469 void Rewriter::relocate_and_link(instanceKlassHandle this_oop, TRAPS) { | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
470 relocate_and_link(this_oop, this_oop->methods(), THREAD); |
3404 | 471 } |
472 | |
473 void Rewriter::relocate_and_link(instanceKlassHandle this_oop, | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
474 Array<Method*>* methods, TRAPS) { |
3404 | 475 int len = methods->length(); |
476 for (int i = len-1; i >= 0; i--) { | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
477 methodHandle m(THREAD, methods->at(i)); |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
478 |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
479 if (m->has_jsrs()) { |
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
480 m = rewrite_jsrs(m, CHECK); |
0 | 481 // Method might have gotten rewritten. |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
482 methods->at_put(i, m()); |
0 | 483 } |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
484 |
3404 | 485 // Set up method entry points for compiler and interpreter . |
726
be93aad57795
6655646: dynamic languages need dynamically linked call sites
jrose
parents:
579
diff
changeset
|
486 m->link_method(m, CHECK); |
1574 | 487 |
3404 | 488 // This is for JVMTI and unrelated to relocator but the last thing we do |
1574 | 489 #ifdef ASSERT |
490 if (StressMethodComparator) { | |
491 static int nmc = 0; | |
492 for (int j = i; j >= 0 && j >= i-4; j--) { | |
493 if ((++nmc % 1000) == 0) tty->print_cr("Have run MethodComparator %d times...", nmc); | |
3404 | 494 bool z = MethodComparator::methods_EMCP(m(), |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
495 methods->at(j)); |
1574 | 496 if (j == i && !z) { |
497 tty->print("MethodComparator FAIL: "); m->print(); m->print_codes(); | |
498 assert(z, "method must compare equal to itself"); | |
499 } | |
500 } | |
501 } | |
502 #endif //ASSERT | |
0 | 503 } |
504 } |