Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/heapRegion.cpp @ 19083:09292c24d555
LSStackSlotAllocator: hide inner class.
author | Josef Eisl <josef.eisl@jku.at> |
---|---|
date | Sat, 31 Jan 2015 11:07:15 +0100 |
parents | 52b4284cb496 |
children | 7848fc12602b |
rev | line source |
---|---|
342 | 1 /* |
17755
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
2 * Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights reserved. |
342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
21 * questions. |
342 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
12080 | 26 #include "code/nmethod.hpp" |
1972 | 27 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" |
28 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
29 #include "gc_implementation/g1/g1OopClosures.inline.hpp" | |
30 #include "gc_implementation/g1/heapRegion.inline.hpp" | |
31 #include "gc_implementation/g1/heapRegionRemSet.hpp" | |
32 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
33 #include "memory/genOopClosures.inline.hpp" | |
34 #include "memory/iterator.hpp" | |
35 #include "oops/oop.inline.hpp" | |
342 | 36 |
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17773
diff
changeset
|
37 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17773
diff
changeset
|
38 |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
39 int HeapRegion::LogOfHRGrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
40 int HeapRegion::LogOfHRGrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
41 size_t HeapRegion::GrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
42 size_t HeapRegion::GrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
43 size_t HeapRegion::CardsPerRegion = 0; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
44 |
342 | 45 HeapRegionDCTOC::HeapRegionDCTOC(G1CollectedHeap* g1, |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
46 HeapRegion* hr, ExtendedOopClosure* cl, |
342 | 47 CardTableModRefBS::PrecisionStyle precision, |
48 FilterKind fk) : | |
49 ContiguousSpaceDCTOC(hr, cl, precision, NULL), | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
50 _hr(hr), _fk(fk), _g1(g1) { } |
342 | 51 |
52 FilterOutOfRegionClosure::FilterOutOfRegionClosure(HeapRegion* r, | |
53 OopClosure* oc) : | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
54 _r_bottom(r->bottom()), _r_end(r->end()), _oc(oc) { } |
342 | 55 |
56 template<class ClosureType> | |
57 HeapWord* walk_mem_region_loop(ClosureType* cl, G1CollectedHeap* g1h, | |
58 HeapRegion* hr, | |
59 HeapWord* cur, HeapWord* top) { | |
60 oop cur_oop = oop(cur); | |
61 int oop_size = cur_oop->size(); | |
62 HeapWord* next_obj = cur + oop_size; | |
63 while (next_obj < top) { | |
64 // Keep filtering the remembered set. | |
65 if (!g1h->is_obj_dead(cur_oop, hr)) { | |
66 // Bottom lies entirely below top, so we can call the | |
67 // non-memRegion version of oop_iterate below. | |
68 cur_oop->oop_iterate(cl); | |
69 } | |
70 cur = next_obj; | |
71 cur_oop = oop(cur); | |
72 oop_size = cur_oop->size(); | |
73 next_obj = cur + oop_size; | |
74 } | |
75 return cur; | |
76 } | |
77 | |
78 void HeapRegionDCTOC::walk_mem_region_with_cl(MemRegion mr, | |
79 HeapWord* bottom, | |
80 HeapWord* top, | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
81 ExtendedOopClosure* cl) { |
342 | 82 G1CollectedHeap* g1h = _g1; |
83 int oop_size; | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
84 ExtendedOopClosure* cl2 = NULL; |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
85 |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
86 FilterIntoCSClosure intoCSFilt(this, g1h, cl); |
342 | 87 FilterOutOfRegionClosure outOfRegionFilt(_hr, cl); |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
88 |
342 | 89 switch (_fk) { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
90 case NoFilterKind: cl2 = cl; break; |
342 | 91 case IntoCSFilterKind: cl2 = &intoCSFilt; break; |
92 case OutOfRegionFilterKind: cl2 = &outOfRegionFilt; break; | |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
93 default: ShouldNotReachHere(); |
342 | 94 } |
95 | |
96 // Start filtering what we add to the remembered set. If the object is | |
97 // not considered dead, either because it is marked (in the mark bitmap) | |
98 // or it was allocated after marking finished, then we add it. Otherwise | |
99 // we can safely ignore the object. | |
100 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
101 oop_size = oop(bottom)->oop_iterate(cl2, mr); | |
102 } else { | |
103 oop_size = oop(bottom)->size(); | |
104 } | |
105 | |
106 bottom += oop_size; | |
107 | |
108 if (bottom < top) { | |
109 // We replicate the loop below for several kinds of possible filters. | |
110 switch (_fk) { | |
111 case NoFilterKind: | |
112 bottom = walk_mem_region_loop(cl, g1h, _hr, bottom, top); | |
113 break; | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
114 |
342 | 115 case IntoCSFilterKind: { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
116 FilterIntoCSClosure filt(this, g1h, cl); |
342 | 117 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); |
118 break; | |
119 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
120 |
342 | 121 case OutOfRegionFilterKind: { |
122 FilterOutOfRegionClosure filt(_hr, cl); | |
123 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); | |
124 break; | |
125 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
126 |
342 | 127 default: |
128 ShouldNotReachHere(); | |
129 } | |
130 | |
131 // Last object. Need to do dead-obj filtering here too. | |
132 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
133 oop(bottom)->oop_iterate(cl2, mr); | |
134 } | |
135 } | |
136 } | |
137 | |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
138 // Minimum region size; we won't go lower than that. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
139 // We might want to decrease this in the future, to deal with small |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
140 // heaps a bit more efficiently. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
141 #define MIN_REGION_SIZE ( 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
142 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
143 // Maximum region size; we don't go higher than that. There's a good |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
144 // reason for having an upper bound. We don't want regions to get too |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
145 // large, otherwise cleanup's effectiveness would decrease as there |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
146 // will be fewer opportunities to find totally empty regions after |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
147 // marking. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
148 #define MAX_REGION_SIZE ( 32 * 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
149 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
150 // The automatic region size calculation will try to have around this |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
151 // many regions in the heap (based on the min heap size). |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
152 #define TARGET_REGION_NUMBER 2048 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
153 |
12233
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
154 size_t HeapRegion::max_region_size() { |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
155 return (size_t)MAX_REGION_SIZE; |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
156 } |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
157 |
12178
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
158 void HeapRegion::setup_heap_region_size(size_t initial_heap_size, size_t max_heap_size) { |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
159 uintx region_size = G1HeapRegionSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
160 if (FLAG_IS_DEFAULT(G1HeapRegionSize)) { |
12178
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
161 size_t average_heap_size = (initial_heap_size + max_heap_size) / 2; |
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
162 region_size = MAX2(average_heap_size / TARGET_REGION_NUMBER, |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
163 (uintx) MIN_REGION_SIZE); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
164 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
165 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
166 int region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
167 // Recalculate the region size to make sure it's a power of |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
168 // 2. This means that region_size is the largest power of 2 that's |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
169 // <= what we've calculated so far. |
1485
fb57d4cf76c2
6931180: Migration to recent versions of MS Platform SDK
prr
parents:
1394
diff
changeset
|
170 region_size = ((uintx)1 << region_size_log); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
171 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
172 // Now make sure that we don't go over or under our limits. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
173 if (region_size < MIN_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
174 region_size = MIN_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
175 } else if (region_size > MAX_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
176 region_size = MAX_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
177 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
178 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
179 // And recalculate the log. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
180 region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
181 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
182 // Now, set up the globals. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
183 guarantee(LogOfHRGrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
184 LogOfHRGrainBytes = region_size_log; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
185 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
186 guarantee(LogOfHRGrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
187 LogOfHRGrainWords = LogOfHRGrainBytes - LogHeapWordSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
188 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
189 guarantee(GrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
190 // The cast to int is safe, given that we've bounded region_size by |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
191 // MIN_REGION_SIZE and MAX_REGION_SIZE. |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
192 GrainBytes = (size_t)region_size; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
193 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
194 guarantee(GrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
195 GrainWords = GrainBytes >> LogHeapWordSize; |
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
196 guarantee((size_t) 1 << LogOfHRGrainWords == GrainWords, "sanity"); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
197 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
198 guarantee(CardsPerRegion == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
199 CardsPerRegion = GrainBytes >> CardTableModRefBS::card_shift; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
200 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
201 |
342 | 202 void HeapRegion::reset_after_compaction() { |
203 G1OffsetTableContigSpace::reset_after_compaction(); | |
204 // After a compaction the mark bitmap is invalid, so we must | |
205 // treat all objects as being inside the unmarked area. | |
206 zero_marked_bytes(); | |
207 init_top_at_mark_start(); | |
208 } | |
209 | |
17755
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
210 void HeapRegion::hr_clear(bool par, bool clear_space, bool locked) { |
2152 | 211 assert(_humongous_type == NotHumongous, |
212 "we should have already filtered out humongous regions"); | |
213 assert(_humongous_start_region == NULL, | |
214 "we should have already filtered out humongous regions"); | |
215 assert(_end == _orig_end, | |
216 "we should have already filtered out humongous regions"); | |
217 | |
342 | 218 _in_collection_set = false; |
219 | |
220 set_young_index_in_cset(-1); | |
221 uninstall_surv_rate_group(); | |
222 set_young_type(NotYoung); | |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
223 reset_pre_dummy_top(); |
342 | 224 |
225 if (!par) { | |
226 // If this is parallel, this will be done later. | |
227 HeapRegionRemSet* hrrs = rem_set(); | |
17755
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
228 if (locked) { |
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
229 hrrs->clear_locked(); |
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
230 } else { |
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
231 hrrs->clear(); |
96b1c2e06e25
8027295: Free CSet takes ~50% of young pause time
tschatzl
parents:
17753
diff
changeset
|
232 } |
355 | 233 _claimed = InitialClaimValue; |
342 | 234 } |
235 zero_marked_bytes(); | |
236 | |
237 _offsets.resize(HeapRegion::GrainWords); | |
238 init_top_at_mark_start(); | |
356 | 239 if (clear_space) clear(SpaceDecorator::Mangle); |
342 | 240 } |
241 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
242 void HeapRegion::par_clear() { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
243 assert(used() == 0, "the region should have been already cleared"); |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
244 assert(capacity() == HeapRegion::GrainBytes, "should be back to normal"); |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
245 HeapRegionRemSet* hrrs = rem_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
246 hrrs->clear(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
247 CardTableModRefBS* ct_bs = |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
248 (CardTableModRefBS*)G1CollectedHeap::heap()->barrier_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
249 ct_bs->clear(MemRegion(bottom(), end())); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
250 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
251 |
342 | 252 void HeapRegion::calc_gc_efficiency() { |
6611 | 253 // GC efficiency is the ratio of how much space would be |
254 // reclaimed over how long we predict it would take to reclaim it. | |
342 | 255 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
4912
a9647476d1a4
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
4839
diff
changeset
|
256 G1CollectorPolicy* g1p = g1h->g1_policy(); |
6611 | 257 |
258 // Retrieve a prediction of the elapsed time for this region for | |
259 // a mixed gc because the region will only be evacuated during a | |
260 // mixed gc. | |
261 double region_elapsed_time_ms = | |
262 g1p->predict_region_elapsed_time_ms(this, false /* for_young_gc */); | |
263 _gc_efficiency = (double) reclaimable_bytes() / region_elapsed_time_ms; | |
342 | 264 } |
265 | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
266 void HeapRegion::set_startsHumongous(HeapWord* new_top, HeapWord* new_end) { |
2152 | 267 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
268 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
269 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
270 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
271 assert(bottom() <= new_top && new_top <= new_end, "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
272 |
355 | 273 _humongous_type = StartsHumongous; |
342 | 274 _humongous_start_region = this; |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
275 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
276 set_end(new_end); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
277 _offsets.set_for_starts_humongous(new_top); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
278 } |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
279 |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
280 void HeapRegion::set_continuesHumongous(HeapRegion* first_hr) { |
2152 | 281 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
282 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
283 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
284 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
285 assert(first_hr->startsHumongous(), "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
286 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
287 _humongous_type = ContinuesHumongous; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
288 _humongous_start_region = first_hr; |
342 | 289 } |
290 | |
2152 | 291 void HeapRegion::set_notHumongous() { |
292 assert(isHumongous(), "pre-condition"); | |
293 | |
294 if (startsHumongous()) { | |
295 assert(top() <= end(), "pre-condition"); | |
296 set_end(_orig_end); | |
297 if (top() > end()) { | |
298 // at least one "continues humongous" region after it | |
299 set_top(end()); | |
300 } | |
301 } else { | |
302 // continues humongous | |
303 assert(end() == _orig_end, "sanity"); | |
304 } | |
305 | |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
306 assert(capacity() == HeapRegion::GrainBytes, "pre-condition"); |
2152 | 307 _humongous_type = NotHumongous; |
308 _humongous_start_region = NULL; | |
309 } | |
310 | |
342 | 311 bool HeapRegion::claimHeapRegion(jint claimValue) { |
312 jint current = _claimed; | |
313 if (current != claimValue) { | |
314 jint res = Atomic::cmpxchg(claimValue, &_claimed, current); | |
315 if (res == current) { | |
316 return true; | |
317 } | |
318 } | |
319 return false; | |
320 } | |
321 | |
322 HeapWord* HeapRegion::next_block_start_careful(HeapWord* addr) { | |
323 HeapWord* low = addr; | |
324 HeapWord* high = end(); | |
325 while (low < high) { | |
326 size_t diff = pointer_delta(high, low); | |
327 // Must add one below to bias toward the high amount. Otherwise, if | |
328 // "high" were at the desired value, and "low" were one less, we | |
329 // would not converge on "high". This is not symmetric, because | |
330 // we set "high" to a block start, which might be the right one, | |
331 // which we don't do for "low". | |
332 HeapWord* middle = low + (diff+1)/2; | |
333 if (middle == high) return high; | |
334 HeapWord* mid_bs = block_start_careful(middle); | |
335 if (mid_bs < addr) { | |
336 low = middle; | |
337 } else { | |
338 high = mid_bs; | |
339 } | |
340 } | |
341 assert(low == high && low >= addr, "Didn't work."); | |
342 return low; | |
343 } | |
344 | |
345 #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away | |
346 #pragma warning( disable:4355 ) // 'this' : used in base member initializer list | |
347 #endif // _MSC_VER | |
348 | |
349 | |
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
350 HeapRegion::HeapRegion(uint hrs_index, |
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
351 G1BlockOffsetSharedArray* sharedOffsetArray, |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
352 MemRegion mr) : |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
353 G1OffsetTableContigSpace(sharedOffsetArray, mr), |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
354 _hrs_index(hrs_index), |
355 | 355 _humongous_type(NotHumongous), _humongous_start_region(NULL), |
3830
f44782f04dd4
7039627: G1: avoid BOT updates for survivor allocations and dirty survivor regions incrementally
tonyp
parents:
3772
diff
changeset
|
356 _in_collection_set(false), |
342 | 357 _next_in_special_set(NULL), _orig_end(NULL), |
355 | 358 _claimed(InitialClaimValue), _evacuation_failed(false), |
6011 | 359 _prev_marked_bytes(0), _next_marked_bytes(0), _gc_efficiency(0.0), |
342 | 360 _young_type(NotYoung), _next_young_region(NULL), |
17773
8ee855b4e667
8036025: Sort the freelist in order to shrink the heap
jwilhelm
parents:
17755
diff
changeset
|
361 _next_dirty_cards_region(NULL), _next(NULL), _prev(NULL), _pending_removal(false), |
2152 | 362 #ifdef ASSERT |
363 _containing_set(NULL), | |
364 #endif // ASSERT | |
365 _young_index_in_cset(-1), _surv_rate_group(NULL), _age_index(-1), | |
366 _rem_set(NULL), _recorded_rs_length(0), _predicted_elapsed_time_ms(0), | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
367 _predicted_bytes_to_copy(0) |
342 | 368 { |
12080 | 369 _rem_set = new HeapRegionRemSet(sharedOffsetArray, this); |
342 | 370 _orig_end = mr.end(); |
371 // Note that initialize() will set the start of the unmarked area of the | |
372 // region. | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
373 hr_clear(false /*par*/, false /*clear_space*/); |
356 | 374 set_top(bottom()); |
375 set_saved_mark(); | |
342 | 376 |
377 assert(HeapRegionRemSet::num_par_rem_sets() > 0, "Invariant."); | |
378 } | |
379 | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
380 CompactibleSpace* HeapRegion::next_compaction_space() const { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
381 // We're not using an iterator given that it will wrap around when |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
382 // it reaches the last region and this is not what we want here. |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
383 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
384 uint index = hrs_index() + 1; |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
385 while (index < g1h->n_regions()) { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
386 HeapRegion* hr = g1h->region_at(index); |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
387 if (!hr->isHumongous()) { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
388 return hr; |
342 | 389 } |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
390 index += 1; |
342 | 391 } |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
392 return NULL; |
342 | 393 } |
394 | |
395 void HeapRegion::save_marks() { | |
396 set_saved_mark(); | |
397 } | |
398 | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
399 void HeapRegion::oops_in_mr_iterate(MemRegion mr, ExtendedOopClosure* cl) { |
342 | 400 HeapWord* p = mr.start(); |
401 HeapWord* e = mr.end(); | |
402 oop obj; | |
403 while (p < e) { | |
404 obj = oop(p); | |
405 p += obj->oop_iterate(cl); | |
406 } | |
407 assert(p == e, "bad memregion: doesn't end on obj boundary"); | |
408 } | |
409 | |
410 #define HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN(OopClosureType, nv_suffix) \ | |
411 void HeapRegion::oop_since_save_marks_iterate##nv_suffix(OopClosureType* cl) { \ | |
412 ContiguousSpace::oop_since_save_marks_iterate##nv_suffix(cl); \ | |
413 } | |
414 SPECIALIZED_SINCE_SAVE_MARKS_CLOSURES(HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN) | |
415 | |
416 | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
417 void HeapRegion::oop_before_save_marks_iterate(ExtendedOopClosure* cl) { |
342 | 418 oops_in_mr_iterate(MemRegion(bottom(), saved_mark_word()), cl); |
419 } | |
420 | |
4787
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
421 void HeapRegion::note_self_forwarding_removal_start(bool during_initial_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
422 bool during_conc_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
423 // We always recreate the prev marking info and we'll explicitly |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
424 // mark all objects we find to be self-forwarded on the prev |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
425 // bitmap. So all objects need to be below PTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
426 _prev_top_at_mark_start = top(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
427 _prev_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
428 |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
429 if (during_initial_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
430 // During initial-mark, we'll also explicitly mark all objects |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
431 // we find to be self-forwarded on the next bitmap. So all |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
432 // objects need to be below NTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
433 _next_top_at_mark_start = top(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
434 _next_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
435 } else if (during_conc_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
436 // During concurrent mark, all objects in the CSet (including |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
437 // the ones we find to be self-forwarded) are implicitly live. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
438 // So all objects need to be above NTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
439 _next_top_at_mark_start = bottom(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
440 _next_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
441 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
442 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
443 |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
444 void HeapRegion::note_self_forwarding_removal_end(bool during_initial_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
445 bool during_conc_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
446 size_t marked_bytes) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
447 assert(0 <= marked_bytes && marked_bytes <= used(), |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
448 err_msg("marked: "SIZE_FORMAT" used: "SIZE_FORMAT, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
449 marked_bytes, used())); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
450 _prev_marked_bytes = marked_bytes; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
451 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
452 |
342 | 453 HeapWord* |
454 HeapRegion::object_iterate_mem_careful(MemRegion mr, | |
455 ObjectClosure* cl) { | |
456 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
457 // We used to use "block_start_careful" here. But we're actually happy | |
458 // to update the BOT while we do this... | |
459 HeapWord* cur = block_start(mr.start()); | |
460 mr = mr.intersection(used_region()); | |
461 if (mr.is_empty()) return NULL; | |
462 // Otherwise, find the obj that extends onto mr.start(). | |
463 | |
464 assert(cur <= mr.start() | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
465 && (oop(cur)->klass_or_null() == NULL || |
342 | 466 cur + oop(cur)->size() > mr.start()), |
467 "postcondition of block_start"); | |
468 oop obj; | |
469 while (cur < mr.end()) { | |
470 obj = oop(cur); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
471 if (obj->klass_or_null() == NULL) { |
342 | 472 // Ran into an unparseable point. |
473 return cur; | |
474 } else if (!g1h->is_obj_dead(obj)) { | |
475 cl->do_object(obj); | |
476 } | |
477 if (cl->abort()) return cur; | |
478 // The check above must occur before the operation below, since an | |
479 // abort might invalidate the "size" operation. | |
480 cur += obj->size(); | |
481 } | |
482 return NULL; | |
483 } | |
484 | |
485 HeapWord* | |
486 HeapRegion:: | |
487 oops_on_card_seq_iterate_careful(MemRegion mr, | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
488 FilterOutOfRegionClosure* cl, |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
489 bool filter_young, |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
490 jbyte* card_ptr) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
491 // Currently, we should only have to clean the card if filter_young |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
492 // is true and vice versa. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
493 if (filter_young) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
494 assert(card_ptr != NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
495 } else { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
496 assert(card_ptr == NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
497 } |
342 | 498 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
499 | |
500 // If we're within a stop-world GC, then we might look at a card in a | |
501 // GC alloc region that extends onto a GC LAB, which may not be | |
502 // parseable. Stop such at the "saved_mark" of the region. | |
4839 | 503 if (g1h->is_gc_active()) { |
342 | 504 mr = mr.intersection(used_region_at_save_marks()); |
505 } else { | |
506 mr = mr.intersection(used_region()); | |
507 } | |
508 if (mr.is_empty()) return NULL; | |
509 // Otherwise, find the obj that extends onto mr.start(). | |
510 | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
511 // The intersection of the incoming mr (for the card) and the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
512 // allocated part of the region is non-empty. This implies that |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
513 // we have actually allocated into this region. The code in |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
514 // G1CollectedHeap.cpp that allocates a new region sets the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
515 // is_young tag on the region before allocating. Thus we |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
516 // safely know if this region is young. |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
517 if (is_young() && filter_young) { |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
518 return NULL; |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
519 } |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
520 |
1705 | 521 assert(!is_young(), "check value of filter_young"); |
522 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
523 // We can only clean the card here, after we make the decision that |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
524 // the card is not young. And we only clean the card if we have been |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
525 // asked to (i.e., card_ptr != NULL). |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
526 if (card_ptr != NULL) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
527 *card_ptr = CardTableModRefBS::clean_card_val(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
528 // We must complete this write before we do any of the reads below. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
529 OrderAccess::storeload(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
530 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
531 |
4839 | 532 // Cache the boundaries of the memory region in some const locals |
533 HeapWord* const start = mr.start(); | |
534 HeapWord* const end = mr.end(); | |
535 | |
342 | 536 // We used to use "block_start_careful" here. But we're actually happy |
537 // to update the BOT while we do this... | |
4839 | 538 HeapWord* cur = block_start(start); |
539 assert(cur <= start, "Postcondition"); | |
540 | |
541 oop obj; | |
342 | 542 |
4839 | 543 HeapWord* next = cur; |
544 while (next <= start) { | |
545 cur = next; | |
546 obj = oop(cur); | |
547 if (obj->klass_or_null() == NULL) { | |
342 | 548 // Ran into an unparseable point. |
549 return cur; | |
550 } | |
551 // Otherwise... | |
4839 | 552 next = (cur + obj->size()); |
342 | 553 } |
4839 | 554 |
555 // If we finish the above loop...We have a parseable object that | |
556 // begins on or before the start of the memory region, and ends | |
557 // inside or spans the entire region. | |
558 | |
559 assert(obj == oop(cur), "sanity"); | |
560 assert(cur <= start && | |
561 obj->klass_or_null() != NULL && | |
562 (cur + obj->size()) > start, | |
342 | 563 "Loop postcondition"); |
4839 | 564 |
342 | 565 if (!g1h->is_obj_dead(obj)) { |
566 obj->oop_iterate(cl, mr); | |
567 } | |
568 | |
4839 | 569 while (cur < end) { |
342 | 570 obj = oop(cur); |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
571 if (obj->klass_or_null() == NULL) { |
342 | 572 // Ran into an unparseable point. |
573 return cur; | |
574 }; | |
4839 | 575 |
342 | 576 // Otherwise: |
577 next = (cur + obj->size()); | |
4839 | 578 |
342 | 579 if (!g1h->is_obj_dead(obj)) { |
4839 | 580 if (next < end || !obj->is_objArray()) { |
581 // This object either does not span the MemRegion | |
582 // boundary, or if it does it's not an array. | |
583 // Apply closure to whole object. | |
342 | 584 obj->oop_iterate(cl); |
585 } else { | |
4839 | 586 // This obj is an array that spans the boundary. |
587 // Stop at the boundary. | |
588 obj->oop_iterate(cl, mr); | |
342 | 589 } |
590 } | |
591 cur = next; | |
592 } | |
593 return NULL; | |
594 } | |
595 | |
12080 | 596 // Code roots support |
597 | |
598 void HeapRegion::add_strong_code_root(nmethod* nm) { | |
599 HeapRegionRemSet* hrrs = rem_set(); | |
600 hrrs->add_strong_code_root(nm); | |
601 } | |
602 | |
603 void HeapRegion::remove_strong_code_root(nmethod* nm) { | |
604 HeapRegionRemSet* hrrs = rem_set(); | |
605 hrrs->remove_strong_code_root(nm); | |
606 } | |
607 | |
608 void HeapRegion::migrate_strong_code_roots() { | |
609 assert(in_collection_set(), "only collection set regions"); | |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
610 assert(!isHumongous(), |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
611 err_msg("humongous region "HR_FORMAT" should not have been added to collection set", |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
612 HR_FORMAT_PARAMS(this))); |
12080 | 613 |
614 HeapRegionRemSet* hrrs = rem_set(); | |
615 hrrs->migrate_strong_code_roots(); | |
616 } | |
617 | |
618 void HeapRegion::strong_code_roots_do(CodeBlobClosure* blk) const { | |
619 HeapRegionRemSet* hrrs = rem_set(); | |
620 hrrs->strong_code_roots_do(blk); | |
621 } | |
622 | |
623 class VerifyStrongCodeRootOopClosure: public OopClosure { | |
624 const HeapRegion* _hr; | |
625 nmethod* _nm; | |
626 bool _failures; | |
627 bool _has_oops_in_region; | |
628 | |
629 template <class T> void do_oop_work(T* p) { | |
630 T heap_oop = oopDesc::load_heap_oop(p); | |
631 if (!oopDesc::is_null(heap_oop)) { | |
632 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
633 | |
634 // Note: not all the oops embedded in the nmethod are in the | |
635 // current region. We only look at those which are. | |
636 if (_hr->is_in(obj)) { | |
637 // Object is in the region. Check that its less than top | |
638 if (_hr->top() <= (HeapWord*)obj) { | |
639 // Object is above top | |
640 gclog_or_tty->print_cr("Object "PTR_FORMAT" in region " | |
641 "["PTR_FORMAT", "PTR_FORMAT") is above " | |
642 "top "PTR_FORMAT, | |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
643 (void *)obj, _hr->bottom(), _hr->end(), _hr->top()); |
12080 | 644 _failures = true; |
645 return; | |
646 } | |
647 // Nmethod has at least one oop in the current region | |
648 _has_oops_in_region = true; | |
649 } | |
650 } | |
651 } | |
652 | |
653 public: | |
654 VerifyStrongCodeRootOopClosure(const HeapRegion* hr, nmethod* nm): | |
655 _hr(hr), _failures(false), _has_oops_in_region(false) {} | |
656 | |
657 void do_oop(narrowOop* p) { do_oop_work(p); } | |
658 void do_oop(oop* p) { do_oop_work(p); } | |
659 | |
660 bool failures() { return _failures; } | |
661 bool has_oops_in_region() { return _has_oops_in_region; } | |
662 }; | |
663 | |
664 class VerifyStrongCodeRootCodeBlobClosure: public CodeBlobClosure { | |
665 const HeapRegion* _hr; | |
666 bool _failures; | |
667 public: | |
668 VerifyStrongCodeRootCodeBlobClosure(const HeapRegion* hr) : | |
669 _hr(hr), _failures(false) {} | |
670 | |
671 void do_code_blob(CodeBlob* cb) { | |
672 nmethod* nm = (cb == NULL) ? NULL : cb->as_nmethod_or_null(); | |
673 if (nm != NULL) { | |
674 // Verify that the nemthod is live | |
675 if (!nm->is_alive()) { | |
676 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has dead nmethod " | |
677 PTR_FORMAT" in its strong code roots", | |
678 _hr->bottom(), _hr->end(), nm); | |
679 _failures = true; | |
680 } else { | |
681 VerifyStrongCodeRootOopClosure oop_cl(_hr, nm); | |
682 nm->oops_do(&oop_cl); | |
683 if (!oop_cl.has_oops_in_region()) { | |
684 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has nmethod " | |
685 PTR_FORMAT" in its strong code roots " | |
686 "with no pointers into region", | |
687 _hr->bottom(), _hr->end(), nm); | |
688 _failures = true; | |
689 } else if (oop_cl.failures()) { | |
690 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has other " | |
691 "failures for nmethod "PTR_FORMAT, | |
692 _hr->bottom(), _hr->end(), nm); | |
693 _failures = true; | |
694 } | |
695 } | |
696 } | |
697 } | |
698 | |
699 bool failures() { return _failures; } | |
700 }; | |
701 | |
702 void HeapRegion::verify_strong_code_roots(VerifyOption vo, bool* failures) const { | |
703 if (!G1VerifyHeapRegionCodeRoots) { | |
704 // We're not verifying code roots. | |
705 return; | |
706 } | |
707 if (vo == VerifyOption_G1UseMarkWord) { | |
708 // Marking verification during a full GC is performed after class | |
709 // unloading, code cache unloading, etc so the strong code roots | |
710 // attached to each heap region are in an inconsistent state. They won't | |
711 // be consistent until the strong code roots are rebuilt after the | |
712 // actual GC. Skip verifying the strong code roots in this particular | |
713 // time. | |
714 assert(VerifyDuringGC, "only way to get here"); | |
715 return; | |
716 } | |
717 | |
718 HeapRegionRemSet* hrrs = rem_set(); | |
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
719 size_t strong_code_roots_length = hrrs->strong_code_roots_list_length(); |
12080 | 720 |
721 // if this region is empty then there should be no entries | |
722 // on its strong code root list | |
723 if (is_empty()) { | |
724 if (strong_code_roots_length > 0) { | |
725 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] is empty " | |
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
726 "but has "SIZE_FORMAT" code root entries", |
12080 | 727 bottom(), end(), strong_code_roots_length); |
728 *failures = true; | |
729 } | |
730 return; | |
731 } | |
732 | |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
733 if (continuesHumongous()) { |
12080 | 734 if (strong_code_roots_length > 0) { |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
735 gclog_or_tty->print_cr("region "HR_FORMAT" is a continuation of a humongous " |
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
736 "region but has "SIZE_FORMAT" code root entries", |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
737 HR_FORMAT_PARAMS(this), strong_code_roots_length); |
12080 | 738 *failures = true; |
739 } | |
740 return; | |
741 } | |
742 | |
743 VerifyStrongCodeRootCodeBlobClosure cb_cl(this); | |
744 strong_code_roots_do(&cb_cl); | |
745 | |
746 if (cb_cl.failures()) { | |
747 *failures = true; | |
748 } | |
749 } | |
750 | |
342 | 751 void HeapRegion::print() const { print_on(gclog_or_tty); } |
752 void HeapRegion::print_on(outputStream* st) const { | |
753 if (isHumongous()) { | |
754 if (startsHumongous()) | |
755 st->print(" HS"); | |
756 else | |
757 st->print(" HC"); | |
758 } else { | |
759 st->print(" "); | |
760 } | |
761 if (in_collection_set()) | |
762 st->print(" CS"); | |
763 else | |
764 st->print(" "); | |
765 if (is_young()) | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
766 st->print(is_survivor() ? " SU" : " Y "); |
342 | 767 else |
768 st->print(" "); | |
769 if (is_empty()) | |
770 st->print(" F"); | |
771 else | |
772 st->print(" "); | |
4073
53074c2c4600
7099849: G1: include heap region information in hs_err files
tonyp
parents:
4023
diff
changeset
|
773 st->print(" TS %5d", _gc_time_stamp); |
1388 | 774 st->print(" PTAMS "PTR_FORMAT" NTAMS "PTR_FORMAT, |
775 prev_top_at_mark_start(), next_top_at_mark_start()); | |
342 | 776 G1OffsetTableContigSpace::print_on(st); |
777 } | |
778 | |
12080 | 779 class VerifyLiveClosure: public OopClosure { |
780 private: | |
781 G1CollectedHeap* _g1h; | |
782 CardTableModRefBS* _bs; | |
783 oop _containing_obj; | |
784 bool _failures; | |
785 int _n_failures; | |
786 VerifyOption _vo; | |
787 public: | |
788 // _vo == UsePrevMarking -> use "prev" marking information, | |
789 // _vo == UseNextMarking -> use "next" marking information, | |
790 // _vo == UseMarkWord -> use mark word from object header. | |
791 VerifyLiveClosure(G1CollectedHeap* g1h, VerifyOption vo) : | |
792 _g1h(g1h), _bs(NULL), _containing_obj(NULL), | |
793 _failures(false), _n_failures(0), _vo(vo) | |
794 { | |
795 BarrierSet* bs = _g1h->barrier_set(); | |
796 if (bs->is_a(BarrierSet::CardTableModRef)) | |
797 _bs = (CardTableModRefBS*)bs; | |
798 } | |
799 | |
800 void set_containing_obj(oop obj) { | |
801 _containing_obj = obj; | |
802 } | |
803 | |
804 bool failures() { return _failures; } | |
805 int n_failures() { return _n_failures; } | |
806 | |
807 virtual void do_oop(narrowOop* p) { do_oop_work(p); } | |
808 virtual void do_oop( oop* p) { do_oop_work(p); } | |
809 | |
810 void print_object(outputStream* out, oop obj) { | |
811 #ifdef PRODUCT | |
812 Klass* k = obj->klass(); | |
813 const char* class_name = InstanceKlass::cast(k)->external_name(); | |
814 out->print_cr("class name %s", class_name); | |
815 #else // PRODUCT | |
816 obj->print_on(out); | |
817 #endif // PRODUCT | |
818 } | |
819 | |
820 template <class T> | |
821 void do_oop_work(T* p) { | |
822 assert(_containing_obj != NULL, "Precondition"); | |
823 assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), | |
824 "Precondition"); | |
825 T heap_oop = oopDesc::load_heap_oop(p); | |
826 if (!oopDesc::is_null(heap_oop)) { | |
827 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
828 bool failed = false; | |
829 if (!_g1h->is_in_closed_subset(obj) || _g1h->is_obj_dead_cond(obj, _vo)) { | |
830 MutexLockerEx x(ParGCRareEvent_lock, | |
831 Mutex::_no_safepoint_check_flag); | |
832 | |
833 if (!_failures) { | |
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17773
diff
changeset
|
834 gclog_or_tty->cr(); |
12080 | 835 gclog_or_tty->print_cr("----------"); |
836 } | |
837 if (!_g1h->is_in_closed_subset(obj)) { | |
838 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
839 gclog_or_tty->print_cr("Field "PTR_FORMAT | |
840 " of live obj "PTR_FORMAT" in region " | |
841 "["PTR_FORMAT", "PTR_FORMAT")", | |
842 p, (void*) _containing_obj, | |
843 from->bottom(), from->end()); | |
844 print_object(gclog_or_tty, _containing_obj); | |
845 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" not in the heap", | |
846 (void*) obj); | |
847 } else { | |
848 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
849 HeapRegion* to = _g1h->heap_region_containing((HeapWord*)obj); | |
850 gclog_or_tty->print_cr("Field "PTR_FORMAT | |
851 " of live obj "PTR_FORMAT" in region " | |
852 "["PTR_FORMAT", "PTR_FORMAT")", | |
853 p, (void*) _containing_obj, | |
854 from->bottom(), from->end()); | |
855 print_object(gclog_or_tty, _containing_obj); | |
856 gclog_or_tty->print_cr("points to dead obj "PTR_FORMAT" in region " | |
857 "["PTR_FORMAT", "PTR_FORMAT")", | |
858 (void*) obj, to->bottom(), to->end()); | |
859 print_object(gclog_or_tty, obj); | |
860 } | |
861 gclog_or_tty->print_cr("----------"); | |
862 gclog_or_tty->flush(); | |
863 _failures = true; | |
864 failed = true; | |
865 _n_failures++; | |
866 } | |
867 | |
868 if (!_g1h->full_collection() || G1VerifyRSetsDuringFullGC) { | |
869 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
870 HeapRegion* to = _g1h->heap_region_containing(obj); | |
871 if (from != NULL && to != NULL && | |
872 from != to && | |
873 !to->isHumongous()) { | |
874 jbyte cv_obj = *_bs->byte_for_const(_containing_obj); | |
875 jbyte cv_field = *_bs->byte_for_const(p); | |
876 const jbyte dirty = CardTableModRefBS::dirty_card_val(); | |
877 | |
878 bool is_bad = !(from->is_young() | |
879 || to->rem_set()->contains_reference(p) | |
880 || !G1HRRSFlushLogBuffersOnVerify && // buffers were not flushed | |
881 (_containing_obj->is_objArray() ? | |
882 cv_field == dirty | |
883 : cv_obj == dirty || cv_field == dirty)); | |
884 if (is_bad) { | |
885 MutexLockerEx x(ParGCRareEvent_lock, | |
886 Mutex::_no_safepoint_check_flag); | |
887 | |
888 if (!_failures) { | |
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17773
diff
changeset
|
889 gclog_or_tty->cr(); |
12080 | 890 gclog_or_tty->print_cr("----------"); |
891 } | |
892 gclog_or_tty->print_cr("Missing rem set entry:"); | |
893 gclog_or_tty->print_cr("Field "PTR_FORMAT" " | |
894 "of obj "PTR_FORMAT", " | |
895 "in region "HR_FORMAT, | |
896 p, (void*) _containing_obj, | |
897 HR_FORMAT_PARAMS(from)); | |
898 _containing_obj->print_on(gclog_or_tty); | |
899 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" " | |
900 "in region "HR_FORMAT, | |
901 (void*) obj, | |
902 HR_FORMAT_PARAMS(to)); | |
903 obj->print_on(gclog_or_tty); | |
904 gclog_or_tty->print_cr("Obj head CTE = %d, field CTE = %d.", | |
905 cv_obj, cv_field); | |
906 gclog_or_tty->print_cr("----------"); | |
907 gclog_or_tty->flush(); | |
908 _failures = true; | |
909 if (!failed) _n_failures++; | |
910 } | |
911 } | |
912 } | |
913 } | |
914 } | |
915 }; | |
811 | 916 |
342 | 917 // This really ought to be commoned up into OffsetTableContigSpace somehow. |
918 // We would need a mechanism to make that code skip dead objects. | |
919 | |
6008 | 920 void HeapRegion::verify(VerifyOption vo, |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
921 bool* failures) const { |
342 | 922 G1CollectedHeap* g1 = G1CollectedHeap::heap(); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
923 *failures = false; |
342 | 924 HeapWord* p = bottom(); |
925 HeapWord* prev_p = NULL; | |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
926 VerifyLiveClosure vl_cl(g1, vo); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
927 bool is_humongous = isHumongous(); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
928 bool do_bot_verify = !is_young(); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
929 size_t object_num = 0; |
342 | 930 while (p < top()) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
931 oop obj = oop(p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
932 size_t obj_size = obj->size(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
933 object_num += 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
934 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
935 if (is_humongous != g1->isHumongous(obj_size)) { |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
936 gclog_or_tty->print_cr("obj "PTR_FORMAT" is of %shumongous size (" |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
937 SIZE_FORMAT" words) in a %shumongous region", |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
938 p, g1->isHumongous(obj_size) ? "" : "non-", |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
939 obj_size, is_humongous ? "" : "non-"); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
940 *failures = true; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
941 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
942 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
943 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
944 // If it returns false, verify_for_object() will output the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
945 // appropriate messasge. |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
946 if (do_bot_verify && !_offsets.verify_for_object(p, obj_size)) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
947 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
948 return; |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
949 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
950 |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
951 if (!g1->is_obj_dead_cond(obj, this, vo)) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
952 if (obj->is_oop()) { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
953 Klass* klass = obj->klass(); |
11034 | 954 if (!klass->is_metaspace_object()) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
955 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
956 "not metadata", klass, (void *)obj); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
957 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
958 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
959 } else if (!klass->is_klass()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
960 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
961 "not a klass", klass, (void *)obj); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
962 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
963 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
964 } else { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
965 vl_cl.set_containing_obj(obj); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
966 obj->oop_iterate_no_header(&vl_cl); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
967 if (vl_cl.failures()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
968 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
969 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
970 if (G1MaxVerifyFailures >= 0 && |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
971 vl_cl.n_failures() >= G1MaxVerifyFailures) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
972 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
973 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
974 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
975 } else { |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
976 gclog_or_tty->print_cr(PTR_FORMAT" no an oop", (void *)obj); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
977 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
978 return; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
979 } |
342 | 980 } |
981 prev_p = p; | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
982 p += obj_size; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
983 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
984 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
985 if (p != top()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
986 gclog_or_tty->print_cr("end of last object "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
987 "does not match top "PTR_FORMAT, p, top()); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
988 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
989 return; |
342 | 990 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
991 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
992 HeapWord* the_end = end(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
993 assert(p == top(), "it should still hold"); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
994 // Do some extra BOT consistency checking for addresses in the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
995 // range [top, end). BOT look-ups in this range should yield |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
996 // top. No point in doing that if top == end (there's nothing there). |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
997 if (p < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
998 // Look up top |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
999 HeapWord* addr_1 = p; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1000 HeapWord* b_start_1 = _offsets.block_start_const(addr_1); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1001 if (b_start_1 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1002 gclog_or_tty->print_cr("BOT look up for top: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1003 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1004 addr_1, b_start_1, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1005 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1006 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1007 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1008 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1009 // Look up top + 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1010 HeapWord* addr_2 = p + 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1011 if (addr_2 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1012 HeapWord* b_start_2 = _offsets.block_start_const(addr_2); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1013 if (b_start_2 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1014 gclog_or_tty->print_cr("BOT look up for top + 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1015 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1016 addr_2, b_start_2, p); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1017 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1018 return; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1019 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1020 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1021 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1022 // Look up an address between top and end |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1023 size_t diff = pointer_delta(the_end, p) / 2; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1024 HeapWord* addr_3 = p + diff; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1025 if (addr_3 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1026 HeapWord* b_start_3 = _offsets.block_start_const(addr_3); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1027 if (b_start_3 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1028 gclog_or_tty->print_cr("BOT look up for top + diff: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1029 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1030 addr_3, b_start_3, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1031 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1032 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1033 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1034 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1035 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1036 // Loook up end - 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1037 HeapWord* addr_4 = the_end - 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1038 HeapWord* b_start_4 = _offsets.block_start_const(addr_4); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1039 if (b_start_4 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1040 gclog_or_tty->print_cr("BOT look up for end - 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1041 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1042 addr_4, b_start_4, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1043 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1044 return; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1045 } |
342 | 1046 } |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1047 |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1048 if (is_humongous && object_num > 1) { |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1049 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] is humongous " |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1050 "but has "SIZE_FORMAT", objects", |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1051 bottom(), end(), object_num); |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1052 *failures = true; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1053 return; |
342 | 1054 } |
12080 | 1055 |
1056 verify_strong_code_roots(vo, failures); | |
1057 } | |
1058 | |
1059 void HeapRegion::verify() const { | |
1060 bool dummy = false; | |
1061 verify(VerifyOption_G1UsePrevMarking, /* failures */ &dummy); | |
342 | 1062 } |
1063 | |
1064 // G1OffsetTableContigSpace code; copied from space.cpp. Hope this can go | |
1065 // away eventually. | |
1066 | |
356 | 1067 void G1OffsetTableContigSpace::clear(bool mangle_space) { |
1068 ContiguousSpace::clear(mangle_space); | |
342 | 1069 _offsets.zero_bottom_entry(); |
1070 _offsets.initialize_threshold(); | |
1071 } | |
1072 | |
1073 void G1OffsetTableContigSpace::set_bottom(HeapWord* new_bottom) { | |
1074 Space::set_bottom(new_bottom); | |
1075 _offsets.set_bottom(new_bottom); | |
1076 } | |
1077 | |
1078 void G1OffsetTableContigSpace::set_end(HeapWord* new_end) { | |
1079 Space::set_end(new_end); | |
1080 _offsets.resize(new_end - bottom()); | |
1081 } | |
1082 | |
1083 void G1OffsetTableContigSpace::print() const { | |
1084 print_short(); | |
1085 gclog_or_tty->print_cr(" [" INTPTR_FORMAT ", " INTPTR_FORMAT ", " | |
1086 INTPTR_FORMAT ", " INTPTR_FORMAT ")", | |
1087 bottom(), top(), _offsets.threshold(), end()); | |
1088 } | |
1089 | |
1090 HeapWord* G1OffsetTableContigSpace::initialize_threshold() { | |
1091 return _offsets.initialize_threshold(); | |
1092 } | |
1093 | |
1094 HeapWord* G1OffsetTableContigSpace::cross_threshold(HeapWord* start, | |
1095 HeapWord* end) { | |
1096 _offsets.alloc_block(start, end); | |
1097 return _offsets.threshold(); | |
1098 } | |
1099 | |
1100 HeapWord* G1OffsetTableContigSpace::saved_mark_word() const { | |
1101 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
1102 assert( _gc_time_stamp <= g1h->get_gc_time_stamp(), "invariant" ); | |
1103 if (_gc_time_stamp < g1h->get_gc_time_stamp()) | |
1104 return top(); | |
1105 else | |
1106 return ContiguousSpace::saved_mark_word(); | |
1107 } | |
1108 | |
1109 void G1OffsetTableContigSpace::set_saved_mark() { | |
1110 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
1111 unsigned curr_gc_time_stamp = g1h->get_gc_time_stamp(); | |
1112 | |
1113 if (_gc_time_stamp < curr_gc_time_stamp) { | |
1114 // The order of these is important, as another thread might be | |
1115 // about to start scanning this region. If it does so after | |
1116 // set_saved_mark and before _gc_time_stamp = ..., then the latter | |
1117 // will be false, and it will pick up top() as the high water mark | |
1118 // of region. If it does so after _gc_time_stamp = ..., then it | |
1119 // will pick up the right saved_mark_word() as the high water mark | |
1120 // of the region. Either way, the behaviour will be correct. | |
1121 ContiguousSpace::set_saved_mark(); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
1122 OrderAccess::storestore(); |
353
9bb2c10ac07b
6723570: G1: assertion failure: p == current_top or oop(p)->is_oop(),"p is not a block start" (revisited!)
iveresov
parents:
342
diff
changeset
|
1123 _gc_time_stamp = curr_gc_time_stamp; |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1124 // No need to do another barrier to flush the writes above. If |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1125 // this is called in parallel with other threads trying to |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1126 // allocate into the region, the caller should call this while |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1127 // holding a lock and when the lock is released the writes will be |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1128 // flushed. |
342 | 1129 } |
1130 } | |
1131 | |
1132 G1OffsetTableContigSpace:: | |
1133 G1OffsetTableContigSpace(G1BlockOffsetSharedArray* sharedOffsetArray, | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1134 MemRegion mr) : |
342 | 1135 _offsets(sharedOffsetArray, mr), |
1136 _par_alloc_lock(Mutex::leaf, "OffsetTableContigSpace par alloc lock", true), | |
1137 _gc_time_stamp(0) | |
1138 { | |
1139 _offsets.set_space(this); | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1140 // false ==> we'll do the clearing if there's clearing to be done. |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1141 ContiguousSpace::initialize(mr, false, SpaceDecorator::Mangle); |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1142 _offsets.zero_bottom_entry(); |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1143 _offsets.initialize_threshold(); |
342 | 1144 } |