8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
author |
stefank |
date |
Fri, 20 Sep 2013 10:53:28 +0200 |
parents |
a61af66fc99e |
children |
|
rev |
line source |
0
|
1 README:
|
|
2 This file should be located at the top of the hotspot Mercurial repository.
|
|
3
|
|
4 See http://openjdk.java.net/ for more information about the OpenJDK.
|
|
5
|
|
6 See ../README-builds.html for complete details on build machine requirements.
|
|
7
|
|
8 Simple Build Instructions:
|
|
9
|
|
10 cd make && gnumake
|
|
11
|
|
12 The files that will be imported into the jdk build will be in the "build"
|
|
13 directory.
|
|
14
|