annotate src/share/vm/memory/metaspaceCounters.hpp @ 12301:2c022e432e10

8024974: Incorrect use of GC_locker::is_active() Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint. Reviewed-by: brutisso, dcubed Contributed-by: per.liden@oracle.com
author stefank
date Fri, 20 Sep 2013 10:53:28 +0200
parents 73d0d0218068
children de6a9e811145
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
1 /*
7440
79f492f184d0 8004982: JDK8 source with GPL header errors
katleman
parents: 6725
diff changeset
2 * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
4 *
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
7 * published by the Free Software Foundation.
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
8 *
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
13 * accompanied this code).
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
14 *
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
18 *
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
21 * questions.
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
22 *
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
23 */
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
24
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
25 #ifndef SHARE_VM_MEMORY_METASPACECOUNTERS_HPP
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
26 #define SHARE_VM_MEMORY_METASPACECOUNTERS_HPP
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
27
12248
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
28 #include "memory/allocation.hpp"
12063
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
29
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
30 class MetaspacePerfCounters;
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
31
12063
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
32 class MetaspaceCounters: public AllStatic {
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
33 static MetaspacePerfCounters* _perf_counters;
12248
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
34 static size_t used();
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
35 static size_t capacity();
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
36 static size_t max_capacity();
12063
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
37
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
38 public:
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
39 static void initialize_performance_counters();
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
40 static void update_performance_counters();
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
41 };
12063
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
42
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
43 class CompressedClassSpaceCounters: public AllStatic {
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
44 static MetaspacePerfCounters* _perf_counters;
12248
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
45 static size_t used();
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
46 static size_t capacity();
73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data
ehelin
parents: 12063
diff changeset
47 static size_t max_capacity();
12063
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
48
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
49 public:
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
50 static void initialize_performance_counters();
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
51 static void update_performance_counters();
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
52 };
1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space
ehelin
parents: 10183
diff changeset
53
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
diff changeset
54 #endif // SHARE_VM_MEMORY_METASPACECOUNTERS_HPP