Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp @ 20378:39189caa2894
Merge
| author | tschatzl |
|---|---|
| date | Fri, 29 Aug 2014 13:12:03 +0200 |
| parents | 833b0f92429a a8ea2f110d87 |
| children | 66d359ee9681 |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
2 * Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1390
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1390
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1390
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "gc_implementation/g1/concurrentG1Refine.hpp" | |
| 27 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
| 28 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 29 #include "gc_implementation/g1/heapRegionRemSet.hpp" | |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
30 #include "gc_implementation/g1/heapRegionManager.inline.hpp" |
| 1972 | 31 #include "memory/allocation.hpp" |
|
17754
d7070f371770
8035815: Cache-align and pad the from card cache
tschatzl
parents:
17753
diff
changeset
|
32 #include "memory/padded.inline.hpp" |
| 1972 | 33 #include "memory/space.inline.hpp" |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
34 #include "oops/oop.inline.hpp" |
| 1972 | 35 #include "utilities/bitMap.inline.hpp" |
| 36 #include "utilities/globalDefinitions.hpp" | |
| 12080 | 37 #include "utilities/growableArray.hpp" |
| 342 | 38 |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
39 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
|
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
40 |
| 6197 | 41 class PerRegionTable: public CHeapObj<mtGC> { |
| 342 | 42 friend class OtherRegionsTable; |
| 43 friend class HeapRegionRemSetIterator; | |
| 44 | |
| 45 HeapRegion* _hr; | |
| 46 BitMap _bm; | |
| 47 jint _occupied; | |
| 48 | |
| 6253 | 49 // next pointer for free/allocated 'all' list |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
50 PerRegionTable* _next; |
| 342 | 51 |
| 6253 | 52 // prev pointer for the allocated 'all' list |
| 53 PerRegionTable* _prev; | |
| 342 | 54 |
| 6253 | 55 // next pointer in collision list |
| 56 PerRegionTable * _collision_list_next; | |
| 342 | 57 |
| 6253 | 58 // Global free list of PRTs |
| 59 static PerRegionTable* _free_list; | |
| 342 | 60 |
| 61 protected: | |
| 62 // We need access in order to union things into the base table. | |
| 63 BitMap* bm() { return &_bm; } | |
| 64 | |
| 65 void recount_occupied() { | |
| 66 _occupied = (jint) bm()->count_one_bits(); | |
| 67 } | |
| 68 | |
| 69 PerRegionTable(HeapRegion* hr) : | |
| 70 _hr(hr), | |
| 71 _occupied(0), | |
| 6253 | 72 _bm(HeapRegion::CardsPerRegion, false /* in-resource-area */), |
| 73 _collision_list_next(NULL), _next(NULL), _prev(NULL) | |
| 342 | 74 {} |
| 75 | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
76 void add_card_work(CardIdx_t from_card, bool par) { |
| 342 | 77 if (!_bm.at(from_card)) { |
| 78 if (par) { | |
| 79 if (_bm.par_at_put(from_card, 1)) { | |
| 80 Atomic::inc(&_occupied); | |
| 81 } | |
| 82 } else { | |
| 83 _bm.at_put(from_card, 1); | |
| 84 _occupied++; | |
| 85 } | |
| 86 } | |
| 87 } | |
| 88 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
89 void add_reference_work(OopOrNarrowOopStar from, bool par) { |
| 342 | 90 // Must make this robust in case "from" is not in "_hr", because of |
| 91 // concurrency. | |
| 92 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
93 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
94 gclog_or_tty->print_cr(" PRT::Add_reference_work(" PTR_FORMAT "->" PTR_FORMAT").", |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
95 from, |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
96 UseCompressedOops |
|
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12080
diff
changeset
|
97 ? (void *)oopDesc::load_decode_heap_oop((narrowOop*)from) |
|
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12080
diff
changeset
|
98 : (void *)oopDesc::load_decode_heap_oop((oop*)from)); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
99 } |
| 342 | 100 |
| 101 HeapRegion* loc_hr = hr(); | |
| 102 // If the test below fails, then this table was reused concurrently | |
| 103 // with this operation. This is OK, since the old table was coarsened, | |
| 104 // and adding a bit to the new table is never incorrect. | |
|
4020
5e5d4821bf07
7097516: G1: assert(0<= from_card && from_card<HeapRegion::CardsPerRegion) failed: Must be in range.
brutisso
parents:
3986
diff
changeset
|
105 // If the table used to belong to a continues humongous region and is |
|
5e5d4821bf07
7097516: G1: assert(0<= from_card && from_card<HeapRegion::CardsPerRegion) failed: Must be in range.
brutisso
parents:
3986
diff
changeset
|
106 // now reused for the corresponding start humongous region, we need to |
|
5e5d4821bf07
7097516: G1: assert(0<= from_card && from_card<HeapRegion::CardsPerRegion) failed: Must be in range.
brutisso
parents:
3986
diff
changeset
|
107 // make sure that we detect this. Thus, we call is_in_reserved_raw() |
|
5e5d4821bf07
7097516: G1: assert(0<= from_card && from_card<HeapRegion::CardsPerRegion) failed: Must be in range.
brutisso
parents:
3986
diff
changeset
|
108 // instead of just is_in_reserved() here. |
|
5e5d4821bf07
7097516: G1: assert(0<= from_card && from_card<HeapRegion::CardsPerRegion) failed: Must be in range.
brutisso
parents:
3986
diff
changeset
|
109 if (loc_hr->is_in_reserved_raw(from)) { |
| 342 | 110 size_t hw_offset = pointer_delta((HeapWord*)from, loc_hr->bottom()); |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
111 CardIdx_t from_card = (CardIdx_t) |
|
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
112 hw_offset >> (CardTableModRefBS::card_shift - LogHeapWordSize); |
| 342 | 113 |
|
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3830
diff
changeset
|
114 assert(0 <= from_card && (size_t)from_card < HeapRegion::CardsPerRegion, |
|
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
845
diff
changeset
|
115 "Must be in range."); |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
116 add_card_work(from_card, par); |
| 342 | 117 } |
| 118 } | |
| 119 | |
| 120 public: | |
| 121 | |
| 122 HeapRegion* hr() const { return _hr; } | |
| 123 | |
| 124 jint occupied() const { | |
| 125 // Overkill, but if we ever need it... | |
| 126 // guarantee(_occupied == _bm.count_one_bits(), "Check"); | |
| 127 return _occupied; | |
| 128 } | |
| 129 | |
| 6253 | 130 void init(HeapRegion* hr, bool clear_links_to_all_list) { |
| 131 if (clear_links_to_all_list) { | |
| 132 set_next(NULL); | |
| 133 set_prev(NULL); | |
| 134 } | |
| 342 | 135 _hr = hr; |
| 6253 | 136 _collision_list_next = NULL; |
| 342 | 137 _occupied = 0; |
| 138 _bm.clear(); | |
| 139 } | |
| 140 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
141 void add_reference(OopOrNarrowOopStar from) { |
| 342 | 142 add_reference_work(from, /*parallel*/ true); |
| 143 } | |
| 144 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
145 void seq_add_reference(OopOrNarrowOopStar from) { |
| 342 | 146 add_reference_work(from, /*parallel*/ false); |
| 147 } | |
| 148 | |
| 149 void scrub(CardTableModRefBS* ctbs, BitMap* card_bm) { | |
| 150 HeapWord* hr_bot = hr()->bottom(); | |
|
489
2494ab195856
6653214: MemoryPoolMXBean.setUsageThreshold() does not support large heap sizes.
swamyv
parents:
342
diff
changeset
|
151 size_t hr_first_card_index = ctbs->index_for(hr_bot); |
| 342 | 152 bm()->set_intersection_at_offset(*card_bm, hr_first_card_index); |
| 153 recount_occupied(); | |
| 154 } | |
| 155 | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
156 void add_card(CardIdx_t from_card_index) { |
| 342 | 157 add_card_work(from_card_index, /*parallel*/ true); |
| 158 } | |
| 159 | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
160 void seq_add_card(CardIdx_t from_card_index) { |
| 342 | 161 add_card_work(from_card_index, /*parallel*/ false); |
| 162 } | |
| 163 | |
| 164 // (Destructively) union the bitmap of the current table into the given | |
| 165 // bitmap (which is assumed to be of the same size.) | |
| 166 void union_bitmap_into(BitMap* bm) { | |
| 167 bm->set_union(_bm); | |
| 168 } | |
| 169 | |
| 170 // Mem size in bytes. | |
| 171 size_t mem_size() const { | |
|
20218
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
172 return sizeof(PerRegionTable) + _bm.size_in_words() * HeapWordSize; |
| 342 | 173 } |
| 174 | |
| 175 // Requires "from" to be in "hr()". | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
176 bool contains_reference(OopOrNarrowOopStar from) const { |
| 342 | 177 assert(hr()->is_in_reserved(from), "Precondition."); |
| 178 size_t card_ind = pointer_delta(from, hr()->bottom(), | |
| 179 CardTableModRefBS::card_size); | |
| 180 return _bm.at(card_ind); | |
| 181 } | |
| 182 | |
| 6253 | 183 // Bulk-free the PRTs from prt to last, assumes that they are |
| 184 // linked together using their _next field. | |
| 185 static void bulk_free(PerRegionTable* prt, PerRegionTable* last) { | |
| 342 | 186 while (true) { |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
187 PerRegionTable* fl = _free_list; |
| 6253 | 188 last->set_next(fl); |
| 189 PerRegionTable* res = (PerRegionTable*) Atomic::cmpxchg_ptr(prt, &_free_list, fl); | |
| 190 if (res == fl) { | |
| 191 return; | |
| 192 } | |
| 342 | 193 } |
| 194 ShouldNotReachHere(); | |
| 195 } | |
| 196 | |
| 6253 | 197 static void free(PerRegionTable* prt) { |
| 198 bulk_free(prt, prt); | |
| 199 } | |
| 200 | |
| 201 // Returns an initialized PerRegionTable instance. | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
202 static PerRegionTable* alloc(HeapRegion* hr) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
203 PerRegionTable* fl = _free_list; |
| 342 | 204 while (fl != NULL) { |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
205 PerRegionTable* nxt = fl->next(); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
206 PerRegionTable* res = |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
207 (PerRegionTable*) |
| 342 | 208 Atomic::cmpxchg_ptr(nxt, &_free_list, fl); |
| 209 if (res == fl) { | |
| 6253 | 210 fl->init(hr, true); |
| 342 | 211 return fl; |
| 212 } else { | |
| 213 fl = _free_list; | |
| 214 } | |
| 215 } | |
| 216 assert(fl == NULL, "Loop condition."); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
217 return new PerRegionTable(hr); |
| 342 | 218 } |
| 219 | |
| 6253 | 220 PerRegionTable* next() const { return _next; } |
| 221 void set_next(PerRegionTable* next) { _next = next; } | |
| 222 PerRegionTable* prev() const { return _prev; } | |
| 223 void set_prev(PerRegionTable* prev) { _prev = prev; } | |
| 224 | |
| 225 // Accessor and Modification routines for the pointer for the | |
| 226 // singly linked collision list that links the PRTs within the | |
| 227 // OtherRegionsTable::_fine_grain_regions hash table. | |
| 228 // | |
| 229 // It might be useful to also make the collision list doubly linked | |
| 230 // to avoid iteration over the collisions list during scrubbing/deletion. | |
| 231 // OTOH there might not be many collisions. | |
| 232 | |
| 233 PerRegionTable* collision_list_next() const { | |
| 234 return _collision_list_next; | |
| 235 } | |
| 236 | |
| 237 void set_collision_list_next(PerRegionTable* next) { | |
| 238 _collision_list_next = next; | |
| 239 } | |
| 240 | |
| 241 PerRegionTable** collision_list_next_addr() { | |
| 242 return &_collision_list_next; | |
| 243 } | |
| 244 | |
| 342 | 245 static size_t fl_mem_size() { |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
246 PerRegionTable* cur = _free_list; |
| 342 | 247 size_t res = 0; |
| 248 while (cur != NULL) { | |
|
10333
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
249 res += cur->mem_size(); |
| 342 | 250 cur = cur->next(); |
| 251 } | |
| 252 return res; | |
| 253 } | |
|
10333
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
254 |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
255 static void test_fl_mem_size(); |
| 342 | 256 }; |
| 257 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
258 PerRegionTable* PerRegionTable::_free_list = NULL; |
| 342 | 259 |
| 260 size_t OtherRegionsTable::_max_fine_entries = 0; | |
| 261 size_t OtherRegionsTable::_mod_max_fine_entries_mask = 0; | |
| 262 size_t OtherRegionsTable::_fine_eviction_stride = 0; | |
| 263 size_t OtherRegionsTable::_fine_eviction_sample_size = 0; | |
| 264 | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
265 OtherRegionsTable::OtherRegionsTable(HeapRegion* hr, Mutex* m) : |
| 342 | 266 _g1h(G1CollectedHeap::heap()), |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
267 _hr(hr), _m(m), |
| 342 | 268 _coarse_map(G1CollectedHeap::heap()->max_regions(), |
| 269 false /* in-resource-area */), | |
| 270 _fine_grain_regions(NULL), | |
| 6253 | 271 _first_all_fine_prts(NULL), _last_all_fine_prts(NULL), |
| 342 | 272 _n_fine_entries(0), _n_coarse_entries(0), |
| 273 _fine_eviction_start(0), | |
| 274 _sparse_table(hr) | |
| 275 { | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
276 typedef PerRegionTable* PerRegionTablePtr; |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
277 |
| 342 | 278 if (_max_fine_entries == 0) { |
| 279 assert(_mod_max_fine_entries_mask == 0, "Both or none."); | |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
280 size_t max_entries_log = (size_t)log2_long((jlong)G1RSetRegionEntries); |
|
6750
859cd1a76f8a
7197906: BlockOffsetArray::power_to_cards_back() needs to handle > 32 bit shifts
brutisso
parents:
6253
diff
changeset
|
281 _max_fine_entries = (size_t)1 << max_entries_log; |
| 342 | 282 _mod_max_fine_entries_mask = _max_fine_entries - 1; |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
283 |
| 342 | 284 assert(_fine_eviction_sample_size == 0 |
| 285 && _fine_eviction_stride == 0, "All init at same time."); | |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
286 _fine_eviction_sample_size = MAX2((size_t)4, max_entries_log); |
| 342 | 287 _fine_eviction_stride = _max_fine_entries / _fine_eviction_sample_size; |
| 288 } | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
289 |
|
10271
f9be75d21404
8012902: remove use of global operator new - take 2
minqi
parents:
10193
diff
changeset
|
290 _fine_grain_regions = NEW_C_HEAP_ARRAY3(PerRegionTablePtr, _max_fine_entries, |
| 20360 | 291 mtGC, CURRENT_PC, AllocFailStrategy::RETURN_NULL); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
292 |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
293 if (_fine_grain_regions == NULL) { |
|
10161
746b070f5022
8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap"
ccheung
parents:
10135
diff
changeset
|
294 vm_exit_out_of_memory(sizeof(void*)*_max_fine_entries, OOM_MALLOC_ERROR, |
| 342 | 295 "Failed to allocate _fine_grain_entries."); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
296 } |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
297 |
| 342 | 298 for (size_t i = 0; i < _max_fine_entries; i++) { |
| 299 _fine_grain_regions[i] = NULL; | |
| 300 } | |
| 301 } | |
| 302 | |
| 6253 | 303 void OtherRegionsTable::link_to_all(PerRegionTable* prt) { |
| 304 // We always append to the beginning of the list for convenience; | |
| 305 // the order of entries in this list does not matter. | |
| 306 if (_first_all_fine_prts != NULL) { | |
| 307 assert(_first_all_fine_prts->prev() == NULL, "invariant"); | |
| 308 _first_all_fine_prts->set_prev(prt); | |
| 309 prt->set_next(_first_all_fine_prts); | |
| 310 } else { | |
| 311 // this is the first element we insert. Adjust the "last" pointer | |
| 312 _last_all_fine_prts = prt; | |
| 313 assert(prt->next() == NULL, "just checking"); | |
| 314 } | |
| 315 // the new element is always the first element without a predecessor | |
| 316 prt->set_prev(NULL); | |
| 317 _first_all_fine_prts = prt; | |
| 318 | |
| 319 assert(prt->prev() == NULL, "just checking"); | |
| 320 assert(_first_all_fine_prts == prt, "just checking"); | |
| 321 assert((_first_all_fine_prts == NULL && _last_all_fine_prts == NULL) || | |
| 322 (_first_all_fine_prts != NULL && _last_all_fine_prts != NULL), | |
| 323 "just checking"); | |
| 324 assert(_last_all_fine_prts == NULL || _last_all_fine_prts->next() == NULL, | |
| 325 "just checking"); | |
| 326 assert(_first_all_fine_prts == NULL || _first_all_fine_prts->prev() == NULL, | |
| 327 "just checking"); | |
| 328 } | |
| 329 | |
| 330 void OtherRegionsTable::unlink_from_all(PerRegionTable* prt) { | |
| 331 if (prt->prev() != NULL) { | |
| 332 assert(_first_all_fine_prts != prt, "just checking"); | |
| 333 prt->prev()->set_next(prt->next()); | |
| 334 // removing the last element in the list? | |
| 335 if (_last_all_fine_prts == prt) { | |
| 336 _last_all_fine_prts = prt->prev(); | |
| 337 } | |
| 338 } else { | |
| 339 assert(_first_all_fine_prts == prt, "just checking"); | |
| 340 _first_all_fine_prts = prt->next(); | |
| 341 // list is empty now? | |
| 342 if (_first_all_fine_prts == NULL) { | |
| 343 _last_all_fine_prts = NULL; | |
| 344 } | |
| 345 } | |
| 346 | |
| 347 if (prt->next() != NULL) { | |
| 348 prt->next()->set_prev(prt->prev()); | |
| 349 } | |
| 350 | |
| 351 prt->set_next(NULL); | |
| 352 prt->set_prev(NULL); | |
| 353 | |
| 354 assert((_first_all_fine_prts == NULL && _last_all_fine_prts == NULL) || | |
| 355 (_first_all_fine_prts != NULL && _last_all_fine_prts != NULL), | |
| 356 "just checking"); | |
| 357 assert(_last_all_fine_prts == NULL || _last_all_fine_prts->next() == NULL, | |
| 358 "just checking"); | |
| 359 assert(_first_all_fine_prts == NULL || _first_all_fine_prts->prev() == NULL, | |
| 360 "just checking"); | |
| 361 } | |
| 362 | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
363 int** FromCardCache::_cache = NULL; |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
364 uint FromCardCache::_max_regions = 0; |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
365 size_t FromCardCache::_static_mem_size = 0; |
| 342 | 366 |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
367 void FromCardCache::initialize(uint n_par_rs, uint max_num_regions) { |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
368 guarantee(_cache == NULL, "Should not call this multiple times"); |
| 342 | 369 |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
370 _max_regions = max_num_regions; |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
371 _cache = Padded2DArray<int, mtGC>::create_unfreeable(n_par_rs, |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
372 _max_regions, |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
373 &_static_mem_size); |
|
17754
d7070f371770
8035815: Cache-align and pad the from card cache
tschatzl
parents:
17753
diff
changeset
|
374 |
| 20337 | 375 invalidate(0, _max_regions); |
| 342 | 376 } |
| 377 | |
| 20337 | 378 void FromCardCache::invalidate(uint start_idx, size_t new_num_regions) { |
| 379 guarantee((size_t)start_idx + new_num_regions <= max_uintx, | |
| 380 err_msg("Trying to invalidate beyond maximum region, from %u size "SIZE_FORMAT, | |
| 381 start_idx, new_num_regions)); | |
|
17754
d7070f371770
8035815: Cache-align and pad the from card cache
tschatzl
parents:
17753
diff
changeset
|
382 for (uint i = 0; i < HeapRegionRemSet::num_par_rem_sets(); i++) { |
| 20337 | 383 uint end_idx = (start_idx + (uint)new_num_regions); |
| 384 assert(end_idx <= _max_regions, "Must be within max."); | |
| 385 for (uint j = start_idx; j < end_idx; j++) { | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
386 set(i, j, InvalidCard); |
| 342 | 387 } |
| 388 } | |
| 389 } | |
| 390 | |
| 391 #ifndef PRODUCT | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
392 void FromCardCache::print(outputStream* out) { |
|
17754
d7070f371770
8035815: Cache-align and pad the from card cache
tschatzl
parents:
17753
diff
changeset
|
393 for (uint i = 0; i < HeapRegionRemSet::num_par_rem_sets(); i++) { |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
394 for (uint j = 0; j < _max_regions; j++) { |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
395 out->print_cr("_from_card_cache["UINT32_FORMAT"]["UINT32_FORMAT"] = "INT32_FORMAT".", |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
396 i, j, at(i, j)); |
| 342 | 397 } |
| 398 } | |
| 399 } | |
| 400 #endif | |
| 401 | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
402 void FromCardCache::clear(uint region_idx) { |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
403 uint num_par_remsets = HeapRegionRemSet::num_par_rem_sets(); |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
404 for (uint i = 0; i < num_par_remsets; i++) { |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
405 set(i, region_idx, InvalidCard); |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
406 } |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
407 } |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
408 |
| 20337 | 409 void OtherRegionsTable::initialize(uint max_regions) { |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
410 FromCardCache::initialize(HeapRegionRemSet::num_par_rem_sets(), max_regions); |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
411 } |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
412 |
| 20337 | 413 void OtherRegionsTable::invalidate(uint start_idx, size_t num_regions) { |
| 414 FromCardCache::invalidate(start_idx, num_regions); | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
415 } |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
416 |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
417 void OtherRegionsTable::print_from_card_cache() { |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
418 FromCardCache::print(); |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
419 } |
|
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
420 |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
421 void OtherRegionsTable::add_reference(OopOrNarrowOopStar from, int tid) { |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
422 uint cur_hrm_ind = hr()->hrm_index(); |
| 342 | 423 |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
424 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
425 gclog_or_tty->print_cr("ORT::add_reference_work(" PTR_FORMAT "->" PTR_FORMAT ").", |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
426 from, |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
427 UseCompressedOops |
|
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12080
diff
changeset
|
428 ? (void *)oopDesc::load_decode_heap_oop((narrowOop*)from) |
|
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12080
diff
changeset
|
429 : (void *)oopDesc::load_decode_heap_oop((oop*)from)); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
430 } |
| 342 | 431 |
| 432 int from_card = (int)(uintptr_t(from) >> CardTableModRefBS::card_shift); | |
| 433 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
434 if (G1TraceHeapRegionRememberedSet) { |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
435 gclog_or_tty->print_cr("Table for [" PTR_FORMAT "...): card %d (cache = "INT32_FORMAT")", |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
436 hr()->bottom(), from_card, |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
437 FromCardCache::at((uint)tid, cur_hrm_ind)); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
438 } |
| 342 | 439 |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
440 if (FromCardCache::contains_or_replace((uint)tid, cur_hrm_ind, from_card)) { |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
441 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
442 gclog_or_tty->print_cr(" from-card cache hit."); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
443 } |
| 342 | 444 assert(contains_reference(from), "We just added it!"); |
| 445 return; | |
| 446 } | |
| 447 | |
| 448 // Note that this may be a continued H region. | |
| 449 HeapRegion* from_hr = _g1h->heap_region_containing_raw(from); | |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
450 RegionIdx_t from_hrs_ind = (RegionIdx_t) from_hr->hrm_index(); |
| 342 | 451 |
| 452 // If the region is already coarsened, return. | |
| 453 if (_coarse_map.at(from_hrs_ind)) { | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
454 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
455 gclog_or_tty->print_cr(" coarse map hit."); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
456 } |
| 342 | 457 assert(contains_reference(from), "We just added it!"); |
| 458 return; | |
| 459 } | |
| 460 | |
| 461 // Otherwise find a per-region table to add it to. | |
| 462 size_t ind = from_hrs_ind & _mod_max_fine_entries_mask; | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
463 PerRegionTable* prt = find_region_table(ind, from_hr); |
| 342 | 464 if (prt == NULL) { |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
465 MutexLockerEx x(_m, Mutex::_no_safepoint_check_flag); |
| 342 | 466 // Confirm that it's really not there... |
| 467 prt = find_region_table(ind, from_hr); | |
| 468 if (prt == NULL) { | |
| 469 | |
| 470 uintptr_t from_hr_bot_card_index = | |
| 471 uintptr_t(from_hr->bottom()) | |
| 472 >> CardTableModRefBS::card_shift; | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
473 CardIdx_t card_index = from_card - from_hr_bot_card_index; |
|
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3830
diff
changeset
|
474 assert(0 <= card_index && (size_t)card_index < HeapRegion::CardsPerRegion, |
| 342 | 475 "Must be in range."); |
| 476 if (G1HRRSUseSparseTable && | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
477 _sparse_table.add_card(from_hrs_ind, card_index)) { |
| 342 | 478 if (G1RecordHRRSOops) { |
| 479 HeapRegionRemSet::record(hr(), from); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
480 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
481 gclog_or_tty->print(" Added card " PTR_FORMAT " to region " |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
482 "[" PTR_FORMAT "...) for ref " PTR_FORMAT ".\n", |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
483 align_size_down(uintptr_t(from), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
484 CardTableModRefBS::card_size), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
485 hr()->bottom(), from); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
486 } |
| 342 | 487 } |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
488 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
489 gclog_or_tty->print_cr(" added card to sparse table."); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
490 } |
| 342 | 491 assert(contains_reference_locked(from), "We just added it!"); |
| 492 return; | |
| 493 } else { | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
494 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
495 gclog_or_tty->print_cr(" [tid %d] sparse table entry " |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
496 "overflow(f: %d, t: %u)", |
|
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
497 tid, from_hrs_ind, cur_hrm_ind); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
498 } |
| 342 | 499 } |
| 500 | |
| 501 if (_n_fine_entries == _max_fine_entries) { | |
| 502 prt = delete_region_table(); | |
| 6253 | 503 // There is no need to clear the links to the 'all' list here: |
| 504 // prt will be reused immediately, i.e. remain in the 'all' list. | |
| 505 prt->init(from_hr, false /* clear_links_to_all_list */); | |
| 342 | 506 } else { |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
507 prt = PerRegionTable::alloc(from_hr); |
| 6253 | 508 link_to_all(prt); |
| 342 | 509 } |
| 510 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
511 PerRegionTable* first_prt = _fine_grain_regions[ind]; |
| 6253 | 512 prt->set_collision_list_next(first_prt); |
| 342 | 513 _fine_grain_regions[ind] = prt; |
| 514 _n_fine_entries++; | |
| 515 | |
| 516 if (G1HRRSUseSparseTable) { | |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
517 // Transfer from sparse to fine-grain. |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
518 SparsePRTEntry *sprt_entry = _sparse_table.get_entry(from_hrs_ind); |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
519 assert(sprt_entry != NULL, "There should have been an entry"); |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
520 for (int i = 0; i < SparsePRTEntry::cards_num(); i++) { |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
521 CardIdx_t c = sprt_entry->card(i); |
| 342 | 522 if (c != SparsePRTEntry::NullEntry) { |
| 523 prt->add_card(c); | |
| 524 } | |
| 525 } | |
| 526 // Now we can delete the sparse entry. | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
527 bool res = _sparse_table.delete_entry(from_hrs_ind); |
| 342 | 528 assert(res, "It should have been there."); |
| 529 } | |
| 530 } | |
| 531 assert(prt != NULL && prt->hr() == from_hr, "consequence"); | |
| 532 } | |
| 533 // Note that we can't assert "prt->hr() == from_hr", because of the | |
| 534 // possibility of concurrent reuse. But see head comment of | |
| 535 // OtherRegionsTable for why this is OK. | |
| 536 assert(prt != NULL, "Inv"); | |
| 537 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
538 prt->add_reference(from); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
539 |
| 342 | 540 if (G1RecordHRRSOops) { |
| 541 HeapRegionRemSet::record(hr(), from); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
542 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
543 gclog_or_tty->print("Added card " PTR_FORMAT " to region " |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
544 "[" PTR_FORMAT "...) for ref " PTR_FORMAT ".\n", |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
545 align_size_down(uintptr_t(from), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
546 CardTableModRefBS::card_size), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
547 hr()->bottom(), from); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
548 } |
| 342 | 549 } |
| 550 assert(contains_reference(from), "We just added it!"); | |
| 551 } | |
| 552 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
553 PerRegionTable* |
| 342 | 554 OtherRegionsTable::find_region_table(size_t ind, HeapRegion* hr) const { |
| 555 assert(0 <= ind && ind < _max_fine_entries, "Preconditions."); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
556 PerRegionTable* prt = _fine_grain_regions[ind]; |
| 342 | 557 while (prt != NULL && prt->hr() != hr) { |
| 6253 | 558 prt = prt->collision_list_next(); |
| 342 | 559 } |
| 560 // Loop postcondition is the method postcondition. | |
| 561 return prt; | |
| 562 } | |
| 563 | |
| 564 jint OtherRegionsTable::_n_coarsenings = 0; | |
| 565 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
566 PerRegionTable* OtherRegionsTable::delete_region_table() { |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
567 assert(_m->owned_by_self(), "Precondition"); |
| 342 | 568 assert(_n_fine_entries == _max_fine_entries, "Precondition"); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
569 PerRegionTable* max = NULL; |
| 342 | 570 jint max_occ = 0; |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
571 PerRegionTable** max_prev; |
| 342 | 572 size_t max_ind; |
| 573 | |
| 574 size_t i = _fine_eviction_start; | |
| 575 for (size_t k = 0; k < _fine_eviction_sample_size; k++) { | |
| 576 size_t ii = i; | |
| 577 // Make sure we get a non-NULL sample. | |
| 578 while (_fine_grain_regions[ii] == NULL) { | |
| 579 ii++; | |
| 580 if (ii == _max_fine_entries) ii = 0; | |
| 581 guarantee(ii != i, "We must find one."); | |
| 582 } | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
583 PerRegionTable** prev = &_fine_grain_regions[ii]; |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
584 PerRegionTable* cur = *prev; |
| 342 | 585 while (cur != NULL) { |
| 586 jint cur_occ = cur->occupied(); | |
| 587 if (max == NULL || cur_occ > max_occ) { | |
| 588 max = cur; | |
| 589 max_prev = prev; | |
| 590 max_ind = i; | |
| 591 max_occ = cur_occ; | |
| 592 } | |
| 6253 | 593 prev = cur->collision_list_next_addr(); |
| 594 cur = cur->collision_list_next(); | |
| 342 | 595 } |
| 596 i = i + _fine_eviction_stride; | |
| 597 if (i >= _n_fine_entries) i = i - _n_fine_entries; | |
| 598 } | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
599 |
| 342 | 600 _fine_eviction_start++; |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
601 |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
602 if (_fine_eviction_start >= _n_fine_entries) { |
| 342 | 603 _fine_eviction_start -= _n_fine_entries; |
| 604 } | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
605 |
| 342 | 606 guarantee(max != NULL, "Since _n_fine_entries > 0"); |
| 607 | |
| 608 // Set the corresponding coarse bit. | |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
609 size_t max_hrm_index = (size_t) max->hr()->hrm_index(); |
|
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
610 if (!_coarse_map.at(max_hrm_index)) { |
|
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
611 _coarse_map.at_put(max_hrm_index, true); |
| 342 | 612 _n_coarse_entries++; |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
613 if (G1TraceHeapRegionRememberedSet) { |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
614 gclog_or_tty->print("Coarsened entry in region [" PTR_FORMAT "...] " |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
615 "for region [" PTR_FORMAT "...] (%d coarse entries).\n", |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
616 hr()->bottom(), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
617 max->hr()->bottom(), |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
618 _n_coarse_entries); |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
619 } |
| 342 | 620 } |
| 621 | |
| 622 // Unsplice. | |
| 6253 | 623 *max_prev = max->collision_list_next(); |
| 342 | 624 Atomic::inc(&_n_coarsenings); |
| 625 _n_fine_entries--; | |
| 626 return max; | |
| 627 } | |
| 628 | |
| 629 | |
| 630 // At present, this must be called stop-world single-threaded. | |
| 631 void OtherRegionsTable::scrub(CardTableModRefBS* ctbs, | |
| 632 BitMap* region_bm, BitMap* card_bm) { | |
| 633 // First eliminated garbage regions from the coarse map. | |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
634 if (G1RSScrubVerbose) { |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
635 gclog_or_tty->print_cr("Scrubbing region %u:", hr()->hrm_index()); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
636 } |
| 342 | 637 |
| 638 assert(_coarse_map.size() == region_bm->size(), "Precondition"); | |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
639 if (G1RSScrubVerbose) { |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
640 gclog_or_tty->print(" Coarse map: before = "SIZE_FORMAT"...", |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
641 _n_coarse_entries); |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
642 } |
| 342 | 643 _coarse_map.set_intersection(*region_bm); |
| 644 _n_coarse_entries = _coarse_map.count_one_bits(); | |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
645 if (G1RSScrubVerbose) { |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
646 gclog_or_tty->print_cr(" after = "SIZE_FORMAT".", _n_coarse_entries); |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
647 } |
| 342 | 648 |
| 649 // Now do the fine-grained maps. | |
| 650 for (size_t i = 0; i < _max_fine_entries; i++) { | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
651 PerRegionTable* cur = _fine_grain_regions[i]; |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
652 PerRegionTable** prev = &_fine_grain_regions[i]; |
| 342 | 653 while (cur != NULL) { |
| 6253 | 654 PerRegionTable* nxt = cur->collision_list_next(); |
| 342 | 655 // If the entire region is dead, eliminate. |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
656 if (G1RSScrubVerbose) { |
|
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
657 gclog_or_tty->print_cr(" For other region %u:", |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
658 cur->hr()->hrm_index()); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
659 } |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
660 if (!region_bm->at((size_t) cur->hr()->hrm_index())) { |
| 342 | 661 *prev = nxt; |
| 6253 | 662 cur->set_collision_list_next(NULL); |
| 342 | 663 _n_fine_entries--; |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
664 if (G1RSScrubVerbose) { |
| 342 | 665 gclog_or_tty->print_cr(" deleted via region map."); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
666 } |
| 6253 | 667 unlink_from_all(cur); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
668 PerRegionTable::free(cur); |
| 342 | 669 } else { |
| 670 // Do fine-grain elimination. | |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
671 if (G1RSScrubVerbose) { |
| 342 | 672 gclog_or_tty->print(" occ: before = %4d.", cur->occupied()); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
673 } |
| 342 | 674 cur->scrub(ctbs, card_bm); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
675 if (G1RSScrubVerbose) { |
| 342 | 676 gclog_or_tty->print_cr(" after = %4d.", cur->occupied()); |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
677 } |
| 342 | 678 // Did that empty the table completely? |
| 679 if (cur->occupied() == 0) { | |
| 680 *prev = nxt; | |
| 6253 | 681 cur->set_collision_list_next(NULL); |
| 342 | 682 _n_fine_entries--; |
| 6253 | 683 unlink_from_all(cur); |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
684 PerRegionTable::free(cur); |
| 342 | 685 } else { |
| 6253 | 686 prev = cur->collision_list_next_addr(); |
| 342 | 687 } |
| 688 } | |
| 689 cur = nxt; | |
| 690 } | |
| 691 } | |
| 692 // Since we may have deleted a from_card_cache entry from the RS, clear | |
| 693 // the FCC. | |
| 694 clear_fcc(); | |
| 695 } | |
| 696 | |
|
20296
a3953c777565
8027959: Early reclamation of large objects in G1
tschatzl
parents:
20278
diff
changeset
|
697 bool OtherRegionsTable::is_empty() const { |
|
a3953c777565
8027959: Early reclamation of large objects in G1
tschatzl
parents:
20278
diff
changeset
|
698 return occ_sparse() == 0 && occ_coarse() == 0 && _first_all_fine_prts == NULL; |
|
a3953c777565
8027959: Early reclamation of large objects in G1
tschatzl
parents:
20278
diff
changeset
|
699 } |
| 342 | 700 |
| 701 size_t OtherRegionsTable::occupied() const { | |
| 702 size_t sum = occ_fine(); | |
| 703 sum += occ_sparse(); | |
| 704 sum += occ_coarse(); | |
| 705 return sum; | |
| 706 } | |
| 707 | |
| 708 size_t OtherRegionsTable::occ_fine() const { | |
| 709 size_t sum = 0; | |
| 6253 | 710 |
| 711 size_t num = 0; | |
| 712 PerRegionTable * cur = _first_all_fine_prts; | |
| 713 while (cur != NULL) { | |
| 714 sum += cur->occupied(); | |
| 715 cur = cur->next(); | |
| 716 num++; | |
| 342 | 717 } |
| 6253 | 718 guarantee(num == _n_fine_entries, "just checking"); |
| 342 | 719 return sum; |
| 720 } | |
| 721 | |
| 722 size_t OtherRegionsTable::occ_coarse() const { | |
|
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
845
diff
changeset
|
723 return (_n_coarse_entries * HeapRegion::CardsPerRegion); |
| 342 | 724 } |
| 725 | |
| 726 size_t OtherRegionsTable::occ_sparse() const { | |
| 727 return _sparse_table.occupied(); | |
| 728 } | |
| 729 | |
| 730 size_t OtherRegionsTable::mem_size() const { | |
| 731 size_t sum = 0; | |
|
10290
05a17f270c7e
8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
tschatzl
parents:
10193
diff
changeset
|
732 // all PRTs are of the same size so it is sufficient to query only one of them. |
|
05a17f270c7e
8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
tschatzl
parents:
10193
diff
changeset
|
733 if (_first_all_fine_prts != NULL) { |
|
05a17f270c7e
8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
tschatzl
parents:
10193
diff
changeset
|
734 assert(_last_all_fine_prts != NULL && |
|
05a17f270c7e
8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
tschatzl
parents:
10193
diff
changeset
|
735 _first_all_fine_prts->mem_size() == _last_all_fine_prts->mem_size(), "check that mem_size() is constant"); |
|
05a17f270c7e
8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
tschatzl
parents:
10193
diff
changeset
|
736 sum += _first_all_fine_prts->mem_size() * _n_fine_entries; |
| 342 | 737 } |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
738 sum += (sizeof(PerRegionTable*) * _max_fine_entries); |
| 342 | 739 sum += (_coarse_map.size_in_words() * HeapWordSize); |
| 740 sum += (_sparse_table.mem_size()); | |
|
20218
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
741 sum += sizeof(OtherRegionsTable) - sizeof(_sparse_table); // Avoid double counting above. |
| 342 | 742 return sum; |
| 743 } | |
| 744 | |
| 745 size_t OtherRegionsTable::static_mem_size() { | |
|
17758
ae7336d6337e
8034868: Extract G1 From Card Cache into separate class
tschatzl
parents:
17755
diff
changeset
|
746 return FromCardCache::static_mem_size(); |
| 342 | 747 } |
| 748 | |
| 749 size_t OtherRegionsTable::fl_mem_size() { | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
750 return PerRegionTable::fl_mem_size(); |
| 342 | 751 } |
| 752 | |
| 753 void OtherRegionsTable::clear_fcc() { | |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
754 FromCardCache::clear(hr()->hrm_index()); |
| 342 | 755 } |
| 756 | |
| 757 void OtherRegionsTable::clear() { | |
| 6253 | 758 // if there are no entries, skip this step |
| 759 if (_first_all_fine_prts != NULL) { | |
| 760 guarantee(_first_all_fine_prts != NULL && _last_all_fine_prts != NULL, "just checking"); | |
| 761 PerRegionTable::bulk_free(_first_all_fine_prts, _last_all_fine_prts); | |
| 762 memset(_fine_grain_regions, 0, _max_fine_entries * sizeof(_fine_grain_regions[0])); | |
| 763 } else { | |
| 764 guarantee(_first_all_fine_prts == NULL && _last_all_fine_prts == NULL, "just checking"); | |
| 342 | 765 } |
| 6253 | 766 |
| 767 _first_all_fine_prts = _last_all_fine_prts = NULL; | |
| 342 | 768 _sparse_table.clear(); |
| 769 _coarse_map.clear(); | |
| 770 _n_fine_entries = 0; | |
| 771 _n_coarse_entries = 0; | |
| 772 | |
| 773 clear_fcc(); | |
| 774 } | |
| 775 | |
| 776 bool OtherRegionsTable::del_single_region_table(size_t ind, | |
| 777 HeapRegion* hr) { | |
| 778 assert(0 <= ind && ind < _max_fine_entries, "Preconditions."); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
779 PerRegionTable** prev_addr = &_fine_grain_regions[ind]; |
|
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
780 PerRegionTable* prt = *prev_addr; |
| 342 | 781 while (prt != NULL && prt->hr() != hr) { |
| 6253 | 782 prev_addr = prt->collision_list_next_addr(); |
| 783 prt = prt->collision_list_next(); | |
| 342 | 784 } |
| 785 if (prt != NULL) { | |
| 786 assert(prt->hr() == hr, "Loop postcondition."); | |
| 6253 | 787 *prev_addr = prt->collision_list_next(); |
| 788 unlink_from_all(prt); | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
789 PerRegionTable::free(prt); |
| 342 | 790 _n_fine_entries--; |
| 791 return true; | |
| 792 } else { | |
| 793 return false; | |
| 794 } | |
| 795 } | |
| 796 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
797 bool OtherRegionsTable::contains_reference(OopOrNarrowOopStar from) const { |
| 342 | 798 // Cast away const in this case. |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
799 MutexLockerEx x((Mutex*)_m, Mutex::_no_safepoint_check_flag); |
| 342 | 800 return contains_reference_locked(from); |
| 801 } | |
| 802 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
803 bool OtherRegionsTable::contains_reference_locked(OopOrNarrowOopStar from) const { |
| 342 | 804 HeapRegion* hr = _g1h->heap_region_containing_raw(from); |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
805 RegionIdx_t hr_ind = (RegionIdx_t) hr->hrm_index(); |
| 342 | 806 // Is this region in the coarse map? |
| 807 if (_coarse_map.at(hr_ind)) return true; | |
| 808 | |
|
6188
7994a5a35fcf
6921087: G1: remove per-GC-thread expansion tables from the fine-grain remembered sets
johnc
parents:
6107
diff
changeset
|
809 PerRegionTable* prt = find_region_table(hr_ind & _mod_max_fine_entries_mask, |
| 342 | 810 hr); |
| 811 if (prt != NULL) { | |
| 812 return prt->contains_reference(from); | |
| 813 | |
| 814 } else { | |
| 815 uintptr_t from_card = | |
| 816 (uintptr_t(from) >> CardTableModRefBS::card_shift); | |
| 817 uintptr_t hr_bot_card_index = | |
| 818 uintptr_t(hr->bottom()) >> CardTableModRefBS::card_shift; | |
| 819 assert(from_card >= hr_bot_card_index, "Inv"); | |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
820 CardIdx_t card_index = from_card - hr_bot_card_index; |
|
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3830
diff
changeset
|
821 assert(0 <= card_index && (size_t)card_index < HeapRegion::CardsPerRegion, |
|
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
845
diff
changeset
|
822 "Must be in range."); |
|
807
d44bdab1c03d
6843694: G1: assert(index < _vs.committed_size(),"bad index"), g1BlockOffsetTable.inline.hpp:55
johnc
parents:
795
diff
changeset
|
823 return _sparse_table.contains_card(hr_ind, card_index); |
| 342 | 824 } |
| 825 } | |
| 826 | |
| 2173 | 827 void |
| 828 OtherRegionsTable::do_cleanup_work(HRRSCleanupTask* hrrs_cleanup_task) { | |
| 829 _sparse_table.do_cleanup_work(hrrs_cleanup_task); | |
| 830 } | |
| 831 | |
|
795
215f81b4d9b3
6841831: G1: assert(contains_reference(from),"We just added it!") fires
iveresov
parents:
794
diff
changeset
|
832 // Determines how many threads can add records to an rset in parallel. |
|
215f81b4d9b3
6841831: G1: assert(contains_reference(from),"We just added it!") fires
iveresov
parents:
794
diff
changeset
|
833 // This can be done by either mutator threads together with the |
|
215f81b4d9b3
6841831: G1: assert(contains_reference(from),"We just added it!") fires
iveresov
parents:
794
diff
changeset
|
834 // concurrent refinement threads or GC threads. |
|
17754
d7070f371770
8035815: Cache-align and pad the from card cache
tschatzl
parents:
17753
diff
changeset
|
835 uint HeapRegionRemSet::num_par_rem_sets() { |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17758
diff
changeset
|
836 return MAX2(DirtyCardQueueSet::num_par_ids() + ConcurrentG1Refine::thread_num(), (uint)ParallelGCThreads); |
| 342 | 837 } |
| 838 | |
| 839 HeapRegionRemSet::HeapRegionRemSet(G1BlockOffsetSharedArray* bosa, | |
| 840 HeapRegion* hr) | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
841 : _bosa(bosa), |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
842 _m(Mutex::leaf, FormatBuffer<128>("HeapRegionRemSet lock #%u", hr->hrm_index()), true), |
| 20337 | 843 _code_roots(), _other_regions(hr, &_m), _iter_state(Unclaimed), _iter_claimed(0) { |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
844 reset_for_par_iteration(); |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
845 } |
| 342 | 846 |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
847 void HeapRegionRemSet::setup_remset_size() { |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
848 // Setup sparse and fine-grain tables sizes. |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
849 // table_size = base * (log(region_size / 1M) + 1) |
|
6107
5c8bd7c16119
7171936: LOG_G incorrectly defined in globalDefinitions.hpp
brutisso
parents:
6010
diff
changeset
|
850 const int LOG_M = 20; |
|
5c8bd7c16119
7171936: LOG_G incorrectly defined in globalDefinitions.hpp
brutisso
parents:
6010
diff
changeset
|
851 int region_size_log_mb = MAX2(HeapRegion::LogOfHRGrainBytes - LOG_M, 0); |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
852 if (FLAG_IS_DEFAULT(G1RSetSparseRegionEntries)) { |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
853 G1RSetSparseRegionEntries = G1RSetSparseRegionEntriesBase * (region_size_log_mb + 1); |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
854 } |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
855 if (FLAG_IS_DEFAULT(G1RSetRegionEntries)) { |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
856 G1RSetRegionEntries = G1RSetRegionEntriesBase * (region_size_log_mb + 1); |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
857 } |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
858 guarantee(G1RSetSparseRegionEntries > 0 && G1RSetRegionEntries > 0 , "Sanity"); |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
859 } |
|
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
860 |
| 342 | 861 bool HeapRegionRemSet::claim_iter() { |
| 862 if (_iter_state != Unclaimed) return false; | |
| 863 jint res = Atomic::cmpxchg(Claimed, (jint*)(&_iter_state), Unclaimed); | |
| 864 return (res == Unclaimed); | |
| 865 } | |
| 866 | |
| 867 void HeapRegionRemSet::set_iter_complete() { | |
| 868 _iter_state = Complete; | |
| 869 } | |
| 870 | |
| 871 bool HeapRegionRemSet::iter_is_complete() { | |
| 872 return _iter_state == Complete; | |
| 873 } | |
| 874 | |
| 875 #ifndef PRODUCT | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
876 void HeapRegionRemSet::print() { |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
877 HeapRegionRemSetIterator iter(this); |
| 342 | 878 size_t card_index; |
| 879 while (iter.has_next(card_index)) { | |
| 880 HeapWord* card_start = | |
| 881 G1CollectedHeap::heap()->bot_shared()->address_for_index(card_index); | |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
882 gclog_or_tty->print_cr(" Card " PTR_FORMAT, card_start); |
| 342 | 883 } |
| 884 if (iter.n_yielded() != occupied()) { | |
| 885 gclog_or_tty->print_cr("Yielded disagrees with occupied:"); | |
| 886 gclog_or_tty->print_cr(" %6d yielded (%6d coarse, %6d fine).", | |
| 887 iter.n_yielded(), | |
| 888 iter.n_yielded_coarse(), iter.n_yielded_fine()); | |
| 889 gclog_or_tty->print_cr(" %6d occ (%6d coarse, %6d fine).", | |
| 890 occupied(), occ_coarse(), occ_fine()); | |
| 891 } | |
| 892 guarantee(iter.n_yielded() == occupied(), | |
| 893 "We should have yielded all the represented cards."); | |
| 894 } | |
| 895 #endif | |
| 896 | |
| 897 void HeapRegionRemSet::cleanup() { | |
| 898 SparsePRT::cleanup_all(); | |
| 899 } | |
| 900 | |
| 901 void HeapRegionRemSet::clear() { | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
902 MutexLockerEx x(&_m, Mutex::_no_safepoint_check_flag); |
|
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
903 clear_locked(); |
|
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
904 } |
| 12080 | 905 |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
906 void HeapRegionRemSet::clear_locked() { |
|
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
907 _code_roots.clear(); |
| 342 | 908 _other_regions.clear(); |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
909 assert(occupied_locked() == 0, "Should be clear."); |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
910 reset_for_par_iteration(); |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
911 } |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
912 |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
913 void HeapRegionRemSet::reset_for_par_iteration() { |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
914 _iter_state = Unclaimed; |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
915 _iter_claimed = 0; |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
916 // It's good to check this to make sure that the two methods are in sync. |
|
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3766
diff
changeset
|
917 assert(verify_ready_for_par_iteration(), "post-condition"); |
| 342 | 918 } |
| 919 | |
| 920 void HeapRegionRemSet::scrub(CardTableModRefBS* ctbs, | |
| 921 BitMap* region_bm, BitMap* card_bm) { | |
| 922 _other_regions.scrub(ctbs, region_bm, card_bm); | |
| 923 } | |
| 924 | |
| 12080 | 925 // Code roots support |
| 926 | |
| 927 void HeapRegionRemSet::add_strong_code_root(nmethod* nm) { | |
| 928 assert(nm != NULL, "sanity"); | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
929 _code_roots.add(nm); |
| 12080 | 930 } |
| 931 | |
| 932 void HeapRegionRemSet::remove_strong_code_root(nmethod* nm) { | |
| 933 assert(nm != NULL, "sanity"); | |
|
20278
2c6ef90f030a
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
20218
diff
changeset
|
934 assert_locked_or_safepoint(CodeCache_lock); |
|
2c6ef90f030a
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
20218
diff
changeset
|
935 |
|
2c6ef90f030a
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
20218
diff
changeset
|
936 _code_roots.remove_lock_free(nm); |
|
2c6ef90f030a
8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents:
20218
diff
changeset
|
937 |
| 12080 | 938 // Check that there were no duplicates |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
939 guarantee(!_code_roots.contains(nm), "duplicate entry found"); |
| 12080 | 940 } |
| 941 | |
| 942 class NMethodMigrationOopClosure : public OopClosure { | |
| 943 G1CollectedHeap* _g1h; | |
| 944 HeapRegion* _from; | |
| 945 nmethod* _nm; | |
| 946 | |
| 947 uint _num_self_forwarded; | |
| 948 | |
| 949 template <class T> void do_oop_work(T* p) { | |
| 950 T heap_oop = oopDesc::load_heap_oop(p); | |
| 951 if (!oopDesc::is_null(heap_oop)) { | |
| 952 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
| 953 if (_from->is_in(obj)) { | |
| 954 // Reference still points into the source region. | |
| 955 // Since roots are immediately evacuated this means that | |
| 956 // we must have self forwarded the object | |
| 957 assert(obj->is_forwarded(), | |
| 958 err_msg("code roots should be immediately evacuated. " | |
| 959 "Ref: "PTR_FORMAT", " | |
| 960 "Obj: "PTR_FORMAT", " | |
| 961 "Region: "HR_FORMAT, | |
| 962 p, (void*) obj, HR_FORMAT_PARAMS(_from))); | |
| 963 assert(obj->forwardee() == obj, | |
| 964 err_msg("not self forwarded? obj = "PTR_FORMAT, (void*)obj)); | |
| 965 | |
| 966 // The object has been self forwarded. | |
| 967 // Note, if we're during an initial mark pause, there is | |
| 968 // no need to explicitly mark object. It will be marked | |
| 969 // during the regular evacuation failure handling code. | |
| 970 _num_self_forwarded++; | |
| 971 } else { | |
| 972 // The reference points into a promotion or to-space region | |
| 973 HeapRegion* to = _g1h->heap_region_containing(obj); | |
| 974 to->rem_set()->add_strong_code_root(_nm); | |
| 975 } | |
| 976 } | |
| 977 } | |
| 978 | |
| 979 public: | |
| 980 NMethodMigrationOopClosure(G1CollectedHeap* g1h, HeapRegion* from, nmethod* nm): | |
| 981 _g1h(g1h), _from(from), _nm(nm), _num_self_forwarded(0) {} | |
| 982 | |
| 983 void do_oop(narrowOop* p) { do_oop_work(p); } | |
| 984 void do_oop(oop* p) { do_oop_work(p); } | |
| 985 | |
| 986 uint retain() { return _num_self_forwarded > 0; } | |
| 987 }; | |
| 988 | |
| 989 void HeapRegionRemSet::migrate_strong_code_roots() { | |
| 990 assert(hr()->in_collection_set(), "only collection set regions"); | |
|
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
12316
diff
changeset
|
991 assert(!hr()->isHumongous(), |
|
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
12316
diff
changeset
|
992 err_msg("humongous region "HR_FORMAT" should not have been added to the collection set", |
|
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
12316
diff
changeset
|
993 HR_FORMAT_PARAMS(hr()))); |
| 12080 | 994 |
| 995 ResourceMark rm; | |
| 996 | |
| 997 // List of code blobs to retain for this region | |
| 998 GrowableArray<nmethod*> to_be_retained(10); | |
| 999 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
| 1000 | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
1001 while (!_code_roots.is_empty()) { |
|
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
1002 nmethod *nm = _code_roots.pop(); |
| 12080 | 1003 if (nm != NULL) { |
| 1004 NMethodMigrationOopClosure oop_cl(g1h, hr(), nm); | |
| 1005 nm->oops_do(&oop_cl); | |
| 1006 if (oop_cl.retain()) { | |
| 1007 to_be_retained.push(nm); | |
| 1008 } | |
| 1009 } | |
| 1010 } | |
| 1011 | |
| 1012 // Now push any code roots we need to retain | |
| 1013 assert(to_be_retained.is_empty() || hr()->evacuation_failed(), | |
| 1014 "Retained nmethod list must be empty or " | |
| 1015 "evacuation of this region failed"); | |
| 1016 | |
| 1017 while (to_be_retained.is_nonempty()) { | |
| 1018 nmethod* nm = to_be_retained.pop(); | |
| 1019 assert(nm != NULL, "sanity"); | |
| 1020 add_strong_code_root(nm); | |
| 1021 } | |
| 1022 } | |
| 1023 | |
| 1024 void HeapRegionRemSet::strong_code_roots_do(CodeBlobClosure* blk) const { | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
1025 _code_roots.nmethods_do(blk); |
| 12080 | 1026 } |
| 1027 | |
| 1028 size_t HeapRegionRemSet::strong_code_roots_mem_size() { | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
1029 return _code_roots.mem_size(); |
| 12080 | 1030 } |
| 1031 | |
|
17753
191174b49bec
8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
13062
diff
changeset
|
1032 HeapRegionRemSetIterator:: HeapRegionRemSetIterator(HeapRegionRemSet* hrrs) : |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1033 _hrrs(hrrs), |
| 342 | 1034 _g1h(G1CollectedHeap::heap()), |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1035 _coarse_map(&hrrs->_other_regions._coarse_map), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1036 _bosa(hrrs->bosa()), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1037 _is(Sparse), |
| 342 | 1038 // Set these values so that we increment to the first region. |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1039 _coarse_cur_region_index(-1), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1040 _coarse_cur_region_cur_card(HeapRegion::CardsPerRegion-1), |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1041 _cur_card_in_prt(HeapRegion::CardsPerRegion), |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1042 _fine_cur_prt(NULL), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1043 _n_yielded_coarse(0), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1044 _n_yielded_fine(0), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1045 _n_yielded_sparse(0), |
|
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1046 _sparse_iter(&hrrs->_other_regions._sparse_table) {} |
| 342 | 1047 |
| 1048 bool HeapRegionRemSetIterator::coarse_has_next(size_t& card_index) { | |
| 1049 if (_hrrs->_other_regions._n_coarse_entries == 0) return false; | |
| 1050 // Go to the next card. | |
| 1051 _coarse_cur_region_cur_card++; | |
| 1052 // Was the last the last card in the current region? | |
|
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
845
diff
changeset
|
1053 if (_coarse_cur_region_cur_card == HeapRegion::CardsPerRegion) { |
| 342 | 1054 // Yes: find the next region. This may leave _coarse_cur_region_index |
| 1055 // Set to the last index, in which case there are no more coarse | |
| 1056 // regions. | |
| 1057 _coarse_cur_region_index = | |
| 1058 (int) _coarse_map->get_next_one_offset(_coarse_cur_region_index + 1); | |
| 1059 if ((size_t)_coarse_cur_region_index < _coarse_map->size()) { | |
| 1060 _coarse_cur_region_cur_card = 0; | |
| 1061 HeapWord* r_bot = | |
|
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
4020
diff
changeset
|
1062 _g1h->region_at((uint) _coarse_cur_region_index)->bottom(); |
| 342 | 1063 _cur_region_card_offset = _bosa->index_for(r_bot); |
| 1064 } else { | |
| 1065 return false; | |
| 1066 } | |
| 1067 } | |
| 1068 // If we didn't return false above, then we can yield a card. | |
| 1069 card_index = _cur_region_card_offset + _coarse_cur_region_cur_card; | |
| 1070 return true; | |
| 1071 } | |
| 1072 | |
| 1073 bool HeapRegionRemSetIterator::fine_has_next(size_t& card_index) { | |
| 1074 if (fine_has_next()) { | |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1075 _cur_card_in_prt = |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1076 _fine_cur_prt->_bm.get_next_one_offset(_cur_card_in_prt + 1); |
| 342 | 1077 } |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1078 if (_cur_card_in_prt == HeapRegion::CardsPerRegion) { |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1079 // _fine_cur_prt may still be NULL in case if there are not PRTs at all for |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1080 // the remembered set. |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1081 if (_fine_cur_prt == NULL || _fine_cur_prt->next() == NULL) { |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1082 return false; |
| 342 | 1083 } |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1084 PerRegionTable* next_prt = _fine_cur_prt->next(); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1085 switch_to_prt(next_prt); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1086 _cur_card_in_prt = _fine_cur_prt->_bm.get_next_one_offset(_cur_card_in_prt + 1); |
| 342 | 1087 } |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1088 |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1089 card_index = _cur_region_card_offset + _cur_card_in_prt; |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1090 guarantee(_cur_card_in_prt < HeapRegion::CardsPerRegion, |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1091 err_msg("Card index "SIZE_FORMAT" must be within the region", _cur_card_in_prt)); |
| 342 | 1092 return true; |
| 1093 } | |
| 1094 | |
| 1095 bool HeapRegionRemSetIterator::fine_has_next() { | |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1096 return _cur_card_in_prt != HeapRegion::CardsPerRegion; |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1097 } |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1098 |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1099 void HeapRegionRemSetIterator::switch_to_prt(PerRegionTable* prt) { |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1100 assert(prt != NULL, "Cannot switch to NULL prt"); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1101 _fine_cur_prt = prt; |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1102 |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1103 HeapWord* r_bot = _fine_cur_prt->hr()->bottom(); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1104 _cur_region_card_offset = _bosa->index_for(r_bot); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1105 |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1106 // The bitmap scan for the PRT always scans from _cur_region_cur_card + 1. |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1107 // To avoid special-casing this start case, and not miss the first bitmap |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1108 // entry, initialize _cur_region_cur_card with -1 instead of 0. |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1109 _cur_card_in_prt = (size_t)-1; |
| 342 | 1110 } |
| 1111 | |
| 1112 bool HeapRegionRemSetIterator::has_next(size_t& card_index) { | |
| 1113 switch (_is) { | |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1114 case Sparse: { |
| 342 | 1115 if (_sparse_iter.has_next(card_index)) { |
| 1116 _n_yielded_sparse++; | |
| 1117 return true; | |
| 1118 } | |
| 1119 // Otherwise, deliberate fall-through | |
| 1120 _is = Fine; | |
|
20213
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1121 PerRegionTable* initial_fine_prt = _hrrs->_other_regions._first_all_fine_prts; |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1122 if (initial_fine_prt != NULL) { |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1123 switch_to_prt(_hrrs->_other_regions._first_all_fine_prts); |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1124 } |
|
ff7b317d2af8
8037344: Use the "next" field to iterate over fine remembered instead of using the hash table
tschatzl
parents:
17937
diff
changeset
|
1125 } |
| 342 | 1126 case Fine: |
| 1127 if (fine_has_next(card_index)) { | |
| 1128 _n_yielded_fine++; | |
| 1129 return true; | |
| 1130 } | |
| 1131 // Otherwise, deliberate fall-through | |
| 1132 _is = Coarse; | |
| 1133 case Coarse: | |
| 1134 if (coarse_has_next(card_index)) { | |
| 1135 _n_yielded_coarse++; | |
| 1136 return true; | |
| 1137 } | |
| 1138 // Otherwise... | |
| 1139 break; | |
| 1140 } | |
| 1141 assert(ParallelGCThreads > 1 || | |
| 1142 n_yielded() == _hrrs->occupied(), | |
| 1143 "Should have yielded all the cards in the rem set " | |
| 1144 "(in the non-par case)."); | |
| 1145 return false; | |
| 1146 } | |
| 1147 | |
| 1148 | |
| 1149 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1150 OopOrNarrowOopStar* HeapRegionRemSet::_recorded_oops = NULL; |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1151 HeapWord** HeapRegionRemSet::_recorded_cards = NULL; |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1152 HeapRegion** HeapRegionRemSet::_recorded_regions = NULL; |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1153 int HeapRegionRemSet::_n_recorded = 0; |
| 342 | 1154 |
| 1155 HeapRegionRemSet::Event* HeapRegionRemSet::_recorded_events = NULL; | |
| 1156 int* HeapRegionRemSet::_recorded_event_index = NULL; | |
| 1157 int HeapRegionRemSet::_n_recorded_events = 0; | |
| 1158 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1159 void HeapRegionRemSet::record(HeapRegion* hr, OopOrNarrowOopStar f) { |
| 342 | 1160 if (_recorded_oops == NULL) { |
| 1161 assert(_n_recorded == 0 | |
| 1162 && _recorded_cards == NULL | |
| 1163 && _recorded_regions == NULL, | |
| 1164 "Inv"); | |
| 6197 | 1165 _recorded_oops = NEW_C_HEAP_ARRAY(OopOrNarrowOopStar, MaxRecorded, mtGC); |
| 1166 _recorded_cards = NEW_C_HEAP_ARRAY(HeapWord*, MaxRecorded, mtGC); | |
| 1167 _recorded_regions = NEW_C_HEAP_ARRAY(HeapRegion*, MaxRecorded, mtGC); | |
| 342 | 1168 } |
| 1169 if (_n_recorded == MaxRecorded) { | |
| 1170 gclog_or_tty->print_cr("Filled up 'recorded' (%d).", MaxRecorded); | |
| 1171 } else { | |
| 1172 _recorded_cards[_n_recorded] = | |
| 1173 (HeapWord*)align_size_down(uintptr_t(f), | |
| 1174 CardTableModRefBS::card_size); | |
| 1175 _recorded_oops[_n_recorded] = f; | |
| 1176 _recorded_regions[_n_recorded] = hr; | |
| 1177 _n_recorded++; | |
| 1178 } | |
| 1179 } | |
| 1180 | |
| 1181 void HeapRegionRemSet::record_event(Event evnt) { | |
| 1182 if (!G1RecordHRRSEvents) return; | |
| 1183 | |
| 1184 if (_recorded_events == NULL) { | |
| 1185 assert(_n_recorded_events == 0 | |
| 1186 && _recorded_event_index == NULL, | |
| 1187 "Inv"); | |
| 6197 | 1188 _recorded_events = NEW_C_HEAP_ARRAY(Event, MaxRecordedEvents, mtGC); |
| 1189 _recorded_event_index = NEW_C_HEAP_ARRAY(int, MaxRecordedEvents, mtGC); | |
| 342 | 1190 } |
| 1191 if (_n_recorded_events == MaxRecordedEvents) { | |
| 1192 gclog_or_tty->print_cr("Filled up 'recorded_events' (%d).", MaxRecordedEvents); | |
| 1193 } else { | |
| 1194 _recorded_events[_n_recorded_events] = evnt; | |
| 1195 _recorded_event_index[_n_recorded_events] = _n_recorded; | |
| 1196 _n_recorded_events++; | |
| 1197 } | |
| 1198 } | |
| 1199 | |
| 1200 void HeapRegionRemSet::print_event(outputStream* str, Event evnt) { | |
| 1201 switch (evnt) { | |
| 1202 case Event_EvacStart: | |
| 1203 str->print("Evac Start"); | |
| 1204 break; | |
| 1205 case Event_EvacEnd: | |
| 1206 str->print("Evac End"); | |
| 1207 break; | |
| 1208 case Event_RSUpdateEnd: | |
| 1209 str->print("RS Update End"); | |
| 1210 break; | |
| 1211 } | |
| 1212 } | |
| 1213 | |
| 1214 void HeapRegionRemSet::print_recorded() { | |
| 1215 int cur_evnt = 0; | |
| 1216 Event cur_evnt_kind; | |
| 1217 int cur_evnt_ind = 0; | |
| 1218 if (_n_recorded_events > 0) { | |
| 1219 cur_evnt_kind = _recorded_events[cur_evnt]; | |
| 1220 cur_evnt_ind = _recorded_event_index[cur_evnt]; | |
| 1221 } | |
| 1222 | |
| 1223 for (int i = 0; i < _n_recorded; i++) { | |
| 1224 while (cur_evnt < _n_recorded_events && i == cur_evnt_ind) { | |
| 1225 gclog_or_tty->print("Event: "); | |
| 1226 print_event(gclog_or_tty, cur_evnt_kind); | |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
1227 gclog_or_tty->cr(); |
| 342 | 1228 cur_evnt++; |
| 1229 if (cur_evnt < MaxRecordedEvents) { | |
| 1230 cur_evnt_kind = _recorded_events[cur_evnt]; | |
| 1231 cur_evnt_ind = _recorded_event_index[cur_evnt]; | |
| 1232 } | |
| 1233 } | |
| 1234 gclog_or_tty->print("Added card " PTR_FORMAT " to region [" PTR_FORMAT "...]" | |
| 1235 " for ref " PTR_FORMAT ".\n", | |
| 1236 _recorded_cards[i], _recorded_regions[i]->bottom(), | |
| 1237 _recorded_oops[i]); | |
| 1238 } | |
| 1239 } | |
| 1240 | |
| 2173 | 1241 void HeapRegionRemSet::reset_for_cleanup_tasks() { |
| 1242 SparsePRT::reset_for_cleanup_tasks(); | |
| 1243 } | |
| 1244 | |
| 1245 void HeapRegionRemSet::do_cleanup_work(HRRSCleanupTask* hrrs_cleanup_task) { | |
| 1246 _other_regions.do_cleanup_work(hrrs_cleanup_task); | |
| 1247 } | |
| 1248 | |
| 1249 void | |
| 1250 HeapRegionRemSet::finish_cleanup_task(HRRSCleanupTask* hrrs_cleanup_task) { | |
| 1251 SparsePRT::finish_cleanup_task(hrrs_cleanup_task); | |
| 1252 } | |
| 1253 | |
| 342 | 1254 #ifndef PRODUCT |
|
10333
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1255 void PerRegionTable::test_fl_mem_size() { |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1256 PerRegionTable* dummy = alloc(NULL); |
|
20218
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
1257 |
|
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
1258 size_t min_prt_size = sizeof(void*) + dummy->bm()->size_in_words() * HeapWordSize; |
|
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
1259 assert(dummy->mem_size() > min_prt_size, |
|
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
1260 err_msg("PerRegionTable memory usage is suspiciously small, only has "SIZE_FORMAT" bytes. " |
|
828056cf311f
8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname)
tschatzl
parents:
20214
diff
changeset
|
1261 "Should be at least "SIZE_FORMAT" bytes.", dummy->mem_size(), min_prt_size)); |
|
10333
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1262 free(dummy); |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1263 guarantee(dummy->mem_size() == fl_mem_size(), "fl_mem_size() does not return the correct element size"); |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1264 // try to reset the state |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1265 _free_list = NULL; |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1266 delete dummy; |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1267 } |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1268 |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1269 void HeapRegionRemSet::test_prt() { |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1270 PerRegionTable::test_fl_mem_size(); |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1271 } |
|
6702da6b6082
8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
tschatzl
parents:
10293
diff
changeset
|
1272 |
| 342 | 1273 void HeapRegionRemSet::test() { |
| 1274 os::sleep(Thread::current(), (jlong)5000, false); | |
| 1275 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
| 1276 | |
|
1261
0414c1049f15
6923991: G1: improve scalability of RSet scanning
iveresov
parents:
1259
diff
changeset
|
1277 // Run with "-XX:G1LogRSetRegionEntries=2", so that 1 and 5 end up in same |
| 342 | 1278 // hash bucket. |
| 1279 HeapRegion* hr0 = g1h->region_at(0); | |
| 1280 HeapRegion* hr1 = g1h->region_at(1); | |
| 1281 HeapRegion* hr2 = g1h->region_at(5); | |
| 1282 HeapRegion* hr3 = g1h->region_at(6); | |
| 1283 HeapRegion* hr4 = g1h->region_at(7); | |
| 1284 HeapRegion* hr5 = g1h->region_at(8); | |
| 1285 | |
| 1286 HeapWord* hr1_start = hr1->bottom(); | |
| 1287 HeapWord* hr1_mid = hr1_start + HeapRegion::GrainWords/2; | |
| 1288 HeapWord* hr1_last = hr1->end() - 1; | |
| 1289 | |
| 1290 HeapWord* hr2_start = hr2->bottom(); | |
| 1291 HeapWord* hr2_mid = hr2_start + HeapRegion::GrainWords/2; | |
| 1292 HeapWord* hr2_last = hr2->end() - 1; | |
| 1293 | |
| 1294 HeapWord* hr3_start = hr3->bottom(); | |
| 1295 HeapWord* hr3_mid = hr3_start + HeapRegion::GrainWords/2; | |
| 1296 HeapWord* hr3_last = hr3->end() - 1; | |
| 1297 | |
| 1298 HeapRegionRemSet* hrrs = hr0->rem_set(); | |
| 1299 | |
| 1300 // Make three references from region 0x101... | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1301 hrrs->add_reference((OopOrNarrowOopStar)hr1_start); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1302 hrrs->add_reference((OopOrNarrowOopStar)hr1_mid); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1303 hrrs->add_reference((OopOrNarrowOopStar)hr1_last); |
| 342 | 1304 |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1305 hrrs->add_reference((OopOrNarrowOopStar)hr2_start); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1306 hrrs->add_reference((OopOrNarrowOopStar)hr2_mid); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1307 hrrs->add_reference((OopOrNarrowOopStar)hr2_last); |
| 342 | 1308 |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1309 hrrs->add_reference((OopOrNarrowOopStar)hr3_start); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1310 hrrs->add_reference((OopOrNarrowOopStar)hr3_mid); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1311 hrrs->add_reference((OopOrNarrowOopStar)hr3_last); |
| 342 | 1312 |
| 1313 // Now cause a coarsening. | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1314 hrrs->add_reference((OopOrNarrowOopStar)hr4->bottom()); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
807
diff
changeset
|
1315 hrrs->add_reference((OopOrNarrowOopStar)hr5->bottom()); |
| 342 | 1316 |
| 1317 // Now, does iteration yield these three? | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6750
diff
changeset
|
1318 HeapRegionRemSetIterator iter(hrrs); |
| 342 | 1319 size_t sum = 0; |
| 1320 size_t card_index; | |
| 1321 while (iter.has_next(card_index)) { | |
| 1322 HeapWord* card_start = | |
| 1323 G1CollectedHeap::heap()->bot_shared()->address_for_index(card_index); | |
| 1324 gclog_or_tty->print_cr(" Card " PTR_FORMAT ".", card_start); | |
| 1325 sum++; | |
| 1326 } | |
| 1327 guarantee(sum == 11 - 3 + 2048, "Failure"); | |
| 1328 guarantee(sum == hrrs->occupied(), "Failure"); | |
| 1329 } | |
| 1330 #endif |