annotate src/share/vm/interpreter/bytecodeStream.cpp @ 1721:413ad0331a0c

6977924: Changes for 6975078 produce build error with certain gcc versions Summary: The changes introduced for 6975078 assign badHeapOopVal to the _allocation field in the ResourceObj class. In 32 bit linux builds with certain versions of gcc this assignment will be flagged as an error while compiling allocation.cpp. In 32 bit builds the constant value badHeapOopVal (which is cast to an intptr_t) is negative. The _allocation field is typed as an unsigned intptr_t and gcc catches this as an error. Reviewed-by: jcoomes, ysr, phh
author johnc
date Wed, 18 Aug 2010 10:59:06 -0700
parents e9ff18c4ace7
children f95d63e2154a
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
1579
jrose
parents: 1552 1565
diff changeset
2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
a61af66fc99e Initial load
duke
parents:
diff changeset
25 # include "incls/_precompiled.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
26 # include "incls/_bytecodeStream.cpp.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
27
a61af66fc99e Initial load
duke
parents:
diff changeset
28 Bytecodes::Code RawBytecodeStream::raw_next_special(Bytecodes::Code code) {
a61af66fc99e Initial load
duke
parents:
diff changeset
29 assert(!is_last_bytecode(), "should have been checked");
a61af66fc99e Initial load
duke
parents:
diff changeset
30 // set next bytecode position
413
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
31 address bcp = RawBytecodeStream::bcp();
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
32 address end = method()->code_base() + end_bci();
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
33 int l = Bytecodes::raw_special_length_at(bcp, end);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
34 if (l <= 0 || (_bci + l) > _end_bci) {
a61af66fc99e Initial load
duke
parents:
diff changeset
35 code = Bytecodes::_illegal;
a61af66fc99e Initial load
duke
parents:
diff changeset
36 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
37 _next_bci += l;
a61af66fc99e Initial load
duke
parents:
diff changeset
38 assert(_bci < _next_bci, "length must be > 0");
a61af66fc99e Initial load
duke
parents:
diff changeset
39 // set attributes
a61af66fc99e Initial load
duke
parents:
diff changeset
40 _is_wide = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
41 // check for special (uncommon) cases
a61af66fc99e Initial load
duke
parents:
diff changeset
42 if (code == Bytecodes::_wide) {
413
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
43 if (bcp + 1 >= end) {
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
44 code = Bytecodes::_illegal;
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
45 } else {
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
46 code = (Bytecodes::Code)bcp[1];
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
47 _is_wide = true;
c7ec737733a6 6756528: Bytecodes::special_length_at reads past end of code buffer
kamg
parents: 0
diff changeset
48 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
49 }
a61af66fc99e Initial load
duke
parents:
diff changeset
50 }
1565
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
51 _raw_code = code;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
52 return code;
a61af66fc99e Initial load
duke
parents:
diff changeset
53 }
1565
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
54
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
55 #ifdef ASSERT
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
56 void BaseBytecodeStream::assert_raw_index_size(int size) const {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
57 if (raw_code() == Bytecodes::_invokedynamic && is_raw()) {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
58 // in raw mode, pretend indy is "bJJ__"
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
59 assert(size == 2, "raw invokedynamic instruction has 2-byte index only");
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
60 } else {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
61 bytecode()->assert_index_size(size, raw_code(), is_wide());
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
62 }
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
63 }
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
64
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
65 void BaseBytecodeStream::assert_raw_stream(bool want_raw) const {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
66 if (want_raw) {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
67 assert( is_raw(), "this function only works on raw streams");
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
68 } else {
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
69 assert(!is_raw(), "this function only works on non-raw streams");
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
70 }
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
71 }
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 470
diff changeset
72 #endif //ASSERT