Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/heapRegion.cpp @ 17567:5656140324ed
8030763: Validate global memory allocation
Summary: Add length checks where necessary
Reviewed-by: coleenp, mschoene
author | hseigel |
---|---|
date | Thu, 13 Feb 2014 11:28:17 -0500 |
parents | 28674af341ac |
children | 096c224171c4 63a4eb8bcd23 191174b49bec |
rev | line source |
---|---|
342 | 1 /* |
12233
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
2 * Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved. |
342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
21 * questions. |
342 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
12080 | 26 #include "code/nmethod.hpp" |
1972 | 27 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" |
28 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
29 #include "gc_implementation/g1/g1OopClosures.inline.hpp" | |
30 #include "gc_implementation/g1/heapRegion.inline.hpp" | |
31 #include "gc_implementation/g1/heapRegionRemSet.hpp" | |
32 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
33 #include "memory/genOopClosures.inline.hpp" | |
34 #include "memory/iterator.hpp" | |
35 #include "oops/oop.inline.hpp" | |
342 | 36 |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
37 int HeapRegion::LogOfHRGrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
38 int HeapRegion::LogOfHRGrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
39 size_t HeapRegion::GrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
40 size_t HeapRegion::GrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
41 size_t HeapRegion::CardsPerRegion = 0; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
42 |
342 | 43 HeapRegionDCTOC::HeapRegionDCTOC(G1CollectedHeap* g1, |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
44 HeapRegion* hr, ExtendedOopClosure* cl, |
342 | 45 CardTableModRefBS::PrecisionStyle precision, |
46 FilterKind fk) : | |
47 ContiguousSpaceDCTOC(hr, cl, precision, NULL), | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
48 _hr(hr), _fk(fk), _g1(g1) { } |
342 | 49 |
50 FilterOutOfRegionClosure::FilterOutOfRegionClosure(HeapRegion* r, | |
51 OopClosure* oc) : | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
52 _r_bottom(r->bottom()), _r_end(r->end()), _oc(oc) { } |
342 | 53 |
54 template<class ClosureType> | |
55 HeapWord* walk_mem_region_loop(ClosureType* cl, G1CollectedHeap* g1h, | |
56 HeapRegion* hr, | |
57 HeapWord* cur, HeapWord* top) { | |
58 oop cur_oop = oop(cur); | |
59 int oop_size = cur_oop->size(); | |
60 HeapWord* next_obj = cur + oop_size; | |
61 while (next_obj < top) { | |
62 // Keep filtering the remembered set. | |
63 if (!g1h->is_obj_dead(cur_oop, hr)) { | |
64 // Bottom lies entirely below top, so we can call the | |
65 // non-memRegion version of oop_iterate below. | |
66 cur_oop->oop_iterate(cl); | |
67 } | |
68 cur = next_obj; | |
69 cur_oop = oop(cur); | |
70 oop_size = cur_oop->size(); | |
71 next_obj = cur + oop_size; | |
72 } | |
73 return cur; | |
74 } | |
75 | |
76 void HeapRegionDCTOC::walk_mem_region_with_cl(MemRegion mr, | |
77 HeapWord* bottom, | |
78 HeapWord* top, | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
79 ExtendedOopClosure* cl) { |
342 | 80 G1CollectedHeap* g1h = _g1; |
81 int oop_size; | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
82 ExtendedOopClosure* cl2 = NULL; |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
83 |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
84 FilterIntoCSClosure intoCSFilt(this, g1h, cl); |
342 | 85 FilterOutOfRegionClosure outOfRegionFilt(_hr, cl); |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
86 |
342 | 87 switch (_fk) { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
88 case NoFilterKind: cl2 = cl; break; |
342 | 89 case IntoCSFilterKind: cl2 = &intoCSFilt; break; |
90 case OutOfRegionFilterKind: cl2 = &outOfRegionFilt; break; | |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
91 default: ShouldNotReachHere(); |
342 | 92 } |
93 | |
94 // Start filtering what we add to the remembered set. If the object is | |
95 // not considered dead, either because it is marked (in the mark bitmap) | |
96 // or it was allocated after marking finished, then we add it. Otherwise | |
97 // we can safely ignore the object. | |
98 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
99 oop_size = oop(bottom)->oop_iterate(cl2, mr); | |
100 } else { | |
101 oop_size = oop(bottom)->size(); | |
102 } | |
103 | |
104 bottom += oop_size; | |
105 | |
106 if (bottom < top) { | |
107 // We replicate the loop below for several kinds of possible filters. | |
108 switch (_fk) { | |
109 case NoFilterKind: | |
110 bottom = walk_mem_region_loop(cl, g1h, _hr, bottom, top); | |
111 break; | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
112 |
342 | 113 case IntoCSFilterKind: { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
114 FilterIntoCSClosure filt(this, g1h, cl); |
342 | 115 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); |
116 break; | |
117 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
118 |
342 | 119 case OutOfRegionFilterKind: { |
120 FilterOutOfRegionClosure filt(_hr, cl); | |
121 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); | |
122 break; | |
123 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
124 |
342 | 125 default: |
126 ShouldNotReachHere(); | |
127 } | |
128 | |
129 // Last object. Need to do dead-obj filtering here too. | |
130 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
131 oop(bottom)->oop_iterate(cl2, mr); | |
132 } | |
133 } | |
134 } | |
135 | |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
136 // Minimum region size; we won't go lower than that. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
137 // We might want to decrease this in the future, to deal with small |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
138 // heaps a bit more efficiently. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
139 #define MIN_REGION_SIZE ( 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
140 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
141 // Maximum region size; we don't go higher than that. There's a good |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
142 // reason for having an upper bound. We don't want regions to get too |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
143 // large, otherwise cleanup's effectiveness would decrease as there |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
144 // will be fewer opportunities to find totally empty regions after |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
145 // marking. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
146 #define MAX_REGION_SIZE ( 32 * 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
147 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
148 // The automatic region size calculation will try to have around this |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
149 // many regions in the heap (based on the min heap size). |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
150 #define TARGET_REGION_NUMBER 2048 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
151 |
12233
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
152 size_t HeapRegion::max_region_size() { |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
153 return (size_t)MAX_REGION_SIZE; |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
154 } |
40136aa2cdb1
8010722: assert: failed: heap size is too big for compressed oops
tschatzl
parents:
12178
diff
changeset
|
155 |
12178
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
156 void HeapRegion::setup_heap_region_size(size_t initial_heap_size, size_t max_heap_size) { |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
157 uintx region_size = G1HeapRegionSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
158 if (FLAG_IS_DEFAULT(G1HeapRegionSize)) { |
12178
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
159 size_t average_heap_size = (initial_heap_size + max_heap_size) / 2; |
84683e78e713
8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size
brutisso
parents:
12080
diff
changeset
|
160 region_size = MAX2(average_heap_size / TARGET_REGION_NUMBER, |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
161 (uintx) MIN_REGION_SIZE); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
162 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
163 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
164 int region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
165 // Recalculate the region size to make sure it's a power of |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
166 // 2. This means that region_size is the largest power of 2 that's |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
167 // <= what we've calculated so far. |
1485
fb57d4cf76c2
6931180: Migration to recent versions of MS Platform SDK
prr
parents:
1394
diff
changeset
|
168 region_size = ((uintx)1 << region_size_log); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
169 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
170 // Now make sure that we don't go over or under our limits. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
171 if (region_size < MIN_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
172 region_size = MIN_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
173 } else if (region_size > MAX_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
174 region_size = MAX_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
175 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
176 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
177 // And recalculate the log. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
178 region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
179 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
180 // Now, set up the globals. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
181 guarantee(LogOfHRGrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
182 LogOfHRGrainBytes = region_size_log; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
183 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
184 guarantee(LogOfHRGrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
185 LogOfHRGrainWords = LogOfHRGrainBytes - LogHeapWordSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
186 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
187 guarantee(GrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
188 // The cast to int is safe, given that we've bounded region_size by |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
189 // MIN_REGION_SIZE and MAX_REGION_SIZE. |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
190 GrainBytes = (size_t)region_size; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
191 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
192 guarantee(GrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
193 GrainWords = GrainBytes >> LogHeapWordSize; |
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
194 guarantee((size_t) 1 << LogOfHRGrainWords == GrainWords, "sanity"); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
195 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
196 guarantee(CardsPerRegion == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
197 CardsPerRegion = GrainBytes >> CardTableModRefBS::card_shift; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
198 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
199 |
342 | 200 void HeapRegion::reset_after_compaction() { |
201 G1OffsetTableContigSpace::reset_after_compaction(); | |
202 // After a compaction the mark bitmap is invalid, so we must | |
203 // treat all objects as being inside the unmarked area. | |
204 zero_marked_bytes(); | |
205 init_top_at_mark_start(); | |
206 } | |
207 | |
208 void HeapRegion::hr_clear(bool par, bool clear_space) { | |
2152 | 209 assert(_humongous_type == NotHumongous, |
210 "we should have already filtered out humongous regions"); | |
211 assert(_humongous_start_region == NULL, | |
212 "we should have already filtered out humongous regions"); | |
213 assert(_end == _orig_end, | |
214 "we should have already filtered out humongous regions"); | |
215 | |
342 | 216 _in_collection_set = false; |
217 | |
218 set_young_index_in_cset(-1); | |
219 uninstall_surv_rate_group(); | |
220 set_young_type(NotYoung); | |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
221 reset_pre_dummy_top(); |
342 | 222 |
223 if (!par) { | |
224 // If this is parallel, this will be done later. | |
225 HeapRegionRemSet* hrrs = rem_set(); | |
12080 | 226 hrrs->clear(); |
355 | 227 _claimed = InitialClaimValue; |
342 | 228 } |
229 zero_marked_bytes(); | |
230 | |
231 _offsets.resize(HeapRegion::GrainWords); | |
232 init_top_at_mark_start(); | |
356 | 233 if (clear_space) clear(SpaceDecorator::Mangle); |
342 | 234 } |
235 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
236 void HeapRegion::par_clear() { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
237 assert(used() == 0, "the region should have been already cleared"); |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
238 assert(capacity() == HeapRegion::GrainBytes, "should be back to normal"); |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
239 HeapRegionRemSet* hrrs = rem_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
240 hrrs->clear(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
241 CardTableModRefBS* ct_bs = |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
242 (CardTableModRefBS*)G1CollectedHeap::heap()->barrier_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
243 ct_bs->clear(MemRegion(bottom(), end())); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
244 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
245 |
342 | 246 void HeapRegion::calc_gc_efficiency() { |
6611 | 247 // GC efficiency is the ratio of how much space would be |
248 // reclaimed over how long we predict it would take to reclaim it. | |
342 | 249 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
4912
a9647476d1a4
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
4839
diff
changeset
|
250 G1CollectorPolicy* g1p = g1h->g1_policy(); |
6611 | 251 |
252 // Retrieve a prediction of the elapsed time for this region for | |
253 // a mixed gc because the region will only be evacuated during a | |
254 // mixed gc. | |
255 double region_elapsed_time_ms = | |
256 g1p->predict_region_elapsed_time_ms(this, false /* for_young_gc */); | |
257 _gc_efficiency = (double) reclaimable_bytes() / region_elapsed_time_ms; | |
342 | 258 } |
259 | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
260 void HeapRegion::set_startsHumongous(HeapWord* new_top, HeapWord* new_end) { |
2152 | 261 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
262 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
263 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
264 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
265 assert(bottom() <= new_top && new_top <= new_end, "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
266 |
355 | 267 _humongous_type = StartsHumongous; |
342 | 268 _humongous_start_region = this; |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
269 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
270 set_end(new_end); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
271 _offsets.set_for_starts_humongous(new_top); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
272 } |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
273 |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
274 void HeapRegion::set_continuesHumongous(HeapRegion* first_hr) { |
2152 | 275 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
276 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
277 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
278 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
279 assert(first_hr->startsHumongous(), "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
280 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
281 _humongous_type = ContinuesHumongous; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
282 _humongous_start_region = first_hr; |
342 | 283 } |
284 | |
2152 | 285 void HeapRegion::set_notHumongous() { |
286 assert(isHumongous(), "pre-condition"); | |
287 | |
288 if (startsHumongous()) { | |
289 assert(top() <= end(), "pre-condition"); | |
290 set_end(_orig_end); | |
291 if (top() > end()) { | |
292 // at least one "continues humongous" region after it | |
293 set_top(end()); | |
294 } | |
295 } else { | |
296 // continues humongous | |
297 assert(end() == _orig_end, "sanity"); | |
298 } | |
299 | |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
300 assert(capacity() == HeapRegion::GrainBytes, "pre-condition"); |
2152 | 301 _humongous_type = NotHumongous; |
302 _humongous_start_region = NULL; | |
303 } | |
304 | |
342 | 305 bool HeapRegion::claimHeapRegion(jint claimValue) { |
306 jint current = _claimed; | |
307 if (current != claimValue) { | |
308 jint res = Atomic::cmpxchg(claimValue, &_claimed, current); | |
309 if (res == current) { | |
310 return true; | |
311 } | |
312 } | |
313 return false; | |
314 } | |
315 | |
316 HeapWord* HeapRegion::next_block_start_careful(HeapWord* addr) { | |
317 HeapWord* low = addr; | |
318 HeapWord* high = end(); | |
319 while (low < high) { | |
320 size_t diff = pointer_delta(high, low); | |
321 // Must add one below to bias toward the high amount. Otherwise, if | |
322 // "high" were at the desired value, and "low" were one less, we | |
323 // would not converge on "high". This is not symmetric, because | |
324 // we set "high" to a block start, which might be the right one, | |
325 // which we don't do for "low". | |
326 HeapWord* middle = low + (diff+1)/2; | |
327 if (middle == high) return high; | |
328 HeapWord* mid_bs = block_start_careful(middle); | |
329 if (mid_bs < addr) { | |
330 low = middle; | |
331 } else { | |
332 high = mid_bs; | |
333 } | |
334 } | |
335 assert(low == high && low >= addr, "Didn't work."); | |
336 return low; | |
337 } | |
338 | |
339 #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away | |
340 #pragma warning( disable:4355 ) // 'this' : used in base member initializer list | |
341 #endif // _MSC_VER | |
342 | |
343 | |
6010
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
344 HeapRegion::HeapRegion(uint hrs_index, |
720b6a76dd9d
7157073: G1: type change size_t -> uint for region counts / indexes
tonyp
parents:
6008
diff
changeset
|
345 G1BlockOffsetSharedArray* sharedOffsetArray, |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
346 MemRegion mr) : |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
347 G1OffsetTableContigSpace(sharedOffsetArray, mr), |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
348 _hrs_index(hrs_index), |
355 | 349 _humongous_type(NotHumongous), _humongous_start_region(NULL), |
3830
f44782f04dd4
7039627: G1: avoid BOT updates for survivor allocations and dirty survivor regions incrementally
tonyp
parents:
3772
diff
changeset
|
350 _in_collection_set(false), |
342 | 351 _next_in_special_set(NULL), _orig_end(NULL), |
355 | 352 _claimed(InitialClaimValue), _evacuation_failed(false), |
6011 | 353 _prev_marked_bytes(0), _next_marked_bytes(0), _gc_efficiency(0.0), |
342 | 354 _young_type(NotYoung), _next_young_region(NULL), |
2152 | 355 _next_dirty_cards_region(NULL), _next(NULL), _pending_removal(false), |
356 #ifdef ASSERT | |
357 _containing_set(NULL), | |
358 #endif // ASSERT | |
359 _young_index_in_cset(-1), _surv_rate_group(NULL), _age_index(-1), | |
360 _rem_set(NULL), _recorded_rs_length(0), _predicted_elapsed_time_ms(0), | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
361 _predicted_bytes_to_copy(0) |
342 | 362 { |
12080 | 363 _rem_set = new HeapRegionRemSet(sharedOffsetArray, this); |
342 | 364 _orig_end = mr.end(); |
365 // Note that initialize() will set the start of the unmarked area of the | |
366 // region. | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
367 hr_clear(false /*par*/, false /*clear_space*/); |
356 | 368 set_top(bottom()); |
369 set_saved_mark(); | |
342 | 370 |
371 assert(HeapRegionRemSet::num_par_rem_sets() > 0, "Invariant."); | |
372 } | |
373 | |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
374 CompactibleSpace* HeapRegion::next_compaction_space() const { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
375 // We're not using an iterator given that it will wrap around when |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
376 // it reaches the last region and this is not what we want here. |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
377 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
378 uint index = hrs_index() + 1; |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
379 while (index < g1h->n_regions()) { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
380 HeapRegion* hr = g1h->region_at(index); |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
381 if (!hr->isHumongous()) { |
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
382 return hr; |
342 | 383 } |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
384 index += 1; |
342 | 385 } |
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6027
diff
changeset
|
386 return NULL; |
342 | 387 } |
388 | |
389 void HeapRegion::save_marks() { | |
390 set_saved_mark(); | |
391 } | |
392 | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
393 void HeapRegion::oops_in_mr_iterate(MemRegion mr, ExtendedOopClosure* cl) { |
342 | 394 HeapWord* p = mr.start(); |
395 HeapWord* e = mr.end(); | |
396 oop obj; | |
397 while (p < e) { | |
398 obj = oop(p); | |
399 p += obj->oop_iterate(cl); | |
400 } | |
401 assert(p == e, "bad memregion: doesn't end on obj boundary"); | |
402 } | |
403 | |
404 #define HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN(OopClosureType, nv_suffix) \ | |
405 void HeapRegion::oop_since_save_marks_iterate##nv_suffix(OopClosureType* cl) { \ | |
406 ContiguousSpace::oop_since_save_marks_iterate##nv_suffix(cl); \ | |
407 } | |
408 SPECIALIZED_SINCE_SAVE_MARKS_CLOSURES(HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN) | |
409 | |
410 | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
411 void HeapRegion::oop_before_save_marks_iterate(ExtendedOopClosure* cl) { |
342 | 412 oops_in_mr_iterate(MemRegion(bottom(), saved_mark_word()), cl); |
413 } | |
414 | |
4787
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
415 void HeapRegion::note_self_forwarding_removal_start(bool during_initial_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
416 bool during_conc_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
417 // We always recreate the prev marking info and we'll explicitly |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
418 // mark all objects we find to be self-forwarded on the prev |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
419 // bitmap. So all objects need to be below PTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
420 _prev_top_at_mark_start = top(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
421 _prev_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
422 |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
423 if (during_initial_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
424 // During initial-mark, we'll also explicitly mark all objects |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
425 // we find to be self-forwarded on the next bitmap. So all |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
426 // objects need to be below NTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
427 _next_top_at_mark_start = top(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
428 _next_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
429 } else if (during_conc_mark) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
430 // During concurrent mark, all objects in the CSet (including |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
431 // the ones we find to be self-forwarded) are implicitly live. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
432 // So all objects need to be above NTAMS. |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
433 _next_top_at_mark_start = bottom(); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
434 _next_marked_bytes = 0; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
435 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
436 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
437 |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
438 void HeapRegion::note_self_forwarding_removal_end(bool during_initial_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
439 bool during_conc_mark, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
440 size_t marked_bytes) { |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
441 assert(0 <= marked_bytes && marked_bytes <= used(), |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
442 err_msg("marked: "SIZE_FORMAT" used: "SIZE_FORMAT, |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
443 marked_bytes, used())); |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
444 _prev_marked_bytes = marked_bytes; |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
445 } |
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
4725
diff
changeset
|
446 |
342 | 447 HeapWord* |
448 HeapRegion::object_iterate_mem_careful(MemRegion mr, | |
449 ObjectClosure* cl) { | |
450 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
451 // We used to use "block_start_careful" here. But we're actually happy | |
452 // to update the BOT while we do this... | |
453 HeapWord* cur = block_start(mr.start()); | |
454 mr = mr.intersection(used_region()); | |
455 if (mr.is_empty()) return NULL; | |
456 // Otherwise, find the obj that extends onto mr.start(). | |
457 | |
458 assert(cur <= mr.start() | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
459 && (oop(cur)->klass_or_null() == NULL || |
342 | 460 cur + oop(cur)->size() > mr.start()), |
461 "postcondition of block_start"); | |
462 oop obj; | |
463 while (cur < mr.end()) { | |
464 obj = oop(cur); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
465 if (obj->klass_or_null() == NULL) { |
342 | 466 // Ran into an unparseable point. |
467 return cur; | |
468 } else if (!g1h->is_obj_dead(obj)) { | |
469 cl->do_object(obj); | |
470 } | |
471 if (cl->abort()) return cur; | |
472 // The check above must occur before the operation below, since an | |
473 // abort might invalidate the "size" operation. | |
474 cur += obj->size(); | |
475 } | |
476 return NULL; | |
477 } | |
478 | |
479 HeapWord* | |
480 HeapRegion:: | |
481 oops_on_card_seq_iterate_careful(MemRegion mr, | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
482 FilterOutOfRegionClosure* cl, |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
483 bool filter_young, |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
484 jbyte* card_ptr) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
485 // Currently, we should only have to clean the card if filter_young |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
486 // is true and vice versa. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
487 if (filter_young) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
488 assert(card_ptr != NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
489 } else { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
490 assert(card_ptr == NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
491 } |
342 | 492 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
493 | |
494 // If we're within a stop-world GC, then we might look at a card in a | |
495 // GC alloc region that extends onto a GC LAB, which may not be | |
496 // parseable. Stop such at the "saved_mark" of the region. | |
4839 | 497 if (g1h->is_gc_active()) { |
342 | 498 mr = mr.intersection(used_region_at_save_marks()); |
499 } else { | |
500 mr = mr.intersection(used_region()); | |
501 } | |
502 if (mr.is_empty()) return NULL; | |
503 // Otherwise, find the obj that extends onto mr.start(). | |
504 | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
505 // The intersection of the incoming mr (for the card) and the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
506 // allocated part of the region is non-empty. This implies that |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
507 // we have actually allocated into this region. The code in |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
508 // G1CollectedHeap.cpp that allocates a new region sets the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
509 // is_young tag on the region before allocating. Thus we |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
510 // safely know if this region is young. |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
511 if (is_young() && filter_young) { |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
512 return NULL; |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
513 } |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
514 |
1705 | 515 assert(!is_young(), "check value of filter_young"); |
516 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
517 // We can only clean the card here, after we make the decision that |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
518 // the card is not young. And we only clean the card if we have been |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
519 // asked to (i.e., card_ptr != NULL). |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
520 if (card_ptr != NULL) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
521 *card_ptr = CardTableModRefBS::clean_card_val(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
522 // We must complete this write before we do any of the reads below. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
523 OrderAccess::storeload(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
524 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
525 |
4839 | 526 // Cache the boundaries of the memory region in some const locals |
527 HeapWord* const start = mr.start(); | |
528 HeapWord* const end = mr.end(); | |
529 | |
342 | 530 // We used to use "block_start_careful" here. But we're actually happy |
531 // to update the BOT while we do this... | |
4839 | 532 HeapWord* cur = block_start(start); |
533 assert(cur <= start, "Postcondition"); | |
534 | |
535 oop obj; | |
342 | 536 |
4839 | 537 HeapWord* next = cur; |
538 while (next <= start) { | |
539 cur = next; | |
540 obj = oop(cur); | |
541 if (obj->klass_or_null() == NULL) { | |
342 | 542 // Ran into an unparseable point. |
543 return cur; | |
544 } | |
545 // Otherwise... | |
4839 | 546 next = (cur + obj->size()); |
342 | 547 } |
4839 | 548 |
549 // If we finish the above loop...We have a parseable object that | |
550 // begins on or before the start of the memory region, and ends | |
551 // inside or spans the entire region. | |
552 | |
553 assert(obj == oop(cur), "sanity"); | |
554 assert(cur <= start && | |
555 obj->klass_or_null() != NULL && | |
556 (cur + obj->size()) > start, | |
342 | 557 "Loop postcondition"); |
4839 | 558 |
342 | 559 if (!g1h->is_obj_dead(obj)) { |
560 obj->oop_iterate(cl, mr); | |
561 } | |
562 | |
4839 | 563 while (cur < end) { |
342 | 564 obj = oop(cur); |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
565 if (obj->klass_or_null() == NULL) { |
342 | 566 // Ran into an unparseable point. |
567 return cur; | |
568 }; | |
4839 | 569 |
342 | 570 // Otherwise: |
571 next = (cur + obj->size()); | |
4839 | 572 |
342 | 573 if (!g1h->is_obj_dead(obj)) { |
4839 | 574 if (next < end || !obj->is_objArray()) { |
575 // This object either does not span the MemRegion | |
576 // boundary, or if it does it's not an array. | |
577 // Apply closure to whole object. | |
342 | 578 obj->oop_iterate(cl); |
579 } else { | |
4839 | 580 // This obj is an array that spans the boundary. |
581 // Stop at the boundary. | |
582 obj->oop_iterate(cl, mr); | |
342 | 583 } |
584 } | |
585 cur = next; | |
586 } | |
587 return NULL; | |
588 } | |
589 | |
12080 | 590 // Code roots support |
591 | |
592 void HeapRegion::add_strong_code_root(nmethod* nm) { | |
593 HeapRegionRemSet* hrrs = rem_set(); | |
594 hrrs->add_strong_code_root(nm); | |
595 } | |
596 | |
597 void HeapRegion::remove_strong_code_root(nmethod* nm) { | |
598 HeapRegionRemSet* hrrs = rem_set(); | |
599 hrrs->remove_strong_code_root(nm); | |
600 } | |
601 | |
602 void HeapRegion::migrate_strong_code_roots() { | |
603 assert(in_collection_set(), "only collection set regions"); | |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
604 assert(!isHumongous(), |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
605 err_msg("humongous region "HR_FORMAT" should not have been added to collection set", |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
606 HR_FORMAT_PARAMS(this))); |
12080 | 607 |
608 HeapRegionRemSet* hrrs = rem_set(); | |
609 hrrs->migrate_strong_code_roots(); | |
610 } | |
611 | |
612 void HeapRegion::strong_code_roots_do(CodeBlobClosure* blk) const { | |
613 HeapRegionRemSet* hrrs = rem_set(); | |
614 hrrs->strong_code_roots_do(blk); | |
615 } | |
616 | |
617 class VerifyStrongCodeRootOopClosure: public OopClosure { | |
618 const HeapRegion* _hr; | |
619 nmethod* _nm; | |
620 bool _failures; | |
621 bool _has_oops_in_region; | |
622 | |
623 template <class T> void do_oop_work(T* p) { | |
624 T heap_oop = oopDesc::load_heap_oop(p); | |
625 if (!oopDesc::is_null(heap_oop)) { | |
626 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
627 | |
628 // Note: not all the oops embedded in the nmethod are in the | |
629 // current region. We only look at those which are. | |
630 if (_hr->is_in(obj)) { | |
631 // Object is in the region. Check that its less than top | |
632 if (_hr->top() <= (HeapWord*)obj) { | |
633 // Object is above top | |
634 gclog_or_tty->print_cr("Object "PTR_FORMAT" in region " | |
635 "["PTR_FORMAT", "PTR_FORMAT") is above " | |
636 "top "PTR_FORMAT, | |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
637 (void *)obj, _hr->bottom(), _hr->end(), _hr->top()); |
12080 | 638 _failures = true; |
639 return; | |
640 } | |
641 // Nmethod has at least one oop in the current region | |
642 _has_oops_in_region = true; | |
643 } | |
644 } | |
645 } | |
646 | |
647 public: | |
648 VerifyStrongCodeRootOopClosure(const HeapRegion* hr, nmethod* nm): | |
649 _hr(hr), _failures(false), _has_oops_in_region(false) {} | |
650 | |
651 void do_oop(narrowOop* p) { do_oop_work(p); } | |
652 void do_oop(oop* p) { do_oop_work(p); } | |
653 | |
654 bool failures() { return _failures; } | |
655 bool has_oops_in_region() { return _has_oops_in_region; } | |
656 }; | |
657 | |
658 class VerifyStrongCodeRootCodeBlobClosure: public CodeBlobClosure { | |
659 const HeapRegion* _hr; | |
660 bool _failures; | |
661 public: | |
662 VerifyStrongCodeRootCodeBlobClosure(const HeapRegion* hr) : | |
663 _hr(hr), _failures(false) {} | |
664 | |
665 void do_code_blob(CodeBlob* cb) { | |
666 nmethod* nm = (cb == NULL) ? NULL : cb->as_nmethod_or_null(); | |
667 if (nm != NULL) { | |
668 // Verify that the nemthod is live | |
669 if (!nm->is_alive()) { | |
670 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has dead nmethod " | |
671 PTR_FORMAT" in its strong code roots", | |
672 _hr->bottom(), _hr->end(), nm); | |
673 _failures = true; | |
674 } else { | |
675 VerifyStrongCodeRootOopClosure oop_cl(_hr, nm); | |
676 nm->oops_do(&oop_cl); | |
677 if (!oop_cl.has_oops_in_region()) { | |
678 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has nmethod " | |
679 PTR_FORMAT" in its strong code roots " | |
680 "with no pointers into region", | |
681 _hr->bottom(), _hr->end(), nm); | |
682 _failures = true; | |
683 } else if (oop_cl.failures()) { | |
684 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] has other " | |
685 "failures for nmethod "PTR_FORMAT, | |
686 _hr->bottom(), _hr->end(), nm); | |
687 _failures = true; | |
688 } | |
689 } | |
690 } | |
691 } | |
692 | |
693 bool failures() { return _failures; } | |
694 }; | |
695 | |
696 void HeapRegion::verify_strong_code_roots(VerifyOption vo, bool* failures) const { | |
697 if (!G1VerifyHeapRegionCodeRoots) { | |
698 // We're not verifying code roots. | |
699 return; | |
700 } | |
701 if (vo == VerifyOption_G1UseMarkWord) { | |
702 // Marking verification during a full GC is performed after class | |
703 // unloading, code cache unloading, etc so the strong code roots | |
704 // attached to each heap region are in an inconsistent state. They won't | |
705 // be consistent until the strong code roots are rebuilt after the | |
706 // actual GC. Skip verifying the strong code roots in this particular | |
707 // time. | |
708 assert(VerifyDuringGC, "only way to get here"); | |
709 return; | |
710 } | |
711 | |
712 HeapRegionRemSet* hrrs = rem_set(); | |
713 int strong_code_roots_length = hrrs->strong_code_roots_list_length(); | |
714 | |
715 // if this region is empty then there should be no entries | |
716 // on its strong code root list | |
717 if (is_empty()) { | |
718 if (strong_code_roots_length > 0) { | |
719 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] is empty " | |
720 "but has "INT32_FORMAT" code root entries", | |
721 bottom(), end(), strong_code_roots_length); | |
722 *failures = true; | |
723 } | |
724 return; | |
725 } | |
726 | |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
727 if (continuesHumongous()) { |
12080 | 728 if (strong_code_roots_length > 0) { |
13062
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
729 gclog_or_tty->print_cr("region "HR_FORMAT" is a continuation of a humongous " |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
730 "region but has "INT32_FORMAT" code root entries", |
28674af341ac
8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
13060
diff
changeset
|
731 HR_FORMAT_PARAMS(this), strong_code_roots_length); |
12080 | 732 *failures = true; |
733 } | |
734 return; | |
735 } | |
736 | |
737 VerifyStrongCodeRootCodeBlobClosure cb_cl(this); | |
738 strong_code_roots_do(&cb_cl); | |
739 | |
740 if (cb_cl.failures()) { | |
741 *failures = true; | |
742 } | |
743 } | |
744 | |
342 | 745 void HeapRegion::print() const { print_on(gclog_or_tty); } |
746 void HeapRegion::print_on(outputStream* st) const { | |
747 if (isHumongous()) { | |
748 if (startsHumongous()) | |
749 st->print(" HS"); | |
750 else | |
751 st->print(" HC"); | |
752 } else { | |
753 st->print(" "); | |
754 } | |
755 if (in_collection_set()) | |
756 st->print(" CS"); | |
757 else | |
758 st->print(" "); | |
759 if (is_young()) | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
760 st->print(is_survivor() ? " SU" : " Y "); |
342 | 761 else |
762 st->print(" "); | |
763 if (is_empty()) | |
764 st->print(" F"); | |
765 else | |
766 st->print(" "); | |
4073
53074c2c4600
7099849: G1: include heap region information in hs_err files
tonyp
parents:
4023
diff
changeset
|
767 st->print(" TS %5d", _gc_time_stamp); |
1388 | 768 st->print(" PTAMS "PTR_FORMAT" NTAMS "PTR_FORMAT, |
769 prev_top_at_mark_start(), next_top_at_mark_start()); | |
342 | 770 G1OffsetTableContigSpace::print_on(st); |
771 } | |
772 | |
12080 | 773 class VerifyLiveClosure: public OopClosure { |
774 private: | |
775 G1CollectedHeap* _g1h; | |
776 CardTableModRefBS* _bs; | |
777 oop _containing_obj; | |
778 bool _failures; | |
779 int _n_failures; | |
780 VerifyOption _vo; | |
781 public: | |
782 // _vo == UsePrevMarking -> use "prev" marking information, | |
783 // _vo == UseNextMarking -> use "next" marking information, | |
784 // _vo == UseMarkWord -> use mark word from object header. | |
785 VerifyLiveClosure(G1CollectedHeap* g1h, VerifyOption vo) : | |
786 _g1h(g1h), _bs(NULL), _containing_obj(NULL), | |
787 _failures(false), _n_failures(0), _vo(vo) | |
788 { | |
789 BarrierSet* bs = _g1h->barrier_set(); | |
790 if (bs->is_a(BarrierSet::CardTableModRef)) | |
791 _bs = (CardTableModRefBS*)bs; | |
792 } | |
793 | |
794 void set_containing_obj(oop obj) { | |
795 _containing_obj = obj; | |
796 } | |
797 | |
798 bool failures() { return _failures; } | |
799 int n_failures() { return _n_failures; } | |
800 | |
801 virtual void do_oop(narrowOop* p) { do_oop_work(p); } | |
802 virtual void do_oop( oop* p) { do_oop_work(p); } | |
803 | |
804 void print_object(outputStream* out, oop obj) { | |
805 #ifdef PRODUCT | |
806 Klass* k = obj->klass(); | |
807 const char* class_name = InstanceKlass::cast(k)->external_name(); | |
808 out->print_cr("class name %s", class_name); | |
809 #else // PRODUCT | |
810 obj->print_on(out); | |
811 #endif // PRODUCT | |
812 } | |
813 | |
814 template <class T> | |
815 void do_oop_work(T* p) { | |
816 assert(_containing_obj != NULL, "Precondition"); | |
817 assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), | |
818 "Precondition"); | |
819 T heap_oop = oopDesc::load_heap_oop(p); | |
820 if (!oopDesc::is_null(heap_oop)) { | |
821 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
822 bool failed = false; | |
823 if (!_g1h->is_in_closed_subset(obj) || _g1h->is_obj_dead_cond(obj, _vo)) { | |
824 MutexLockerEx x(ParGCRareEvent_lock, | |
825 Mutex::_no_safepoint_check_flag); | |
826 | |
827 if (!_failures) { | |
828 gclog_or_tty->print_cr(""); | |
829 gclog_or_tty->print_cr("----------"); | |
830 } | |
831 if (!_g1h->is_in_closed_subset(obj)) { | |
832 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
833 gclog_or_tty->print_cr("Field "PTR_FORMAT | |
834 " of live obj "PTR_FORMAT" in region " | |
835 "["PTR_FORMAT", "PTR_FORMAT")", | |
836 p, (void*) _containing_obj, | |
837 from->bottom(), from->end()); | |
838 print_object(gclog_or_tty, _containing_obj); | |
839 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" not in the heap", | |
840 (void*) obj); | |
841 } else { | |
842 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
843 HeapRegion* to = _g1h->heap_region_containing((HeapWord*)obj); | |
844 gclog_or_tty->print_cr("Field "PTR_FORMAT | |
845 " of live obj "PTR_FORMAT" in region " | |
846 "["PTR_FORMAT", "PTR_FORMAT")", | |
847 p, (void*) _containing_obj, | |
848 from->bottom(), from->end()); | |
849 print_object(gclog_or_tty, _containing_obj); | |
850 gclog_or_tty->print_cr("points to dead obj "PTR_FORMAT" in region " | |
851 "["PTR_FORMAT", "PTR_FORMAT")", | |
852 (void*) obj, to->bottom(), to->end()); | |
853 print_object(gclog_or_tty, obj); | |
854 } | |
855 gclog_or_tty->print_cr("----------"); | |
856 gclog_or_tty->flush(); | |
857 _failures = true; | |
858 failed = true; | |
859 _n_failures++; | |
860 } | |
861 | |
862 if (!_g1h->full_collection() || G1VerifyRSetsDuringFullGC) { | |
863 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
864 HeapRegion* to = _g1h->heap_region_containing(obj); | |
865 if (from != NULL && to != NULL && | |
866 from != to && | |
867 !to->isHumongous()) { | |
868 jbyte cv_obj = *_bs->byte_for_const(_containing_obj); | |
869 jbyte cv_field = *_bs->byte_for_const(p); | |
870 const jbyte dirty = CardTableModRefBS::dirty_card_val(); | |
871 | |
872 bool is_bad = !(from->is_young() | |
873 || to->rem_set()->contains_reference(p) | |
874 || !G1HRRSFlushLogBuffersOnVerify && // buffers were not flushed | |
875 (_containing_obj->is_objArray() ? | |
876 cv_field == dirty | |
877 : cv_obj == dirty || cv_field == dirty)); | |
878 if (is_bad) { | |
879 MutexLockerEx x(ParGCRareEvent_lock, | |
880 Mutex::_no_safepoint_check_flag); | |
881 | |
882 if (!_failures) { | |
883 gclog_or_tty->print_cr(""); | |
884 gclog_or_tty->print_cr("----------"); | |
885 } | |
886 gclog_or_tty->print_cr("Missing rem set entry:"); | |
887 gclog_or_tty->print_cr("Field "PTR_FORMAT" " | |
888 "of obj "PTR_FORMAT", " | |
889 "in region "HR_FORMAT, | |
890 p, (void*) _containing_obj, | |
891 HR_FORMAT_PARAMS(from)); | |
892 _containing_obj->print_on(gclog_or_tty); | |
893 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" " | |
894 "in region "HR_FORMAT, | |
895 (void*) obj, | |
896 HR_FORMAT_PARAMS(to)); | |
897 obj->print_on(gclog_or_tty); | |
898 gclog_or_tty->print_cr("Obj head CTE = %d, field CTE = %d.", | |
899 cv_obj, cv_field); | |
900 gclog_or_tty->print_cr("----------"); | |
901 gclog_or_tty->flush(); | |
902 _failures = true; | |
903 if (!failed) _n_failures++; | |
904 } | |
905 } | |
906 } | |
907 } | |
908 } | |
909 }; | |
811 | 910 |
342 | 911 // This really ought to be commoned up into OffsetTableContigSpace somehow. |
912 // We would need a mechanism to make that code skip dead objects. | |
913 | |
6008 | 914 void HeapRegion::verify(VerifyOption vo, |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
915 bool* failures) const { |
342 | 916 G1CollectedHeap* g1 = G1CollectedHeap::heap(); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
917 *failures = false; |
342 | 918 HeapWord* p = bottom(); |
919 HeapWord* prev_p = NULL; | |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
920 VerifyLiveClosure vl_cl(g1, vo); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
921 bool is_humongous = isHumongous(); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
922 bool do_bot_verify = !is_young(); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
923 size_t object_num = 0; |
342 | 924 while (p < top()) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
925 oop obj = oop(p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
926 size_t obj_size = obj->size(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
927 object_num += 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
928 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
929 if (is_humongous != g1->isHumongous(obj_size)) { |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
930 gclog_or_tty->print_cr("obj "PTR_FORMAT" is of %shumongous size (" |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
931 SIZE_FORMAT" words) in a %shumongous region", |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
932 p, g1->isHumongous(obj_size) ? "" : "non-", |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
933 obj_size, is_humongous ? "" : "non-"); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
934 *failures = true; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
935 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
936 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
937 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
938 // If it returns false, verify_for_object() will output the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
939 // appropriate messasge. |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
940 if (do_bot_verify && !_offsets.verify_for_object(p, obj_size)) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
941 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
942 return; |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
943 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
944 |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
945 if (!g1->is_obj_dead_cond(obj, this, vo)) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
946 if (obj->is_oop()) { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
947 Klass* klass = obj->klass(); |
11034 | 948 if (!klass->is_metaspace_object()) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
949 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
950 "not metadata", klass, (void *)obj); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
951 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
952 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
953 } else if (!klass->is_klass()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
954 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
955 "not a klass", klass, (void *)obj); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
956 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
957 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
958 } else { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
959 vl_cl.set_containing_obj(obj); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6611
diff
changeset
|
960 obj->oop_iterate_no_header(&vl_cl); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
961 if (vl_cl.failures()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
962 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
963 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
964 if (G1MaxVerifyFailures >= 0 && |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
965 vl_cl.n_failures() >= G1MaxVerifyFailures) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
966 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
967 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
968 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
969 } else { |
12316
190899198332
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
12233
diff
changeset
|
970 gclog_or_tty->print_cr(PTR_FORMAT" no an oop", (void *)obj); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
971 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
972 return; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
973 } |
342 | 974 } |
975 prev_p = p; | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
976 p += obj_size; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
977 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
978 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
979 if (p != top()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
980 gclog_or_tty->print_cr("end of last object "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
981 "does not match top "PTR_FORMAT, p, top()); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
982 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
983 return; |
342 | 984 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
985 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
986 HeapWord* the_end = end(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
987 assert(p == top(), "it should still hold"); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
988 // Do some extra BOT consistency checking for addresses in the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
989 // range [top, end). BOT look-ups in this range should yield |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
990 // top. No point in doing that if top == end (there's nothing there). |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
991 if (p < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
992 // Look up top |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
993 HeapWord* addr_1 = p; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
994 HeapWord* b_start_1 = _offsets.block_start_const(addr_1); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
995 if (b_start_1 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
996 gclog_or_tty->print_cr("BOT look up for top: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
997 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
998 addr_1, b_start_1, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
999 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1000 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1001 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1002 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1003 // Look up top + 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1004 HeapWord* addr_2 = p + 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1005 if (addr_2 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1006 HeapWord* b_start_2 = _offsets.block_start_const(addr_2); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1007 if (b_start_2 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1008 gclog_or_tty->print_cr("BOT look up for top + 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1009 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1010 addr_2, b_start_2, p); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1011 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1012 return; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1013 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1014 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1015 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1016 // Look up an address between top and end |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1017 size_t diff = pointer_delta(the_end, p) / 2; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1018 HeapWord* addr_3 = p + diff; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1019 if (addr_3 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1020 HeapWord* b_start_3 = _offsets.block_start_const(addr_3); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1021 if (b_start_3 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1022 gclog_or_tty->print_cr("BOT look up for top + diff: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1023 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1024 addr_3, b_start_3, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1025 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1026 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1027 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1028 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1029 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1030 // Loook up end - 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1031 HeapWord* addr_4 = the_end - 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1032 HeapWord* b_start_4 = _offsets.block_start_const(addr_4); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1033 if (b_start_4 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1034 gclog_or_tty->print_cr("BOT look up for end - 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1035 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1036 addr_4, b_start_4, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1037 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
1038 return; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1039 } |
342 | 1040 } |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1041 |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1042 if (is_humongous && object_num > 1) { |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1043 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] is humongous " |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1044 "but has "SIZE_FORMAT", objects", |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1045 bottom(), end(), object_num); |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
1046 *failures = true; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
1047 return; |
342 | 1048 } |
12080 | 1049 |
1050 verify_strong_code_roots(vo, failures); | |
1051 } | |
1052 | |
1053 void HeapRegion::verify() const { | |
1054 bool dummy = false; | |
1055 verify(VerifyOption_G1UsePrevMarking, /* failures */ &dummy); | |
342 | 1056 } |
1057 | |
1058 // G1OffsetTableContigSpace code; copied from space.cpp. Hope this can go | |
1059 // away eventually. | |
1060 | |
356 | 1061 void G1OffsetTableContigSpace::clear(bool mangle_space) { |
1062 ContiguousSpace::clear(mangle_space); | |
342 | 1063 _offsets.zero_bottom_entry(); |
1064 _offsets.initialize_threshold(); | |
1065 } | |
1066 | |
1067 void G1OffsetTableContigSpace::set_bottom(HeapWord* new_bottom) { | |
1068 Space::set_bottom(new_bottom); | |
1069 _offsets.set_bottom(new_bottom); | |
1070 } | |
1071 | |
1072 void G1OffsetTableContigSpace::set_end(HeapWord* new_end) { | |
1073 Space::set_end(new_end); | |
1074 _offsets.resize(new_end - bottom()); | |
1075 } | |
1076 | |
1077 void G1OffsetTableContigSpace::print() const { | |
1078 print_short(); | |
1079 gclog_or_tty->print_cr(" [" INTPTR_FORMAT ", " INTPTR_FORMAT ", " | |
1080 INTPTR_FORMAT ", " INTPTR_FORMAT ")", | |
1081 bottom(), top(), _offsets.threshold(), end()); | |
1082 } | |
1083 | |
1084 HeapWord* G1OffsetTableContigSpace::initialize_threshold() { | |
1085 return _offsets.initialize_threshold(); | |
1086 } | |
1087 | |
1088 HeapWord* G1OffsetTableContigSpace::cross_threshold(HeapWord* start, | |
1089 HeapWord* end) { | |
1090 _offsets.alloc_block(start, end); | |
1091 return _offsets.threshold(); | |
1092 } | |
1093 | |
1094 HeapWord* G1OffsetTableContigSpace::saved_mark_word() const { | |
1095 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
1096 assert( _gc_time_stamp <= g1h->get_gc_time_stamp(), "invariant" ); | |
1097 if (_gc_time_stamp < g1h->get_gc_time_stamp()) | |
1098 return top(); | |
1099 else | |
1100 return ContiguousSpace::saved_mark_word(); | |
1101 } | |
1102 | |
1103 void G1OffsetTableContigSpace::set_saved_mark() { | |
1104 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
1105 unsigned curr_gc_time_stamp = g1h->get_gc_time_stamp(); | |
1106 | |
1107 if (_gc_time_stamp < curr_gc_time_stamp) { | |
1108 // The order of these is important, as another thread might be | |
1109 // about to start scanning this region. If it does so after | |
1110 // set_saved_mark and before _gc_time_stamp = ..., then the latter | |
1111 // will be false, and it will pick up top() as the high water mark | |
1112 // of region. If it does so after _gc_time_stamp = ..., then it | |
1113 // will pick up the right saved_mark_word() as the high water mark | |
1114 // of the region. Either way, the behaviour will be correct. | |
1115 ContiguousSpace::set_saved_mark(); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
1116 OrderAccess::storestore(); |
353
9bb2c10ac07b
6723570: G1: assertion failure: p == current_top or oop(p)->is_oop(),"p is not a block start" (revisited!)
iveresov
parents:
342
diff
changeset
|
1117 _gc_time_stamp = curr_gc_time_stamp; |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1118 // No need to do another barrier to flush the writes above. If |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1119 // this is called in parallel with other threads trying to |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1120 // allocate into the region, the caller should call this while |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1121 // holding a lock and when the lock is released the writes will be |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
1122 // flushed. |
342 | 1123 } |
1124 } | |
1125 | |
1126 G1OffsetTableContigSpace:: | |
1127 G1OffsetTableContigSpace(G1BlockOffsetSharedArray* sharedOffsetArray, | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1128 MemRegion mr) : |
342 | 1129 _offsets(sharedOffsetArray, mr), |
1130 _par_alloc_lock(Mutex::leaf, "OffsetTableContigSpace par alloc lock", true), | |
1131 _gc_time_stamp(0) | |
1132 { | |
1133 _offsets.set_space(this); | |
6754
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1134 // false ==> we'll do the clearing if there's clearing to be done. |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1135 ContiguousSpace::initialize(mr, false, SpaceDecorator::Mangle); |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1136 _offsets.zero_bottom_entry(); |
8fbf05030e24
7016955: G1: remove the is_zeroed parameter from the HeapRegion constructor
johnc
parents:
6725
diff
changeset
|
1137 _offsets.initialize_threshold(); |
342 | 1138 } |