annotate src/share/vm/classfile/resolutionErrors.cpp @ 1091:6aa7255741f3

6906727: UseCompressedOops: some card-marking fixes related to object arrays Summary: Introduced a new write_ref_array(HeapWords* start, size_t count) method that does the requisite MemRegion range calculation so (some of the) clients of the erstwhile write_ref_array(MemRegion mr) do not need to worry. This removed all external uses of array_size(), which was also simplified and made private. Asserts were added to catch other possible issues. Further, less essential, fixes stemming from this investigation are deferred to CR 6904516 (to follow shortly in hs17). Reviewed-by: kvn, coleenp, jmasa
author ysr
date Thu, 03 Dec 2009 15:01:57 -0800
parents a61af66fc99e
children cff162798819
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
a61af66fc99e Initial load
duke
parents:
diff changeset
2 * Copyright 2005 Sun Microsystems, Inc. All Rights Reserved.
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
a61af66fc99e Initial load
duke
parents:
diff changeset
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
a61af66fc99e Initial load
duke
parents:
diff changeset
20 * CA 95054 USA or visit www.sun.com if you need additional information or
a61af66fc99e Initial load
duke
parents:
diff changeset
21 * have any questions.
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
a61af66fc99e Initial load
duke
parents:
diff changeset
25 # include "incls/_precompiled.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
26 # include "incls/_resolutionErrors.cpp.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
27
a61af66fc99e Initial load
duke
parents:
diff changeset
28 // add new entry to the table
a61af66fc99e Initial load
duke
parents:
diff changeset
29 void ResolutionErrorTable::add_entry(int index, unsigned int hash,
a61af66fc99e Initial load
duke
parents:
diff changeset
30 constantPoolHandle pool, int cp_index, symbolHandle error)
a61af66fc99e Initial load
duke
parents:
diff changeset
31 {
a61af66fc99e Initial load
duke
parents:
diff changeset
32 assert_locked_or_safepoint(SystemDictionary_lock);
a61af66fc99e Initial load
duke
parents:
diff changeset
33 assert(!pool.is_null() && !error.is_null(), "adding NULL obj");
a61af66fc99e Initial load
duke
parents:
diff changeset
34
a61af66fc99e Initial load
duke
parents:
diff changeset
35 ResolutionErrorEntry* entry = new_entry(hash, pool(), cp_index, error());
a61af66fc99e Initial load
duke
parents:
diff changeset
36 add_entry(index, entry);
a61af66fc99e Initial load
duke
parents:
diff changeset
37 }
a61af66fc99e Initial load
duke
parents:
diff changeset
38
a61af66fc99e Initial load
duke
parents:
diff changeset
39 // find entry in the table
a61af66fc99e Initial load
duke
parents:
diff changeset
40 ResolutionErrorEntry* ResolutionErrorTable::find_entry(int index, unsigned int hash,
a61af66fc99e Initial load
duke
parents:
diff changeset
41 constantPoolHandle pool, int cp_index)
a61af66fc99e Initial load
duke
parents:
diff changeset
42 {
a61af66fc99e Initial load
duke
parents:
diff changeset
43 assert_locked_or_safepoint(SystemDictionary_lock);
a61af66fc99e Initial load
duke
parents:
diff changeset
44
a61af66fc99e Initial load
duke
parents:
diff changeset
45 for (ResolutionErrorEntry *error_probe = bucket(index);
a61af66fc99e Initial load
duke
parents:
diff changeset
46 error_probe != NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
47 error_probe = error_probe->next()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
48 if (error_probe->hash() == hash && error_probe->pool() == pool()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
49 return error_probe;;
a61af66fc99e Initial load
duke
parents:
diff changeset
50 }
a61af66fc99e Initial load
duke
parents:
diff changeset
51 }
a61af66fc99e Initial load
duke
parents:
diff changeset
52 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
53 }
a61af66fc99e Initial load
duke
parents:
diff changeset
54
a61af66fc99e Initial load
duke
parents:
diff changeset
55 // create new error entry
a61af66fc99e Initial load
duke
parents:
diff changeset
56 ResolutionErrorEntry* ResolutionErrorTable::new_entry(int hash, constantPoolOop pool,
a61af66fc99e Initial load
duke
parents:
diff changeset
57 int cp_index, symbolOop error)
a61af66fc99e Initial load
duke
parents:
diff changeset
58 {
a61af66fc99e Initial load
duke
parents:
diff changeset
59 ResolutionErrorEntry* entry = (ResolutionErrorEntry*)Hashtable::new_entry(hash, pool);
a61af66fc99e Initial load
duke
parents:
diff changeset
60 entry->set_cp_index(cp_index);
a61af66fc99e Initial load
duke
parents:
diff changeset
61 entry->set_error(error);
a61af66fc99e Initial load
duke
parents:
diff changeset
62
a61af66fc99e Initial load
duke
parents:
diff changeset
63 return entry;
a61af66fc99e Initial load
duke
parents:
diff changeset
64 }
a61af66fc99e Initial load
duke
parents:
diff changeset
65
a61af66fc99e Initial load
duke
parents:
diff changeset
66 // create resolution error table
a61af66fc99e Initial load
duke
parents:
diff changeset
67 ResolutionErrorTable::ResolutionErrorTable(int table_size)
a61af66fc99e Initial load
duke
parents:
diff changeset
68 : Hashtable(table_size, sizeof(ResolutionErrorEntry)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
69 }
a61af66fc99e Initial load
duke
parents:
diff changeset
70
a61af66fc99e Initial load
duke
parents:
diff changeset
71 // GC support
a61af66fc99e Initial load
duke
parents:
diff changeset
72 void ResolutionErrorTable::oops_do(OopClosure* f) {
a61af66fc99e Initial load
duke
parents:
diff changeset
73 for (int i = 0; i < table_size(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
74 for (ResolutionErrorEntry* probe = bucket(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
75 probe != NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
76 probe = probe->next()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
77 assert(probe->pool() != (constantPoolOop)NULL, "resolution error table is corrupt");
a61af66fc99e Initial load
duke
parents:
diff changeset
78 assert(probe->error() != (symbolOop)NULL, "resolution error table is corrupt");
a61af66fc99e Initial load
duke
parents:
diff changeset
79 probe->oops_do(f);
a61af66fc99e Initial load
duke
parents:
diff changeset
80 }
a61af66fc99e Initial load
duke
parents:
diff changeset
81 }
a61af66fc99e Initial load
duke
parents:
diff changeset
82 }
a61af66fc99e Initial load
duke
parents:
diff changeset
83
a61af66fc99e Initial load
duke
parents:
diff changeset
84 // GC support
a61af66fc99e Initial load
duke
parents:
diff changeset
85 void ResolutionErrorEntry::oops_do(OopClosure* blk) {
a61af66fc99e Initial load
duke
parents:
diff changeset
86 blk->do_oop((oop*)pool_addr());
a61af66fc99e Initial load
duke
parents:
diff changeset
87 blk->do_oop((oop*)error_addr());
a61af66fc99e Initial load
duke
parents:
diff changeset
88 }
a61af66fc99e Initial load
duke
parents:
diff changeset
89
a61af66fc99e Initial load
duke
parents:
diff changeset
90 // We must keep the symbolOop used in the error alive. The constantPoolOop will
a61af66fc99e Initial load
duke
parents:
diff changeset
91 // decide when the entry can be purged.
a61af66fc99e Initial load
duke
parents:
diff changeset
92 void ResolutionErrorTable::always_strong_classes_do(OopClosure* blk) {
a61af66fc99e Initial load
duke
parents:
diff changeset
93 for (int i = 0; i < table_size(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
94 for (ResolutionErrorEntry* probe = bucket(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
95 probe != NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
96 probe = probe->next()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
97 assert(probe->error() != (symbolOop)NULL, "resolution error table is corrupt");
a61af66fc99e Initial load
duke
parents:
diff changeset
98 blk->do_oop((oop*)probe->error_addr());
a61af66fc99e Initial load
duke
parents:
diff changeset
99 }
a61af66fc99e Initial load
duke
parents:
diff changeset
100 }
a61af66fc99e Initial load
duke
parents:
diff changeset
101 }
a61af66fc99e Initial load
duke
parents:
diff changeset
102
a61af66fc99e Initial load
duke
parents:
diff changeset
103 // Remove unloaded entries from the table
a61af66fc99e Initial load
duke
parents:
diff changeset
104 void ResolutionErrorTable::purge_resolution_errors(BoolObjectClosure* is_alive) {
a61af66fc99e Initial load
duke
parents:
diff changeset
105 assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint")
a61af66fc99e Initial load
duke
parents:
diff changeset
106 for (int i = 0; i < table_size(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
107 for (ResolutionErrorEntry** p = bucket_addr(i); *p != NULL; ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
108 ResolutionErrorEntry* entry = *p;
a61af66fc99e Initial load
duke
parents:
diff changeset
109 assert(entry->pool() != (constantPoolOop)NULL, "resolution error table is corrupt");
a61af66fc99e Initial load
duke
parents:
diff changeset
110 constantPoolOop pool = entry->pool();
a61af66fc99e Initial load
duke
parents:
diff changeset
111 if (is_alive->do_object_b(pool)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
112 p = entry->next_addr();
a61af66fc99e Initial load
duke
parents:
diff changeset
113 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
114 *p = entry->next();
a61af66fc99e Initial load
duke
parents:
diff changeset
115 free_entry(entry);
a61af66fc99e Initial load
duke
parents:
diff changeset
116 }
a61af66fc99e Initial load
duke
parents:
diff changeset
117 }
a61af66fc99e Initial load
duke
parents:
diff changeset
118 }
a61af66fc99e Initial load
duke
parents:
diff changeset
119 }