Mercurial > hg > truffle
annotate src/share/vm/utilities/growableArray.cpp @ 1994:6cd6d394f280
7001033: assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed())
7002546: regression on SpecJbb2005 on 7b118 comparing to 7b117 on small heaps
Summary: Relaxed assertion checking related to incremental_collection_failed flag to allow for ExplicitGCInvokesConcurrent behaviour where we do not want a failing scavenge to bail to a stop-world collection. Parameterized incremental_collection_will_fail() so we can selectively use, or not use, as appropriate, the statistical prediction at specific use sites. This essentially reverts the scavenge bail-out logic to what it was prior to some recent changes that had inadvertently started using the statistical prediction which can be noisy in the presence of bursty loads. Added some associated verbose non-product debugging messages.
Reviewed-by: johnc, tonyp
author | ysr |
---|---|
date | Tue, 07 Dec 2010 21:55:53 -0800 |
parents | f95d63e2154a |
children | f08d439fab8c |
rev | line source |
---|---|
0 | 1 /* |
1972 | 2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "memory/resourceArea.hpp" | |
27 #include "utilities/growableArray.hpp" | |
28 #ifdef TARGET_OS_FAMILY_linux | |
29 # include "thread_linux.inline.hpp" | |
30 #endif | |
31 #ifdef TARGET_OS_FAMILY_solaris | |
32 # include "thread_solaris.inline.hpp" | |
33 #endif | |
34 #ifdef TARGET_OS_FAMILY_windows | |
35 # include "thread_windows.inline.hpp" | |
36 #endif | |
0 | 37 #ifdef ASSERT |
38 void GenericGrowableArray::set_nesting() { | |
39 if (on_stack()) { | |
40 _nesting = Thread::current()->resource_area()->nesting(); | |
41 } | |
42 } | |
43 | |
44 void GenericGrowableArray::check_nesting() { | |
45 // Check for insidious allocation bug: if a GrowableArray overflows, the | |
46 // grown array must be allocated under the same ResourceMark as the original. | |
47 // Otherwise, the _data array will be deallocated too early. | |
48 if (on_stack() && | |
49 _nesting != Thread::current()->resource_area()->nesting()) { | |
50 fatal("allocation bug: GrowableArray could grow within nested ResourceMark"); | |
51 } | |
52 } | |
53 #endif | |
54 | |
55 void* GenericGrowableArray::raw_allocate(int elementSize) { | |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
56 assert(_max >= 0, "integer overflow"); |
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
57 size_t byte_size = elementSize * (size_t) _max; |
0 | 58 if (on_stack()) { |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
59 return (void*)resource_allocate_bytes(byte_size); |
0 | 60 } else if (on_C_heap()) { |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
61 return (void*)AllocateHeap(byte_size, "GrET in " __FILE__); |
0 | 62 } else { |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
63 return _arena->Amalloc(byte_size); |
0 | 64 } |
65 } |