Mercurial > hg > truffle
annotate src/share/vm/runtime/sweeper.cpp @ 13725:8d8732e14447
Refactor reference maps.
author | Roland Schatz <roland.schatz@oracle.com> |
---|---|
date | Wed, 22 Jan 2014 11:27:28 +0100 |
parents | 2d4a8d3d286b |
children | d8041d695d19 |
rev | line source |
---|---|
0 | 1 /* |
10405 | 2 * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1538
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1538
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1538
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "code/codeCache.hpp" | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
27 #include "code/compiledIC.hpp" |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
28 #include "code/icBuffer.hpp" |
1972 | 29 #include "code/nmethod.hpp" |
30 #include "compiler/compileBroker.hpp" | |
31 #include "memory/resourceArea.hpp" | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
32 #include "oops/method.hpp" |
1972 | 33 #include "runtime/atomic.hpp" |
34 #include "runtime/compilationPolicy.hpp" | |
35 #include "runtime/mutexLocker.hpp" | |
36 #include "runtime/os.hpp" | |
37 #include "runtime/sweeper.hpp" | |
38 #include "runtime/vm_operations.hpp" | |
10405 | 39 #include "trace/tracing.hpp" |
1972 | 40 #include "utilities/events.hpp" |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
41 #include "utilities/ticks.inline.hpp" |
1972 | 42 #include "utilities/xmlstream.hpp" |
0 | 43 |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
44 #ifdef ASSERT |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
45 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
46 #define SWEEP(nm) record_sweep(nm, __LINE__) |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
47 // Sweeper logging code |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
48 class SweeperRecord { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
49 public: |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
50 int traversal; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
51 int invocation; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
52 int compile_id; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
53 long traversal_mark; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
54 int state; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
55 const char* kind; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
56 address vep; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
57 address uep; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
58 int line; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
59 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
60 void print() { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
61 tty->print_cr("traversal = %d invocation = %d compile_id = %d %s uep = " PTR_FORMAT " vep = " |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
62 PTR_FORMAT " state = %d traversal_mark %d line = %d", |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
63 traversal, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
64 invocation, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
65 compile_id, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
66 kind == NULL ? "" : kind, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
67 uep, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
68 vep, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
69 state, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
70 traversal_mark, |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
71 line); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
72 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
73 }; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
74 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
75 static int _sweep_index = 0; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
76 static SweeperRecord* _records = NULL; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
77 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
78 void NMethodSweeper::report_events(int id, address entry) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
79 if (_records != NULL) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
80 for (int i = _sweep_index; i < SweeperLogEntries; i++) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
81 if (_records[i].uep == entry || |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
82 _records[i].vep == entry || |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
83 _records[i].compile_id == id) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
84 _records[i].print(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
85 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
86 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
87 for (int i = 0; i < _sweep_index; i++) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
88 if (_records[i].uep == entry || |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
89 _records[i].vep == entry || |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
90 _records[i].compile_id == id) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
91 _records[i].print(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
92 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
93 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
94 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
95 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
96 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
97 void NMethodSweeper::report_events() { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
98 if (_records != NULL) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
99 for (int i = _sweep_index; i < SweeperLogEntries; i++) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
100 // skip empty records |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
101 if (_records[i].vep == NULL) continue; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
102 _records[i].print(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
103 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
104 for (int i = 0; i < _sweep_index; i++) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
105 // skip empty records |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
106 if (_records[i].vep == NULL) continue; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
107 _records[i].print(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
108 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
109 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
110 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
111 |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
112 void NMethodSweeper::record_sweep(nmethod* nm, int line) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
113 if (_records != NULL) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
114 _records[_sweep_index].traversal = _traversals; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
115 _records[_sweep_index].traversal_mark = nm->_stack_traversal_mark; |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
116 _records[_sweep_index].invocation = _sweep_fractions_left; |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
117 _records[_sweep_index].compile_id = nm->compile_id(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
118 _records[_sweep_index].kind = nm->compile_kind(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
119 _records[_sweep_index].state = nm->_state; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
120 _records[_sweep_index].vep = nm->verified_entry_point(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
121 _records[_sweep_index].uep = nm->entry_point(); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
122 _records[_sweep_index].line = line; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
123 _sweep_index = (_sweep_index + 1) % SweeperLogEntries; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
124 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
125 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
126 #else |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
127 #define SWEEP(nm) |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
128 #endif |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
129 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
130 nmethod* NMethodSweeper::_current = NULL; // Current nmethod |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
131 long NMethodSweeper::_traversals = 0; // Stack scan count, also sweep ID. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
132 long NMethodSweeper::_time_counter = 0; // Virtual time used to periodically invoke sweeper |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
133 long NMethodSweeper::_last_sweep = 0; // Value of _time_counter when the last sweep happened |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
134 int NMethodSweeper::_seen = 0; // Nof. nmethod we have currently processed in current pass of CodeCache |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
135 int NMethodSweeper::_flushed_count = 0; // Nof. nmethods flushed in current sweep |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
136 int NMethodSweeper::_zombified_count = 0; // Nof. nmethods made zombie in current sweep |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
137 int NMethodSweeper::_marked_for_reclamation_count = 0; // Nof. nmethods marked for reclaim in current sweep |
0 | 138 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
139 volatile bool NMethodSweeper::_should_sweep = true; // Indicates if we should invoke the sweeper |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
140 volatile int NMethodSweeper::_sweep_fractions_left = 0; // Nof. invocations left until we are completed with this pass |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
141 volatile int NMethodSweeper::_sweep_started = 0; // Flag to control conc sweeper |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
142 volatile int NMethodSweeper::_bytes_changed = 0; // Counts the total nmethod size if the nmethod changed from: |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
143 // 1) alive -> not_entrant |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
144 // 2) not_entrant -> zombie |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
145 // 3) zombie -> marked_for_reclamation |
0 | 146 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
147 int NMethodSweeper::_total_nof_methods_reclaimed = 0; // Accumulated nof methods flushed |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
148 Tickspan NMethodSweeper::_total_time_sweeping; // Accumulated time sweeping |
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
149 Tickspan NMethodSweeper::_total_time_this_sweep; // Total time this sweep |
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
150 Tickspan NMethodSweeper::_peak_sweep_time; // Peak time for a full sweep |
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
151 Tickspan NMethodSweeper::_peak_sweep_fraction_time; // Peak time sweeping one fraction |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
152 int NMethodSweeper::_hotness_counter_reset_val = 0; |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
153 |
10405 | 154 |
989 | 155 class MarkActivationClosure: public CodeBlobClosure { |
156 public: | |
157 virtual void do_code_blob(CodeBlob* cb) { | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
158 if (cb->is_nmethod()) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
159 nmethod* nm = (nmethod*)cb; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
160 nm->set_hotness_counter(NMethodSweeper::hotness_counter_reset_val()); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
161 // If we see an activation belonging to a non_entrant nmethod, we mark it. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
162 if (nm->is_not_entrant()) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
163 nm->mark_as_seen_on_stack(); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
164 } |
989 | 165 } |
166 } | |
167 }; | |
168 static MarkActivationClosure mark_activation_closure; | |
169 | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
170 class SetHotnessClosure: public CodeBlobClosure { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
171 public: |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
172 virtual void do_code_blob(CodeBlob* cb) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
173 if (cb->is_nmethod()) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
174 nmethod* nm = (nmethod*)cb; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
175 nm->set_hotness_counter(NMethodSweeper::hotness_counter_reset_val()); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
176 } |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
177 } |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
178 }; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
179 static SetHotnessClosure set_hotness_closure; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
180 |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
181 |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
182 int NMethodSweeper::hotness_counter_reset_val() { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
183 if (_hotness_counter_reset_val == 0) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
184 _hotness_counter_reset_val = (ReservedCodeCacheSize < M) ? 1 : (ReservedCodeCacheSize / M) * 2; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
185 } |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
186 return _hotness_counter_reset_val; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
187 } |
10206
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
188 bool NMethodSweeper::sweep_in_progress() { |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
189 return (_current != NULL); |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
190 } |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
191 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
192 // Scans the stacks of all Java threads and marks activations of not-entrant methods. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
193 // No need to synchronize access, since 'mark_active_nmethods' is always executed at a |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
194 // safepoint. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
195 void NMethodSweeper::mark_active_nmethods() { |
0 | 196 assert(SafepointSynchronize::is_at_safepoint(), "must be executed at a safepoint"); |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
197 // If we do not want to reclaim not-entrant or zombie methods there is no need |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
198 // to scan stacks |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
199 if (!MethodFlushing) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
200 return; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
201 } |
0 | 202 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
203 // Increase time so that we can estimate when to invoke the sweeper again. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
204 _time_counter++; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
205 |
0 | 206 // Check for restart |
207 assert(CodeCache::find_blob_unsafe(_current) == _current, "Sweeper nmethod cached state invalid"); | |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
208 if (!sweep_in_progress()) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
209 _seen = 0; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
210 _sweep_fractions_left = NmethodSweepFraction; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
211 _current = CodeCache::first_nmethod(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
212 _traversals += 1; |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
213 _total_time_this_sweep = Tickspan(); |
10405 | 214 |
0 | 215 if (PrintMethodFlushing) { |
216 tty->print_cr("### Sweep: stack traversal %d", _traversals); | |
217 } | |
989 | 218 Threads::nmethods_do(&mark_activation_closure); |
0 | 219 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
220 } else { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
221 // Only set hotness counter |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
222 Threads::nmethods_do(&set_hotness_closure); |
0 | 223 } |
224 | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
225 OrderAccess::storestore(); |
0 | 226 } |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
227 /** |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
228 * This function invokes the sweeper if at least one of the three conditions is met: |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
229 * (1) The code cache is getting full |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
230 * (2) There are sufficient state changes in/since the last sweep. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
231 * (3) We have not been sweeping for 'some time' |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
232 */ |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
233 void NMethodSweeper::possibly_sweep() { |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
234 assert(JavaThread::current()->thread_state() == _thread_in_vm, "must run in vm mode"); |
13383
938e1e64e28f
8028306: nsk stress tests, CodeCache fills, then safepoint asserts
anoll
parents:
13074
diff
changeset
|
235 // Only compiler threads are allowed to sweep |
13722
2d4a8d3d286b
Sweeper: make sure we only run the sweeper on java threads
Gilles Duboscq <duboscq@ssw.jku.at>
parents:
13715
diff
changeset
|
236 if (!MethodFlushing || !sweep_in_progress() NOT_GRAAL(|| !Thread::current()->is_Compiler_thread()) GRAAL_ONLY(|| !Thread::current()->is_Java_thread())) { |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
237 return; |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
238 } |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
239 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
240 // If there was no state change while nmethod sweeping, 'should_sweep' will be false. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
241 // This is one of the two places where should_sweep can be set to true. The general |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
242 // idea is as follows: If there is enough free space in the code cache, there is no |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
243 // need to invoke the sweeper. The following formula (which determines whether to invoke |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
244 // the sweeper or not) depends on the assumption that for larger ReservedCodeCacheSizes |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
245 // we need less frequent sweeps than for smaller ReservedCodecCacheSizes. Furthermore, |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
246 // the formula considers how much space in the code cache is currently used. Here are |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
247 // some examples that will (hopefully) help in understanding. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
248 // |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
249 // Small ReservedCodeCacheSizes: (e.g., < 16M) We invoke the sweeper every time, since |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
250 // the result of the division is 0. This |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
251 // keeps the used code cache size small |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
252 // (important for embedded Java) |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
253 // Large ReservedCodeCacheSize : (e.g., 256M + code cache is 10% full). The formula |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
254 // computes: (256 / 16) - 1 = 15 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
255 // As a result, we invoke the sweeper after |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
256 // 15 invocations of 'mark_active_nmethods. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
257 // Large ReservedCodeCacheSize: (e.g., 256M + code Cache is 90% full). The formula |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
258 // computes: (256 / 16) - 10 = 6. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
259 if (!_should_sweep) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
260 int time_since_last_sweep = _time_counter - _last_sweep; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
261 double wait_until_next_sweep = (ReservedCodeCacheSize / (16 * M)) - time_since_last_sweep - |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
262 CodeCache::reverse_free_ratio(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
263 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
264 if ((wait_until_next_sweep <= 0.0) || !CompileBroker::should_compile_new_jobs()) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
265 _should_sweep = true; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
266 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
267 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
268 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
269 if (_should_sweep && _sweep_fractions_left > 0) { |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
270 // Only one thread at a time will sweep |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
271 jint old = Atomic::cmpxchg( 1, &_sweep_started, 0 ); |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
272 if (old != 0) { |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
273 return; |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
274 } |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
275 #ifdef ASSERT |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
276 if (LogSweeper && _records == NULL) { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
277 // Create the ring buffer for the logging code |
6197 | 278 _records = NEW_C_HEAP_ARRAY(SweeperRecord, SweeperLogEntries, mtGC); |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
279 memset(_records, 0, sizeof(SweeperRecord) * SweeperLogEntries); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
280 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
281 #endif |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
282 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
283 if (_sweep_fractions_left > 0) { |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
284 sweep_code_cache(); |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
285 _sweep_fractions_left--; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
286 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
287 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
288 // We are done with sweeping the code cache once. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
289 if (_sweep_fractions_left == 0) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
290 _last_sweep = _time_counter; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
291 // Reset flag; temporarily disables sweeper |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
292 _should_sweep = false; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
293 // If there was enough state change, 'possibly_enable_sweeper()' |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
294 // sets '_should_sweep' to true |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
295 possibly_enable_sweeper(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
296 // Reset _bytes_changed only if there was enough state change. _bytes_changed |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
297 // can further increase by calls to 'report_state_change'. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
298 if (_should_sweep) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
299 _bytes_changed = 0; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
300 } |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
301 } |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
302 _sweep_started = 0; |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
303 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
304 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
305 |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
306 void NMethodSweeper::sweep_code_cache() { |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
307 Ticks sweep_start_counter = Ticks::now(); |
10405 | 308 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
309 _flushed_count = 0; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
310 _zombified_count = 0; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
311 _marked_for_reclamation_count = 0; |
10405 | 312 |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
313 if (PrintMethodFlushing && Verbose) { |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
314 tty->print_cr("### Sweep at %d out of %d. Invocations left: %d", _seen, CodeCache::nof_nmethods(), _sweep_fractions_left); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
315 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
316 |
10206
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
317 if (!CompileBroker::should_compile_new_jobs()) { |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
318 // If we have turned off compilations we might as well do full sweeps |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
319 // in order to reach the clean state faster. Otherwise the sleeping compiler |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
320 // threads will slow down sweeping. |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
321 _sweep_fractions_left = 1; |
10206
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
322 } |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
323 |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
324 // We want to visit all nmethods after NmethodSweepFraction |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
325 // invocations so divide the remaining number of nmethods by the |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
326 // remaining number of invocations. This is only an estimate since |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
327 // the number of nmethods changes during the sweep so the final |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
328 // stage must iterate until it there are no more nmethods. |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
329 int todo = (CodeCache::nof_nmethods() - _seen) / _sweep_fractions_left; |
12266
ab274453d37f
8022883: Assertion failed: sweptCount >= flushedCount + markedCount + zombifiedCount
anoll
parents:
10405
diff
changeset
|
330 int swept_count = 0; |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
331 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
332 |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
333 assert(!SafepointSynchronize::is_at_safepoint(), "should not be in safepoint when we get here"); |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
334 assert(!CodeCache_lock->owned_by_self(), "just checking"); |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
335 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
336 int freed_memory = 0; |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
337 { |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
338 MutexLockerEx mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
339 |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
340 // The last invocation iterates until there are no more nmethods |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
341 for (int i = 0; (i < todo || _sweep_fractions_left == 1) && _current != NULL; i++) { |
12266
ab274453d37f
8022883: Assertion failed: sweptCount >= flushedCount + markedCount + zombifiedCount
anoll
parents:
10405
diff
changeset
|
342 swept_count++; |
4945
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
343 if (SafepointSynchronize::is_synchronizing()) { // Safepoint request |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
344 if (PrintMethodFlushing && Verbose) { |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
345 tty->print_cr("### Sweep at %d out of %d, invocation: %d, yielding to safepoint", _seen, CodeCache::nof_nmethods(), _sweep_fractions_left); |
4945
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
346 } |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
347 MutexUnlockerEx mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
348 |
4945
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
349 assert(Thread::current()->is_Java_thread(), "should be java thread"); |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
350 JavaThread* thread = (JavaThread*)Thread::current(); |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
351 ThreadBlockInVM tbivm(thread); |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
352 thread->java_suspend_self(); |
cfdfbeac0a5b
7145345: Code cache sweeper must cooperate with safepoints
iveresov
parents:
3384
diff
changeset
|
353 } |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
354 // Since we will give up the CodeCache_lock, always skip ahead |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
355 // to the next nmethod. Other blobs can be deleted by other |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
356 // threads but nmethods are only reclaimed by the sweeper. |
1615
ff38d05ea86f
6956958: assert(is_clean() || is_call_to_compiled() || is_call_to_interpreted() || is_optimized() || is_megam
never
parents:
1552
diff
changeset
|
357 nmethod* next = CodeCache::next_nmethod(_current); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
358 |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
359 // Now ready to process nmethod and give up CodeCache_lock |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
360 { |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
361 MutexUnlockerEx mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
362 freed_memory += process_nmethod(_current); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
363 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
364 _seen++; |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
365 _current = next; |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
366 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
367 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
368 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
369 assert(_sweep_fractions_left > 1 || _current == NULL, "must have scanned the whole cache"); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
370 |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
371 const Ticks sweep_end_counter = Ticks::now(); |
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
372 const Tickspan sweep_time = sweep_end_counter - sweep_start_counter; |
10405 | 373 _total_time_sweeping += sweep_time; |
374 _total_time_this_sweep += sweep_time; | |
375 _peak_sweep_fraction_time = MAX2(sweep_time, _peak_sweep_fraction_time); | |
376 _total_nof_methods_reclaimed += _flushed_count; | |
377 | |
378 EventSweepCodeCache event(UNTIMED); | |
379 if (event.should_commit()) { | |
380 event.set_starttime(sweep_start_counter); | |
381 event.set_endtime(sweep_end_counter); | |
382 event.set_sweepIndex(_traversals); | |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
383 event.set_sweepFractionIndex(NmethodSweepFraction - _sweep_fractions_left + 1); |
12266
ab274453d37f
8022883: Assertion failed: sweptCount >= flushedCount + markedCount + zombifiedCount
anoll
parents:
10405
diff
changeset
|
384 event.set_sweptCount(swept_count); |
10405 | 385 event.set_flushedCount(_flushed_count); |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
386 event.set_markedCount(_marked_for_reclamation_count); |
10405 | 387 event.set_zombifiedCount(_zombified_count); |
388 event.commit(); | |
389 } | |
390 | |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
391 #ifdef ASSERT |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
392 if(PrintMethodFlushing) { |
13400
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
393 tty->print_cr("### sweeper: sweep time(%d): " |
86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
mgronlun
parents:
13383
diff
changeset
|
394 INT64_FORMAT, _sweep_fractions_left, (jlong)sweep_time.value()); |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
395 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
396 #endif |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
397 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
398 if (_sweep_fractions_left == 1) { |
10405 | 399 _peak_sweep_time = MAX2(_peak_sweep_time, _total_time_this_sweep); |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
400 log_sweep("finished"); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
401 } |
10206
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
402 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
403 // Sweeper is the only case where memory is released, check here if it |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
404 // is time to restart the compiler. Only checking if there is a certain |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
405 // amount of free memory in the code cache might lead to re-enabling |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
406 // compilation although no memory has been released. For example, there are |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
407 // cases when compilation was disabled although there is 4MB (or more) free |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
408 // memory in the code cache. The reason is code cache fragmentation. Therefore, |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
409 // it only makes sense to re-enable compilation if we have actually freed memory. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
410 // Note that typically several kB are released for sweeping 16MB of the code |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
411 // cache. As a result, 'freed_memory' > 0 to restart the compiler. |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
412 if (!CompileBroker::should_compile_new_jobs() && (freed_memory > 0)) { |
10206
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
413 CompileBroker::set_should_compile_new_jobs(CompileBroker::run_compilation); |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
414 log_sweep("restart_compiler"); |
0cfa93c2fcc4
8012547: Code cache flushing can get stuck reclaming of memory
neliasso
parents:
6725
diff
changeset
|
415 } |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
416 } |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
417 |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
418 /** |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
419 * This function updates the sweeper statistics that keep track of nmethods |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
420 * state changes. If there is 'enough' state change, the sweeper is invoked |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
421 * as soon as possible. There can be data races on _bytes_changed. The data |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
422 * races are benign, since it does not matter if we loose a couple of bytes. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
423 * In the worst case we call the sweeper a little later. Also, we are guaranteed |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
424 * to invoke the sweeper if the code cache gets full. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
425 */ |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
426 void NMethodSweeper::report_state_change(nmethod* nm) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
427 _bytes_changed += nm->total_size(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
428 possibly_enable_sweeper(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
429 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
430 |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
431 /** |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
432 * Function determines if there was 'enough' state change in the code cache to invoke |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
433 * the sweeper again. Currently, we determine 'enough' as more than 1% state change in |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
434 * the code cache since the last sweep. |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
435 */ |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
436 void NMethodSweeper::possibly_enable_sweeper() { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
437 double percent_changed = ((double)_bytes_changed / (double)ReservedCodeCacheSize) * 100; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
438 if (percent_changed > 1.0) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
439 _should_sweep = true; |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
440 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
441 } |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
442 |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
443 class NMethodMarker: public StackObj { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
444 private: |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
445 #ifdef GRAAL |
3696
dc7902820c9b
Make NMethodSweeper work on any JavaThread
Gilles Duboscq <gilles.m.duboscq@gmail.com>
parents:
3384
diff
changeset
|
446 JavaThread* _thread; |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
447 #else |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
448 CompilerThread* _thread; |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
449 #endif |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
450 public: |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
451 NMethodMarker(nmethod* nm) { |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
452 #ifdef GRAAL |
3696
dc7902820c9b
Make NMethodSweeper work on any JavaThread
Gilles Duboscq <gilles.m.duboscq@gmail.com>
parents:
3384
diff
changeset
|
453 _thread = JavaThread::current(); |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
454 #else |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
455 _thread = CompilerThread::current(); |
6948
e522a00b91aa
Merge with http://hg.openjdk.java.net/hsx/hsx25/hotspot/ after NPG - C++ build works
Doug Simon <doug.simon@oracle.com>
diff
changeset
|
456 #endif |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
457 if (!nm->is_zombie() && !nm->is_unloaded()) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
458 // Only expose live nmethods for scanning |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
459 _thread->set_scanned_nmethod(nm); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
460 } |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
461 } |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
462 ~NMethodMarker() { |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
463 _thread->set_scanned_nmethod(NULL); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
464 } |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
465 }; |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
466 |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
467 void NMethodSweeper::release_nmethod(nmethod *nm) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
468 // Clean up any CompiledICHolders |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
469 { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
470 ResourceMark rm; |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
471 MutexLocker ml_patch(CompiledIC_lock); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
472 RelocIterator iter(nm); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
473 while (iter.next()) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
474 if (iter.type() == relocInfo::virtual_call_type) { |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
475 CompiledIC::cleanup_call_site(iter.virtual_call_reloc()); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
476 } |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
477 } |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
478 } |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
479 |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
480 MutexLockerEx mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
481 nm->flush(); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
482 } |
0 | 483 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
484 int NMethodSweeper::process_nmethod(nmethod *nm) { |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
485 assert(!CodeCache_lock->owned_by_self(), "just checking"); |
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
486 |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
487 int freed_memory = 0; |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
488 // Make sure this nmethod doesn't get unloaded during the scan, |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
489 // since safepoints may happen during acquired below locks. |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
490 NMethodMarker nmm(nm); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
491 SWEEP(nm); |
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
492 |
0 | 493 // Skip methods that are currently referenced by the VM |
494 if (nm->is_locked_by_vm()) { | |
495 // But still remember to clean-up inline caches for alive nmethods | |
496 if (nm->is_alive()) { | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
497 // Clean inline caches that point to zombie/non-entrant methods |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
498 MutexLocker cl(CompiledIC_lock); |
0 | 499 nm->cleanup_inline_caches(); |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
500 SWEEP(nm); |
0 | 501 } |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
502 return freed_memory; |
0 | 503 } |
504 | |
505 if (nm->is_zombie()) { | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
506 // If it is the first time we see nmethod then we mark it. Otherwise, |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
507 // we reclaim it. When we have seen a zombie method twice, we know that |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
508 // there are no inline caches that refer to it. |
0 | 509 if (nm->is_marked_for_reclamation()) { |
510 assert(!nm->is_locked_by_vm(), "must not flush locked nmethods"); | |
941 | 511 if (PrintMethodFlushing && Verbose) { |
1202 | 512 tty->print_cr("### Nmethod %3d/" PTR_FORMAT " (marked for reclamation) being flushed", nm->compile_id(), nm); |
941 | 513 } |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
514 freed_memory = nm->total_size(); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
515 release_nmethod(nm); |
10405 | 516 _flushed_count++; |
0 | 517 } else { |
941 | 518 if (PrintMethodFlushing && Verbose) { |
1202 | 519 tty->print_cr("### Nmethod %3d/" PTR_FORMAT " (zombie) being marked for reclamation", nm->compile_id(), nm); |
941 | 520 } |
0 | 521 nm->mark_for_reclamation(); |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
522 // Keep track of code cache state change |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
523 _bytes_changed += nm->total_size(); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
524 _marked_for_reclamation_count++; |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
525 SWEEP(nm); |
0 | 526 } |
527 } else if (nm->is_not_entrant()) { | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
528 // If there are no current activations of this method on the |
0 | 529 // stack we can safely convert it to a zombie method |
530 if (nm->can_not_entrant_be_converted()) { | |
941 | 531 if (PrintMethodFlushing && Verbose) { |
1202 | 532 tty->print_cr("### Nmethod %3d/" PTR_FORMAT " (not entrant) being made zombie", nm->compile_id(), nm); |
941 | 533 } |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
534 // Code cache state change is tracked in make_zombie() |
0 | 535 nm->make_zombie(); |
10405 | 536 _zombified_count++; |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
537 SWEEP(nm); |
0 | 538 } else { |
539 // Still alive, clean up its inline caches | |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
540 MutexLocker cl(CompiledIC_lock); |
0 | 541 nm->cleanup_inline_caches(); |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
542 SWEEP(nm); |
0 | 543 } |
544 } else if (nm->is_unloaded()) { | |
545 // Unloaded code, just make it a zombie | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
546 if (PrintMethodFlushing && Verbose) { |
1202 | 547 tty->print_cr("### Nmethod %3d/" PTR_FORMAT " (unloaded) being made zombie", nm->compile_id(), nm); |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
548 } |
941 | 549 if (nm->is_osr_method()) { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
550 SWEEP(nm); |
0 | 551 // No inline caches will ever point to osr methods, so we can just remove it |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
552 freed_memory = nm->total_size(); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6197
diff
changeset
|
553 release_nmethod(nm); |
10405 | 554 _flushed_count++; |
0 | 555 } else { |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
556 // Code cache state change is tracked in make_zombie() |
0 | 557 nm->make_zombie(); |
10405 | 558 _zombified_count++; |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
559 SWEEP(nm); |
0 | 560 } |
561 } else { | |
1202 | 562 if (UseCodeCacheFlushing) { |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
563 if (!nm->is_locked_by_vm() && !nm->is_osr_method() && !nm->is_native_method()) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
564 // Do not make native methods and OSR-methods not-entrant |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
565 nm->dec_hotness_counter(); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
566 // Get the initial value of the hotness counter. This value depends on the |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
567 // ReservedCodeCacheSize |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
568 int reset_val = hotness_counter_reset_val(); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
569 int time_since_reset = reset_val - nm->hotness_counter(); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
570 double threshold = -reset_val + (CodeCache::reverse_free_ratio() * NmethodSweepActivity); |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
571 // The less free space in the code cache we have - the bigger reverse_free_ratio() is. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
572 // I.e., 'threshold' increases with lower available space in the code cache and a higher |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
573 // NmethodSweepActivity. If the current hotness counter - which decreases from its initial |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
574 // value until it is reset by stack walking - is smaller than the computed threshold, the |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
575 // corresponding nmethod is considered for removal. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
576 if ((NmethodSweepActivity > 0) && (nm->hotness_counter() < threshold) && (time_since_reset > 10)) { |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
577 // A method is marked as not-entrant if the method is |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
578 // 1) 'old enough': nm->hotness_counter() < threshold |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
579 // 2) The method was in_use for a minimum amount of time: (time_since_reset > 10) |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
580 // The second condition is necessary if we are dealing with very small code cache |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
581 // sizes (e.g., <10m) and the code cache size is too small to hold all hot methods. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
582 // The second condition ensures that methods are not immediately made not-entrant |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
583 // after compilation. |
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
584 nm->make_not_entrant(); |
13074
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
585 // Code cache state change is tracked in make_not_entrant() |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
586 if (PrintMethodFlushing && Verbose) { |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
587 tty->print_cr("### Nmethod %d/" PTR_FORMAT "made not-entrant: hotness counter %d/%d threshold %f", |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
588 nm->compile_id(), nm, nm->hotness_counter(), reset_val, threshold); |
78da3894b86f
8027593: performance drop with constrained codecache starting with hs25 b111
anoll
parents:
12324
diff
changeset
|
589 } |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
590 } |
1202 | 591 } |
592 } | |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
593 // Clean-up all inline caches that point to zombie/non-reentrant methods |
1538
bfe29ec02863
6950075: nmethod sweeper should operate concurrently
never
parents:
1202
diff
changeset
|
594 MutexLocker cl(CompiledIC_lock); |
0 | 595 nm->cleanup_inline_caches(); |
3384
f52ed367b66d
6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify
never
parents:
2482
diff
changeset
|
596 SWEEP(nm); |
0 | 597 } |
12324
510fbd28919c
8020151: PSR:PERF Large performance regressions when code cache is filled
anoll
parents:
12266
diff
changeset
|
598 return freed_memory; |
1202 | 599 } |
600 | |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
601 // Print out some state information about the current sweep and the |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
602 // state of the code cache if it's requested. |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
603 void NMethodSweeper::log_sweep(const char* msg, const char* format, ...) { |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
604 if (PrintMethodFlushing) { |
2482
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
605 stringStream s; |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
606 // Dump code cache state into a buffer before locking the tty, |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
607 // because log_state() will use locks causing lock conflicts. |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
608 CodeCache::log_state(&s); |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
609 |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
610 ttyLocker ttyl; |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
611 tty->print("### sweeper: %s ", msg); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
612 if (format != NULL) { |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
613 va_list ap; |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
614 va_start(ap, format); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
615 tty->vprint(format, ap); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
616 va_end(ap); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
617 } |
2482
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
618 tty->print_cr(s.as_string()); |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
619 } |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
620 |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
621 if (LogCompilation && (xtty != NULL)) { |
2482
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
622 stringStream s; |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
623 // Dump code cache state into a buffer before locking the tty, |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
624 // because log_state() will use locks causing lock conflicts. |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
625 CodeCache::log_state(&s); |
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
626 |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
627 ttyLocker ttyl; |
1646 | 628 xtty->begin_elem("sweeper state='%s' traversals='" INTX_FORMAT "' ", msg, (intx)traversal_count()); |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
629 if (format != NULL) { |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
630 va_list ap; |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
631 va_start(ap, format); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
632 xtty->vprint(format, ap); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
633 va_end(ap); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
634 } |
2482
dbccacb79c63
7036236: VM crashes assert((!inside_attrs()) || is_error_reported()) failed ...
iveresov
parents:
2426
diff
changeset
|
635 xtty->print(s.as_string()); |
1644
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
636 xtty->stamp(); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
637 xtty->end_elem(); |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
638 } |
2a47bd84841f
6965184: possible races in make_not_entrant_or_zombie
never
parents:
1615
diff
changeset
|
639 } |