annotate src/share/vm/oops/symbolKlass.cpp @ 2045:9c96c873c42b

Fix includes to match new hotspot mechanism.
author Thomas Wuerthinger <wuerthinger@ssw.jku.at>
date Fri, 07 Jan 2011 18:45:09 +0100
parents f95d63e2154a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1155
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1155
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1155
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
25 #include "precompiled.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
26 #include "classfile/symbolTable.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
27 #include "memory/gcLocker.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
28 #include "oops/oop.inline.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
29 #include "oops/symbolKlass.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
30 #include "oops/symbolOop.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1706
diff changeset
31 #include "runtime/handles.inline.hpp"
0
a61af66fc99e Initial load
duke
parents:
diff changeset
32
a61af66fc99e Initial load
duke
parents:
diff changeset
33 symbolOop symbolKlass::allocate_symbol(u1* name, int len, TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
34 // Don't allow symbol oops to be created which cannot fit in a symbolOop.
a61af66fc99e Initial load
duke
parents:
diff changeset
35 if (len > symbolOopDesc::max_length()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
36 THROW_MSG_0(vmSymbols::java_lang_InternalError(),
a61af66fc99e Initial load
duke
parents:
diff changeset
37 "name is too long to represent");
a61af66fc99e Initial load
duke
parents:
diff changeset
38 }
a61af66fc99e Initial load
duke
parents:
diff changeset
39 int size = symbolOopDesc::object_size(len);
a61af66fc99e Initial load
duke
parents:
diff changeset
40 symbolKlassHandle h_k(THREAD, as_klassOop());
a61af66fc99e Initial load
duke
parents:
diff changeset
41 symbolOop sym = (symbolOop)
a61af66fc99e Initial load
duke
parents:
diff changeset
42 CollectedHeap::permanent_obj_allocate(h_k, size, CHECK_NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
43 assert(!sym->is_parsable(), "not expecting parsability yet.");
a61af66fc99e Initial load
duke
parents:
diff changeset
44 No_Safepoint_Verifier no_safepoint;
a61af66fc99e Initial load
duke
parents:
diff changeset
45 sym->set_utf8_length(len);
a61af66fc99e Initial load
duke
parents:
diff changeset
46 for (int i = 0; i < len; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
47 sym->byte_at_put(i, name[i]);
a61af66fc99e Initial load
duke
parents:
diff changeset
48 }
a61af66fc99e Initial load
duke
parents:
diff changeset
49 // Let the first emptySymbol be created and
a61af66fc99e Initial load
duke
parents:
diff changeset
50 // ensure only one is ever created.
a61af66fc99e Initial load
duke
parents:
diff changeset
51 assert(sym->is_parsable() || Universe::emptySymbol() == NULL,
a61af66fc99e Initial load
duke
parents:
diff changeset
52 "should be parsable here.");
a61af66fc99e Initial load
duke
parents:
diff changeset
53 return sym;
a61af66fc99e Initial load
duke
parents:
diff changeset
54 }
a61af66fc99e Initial load
duke
parents:
diff changeset
55
a61af66fc99e Initial load
duke
parents:
diff changeset
56 bool symbolKlass::allocate_symbols(int names_count, const char** names,
a61af66fc99e Initial load
duke
parents:
diff changeset
57 int* lengths, symbolOop* sym_oops, TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
58 if (UseConcMarkSweepGC || UseParallelGC) {
a61af66fc99e Initial load
duke
parents:
diff changeset
59 // Concurrent GC needs to mark all the allocated symbol oops after
a61af66fc99e Initial load
duke
parents:
diff changeset
60 // the remark phase which isn't done below (except the first symbol oop).
a61af66fc99e Initial load
duke
parents:
diff changeset
61 // So return false which will let the symbols be allocated one by one.
a61af66fc99e Initial load
duke
parents:
diff changeset
62 // The parallel collector uses an object start array to find the
a61af66fc99e Initial load
duke
parents:
diff changeset
63 // start of objects on a dirty card. The object start array is not
a61af66fc99e Initial load
duke
parents:
diff changeset
64 // updated for the start of each symbol so is not precise. During
a61af66fc99e Initial load
duke
parents:
diff changeset
65 // object array verification this causes a verification failure.
a61af66fc99e Initial load
duke
parents:
diff changeset
66 // In a product build this causes extra searching for the start of
a61af66fc99e Initial load
duke
parents:
diff changeset
67 // a symbol. As with the concurrent collector a return of false will
a61af66fc99e Initial load
duke
parents:
diff changeset
68 // cause each symbol to be allocated separately and in the case
a61af66fc99e Initial load
duke
parents:
diff changeset
69 // of the parallel collector will cause the object
a61af66fc99e Initial load
duke
parents:
diff changeset
70 // start array to be updated.
a61af66fc99e Initial load
duke
parents:
diff changeset
71 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
72 }
a61af66fc99e Initial load
duke
parents:
diff changeset
73
a61af66fc99e Initial load
duke
parents:
diff changeset
74 assert(names_count > 0, "can't allocate 0 symbols");
a61af66fc99e Initial load
duke
parents:
diff changeset
75
a61af66fc99e Initial load
duke
parents:
diff changeset
76 int total_size = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
77 int i, sizes[SymbolTable::symbol_alloc_batch_size];
a61af66fc99e Initial load
duke
parents:
diff changeset
78 for (i=0; i<names_count; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
79 int len = lengths[i];
a61af66fc99e Initial load
duke
parents:
diff changeset
80 if (len > symbolOopDesc::max_length()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
81 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
82 }
a61af66fc99e Initial load
duke
parents:
diff changeset
83 int sz = symbolOopDesc::object_size(len);
a61af66fc99e Initial load
duke
parents:
diff changeset
84 sizes[i] = sz * HeapWordSize;
a61af66fc99e Initial load
duke
parents:
diff changeset
85 total_size += sz;
a61af66fc99e Initial load
duke
parents:
diff changeset
86 }
a61af66fc99e Initial load
duke
parents:
diff changeset
87 symbolKlassHandle h_k(THREAD, as_klassOop());
a61af66fc99e Initial load
duke
parents:
diff changeset
88 HeapWord* base = Universe::heap()->permanent_mem_allocate(total_size);
a61af66fc99e Initial load
duke
parents:
diff changeset
89 if (base == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
90 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
91 }
a61af66fc99e Initial load
duke
parents:
diff changeset
92
a61af66fc99e Initial load
duke
parents:
diff changeset
93 // CAN'T take any safepoint during the initialization of the symbol oops !
a61af66fc99e Initial load
duke
parents:
diff changeset
94 No_Safepoint_Verifier nosafepoint;
a61af66fc99e Initial load
duke
parents:
diff changeset
95
a61af66fc99e Initial load
duke
parents:
diff changeset
96 klassOop sk = h_k();
a61af66fc99e Initial load
duke
parents:
diff changeset
97 int pos = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
98 for (i=0; i<names_count; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
99 symbolOop s = (symbolOop) (((char*)base) + pos);
a61af66fc99e Initial load
duke
parents:
diff changeset
100 s->set_mark(markOopDesc::prototype());
a61af66fc99e Initial load
duke
parents:
diff changeset
101 s->set_klass(sk);
a61af66fc99e Initial load
duke
parents:
diff changeset
102 s->set_utf8_length(lengths[i]);
a61af66fc99e Initial load
duke
parents:
diff changeset
103 const char* name = names[i];
a61af66fc99e Initial load
duke
parents:
diff changeset
104 for (int j=0; j<lengths[i]; j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
105 s->byte_at_put(j, name[j]);
a61af66fc99e Initial load
duke
parents:
diff changeset
106 }
a61af66fc99e Initial load
duke
parents:
diff changeset
107
a61af66fc99e Initial load
duke
parents:
diff changeset
108 assert(s->is_parsable(), "should be parsable here.");
a61af66fc99e Initial load
duke
parents:
diff changeset
109
a61af66fc99e Initial load
duke
parents:
diff changeset
110 sym_oops[i] = s;
a61af66fc99e Initial load
duke
parents:
diff changeset
111 pos += sizes[i];
a61af66fc99e Initial load
duke
parents:
diff changeset
112 }
a61af66fc99e Initial load
duke
parents:
diff changeset
113 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
114 }
a61af66fc99e Initial load
duke
parents:
diff changeset
115
a61af66fc99e Initial load
duke
parents:
diff changeset
116 klassOop symbolKlass::create_klass(TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
117 symbolKlass o;
a61af66fc99e Initial load
duke
parents:
diff changeset
118 KlassHandle h_this_klass(THREAD, Universe::klassKlassObj());
a61af66fc99e Initial load
duke
parents:
diff changeset
119 KlassHandle k = base_create_klass(h_this_klass, header_size(), o.vtbl_value(), CHECK_NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
120 // Make sure size calculation is right
a61af66fc99e Initial load
duke
parents:
diff changeset
121 assert(k()->size() == align_object_size(header_size()), "wrong size for object");
a61af66fc99e Initial load
duke
parents:
diff changeset
122 // java_lang_Class::create_mirror(k, CHECK_NULL); // Allocate mirror
a61af66fc99e Initial load
duke
parents:
diff changeset
123 return k();
a61af66fc99e Initial load
duke
parents:
diff changeset
124 }
a61af66fc99e Initial load
duke
parents:
diff changeset
125
a61af66fc99e Initial load
duke
parents:
diff changeset
126 int symbolKlass::oop_size(oop obj) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
127 assert(obj->is_symbol(),"must be a symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
128 symbolOop s = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
129 int size = s->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
130 return size;
a61af66fc99e Initial load
duke
parents:
diff changeset
131 }
a61af66fc99e Initial load
duke
parents:
diff changeset
132
a61af66fc99e Initial load
duke
parents:
diff changeset
133 bool symbolKlass::oop_is_parsable(oop obj) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
134 assert(obj->is_symbol(),"must be a symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
135 symbolOop s = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
136 return s->object_is_parsable();
a61af66fc99e Initial load
duke
parents:
diff changeset
137 }
a61af66fc99e Initial load
duke
parents:
diff changeset
138
a61af66fc99e Initial load
duke
parents:
diff changeset
139 void symbolKlass::oop_follow_contents(oop obj) {
a61af66fc99e Initial load
duke
parents:
diff changeset
140 assert (obj->is_symbol(), "object must be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
141 // Performance tweak: We skip iterating over the klass pointer since we
a61af66fc99e Initial load
duke
parents:
diff changeset
142 // know that Universe::symbolKlassObj never moves.
a61af66fc99e Initial load
duke
parents:
diff changeset
143 // Note: do not follow next link here (see SymbolTable::follow_contents)
a61af66fc99e Initial load
duke
parents:
diff changeset
144 }
a61af66fc99e Initial load
duke
parents:
diff changeset
145
a61af66fc99e Initial load
duke
parents:
diff changeset
146 #ifndef SERIALGC
a61af66fc99e Initial load
duke
parents:
diff changeset
147 void symbolKlass::oop_follow_contents(ParCompactionManager* cm, oop obj) {
a61af66fc99e Initial load
duke
parents:
diff changeset
148 assert (obj->is_symbol(), "object must be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
149 // Performance tweak: We skip iterating over the klass pointer since we
a61af66fc99e Initial load
duke
parents:
diff changeset
150 // know that Universe::symbolKlassObj never moves.
a61af66fc99e Initial load
duke
parents:
diff changeset
151 // Note: do not follow next link here (see SymbolTable::follow_contents)
a61af66fc99e Initial load
duke
parents:
diff changeset
152 }
a61af66fc99e Initial load
duke
parents:
diff changeset
153 #endif // SERIALGC
a61af66fc99e Initial load
duke
parents:
diff changeset
154
a61af66fc99e Initial load
duke
parents:
diff changeset
155 int symbolKlass::oop_oop_iterate(oop obj, OopClosure* blk) {
a61af66fc99e Initial load
duke
parents:
diff changeset
156 assert(obj->is_symbol(), "object must be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
157 symbolOop s = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
158 // Get size before changing pointers.
a61af66fc99e Initial load
duke
parents:
diff changeset
159 // Don't call size() or oop_size() since that is a virtual call.
a61af66fc99e Initial load
duke
parents:
diff changeset
160 int size = s->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
161 // Performance tweak: We skip iterating over the klass pointer since we
a61af66fc99e Initial load
duke
parents:
diff changeset
162 // know that Universe::symbolKlassObj never moves.
a61af66fc99e Initial load
duke
parents:
diff changeset
163 return size;
a61af66fc99e Initial load
duke
parents:
diff changeset
164 }
a61af66fc99e Initial load
duke
parents:
diff changeset
165
a61af66fc99e Initial load
duke
parents:
diff changeset
166
a61af66fc99e Initial load
duke
parents:
diff changeset
167 int symbolKlass::oop_oop_iterate_m(oop obj, OopClosure* blk, MemRegion mr) {
a61af66fc99e Initial load
duke
parents:
diff changeset
168 assert(obj->is_symbol(), "object must be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
169 symbolOop s = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
170 // Get size before changing pointers.
a61af66fc99e Initial load
duke
parents:
diff changeset
171 // Don't call size() or oop_size() since that is a virtual call.
a61af66fc99e Initial load
duke
parents:
diff changeset
172 int size = s->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
173 // Performance tweak: We skip iterating over the klass pointer since we
a61af66fc99e Initial load
duke
parents:
diff changeset
174 // know that Universe::symbolKlassObj never moves.
a61af66fc99e Initial load
duke
parents:
diff changeset
175 return size;
a61af66fc99e Initial load
duke
parents:
diff changeset
176 }
a61af66fc99e Initial load
duke
parents:
diff changeset
177
a61af66fc99e Initial load
duke
parents:
diff changeset
178
a61af66fc99e Initial load
duke
parents:
diff changeset
179 int symbolKlass::oop_adjust_pointers(oop obj) {
a61af66fc99e Initial load
duke
parents:
diff changeset
180 assert(obj->is_symbol(), "should be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
181 symbolOop s = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
182 // Get size before changing pointers.
a61af66fc99e Initial load
duke
parents:
diff changeset
183 // Don't call size() or oop_size() since that is a virtual call.
a61af66fc99e Initial load
duke
parents:
diff changeset
184 int size = s->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
185 // Performance tweak: We skip iterating over the klass pointer since we
a61af66fc99e Initial load
duke
parents:
diff changeset
186 // know that Universe::symbolKlassObj never moves.
a61af66fc99e Initial load
duke
parents:
diff changeset
187 return size;
a61af66fc99e Initial load
duke
parents:
diff changeset
188 }
a61af66fc99e Initial load
duke
parents:
diff changeset
189
a61af66fc99e Initial load
duke
parents:
diff changeset
190
a61af66fc99e Initial load
duke
parents:
diff changeset
191 #ifndef SERIALGC
a61af66fc99e Initial load
duke
parents:
diff changeset
192 void symbolKlass::oop_push_contents(PSPromotionManager* pm, oop obj) {
a61af66fc99e Initial load
duke
parents:
diff changeset
193 assert(obj->is_symbol(), "should be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
194 }
a61af66fc99e Initial load
duke
parents:
diff changeset
195
a61af66fc99e Initial load
duke
parents:
diff changeset
196 int symbolKlass::oop_update_pointers(ParCompactionManager* cm, oop obj) {
a61af66fc99e Initial load
duke
parents:
diff changeset
197 assert(obj->is_symbol(), "should be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
198 return symbolOop(obj)->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
199 }
a61af66fc99e Initial load
duke
parents:
diff changeset
200
a61af66fc99e Initial load
duke
parents:
diff changeset
201 int symbolKlass::oop_update_pointers(ParCompactionManager* cm, oop obj,
a61af66fc99e Initial load
duke
parents:
diff changeset
202 HeapWord* beg_addr, HeapWord* end_addr) {
a61af66fc99e Initial load
duke
parents:
diff changeset
203 assert(obj->is_symbol(), "should be symbol");
a61af66fc99e Initial load
duke
parents:
diff changeset
204 return symbolOop(obj)->object_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
205 }
a61af66fc99e Initial load
duke
parents:
diff changeset
206 #endif // SERIALGC
a61af66fc99e Initial load
duke
parents:
diff changeset
207
a61af66fc99e Initial load
duke
parents:
diff changeset
208 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
209 // Printing
a61af66fc99e Initial load
duke
parents:
diff changeset
210
a61af66fc99e Initial load
duke
parents:
diff changeset
211 void symbolKlass::oop_print_on(oop obj, outputStream* st) {
a61af66fc99e Initial load
duke
parents:
diff changeset
212 st->print("Symbol: '");
222
2a1a77d3458f 6718676: putback for 6604014 is incomplete
never
parents: 0
diff changeset
213 symbolOop(obj)->print_symbol_on(st);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
214 st->print("'");
a61af66fc99e Initial load
duke
parents:
diff changeset
215 }
a61af66fc99e Initial load
duke
parents:
diff changeset
216
1155
4e6abf09f540 6912062: disassembler plugin needs to produce symbolic information in product mode
jrose
parents: 222
diff changeset
217 #endif //PRODUCT
4e6abf09f540 6912062: disassembler plugin needs to produce symbolic information in product mode
jrose
parents: 222
diff changeset
218
0
a61af66fc99e Initial load
duke
parents:
diff changeset
219 void symbolKlass::oop_print_value_on(oop obj, outputStream* st) {
a61af66fc99e Initial load
duke
parents:
diff changeset
220 symbolOop sym = symbolOop(obj);
a61af66fc99e Initial load
duke
parents:
diff changeset
221 st->print("'");
a61af66fc99e Initial load
duke
parents:
diff changeset
222 for (int i = 0; i < sym->utf8_length(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
223 st->print("%c", sym->byte_at(i));
a61af66fc99e Initial load
duke
parents:
diff changeset
224 }
a61af66fc99e Initial load
duke
parents:
diff changeset
225 st->print("'");
a61af66fc99e Initial load
duke
parents:
diff changeset
226 }
a61af66fc99e Initial load
duke
parents:
diff changeset
227
a61af66fc99e Initial load
duke
parents:
diff changeset
228 const char* symbolKlass::internal_name() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
229 return "{symbol}";
a61af66fc99e Initial load
duke
parents:
diff changeset
230 }