Mercurial > hg > truffle
annotate src/share/vm/ci/ciMethodHandle.cpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 15 Apr 2013 19:54:58 +0200 |
parents | da91efe96a93 |
children |
rev | line source |
---|---|
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
1 /* |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
2 * Copyright (c) 2009, 2012, Oracle and/or its affiliates. All rights reserved. |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
4 * |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
5 * This code is free software; you can redistribute it and/or modify it |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
6 * under the terms of the GNU General Public License version 2 only, as |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
7 * published by the Free Software Foundation. |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
8 * |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
9 * This code is distributed in the hope that it will be useful, but WITHOUT |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
12 * version 2 for more details (a copy is included in the LICENSE file that |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
13 * accompanied this code). |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
14 * |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
15 * You should have received a copy of the GNU General Public License version |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
16 * 2 along with this work; if not, write to the Free Software Foundation, |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
18 * |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1138
diff
changeset
|
21 * questions. |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
22 * |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
23 */ |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
24 |
1972 | 25 #include "precompiled.hpp" |
26 #include "ci/ciClassList.hpp" | |
27 #include "ci/ciMethodHandle.hpp" | |
28 #include "ci/ciUtilities.hpp" | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
29 #include "classfile/javaClasses.hpp" |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
30 |
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
31 // ------------------------------------------------------------------ |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
32 // ciMethodHandle::get_vmtarget |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
33 // |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
34 // Return: MH.form -> LF.vmentry -> MN.vmtarget |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
35 ciMethod* ciMethodHandle::get_vmtarget() const { |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
36 VM_ENTRY_MARK; |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
37 oop form_oop = java_lang_invoke_MethodHandle::form(get_oop()); |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
4049
diff
changeset
|
38 oop vmentry_oop = java_lang_invoke_LambdaForm::vmentry(form_oop); |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
39 // FIXME: Share code with ciMemberName::get_vmtarget |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
40 Metadata* vmtarget = java_lang_invoke_MemberName::vmtarget(vmentry_oop); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
41 if (vmtarget->is_method()) |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
42 return CURRENT_ENV->get_method((Method*) vmtarget); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
43 // FIXME: What if the vmtarget is a Klass? |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
44 assert(false, ""); |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6266
diff
changeset
|
45 return NULL; |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
diff
changeset
|
46 } |