Mercurial > hg > truffle
annotate src/share/vm/interpreter/invocationCounter.cpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
| author | Bernhard Urban <bernhard.urban@jku.at> |
|---|---|
| date | Mon, 15 Apr 2013 19:54:58 +0200 |
| parents | e1e681a5558e |
| children | 836a62f43af9 |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1783 | 2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "interpreter/invocationCounter.hpp" | |
| 27 #include "runtime/frame.hpp" | |
| 28 #include "runtime/handles.inline.hpp" | |
| 0 | 29 |
| 30 | |
| 31 // Implementation of InvocationCounter | |
| 32 | |
| 33 void InvocationCounter::init() { | |
| 34 _counter = 0; // reset all the bits, including the sticky carry | |
| 35 reset(); | |
| 36 } | |
| 37 | |
| 38 void InvocationCounter::reset() { | |
| 39 // Only reset the state and don't make the method look like it's never | |
| 40 // been executed | |
| 41 set_state(wait_for_compile); | |
| 42 } | |
| 43 | |
| 44 void InvocationCounter::set_carry() { | |
| 1783 | 45 set_carry_flag(); |
| 0 | 46 // The carry bit now indicates that this counter had achieved a very |
| 47 // large value. Now reduce the value, so that the method can be | |
| 48 // executed many more times before re-entering the VM. | |
| 49 int old_count = count(); | |
|
5183
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
50 int new_count; |
|
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
51 if (CompilationPolicyChoice == 4) { |
|
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
52 new_count = 1; |
|
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
53 } else { |
|
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
54 new_count = MIN2(old_count, (int) (CompileThreshold / 2)); |
|
e1e681a5558e
fix PriorityQueue, enable PriorityQueue and CacheGraphs
Lukas Stadler <lukas.stadler@jku.at>
parents:
5163
diff
changeset
|
55 } |
|
654
c664a0794f85
6805748: Assertion "don't reset to 0 -- could be mistaken for never-executed" in CompilationPolicy
coleenp
parents:
0
diff
changeset
|
56 // prevent from going to zero, to distinguish from never-executed methods |
|
c664a0794f85
6805748: Assertion "don't reset to 0 -- could be mistaken for never-executed" in CompilationPolicy
coleenp
parents:
0
diff
changeset
|
57 if (new_count == 0) new_count = 1; |
| 0 | 58 if (old_count != new_count) set(state(), new_count); |
| 59 } | |
| 60 | |
| 61 void InvocationCounter::set_state(State state) { | |
| 62 assert(0 <= state && state < number_of_states, "illegal state"); | |
| 63 int init = _init[state]; | |
| 64 // prevent from going to zero, to distinguish from never-executed methods | |
| 65 if (init == 0 && count() > 0) init = 1; | |
| 66 int carry = (_counter & carry_mask); // the carry bit is sticky | |
| 67 _counter = (init << number_of_noncount_bits) | carry | state; | |
| 68 } | |
| 69 | |
| 70 | |
| 71 void InvocationCounter::print() { | |
| 72 tty->print_cr("invocation count: up = %d, limit = %d, carry = %s, state = %s", | |
| 73 count(), limit(), | |
| 74 carry() ? "true" : "false", | |
| 75 state_as_string(state())); | |
| 76 } | |
| 77 | |
| 78 void InvocationCounter::print_short() { | |
| 79 tty->print(" [%d%s;%s]", count(), carry()?"+carry":"", state_as_short_string(state())); | |
| 80 } | |
| 81 | |
| 82 // Initialization | |
| 83 | |
| 84 int InvocationCounter::_init [InvocationCounter::number_of_states]; | |
| 85 InvocationCounter::Action InvocationCounter::_action[InvocationCounter::number_of_states]; | |
| 86 int InvocationCounter::InterpreterInvocationLimit; | |
| 87 int InvocationCounter::InterpreterBackwardBranchLimit; | |
| 88 int InvocationCounter::InterpreterProfileLimit; | |
| 89 | |
| 90 | |
| 91 const char* InvocationCounter::state_as_string(State state) { | |
| 92 switch (state) { | |
| 93 case wait_for_nothing : return "wait_for_nothing"; | |
| 94 case wait_for_compile : return "wait_for_compile"; | |
| 95 } | |
| 96 ShouldNotReachHere(); | |
| 97 return NULL; | |
| 98 } | |
| 99 | |
| 100 const char* InvocationCounter::state_as_short_string(State state) { | |
| 101 switch (state) { | |
| 102 case wait_for_nothing : return "not comp."; | |
| 103 case wait_for_compile : return "compileable"; | |
| 104 } | |
| 105 ShouldNotReachHere(); | |
| 106 return NULL; | |
| 107 } | |
| 108 | |
| 109 | |
| 110 static address do_nothing(methodHandle method, TRAPS) { | |
| 111 // dummy action for inactive invocation counters | |
| 112 method->invocation_counter()->set_carry(); | |
| 113 method->invocation_counter()->set_state(InvocationCounter::wait_for_nothing); | |
| 114 return NULL; | |
| 115 } | |
| 116 | |
| 117 | |
| 118 static address do_decay(methodHandle method, TRAPS) { | |
| 119 // decay invocation counters so compilation gets delayed | |
| 120 method->invocation_counter()->decay(); | |
| 121 return NULL; | |
| 122 } | |
| 123 | |
| 124 | |
| 125 void InvocationCounter::def(State state, int init, Action action) { | |
| 126 assert(0 <= state && state < number_of_states, "illegal state"); | |
| 127 assert(0 <= init && init < count_limit, "initial value out of range"); | |
| 128 _init [state] = init; | |
| 129 _action[state] = action; | |
| 130 } | |
| 131 | |
| 132 address dummy_invocation_counter_overflow(methodHandle m, TRAPS) { | |
| 133 ShouldNotReachHere(); | |
| 134 return NULL; | |
| 135 } | |
| 136 | |
| 137 void InvocationCounter::reinitialize(bool delay_overflow) { | |
| 138 // define states | |
| 139 guarantee((int)number_of_states <= (int)state_limit, "adjust number_of_state_bits"); | |
| 140 def(wait_for_nothing, 0, do_nothing); | |
| 141 if (delay_overflow) { | |
| 142 def(wait_for_compile, 0, do_decay); | |
| 143 } else { | |
| 144 def(wait_for_compile, 0, dummy_invocation_counter_overflow); | |
| 145 } | |
| 146 | |
| 147 InterpreterInvocationLimit = CompileThreshold << number_of_noncount_bits; | |
| 148 InterpreterProfileLimit = ((CompileThreshold * InterpreterProfilePercentage) / 100)<< number_of_noncount_bits; | |
| 149 | |
| 150 // When methodData is collected, the backward branch limit is compared against a | |
| 151 // methodData counter, rather than an InvocationCounter. In the former case, we | |
| 152 // don't need the shift by number_of_noncount_bits, but we do need to adjust | |
| 153 // the factor by which we scale the threshold. | |
| 154 if (ProfileInterpreter) { | |
| 155 InterpreterBackwardBranchLimit = (CompileThreshold * (OnStackReplacePercentage - InterpreterProfilePercentage)) / 100; | |
| 156 } else { | |
| 157 InterpreterBackwardBranchLimit = ((CompileThreshold * OnStackReplacePercentage) / 100) << number_of_noncount_bits; | |
| 158 } | |
| 159 | |
| 160 assert(0 <= InterpreterBackwardBranchLimit, | |
| 161 "OSR threshold should be non-negative"); | |
| 162 assert(0 <= InterpreterProfileLimit && | |
| 163 InterpreterProfileLimit <= InterpreterInvocationLimit, | |
| 164 "profile threshold should be less than the compilation threshold " | |
| 165 "and non-negative"); | |
| 166 } | |
| 167 | |
| 168 void invocationCounter_init() { | |
| 169 InvocationCounter::reinitialize(DelayCompilationDuringStartup); | |
| 170 } |