Mercurial > hg > truffle
annotate src/share/vm/opto/locknode.hpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 15 Apr 2013 19:54:58 +0200 |
parents | b9a9ed0f8eeb |
children | d2907f74462e 606acabe7b5c |
rev | line source |
---|---|
0 | 1 /* |
6842
b9a9ed0f8eeb
7197424: update copyright year to match last edit in jdk8 hotspot repository
mikael
parents:
4790
diff
changeset
|
2 * Copyright (c) 1999, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
460
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
460
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
460
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #ifndef SHARE_VM_OPTO_LOCKNODE_HPP |
26 #define SHARE_VM_OPTO_LOCKNODE_HPP | |
27 | |
28 #include "opto/node.hpp" | |
29 #include "opto/opcodes.hpp" | |
30 #include "opto/subnode.hpp" | |
31 #ifdef TARGET_ARCH_MODEL_x86_32 | |
32 # include "adfiles/ad_x86_32.hpp" | |
33 #endif | |
34 #ifdef TARGET_ARCH_MODEL_x86_64 | |
35 # include "adfiles/ad_x86_64.hpp" | |
36 #endif | |
37 #ifdef TARGET_ARCH_MODEL_sparc | |
38 # include "adfiles/ad_sparc.hpp" | |
39 #endif | |
40 #ifdef TARGET_ARCH_MODEL_zero | |
41 # include "adfiles/ad_zero.hpp" | |
42 #endif | |
2192
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
43 #ifdef TARGET_ARCH_MODEL_arm |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
44 # include "adfiles/ad_arm.hpp" |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
45 #endif |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
46 #ifdef TARGET_ARCH_MODEL_ppc |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
47 # include "adfiles/ad_ppc.hpp" |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
48 #endif |
1972 | 49 |
0 | 50 //------------------------------BoxLockNode------------------------------------ |
51 class BoxLockNode : public Node { | |
4790
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
52 const int _slot; // stack slot |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
53 RegMask _inmask; // OptoReg corresponding to stack slot |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
54 bool _is_eliminated; // Associated locks were safely eliminated |
0 | 55 |
4777 | 56 public: |
0 | 57 BoxLockNode( int lock ); |
58 virtual int Opcode() const; | |
59 virtual void emit(CodeBuffer &cbuf, PhaseRegAlloc *ra_) const; | |
60 virtual uint size(PhaseRegAlloc *ra_) const; | |
61 virtual const RegMask &in_RegMask(uint) const; | |
62 virtual const RegMask &out_RegMask() const; | |
63 virtual uint size_of() const; | |
460
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
64 virtual uint hash() const; |
0 | 65 virtual uint cmp( const Node &n ) const; |
66 virtual const class Type *bottom_type() const { return TypeRawPtr::BOTTOM; } | |
67 virtual uint ideal_reg() const { return Op_RegP; } | |
68 | |
4777 | 69 static OptoReg::Name reg(Node* box_node); |
70 static BoxLockNode* box_node(Node* box_node); | |
4790
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
71 static bool same_slot(Node* box1, Node* box2) { |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
72 return box1->as_BoxLock()->_slot == box2->as_BoxLock()->_slot; |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4777
diff
changeset
|
73 } |
4777 | 74 int stack_slot() const { return _slot; } |
0 | 75 |
4777 | 76 bool is_eliminated() const { return _is_eliminated; } |
66
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
77 // mark lock as eliminated. |
4777 | 78 void set_eliminated() { _is_eliminated = true; } |
79 | |
80 // Is BoxLock node used for one simple lock region? | |
81 bool is_simple_lock_region(LockNode** unique_lock, Node* obj); | |
66
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
82 |
0 | 83 #ifndef PRODUCT |
84 virtual void format( PhaseRegAlloc *, outputStream *st ) const; | |
85 virtual void dump_spec(outputStream *st) const { st->print(" Lock %d",_slot); } | |
86 #endif | |
87 }; | |
88 | |
89 //------------------------------FastLockNode----------------------------------- | |
90 class FastLockNode: public CmpNode { | |
91 private: | |
92 BiasedLockingCounters* _counters; | |
93 | |
94 public: | |
95 FastLockNode(Node *ctrl, Node *oop, Node *box) : CmpNode(oop,box) { | |
96 init_req(0,ctrl); | |
97 init_class_id(Class_FastLock); | |
98 _counters = NULL; | |
99 } | |
100 Node* obj_node() const { return in(1); } | |
101 Node* box_node() const { return in(2); } | |
4777 | 102 void set_box_node(Node* box) { set_req(2, box); } |
0 | 103 |
104 // FastLock and FastUnlockNode do not hash, we need one for each correspoding | |
105 // LockNode/UnLockNode to avoid creating Phi's. | |
106 virtual uint hash() const ; // { return NO_HASH; } | |
107 virtual uint cmp( const Node &n ) const ; // Always fail, except on self | |
108 virtual int Opcode() const; | |
109 virtual const Type *Value( PhaseTransform *phase ) const { return TypeInt::CC; } | |
110 const Type *sub(const Type *t1, const Type *t2) const { return TypeInt::CC;} | |
111 | |
112 void create_lock_counter(JVMState* s); | |
113 BiasedLockingCounters* counters() const { return _counters; } | |
114 }; | |
115 | |
116 | |
117 //------------------------------FastUnlockNode--------------------------------- | |
118 class FastUnlockNode: public CmpNode { | |
119 public: | |
120 FastUnlockNode(Node *ctrl, Node *oop, Node *box) : CmpNode(oop,box) { | |
121 init_req(0,ctrl); | |
122 init_class_id(Class_FastUnlock); | |
123 } | |
124 Node* obj_node() const { return in(1); } | |
125 Node* box_node() const { return in(2); } | |
126 | |
127 | |
128 // FastLock and FastUnlockNode do not hash, we need one for each correspoding | |
129 // LockNode/UnLockNode to avoid creating Phi's. | |
130 virtual uint hash() const ; // { return NO_HASH; } | |
131 virtual uint cmp( const Node &n ) const ; // Always fail, except on self | |
132 virtual int Opcode() const; | |
133 virtual const Type *Value( PhaseTransform *phase ) const { return TypeInt::CC; } | |
134 const Type *sub(const Type *t1, const Type *t2) const { return TypeInt::CC;} | |
135 | |
136 }; | |
1972 | 137 |
138 #endif // SHARE_VM_OPTO_LOCKNODE_HPP |