Mercurial > hg > truffle
annotate src/share/vm/runtime/objectMonitor.inline.hpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 15 Apr 2013 19:54:58 +0200 |
parents | 22ba8c8ce6a6 |
children |
rev | line source |
---|---|
0 | 1 /* |
7629
22ba8c8ce6a6
8004902: correctness fixes motivated by contended locking work (6607129)
dcubed
parents:
1972
diff
changeset
|
2 * Copyright (c) 1998, 2013, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #ifndef SHARE_VM_RUNTIME_OBJECTMONITOR_INLINE_HPP |
26 #define SHARE_VM_RUNTIME_OBJECTMONITOR_INLINE_HPP | |
27 | |
0 | 28 inline intptr_t ObjectMonitor::is_entered(TRAPS) const { |
29 if (THREAD == _owner || THREAD->is_lock_owned((address) _owner)) { | |
30 return 1; | |
31 } | |
32 return 0; | |
33 } | |
34 | |
35 inline markOop ObjectMonitor::header() const { | |
36 return _header; | |
37 } | |
38 | |
39 inline void ObjectMonitor::set_header(markOop hdr) { | |
40 _header = hdr; | |
41 } | |
42 | |
43 inline intptr_t ObjectMonitor::count() const { | |
44 return _count; | |
45 } | |
46 | |
47 inline void ObjectMonitor::set_count(intptr_t count) { | |
48 _count= count; | |
49 } | |
50 | |
51 inline intptr_t ObjectMonitor::waiters() const { | |
52 return _waiters; | |
53 } | |
54 | |
55 inline void* ObjectMonitor::owner() const { | |
56 return _owner; | |
57 } | |
58 | |
59 inline void ObjectMonitor::clear() { | |
60 assert(_header, "Fatal logic error in ObjectMonitor header!"); | |
61 assert(_count == 0, "Fatal logic error in ObjectMonitor count!"); | |
62 assert(_waiters == 0, "Fatal logic error in ObjectMonitor waiters!"); | |
63 assert(_recursions == 0, "Fatal logic error in ObjectMonitor recursions!"); | |
64 assert(_object, "Fatal logic error in ObjectMonitor object!"); | |
65 assert(_owner == 0, "Fatal logic error in ObjectMonitor owner!"); | |
66 | |
67 _header = NULL; | |
68 _object = NULL; | |
69 } | |
70 | |
71 | |
72 inline void* ObjectMonitor::object() const { | |
73 return _object; | |
74 } | |
75 | |
76 inline void* ObjectMonitor::object_addr() { | |
77 return (void *)(&_object); | |
78 } | |
79 | |
80 inline void ObjectMonitor::set_object(void* obj) { | |
81 _object = obj; | |
82 } | |
83 | |
84 inline bool ObjectMonitor::check(TRAPS) { | |
85 if (THREAD != _owner) { | |
86 if (THREAD->is_lock_owned((address) _owner)) { | |
87 _owner = THREAD; // regain ownership of inflated monitor | |
88 OwnerIsThread = 1 ; | |
89 assert (_recursions == 0, "invariant") ; | |
90 } else { | |
91 check_slow(THREAD); | |
92 return false; | |
93 } | |
94 } | |
95 return true; | |
96 } | |
97 | |
98 | |
99 // return number of threads contending for this monitor | |
100 inline intptr_t ObjectMonitor::contentions() const { | |
101 return _count; | |
102 } | |
103 | |
7629
22ba8c8ce6a6
8004902: correctness fixes motivated by contended locking work (6607129)
dcubed
parents:
1972
diff
changeset
|
104 // Do NOT set _count = 0. There is a race such that _count could |
22ba8c8ce6a6
8004902: correctness fixes motivated by contended locking work (6607129)
dcubed
parents:
1972
diff
changeset
|
105 // be set while inflating prior to setting _owner |
22ba8c8ce6a6
8004902: correctness fixes motivated by contended locking work (6607129)
dcubed
parents:
1972
diff
changeset
|
106 // Just use Atomic::inc/dec and assert 0 when monitor put on free list |
0 | 107 inline void ObjectMonitor::set_owner(void* owner) { |
108 _owner = owner; | |
109 _recursions = 0; | |
110 } | |
111 | |
1972 | 112 |
113 #endif // SHARE_VM_RUNTIME_OBJECTMONITOR_INLINE_HPP |