Mercurial > hg > truffle
annotate src/share/vm/runtime/simpleThresholdPolicy.inline.hpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
| author | Bernhard Urban <bernhard.urban@jku.at> |
|---|---|
| date | Mon, 15 Apr 2013 19:54:58 +0200 |
| parents | da91efe96a93 |
| children | f2bdbfe9201b 600c44255e5f |
| rev | line source |
|---|---|
| 1783 | 1 /* |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
1972
diff
changeset
|
2 * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved. |
| 1783 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
| 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | |
| 20 * or visit www.oracle.com if you need additional information or have any | |
| 21 * questions. | |
| 22 * | |
| 23 */ | |
| 24 | |
| 1972 | 25 #ifndef SHARE_VM_RUNTIME_SIMPLETHRESHOLDPOLICY_INLINE_HPP |
| 26 #define SHARE_VM_RUNTIME_SIMPLETHRESHOLDPOLICY_INLINE_HPP | |
| 1783 | 27 |
| 28 template<CompLevel level> | |
| 29 bool SimpleThresholdPolicy::call_predicate_helper(int i, int b, double scale) { | |
| 30 switch(level) { | |
| 31 case CompLevel_none: | |
| 32 case CompLevel_limited_profile: | |
| 33 return (i > Tier3InvocationThreshold * scale) || | |
| 34 (i > Tier3MinInvocationThreshold * scale && i + b > Tier3CompileThreshold * scale); | |
| 35 case CompLevel_full_profile: | |
| 36 return (i > Tier4InvocationThreshold * scale) || | |
| 37 (i > Tier4MinInvocationThreshold * scale && i + b > Tier4CompileThreshold * scale); | |
| 38 } | |
| 39 return true; | |
| 40 } | |
| 41 | |
| 42 template<CompLevel level> | |
| 43 bool SimpleThresholdPolicy::loop_predicate_helper(int i, int b, double scale) { | |
| 44 switch(level) { | |
| 45 case CompLevel_none: | |
| 46 case CompLevel_limited_profile: | |
| 47 return b > Tier3BackEdgeThreshold * scale; | |
| 48 case CompLevel_full_profile: | |
| 49 return b > Tier4BackEdgeThreshold * scale; | |
| 50 } | |
| 51 return true; | |
| 52 } | |
| 53 | |
| 54 // Simple methods are as good being compiled with C1 as C2. | |
| 55 // Determine if a given method is such a case. | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
1972
diff
changeset
|
56 bool SimpleThresholdPolicy::is_trivial(Method* method) { |
| 1783 | 57 if (method->is_accessor()) return true; |
| 58 if (method->code() != NULL) { | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
1972
diff
changeset
|
59 MethodData* mdo = method->method_data(); |
| 1783 | 60 if (mdo != NULL && mdo->num_loops() == 0 && |
| 61 (method->code_size() < 5 || (mdo->num_blocks() < 4) && (method->code_size() < 15))) { | |
| 62 return !mdo->would_profile(); | |
| 63 } | |
| 64 } | |
| 65 return false; | |
| 66 } | |
| 1972 | 67 |
| 68 #endif // SHARE_VM_RUNTIME_SIMPLETHRESHOLDPOLICY_INLINE_HPP |