Mercurial > hg > truffle
annotate src/share/vm/utilities/growableArray.cpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 15 Apr 2013 19:54:58 +0200 |
parents | f34d701e952e |
children |
rev | line source |
---|---|
0 | 1 /* |
6842
b9a9ed0f8eeb
7197424: update copyright year to match last edit in jdk8 hotspot repository
mikael
parents:
6197
diff
changeset
|
2 * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
596
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "memory/resourceArea.hpp" | |
7180
f34d701e952e
8003935: Simplify the needed includes for using Thread::current()
stefank
parents:
6842
diff
changeset
|
27 #include "runtime/thread.inline.hpp" |
1972 | 28 #include "utilities/growableArray.hpp" |
7180
f34d701e952e
8003935: Simplify the needed includes for using Thread::current()
stefank
parents:
6842
diff
changeset
|
29 |
0 | 30 #ifdef ASSERT |
31 void GenericGrowableArray::set_nesting() { | |
32 if (on_stack()) { | |
33 _nesting = Thread::current()->resource_area()->nesting(); | |
34 } | |
35 } | |
36 | |
37 void GenericGrowableArray::check_nesting() { | |
38 // Check for insidious allocation bug: if a GrowableArray overflows, the | |
39 // grown array must be allocated under the same ResourceMark as the original. | |
40 // Otherwise, the _data array will be deallocated too early. | |
41 if (on_stack() && | |
42 _nesting != Thread::current()->resource_area()->nesting()) { | |
43 fatal("allocation bug: GrowableArray could grow within nested ResourceMark"); | |
44 } | |
45 } | |
46 #endif | |
47 | |
48 void* GenericGrowableArray::raw_allocate(int elementSize) { | |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
49 assert(_max >= 0, "integer overflow"); |
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
50 size_t byte_size = elementSize * (size_t) _max; |
0 | 51 if (on_stack()) { |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
52 return (void*)resource_allocate_bytes(byte_size); |
0 | 53 } else if (on_C_heap()) { |
6197 | 54 return (void*)AllocateHeap(byte_size, _memflags); |
0 | 55 } else { |
596
83ef1482304c
6806226: Signed integer overflow in growable array code causes JVM crash
jmasa
parents:
0
diff
changeset
|
56 return _arena->Amalloc(byte_size); |
0 | 57 } |
58 } |