Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/heapRegionSets.hpp @ 3766:c3f1170908be
7045330: G1: Simplify/fix the HeapRegionSeq class
7042285: G1: native memory leak during humongous object allocation
6804436: G1: heap region indices should be size_t
Summary: A series of fixes and improvements to the HeapRegionSeq class: a) replace the _regions growable array with a standard C array, b) avoid de-allocating / re-allocating HeapRegion instances when the heap shrinks / grows (fix for 7042285), c) introduce fast method to map address to HeapRegion via a "biased" array pointer, d) embed the _hrs object in G1CollectedHeap, instead of pointing to it via an indirection, e) assume that all the regions added to the HeapRegionSeq instance are contiguous, f) replace int's with size_t's for indexes (and expand that to HeapRegion as part of 6804436), g) remove unnecessary / unused methods, h) rename a couple of fields (_alloc_search_start and _seq_bottom), i) fix iterate_from() not to always start from index 0 irrespective of the region passed to it, j) add a verification method to check the HeapRegionSeq assumptions, k) always call the wrappers for _hrs.iterate(), _hrs_length(), and _hrs.at() from G1CollectedHeap, not those methods directly, and l) unify the code that expands the sequence (by either re-using or creating a new HeapRegion) and make it robust wrt to a HeapRegion allocation failing.
Reviewed-by: stefank, johnc, brutisso
author | tonyp |
---|---|
date | Fri, 10 Jun 2011 13:16:40 -0400 |
parents | ae5b2f1dcf12 |
children | e8b0b0392037 |
rev | line source |
---|---|
2152 | 1 /* |
3765
ae5b2f1dcf12
7045662: G1: OopsInHeapRegionClosure::set_region() should not be virtual
tonyp
parents:
2152
diff
changeset
|
2 * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. |
2152 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | |
20 * or visit www.oracle.com if you need additional information or have any | |
21 * questions. | |
22 * | |
23 */ | |
24 | |
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP | |
26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP | |
27 | |
28 #include "gc_implementation/g1/heapRegionSet.inline.hpp" | |
29 | |
30 //////////////////// FreeRegionList //////////////////// | |
31 | |
32 class FreeRegionList : public HeapRegionLinkedList { | |
33 protected: | |
34 virtual const char* verify_region_extra(HeapRegion* hr); | |
35 | |
36 virtual bool regions_humongous() { return false; } | |
37 virtual bool regions_empty() { return true; } | |
38 | |
39 public: | |
40 FreeRegionList(const char* name) : HeapRegionLinkedList(name) { } | |
41 }; | |
42 | |
43 //////////////////// MasterFreeRegionList //////////////////// | |
44 | |
45 class MasterFreeRegionList : public FreeRegionList { | |
46 protected: | |
47 virtual bool check_mt_safety(); | |
48 | |
49 public: | |
50 MasterFreeRegionList(const char* name) : FreeRegionList(name) { } | |
51 }; | |
52 | |
53 //////////////////// SecondaryFreeRegionList //////////////////// | |
54 | |
55 class SecondaryFreeRegionList : public FreeRegionList { | |
56 protected: | |
57 virtual bool check_mt_safety(); | |
58 | |
59 public: | |
60 SecondaryFreeRegionList(const char* name) : FreeRegionList(name) { } | |
61 }; | |
62 | |
63 //////////////////// HumongousRegionSet //////////////////// | |
64 | |
65 class HumongousRegionSet : public HeapRegionSet { | |
66 protected: | |
67 virtual const char* verify_region_extra(HeapRegion* hr); | |
68 | |
69 virtual bool regions_humongous() { return true; } | |
70 virtual bool regions_empty() { return false; } | |
71 | |
72 public: | |
73 HumongousRegionSet(const char* name) : HeapRegionSet(name) { } | |
74 }; | |
75 | |
76 //////////////////// MasterHumongousRegionSet //////////////////// | |
77 | |
78 class MasterHumongousRegionSet : public HumongousRegionSet { | |
79 protected: | |
80 virtual bool check_mt_safety(); | |
81 | |
82 public: | |
83 MasterHumongousRegionSet(const char* name) : HumongousRegionSet(name) { } | |
84 }; | |
85 | |
86 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP |