Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/heapRegion.cpp @ 4023:c6a6e936dc68
7096030: G1: PrintGCDetails enhancements
7102445: G1: Unnecessary Resource allocations during RSet scanning
Summary: Add a new per-worker thread line in the PrintGCDetails output. GC Worker Other is the difference between the elapsed time for the parallel phase of the evacuation pause and the sum of the times of the sub-phases (external root scanning, mark stack scanning, RSet updating, RSet scanning, object copying, and termination) for that worker. During RSet scanning, stack allocate DirtyCardToOopClosure objects; allocating these in a resource area was causing abnormally high GC Worker Other times while the worker thread freed ResourceArea chunks.
Reviewed-by: tonyp, jwilhelm, brutisso
author | johnc |
---|---|
date | Sun, 23 Oct 2011 23:06:06 -0700 |
parents | 65a8ff39a6da |
children | 53074c2c4600 |
rev | line source |
---|---|
342 | 1 /* |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved. |
342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1550
diff
changeset
|
21 * questions. |
342 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
27 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
28 #include "gc_implementation/g1/g1OopClosures.inline.hpp" | |
29 #include "gc_implementation/g1/heapRegion.inline.hpp" | |
30 #include "gc_implementation/g1/heapRegionRemSet.hpp" | |
31 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
32 #include "memory/genOopClosures.inline.hpp" | |
33 #include "memory/iterator.hpp" | |
34 #include "oops/oop.inline.hpp" | |
342 | 35 |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
36 int HeapRegion::LogOfHRGrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
37 int HeapRegion::LogOfHRGrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
38 size_t HeapRegion::GrainBytes = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
39 size_t HeapRegion::GrainWords = 0; |
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
40 size_t HeapRegion::CardsPerRegion = 0; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
41 |
342 | 42 HeapRegionDCTOC::HeapRegionDCTOC(G1CollectedHeap* g1, |
43 HeapRegion* hr, OopClosure* cl, | |
44 CardTableModRefBS::PrecisionStyle precision, | |
45 FilterKind fk) : | |
46 ContiguousSpaceDCTOC(hr, cl, precision, NULL), | |
47 _hr(hr), _fk(fk), _g1(g1) | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
48 { } |
342 | 49 |
50 FilterOutOfRegionClosure::FilterOutOfRegionClosure(HeapRegion* r, | |
51 OopClosure* oc) : | |
52 _r_bottom(r->bottom()), _r_end(r->end()), | |
53 _oc(oc), _out_of_region(0) | |
54 {} | |
55 | |
56 class VerifyLiveClosure: public OopClosure { | |
811 | 57 private: |
342 | 58 G1CollectedHeap* _g1h; |
59 CardTableModRefBS* _bs; | |
60 oop _containing_obj; | |
61 bool _failures; | |
62 int _n_failures; | |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
63 VerifyOption _vo; |
342 | 64 public: |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
65 // _vo == UsePrevMarking -> use "prev" marking information, |
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
66 // _vo == UseNextMarking -> use "next" marking information, |
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
67 // _vo == UseMarkWord -> use mark word from object header. |
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
68 VerifyLiveClosure(G1CollectedHeap* g1h, VerifyOption vo) : |
342 | 69 _g1h(g1h), _bs(NULL), _containing_obj(NULL), |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
70 _failures(false), _n_failures(0), _vo(vo) |
342 | 71 { |
72 BarrierSet* bs = _g1h->barrier_set(); | |
73 if (bs->is_a(BarrierSet::CardTableModRef)) | |
74 _bs = (CardTableModRefBS*)bs; | |
75 } | |
76 | |
77 void set_containing_obj(oop obj) { | |
78 _containing_obj = obj; | |
79 } | |
80 | |
81 bool failures() { return _failures; } | |
82 int n_failures() { return _n_failures; } | |
83 | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
84 virtual void do_oop(narrowOop* p) { do_oop_work(p); } |
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
85 virtual void do_oop( oop* p) { do_oop_work(p); } |
342 | 86 |
1388 | 87 void print_object(outputStream* out, oop obj) { |
88 #ifdef PRODUCT | |
89 klassOop k = obj->klass(); | |
90 const char* class_name = instanceKlass::cast(k)->external_name(); | |
91 out->print_cr("class name %s", class_name); | |
92 #else // PRODUCT | |
93 obj->print_on(out); | |
94 #endif // PRODUCT | |
95 } | |
96 | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
97 template <class T> void do_oop_work(T* p) { |
342 | 98 assert(_containing_obj != NULL, "Precondition"); |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
99 assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), |
811 | 100 "Precondition"); |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
101 T heap_oop = oopDesc::load_heap_oop(p); |
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
102 if (!oopDesc::is_null(heap_oop)) { |
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
103 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
342 | 104 bool failed = false; |
811 | 105 if (!_g1h->is_in_closed_subset(obj) || |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
106 _g1h->is_obj_dead_cond(obj, _vo)) { |
342 | 107 if (!_failures) { |
108 gclog_or_tty->print_cr(""); | |
109 gclog_or_tty->print_cr("----------"); | |
110 } | |
111 if (!_g1h->is_in_closed_subset(obj)) { | |
1388 | 112 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); |
342 | 113 gclog_or_tty->print_cr("Field "PTR_FORMAT |
1388 | 114 " of live obj "PTR_FORMAT" in region " |
115 "["PTR_FORMAT", "PTR_FORMAT")", | |
116 p, (void*) _containing_obj, | |
117 from->bottom(), from->end()); | |
118 print_object(gclog_or_tty, _containing_obj); | |
119 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" not in the heap", | |
120 (void*) obj); | |
121 } else { | |
122 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); | |
123 HeapRegion* to = _g1h->heap_region_containing((HeapWord*)obj); | |
124 gclog_or_tty->print_cr("Field "PTR_FORMAT | |
125 " of live obj "PTR_FORMAT" in region " | |
126 "["PTR_FORMAT", "PTR_FORMAT")", | |
127 p, (void*) _containing_obj, | |
128 from->bottom(), from->end()); | |
129 print_object(gclog_or_tty, _containing_obj); | |
130 gclog_or_tty->print_cr("points to dead obj "PTR_FORMAT" in region " | |
131 "["PTR_FORMAT", "PTR_FORMAT")", | |
132 (void*) obj, to->bottom(), to->end()); | |
133 print_object(gclog_or_tty, obj); | |
342 | 134 } |
135 gclog_or_tty->print_cr("----------"); | |
136 _failures = true; | |
137 failed = true; | |
138 _n_failures++; | |
139 } | |
140 | |
141 if (!_g1h->full_collection()) { | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
142 HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); |
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
143 HeapRegion* to = _g1h->heap_region_containing(obj); |
342 | 144 if (from != NULL && to != NULL && |
145 from != to && | |
146 !to->isHumongous()) { | |
147 jbyte cv_obj = *_bs->byte_for_const(_containing_obj); | |
148 jbyte cv_field = *_bs->byte_for_const(p); | |
149 const jbyte dirty = CardTableModRefBS::dirty_card_val(); | |
150 | |
151 bool is_bad = !(from->is_young() | |
152 || to->rem_set()->contains_reference(p) | |
153 || !G1HRRSFlushLogBuffersOnVerify && // buffers were not flushed | |
154 (_containing_obj->is_objArray() ? | |
155 cv_field == dirty | |
156 : cv_obj == dirty || cv_field == dirty)); | |
157 if (is_bad) { | |
158 if (!_failures) { | |
159 gclog_or_tty->print_cr(""); | |
160 gclog_or_tty->print_cr("----------"); | |
161 } | |
162 gclog_or_tty->print_cr("Missing rem set entry:"); | |
3766 | 163 gclog_or_tty->print_cr("Field "PTR_FORMAT" " |
164 "of obj "PTR_FORMAT", " | |
165 "in region "HR_FORMAT, | |
166 p, (void*) _containing_obj, | |
167 HR_FORMAT_PARAMS(from)); | |
342 | 168 _containing_obj->print_on(gclog_or_tty); |
3766 | 169 gclog_or_tty->print_cr("points to obj "PTR_FORMAT" " |
170 "in region "HR_FORMAT, | |
171 (void*) obj, | |
172 HR_FORMAT_PARAMS(to)); | |
342 | 173 obj->print_on(gclog_or_tty); |
174 gclog_or_tty->print_cr("Obj head CTE = %d, field CTE = %d.", | |
175 cv_obj, cv_field); | |
176 gclog_or_tty->print_cr("----------"); | |
177 _failures = true; | |
178 if (!failed) _n_failures++; | |
179 } | |
180 } | |
181 } | |
182 } | |
183 } | |
184 }; | |
185 | |
186 template<class ClosureType> | |
187 HeapWord* walk_mem_region_loop(ClosureType* cl, G1CollectedHeap* g1h, | |
188 HeapRegion* hr, | |
189 HeapWord* cur, HeapWord* top) { | |
190 oop cur_oop = oop(cur); | |
191 int oop_size = cur_oop->size(); | |
192 HeapWord* next_obj = cur + oop_size; | |
193 while (next_obj < top) { | |
194 // Keep filtering the remembered set. | |
195 if (!g1h->is_obj_dead(cur_oop, hr)) { | |
196 // Bottom lies entirely below top, so we can call the | |
197 // non-memRegion version of oop_iterate below. | |
198 cur_oop->oop_iterate(cl); | |
199 } | |
200 cur = next_obj; | |
201 cur_oop = oop(cur); | |
202 oop_size = cur_oop->size(); | |
203 next_obj = cur + oop_size; | |
204 } | |
205 return cur; | |
206 } | |
207 | |
208 void HeapRegionDCTOC::walk_mem_region_with_cl(MemRegion mr, | |
209 HeapWord* bottom, | |
210 HeapWord* top, | |
211 OopClosure* cl) { | |
212 G1CollectedHeap* g1h = _g1; | |
213 int oop_size; | |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
214 OopClosure* cl2 = NULL; |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
215 |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
216 FilterIntoCSClosure intoCSFilt(this, g1h, cl); |
342 | 217 FilterOutOfRegionClosure outOfRegionFilt(_hr, cl); |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
218 |
342 | 219 switch (_fk) { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
220 case NoFilterKind: cl2 = cl; break; |
342 | 221 case IntoCSFilterKind: cl2 = &intoCSFilt; break; |
222 case OutOfRegionFilterKind: cl2 = &outOfRegionFilt; break; | |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
223 default: ShouldNotReachHere(); |
342 | 224 } |
225 | |
226 // Start filtering what we add to the remembered set. If the object is | |
227 // not considered dead, either because it is marked (in the mark bitmap) | |
228 // or it was allocated after marking finished, then we add it. Otherwise | |
229 // we can safely ignore the object. | |
230 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
231 oop_size = oop(bottom)->oop_iterate(cl2, mr); | |
232 } else { | |
233 oop_size = oop(bottom)->size(); | |
234 } | |
235 | |
236 bottom += oop_size; | |
237 | |
238 if (bottom < top) { | |
239 // We replicate the loop below for several kinds of possible filters. | |
240 switch (_fk) { | |
241 case NoFilterKind: | |
242 bottom = walk_mem_region_loop(cl, g1h, _hr, bottom, top); | |
243 break; | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
244 |
342 | 245 case IntoCSFilterKind: { |
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
246 FilterIntoCSClosure filt(this, g1h, cl); |
342 | 247 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); |
248 break; | |
249 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
250 |
342 | 251 case OutOfRegionFilterKind: { |
252 FilterOutOfRegionClosure filt(_hr, cl); | |
253 bottom = walk_mem_region_loop(&filt, g1h, _hr, bottom, top); | |
254 break; | |
255 } | |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
256 |
342 | 257 default: |
258 ShouldNotReachHere(); | |
259 } | |
260 | |
261 // Last object. Need to do dead-obj filtering here too. | |
262 if (!g1h->is_obj_dead(oop(bottom), _hr)) { | |
263 oop(bottom)->oop_iterate(cl2, mr); | |
264 } | |
265 } | |
266 } | |
267 | |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
268 // Minimum region size; we won't go lower than that. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
269 // We might want to decrease this in the future, to deal with small |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
270 // heaps a bit more efficiently. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
271 #define MIN_REGION_SIZE ( 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
272 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
273 // Maximum region size; we don't go higher than that. There's a good |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
274 // reason for having an upper bound. We don't want regions to get too |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
275 // large, otherwise cleanup's effectiveness would decrease as there |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
276 // will be fewer opportunities to find totally empty regions after |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
277 // marking. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
278 #define MAX_REGION_SIZE ( 32 * 1024 * 1024 ) |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
279 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
280 // The automatic region size calculation will try to have around this |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
281 // many regions in the heap (based on the min heap size). |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
282 #define TARGET_REGION_NUMBER 2048 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
283 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
284 void HeapRegion::setup_heap_region_size(uintx min_heap_size) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
285 // region_size in bytes |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
286 uintx region_size = G1HeapRegionSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
287 if (FLAG_IS_DEFAULT(G1HeapRegionSize)) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
288 // We base the automatic calculation on the min heap size. This |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
289 // can be problematic if the spread between min and max is quite |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
290 // wide, imagine -Xms128m -Xmx32g. But, if we decided it based on |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
291 // the max size, the region size might be way too large for the |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
292 // min size. Either way, some users might have to set the region |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
293 // size manually for some -Xms / -Xmx combos. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
294 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
295 region_size = MAX2(min_heap_size / TARGET_REGION_NUMBER, |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
296 (uintx) MIN_REGION_SIZE); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
297 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
298 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
299 int region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
300 // Recalculate the region size to make sure it's a power of |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
301 // 2. This means that region_size is the largest power of 2 that's |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
302 // <= what we've calculated so far. |
1485
fb57d4cf76c2
6931180: Migration to recent versions of MS Platform SDK
prr
parents:
1394
diff
changeset
|
303 region_size = ((uintx)1 << region_size_log); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
304 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
305 // Now make sure that we don't go over or under our limits. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
306 if (region_size < MIN_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
307 region_size = MIN_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
308 } else if (region_size > MAX_REGION_SIZE) { |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
309 region_size = MAX_REGION_SIZE; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
310 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
311 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
312 // And recalculate the log. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
313 region_size_log = log2_long((jlong) region_size); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
314 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
315 // Now, set up the globals. |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
316 guarantee(LogOfHRGrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
317 LogOfHRGrainBytes = region_size_log; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
318 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
319 guarantee(LogOfHRGrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
320 LogOfHRGrainWords = LogOfHRGrainBytes - LogHeapWordSize; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
321 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
322 guarantee(GrainBytes == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
323 // The cast to int is safe, given that we've bounded region_size by |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
324 // MIN_REGION_SIZE and MAX_REGION_SIZE. |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
325 GrainBytes = (size_t)region_size; |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
326 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
327 guarantee(GrainWords == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
328 GrainWords = GrainBytes >> LogHeapWordSize; |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
329 guarantee((size_t)(1 << LogOfHRGrainWords) == GrainWords, "sanity"); |
942
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
330 |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
331 guarantee(CardsPerRegion == 0, "we should only set it once"); |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
332 CardsPerRegion = GrainBytes >> CardTableModRefBS::card_shift; |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
333 } |
2c79770d1f6e
6819085: G1: use larger and/or user settable region size
tonyp
parents:
866
diff
changeset
|
334 |
342 | 335 void HeapRegion::reset_after_compaction() { |
336 G1OffsetTableContigSpace::reset_after_compaction(); | |
337 // After a compaction the mark bitmap is invalid, so we must | |
338 // treat all objects as being inside the unmarked area. | |
339 zero_marked_bytes(); | |
340 init_top_at_mark_start(); | |
341 } | |
342 | |
343 void HeapRegion::hr_clear(bool par, bool clear_space) { | |
2152 | 344 assert(_humongous_type == NotHumongous, |
345 "we should have already filtered out humongous regions"); | |
346 assert(_humongous_start_region == NULL, | |
347 "we should have already filtered out humongous regions"); | |
348 assert(_end == _orig_end, | |
349 "we should have already filtered out humongous regions"); | |
350 | |
342 | 351 _in_collection_set = false; |
352 | |
353 set_young_index_in_cset(-1); | |
354 uninstall_surv_rate_group(); | |
355 set_young_type(NotYoung); | |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
356 reset_pre_dummy_top(); |
342 | 357 |
358 if (!par) { | |
359 // If this is parallel, this will be done later. | |
360 HeapRegionRemSet* hrrs = rem_set(); | |
361 if (hrrs != NULL) hrrs->clear(); | |
355 | 362 _claimed = InitialClaimValue; |
342 | 363 } |
364 zero_marked_bytes(); | |
365 set_sort_index(-1); | |
366 | |
367 _offsets.resize(HeapRegion::GrainWords); | |
368 init_top_at_mark_start(); | |
356 | 369 if (clear_space) clear(SpaceDecorator::Mangle); |
342 | 370 } |
371 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
372 void HeapRegion::par_clear() { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
373 assert(used() == 0, "the region should have been already cleared"); |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
374 assert(capacity() == HeapRegion::GrainBytes, "should be back to normal"); |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
375 HeapRegionRemSet* hrrs = rem_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
376 hrrs->clear(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
377 CardTableModRefBS* ct_bs = |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
378 (CardTableModRefBS*)G1CollectedHeap::heap()->barrier_set(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
379 ct_bs->clear(MemRegion(bottom(), end())); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
380 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
381 |
342 | 382 // <PREDICTION> |
383 void HeapRegion::calc_gc_efficiency() { | |
384 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
385 _gc_efficiency = (double) garbage_bytes() / | |
386 g1h->predict_region_elapsed_time_ms(this, false); | |
387 } | |
388 // </PREDICTION> | |
389 | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
390 void HeapRegion::set_startsHumongous(HeapWord* new_top, HeapWord* new_end) { |
2152 | 391 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
392 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
393 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
394 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
395 assert(bottom() <= new_top && new_top <= new_end, "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
396 |
355 | 397 _humongous_type = StartsHumongous; |
342 | 398 _humongous_start_region = this; |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
399 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
400 set_end(new_end); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
401 _offsets.set_for_starts_humongous(new_top); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
402 } |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
403 |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
404 void HeapRegion::set_continuesHumongous(HeapRegion* first_hr) { |
2152 | 405 assert(!isHumongous(), "sanity / pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
406 assert(end() == _orig_end, |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
407 "Should be normal before the humongous object allocation"); |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
408 assert(top() == bottom(), "should be empty"); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
409 assert(first_hr->startsHumongous(), "pre-condition"); |
1886
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
410 |
72a161e62cc4
6991377: G1: race between concurrent refinement and humongous object allocation
tonyp
parents:
1718
diff
changeset
|
411 _humongous_type = ContinuesHumongous; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
412 _humongous_start_region = first_hr; |
342 | 413 } |
414 | |
2152 | 415 void HeapRegion::set_notHumongous() { |
416 assert(isHumongous(), "pre-condition"); | |
417 | |
418 if (startsHumongous()) { | |
419 assert(top() <= end(), "pre-condition"); | |
420 set_end(_orig_end); | |
421 if (top() > end()) { | |
422 // at least one "continues humongous" region after it | |
423 set_top(end()); | |
424 } | |
425 } else { | |
426 // continues humongous | |
427 assert(end() == _orig_end, "sanity"); | |
428 } | |
429 | |
3986
65a8ff39a6da
7095194: G1: HeapRegion::GrainBytes, GrainWords, and CardsPerRegion should be size_t
johnc
parents:
3983
diff
changeset
|
430 assert(capacity() == HeapRegion::GrainBytes, "pre-condition"); |
2152 | 431 _humongous_type = NotHumongous; |
432 _humongous_start_region = NULL; | |
433 } | |
434 | |
342 | 435 bool HeapRegion::claimHeapRegion(jint claimValue) { |
436 jint current = _claimed; | |
437 if (current != claimValue) { | |
438 jint res = Atomic::cmpxchg(claimValue, &_claimed, current); | |
439 if (res == current) { | |
440 return true; | |
441 } | |
442 } | |
443 return false; | |
444 } | |
445 | |
446 HeapWord* HeapRegion::next_block_start_careful(HeapWord* addr) { | |
447 HeapWord* low = addr; | |
448 HeapWord* high = end(); | |
449 while (low < high) { | |
450 size_t diff = pointer_delta(high, low); | |
451 // Must add one below to bias toward the high amount. Otherwise, if | |
452 // "high" were at the desired value, and "low" were one less, we | |
453 // would not converge on "high". This is not symmetric, because | |
454 // we set "high" to a block start, which might be the right one, | |
455 // which we don't do for "low". | |
456 HeapWord* middle = low + (diff+1)/2; | |
457 if (middle == high) return high; | |
458 HeapWord* mid_bs = block_start_careful(middle); | |
459 if (mid_bs < addr) { | |
460 low = middle; | |
461 } else { | |
462 high = mid_bs; | |
463 } | |
464 } | |
465 assert(low == high && low >= addr, "Didn't work."); | |
466 return low; | |
467 } | |
468 | |
356 | 469 void HeapRegion::initialize(MemRegion mr, bool clear_space, bool mangle_space) { |
470 G1OffsetTableContigSpace::initialize(mr, false, mangle_space); | |
342 | 471 hr_clear(false/*par*/, clear_space); |
472 } | |
473 #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away | |
474 #pragma warning( disable:4355 ) // 'this' : used in base member initializer list | |
475 #endif // _MSC_VER | |
476 | |
477 | |
478 HeapRegion:: | |
3766 | 479 HeapRegion(size_t hrs_index, G1BlockOffsetSharedArray* sharedOffsetArray, |
480 MemRegion mr, bool is_zeroed) | |
342 | 481 : G1OffsetTableContigSpace(sharedOffsetArray, mr, is_zeroed), |
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3978
diff
changeset
|
482 _hrs_index(hrs_index), |
355 | 483 _humongous_type(NotHumongous), _humongous_start_region(NULL), |
3830
f44782f04dd4
7039627: G1: avoid BOT updates for survivor allocations and dirty survivor regions incrementally
tonyp
parents:
3772
diff
changeset
|
484 _in_collection_set(false), |
342 | 485 _next_in_special_set(NULL), _orig_end(NULL), |
355 | 486 _claimed(InitialClaimValue), _evacuation_failed(false), |
342 | 487 _prev_marked_bytes(0), _next_marked_bytes(0), _sort_index(-1), |
3978
f0ecbe78fc7b
7092238: G1: Uninitialized field gc_efficiency in G1PrintRegionLivenessInfo output
tonyp
parents:
3830
diff
changeset
|
488 _gc_efficiency(0.0), |
342 | 489 _young_type(NotYoung), _next_young_region(NULL), |
2152 | 490 _next_dirty_cards_region(NULL), _next(NULL), _pending_removal(false), |
491 #ifdef ASSERT | |
492 _containing_set(NULL), | |
493 #endif // ASSERT | |
494 _young_index_in_cset(-1), _surv_rate_group(NULL), _age_index(-1), | |
495 _rem_set(NULL), _recorded_rs_length(0), _predicted_elapsed_time_ms(0), | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
496 _predicted_bytes_to_copy(0) |
342 | 497 { |
498 _orig_end = mr.end(); | |
499 // Note that initialize() will set the start of the unmarked area of the | |
500 // region. | |
356 | 501 this->initialize(mr, !is_zeroed, SpaceDecorator::Mangle); |
502 set_top(bottom()); | |
503 set_saved_mark(); | |
342 | 504 |
505 _rem_set = new HeapRegionRemSet(sharedOffsetArray, this); | |
506 | |
507 assert(HeapRegionRemSet::num_par_rem_sets() > 0, "Invariant."); | |
508 // In case the region is allocated during a pause, note the top. | |
509 // We haven't done any counting on a brand new region. | |
510 _top_at_conc_mark_count = bottom(); | |
511 } | |
512 | |
513 class NextCompactionHeapRegionClosure: public HeapRegionClosure { | |
514 const HeapRegion* _target; | |
515 bool _target_seen; | |
516 HeapRegion* _last; | |
517 CompactibleSpace* _res; | |
518 public: | |
519 NextCompactionHeapRegionClosure(const HeapRegion* target) : | |
520 _target(target), _target_seen(false), _res(NULL) {} | |
521 bool doHeapRegion(HeapRegion* cur) { | |
522 if (_target_seen) { | |
523 if (!cur->isHumongous()) { | |
524 _res = cur; | |
525 return true; | |
526 } | |
527 } else if (cur == _target) { | |
528 _target_seen = true; | |
529 } | |
530 return false; | |
531 } | |
532 CompactibleSpace* result() { return _res; } | |
533 }; | |
534 | |
535 CompactibleSpace* HeapRegion::next_compaction_space() const { | |
536 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
537 // cast away const-ness | |
538 HeapRegion* r = (HeapRegion*) this; | |
539 NextCompactionHeapRegionClosure blk(r); | |
540 g1h->heap_region_iterate_from(r, &blk); | |
541 return blk.result(); | |
542 } | |
543 | |
544 void HeapRegion::save_marks() { | |
545 set_saved_mark(); | |
546 } | |
547 | |
548 void HeapRegion::oops_in_mr_iterate(MemRegion mr, OopClosure* cl) { | |
549 HeapWord* p = mr.start(); | |
550 HeapWord* e = mr.end(); | |
551 oop obj; | |
552 while (p < e) { | |
553 obj = oop(p); | |
554 p += obj->oop_iterate(cl); | |
555 } | |
556 assert(p == e, "bad memregion: doesn't end on obj boundary"); | |
557 } | |
558 | |
559 #define HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN(OopClosureType, nv_suffix) \ | |
560 void HeapRegion::oop_since_save_marks_iterate##nv_suffix(OopClosureType* cl) { \ | |
561 ContiguousSpace::oop_since_save_marks_iterate##nv_suffix(cl); \ | |
562 } | |
563 SPECIALIZED_SINCE_SAVE_MARKS_CLOSURES(HeapRegion_OOP_SINCE_SAVE_MARKS_DEFN) | |
564 | |
565 | |
566 void HeapRegion::oop_before_save_marks_iterate(OopClosure* cl) { | |
567 oops_in_mr_iterate(MemRegion(bottom(), saved_mark_word()), cl); | |
568 } | |
569 | |
570 HeapWord* | |
571 HeapRegion::object_iterate_mem_careful(MemRegion mr, | |
572 ObjectClosure* cl) { | |
573 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
574 // We used to use "block_start_careful" here. But we're actually happy | |
575 // to update the BOT while we do this... | |
576 HeapWord* cur = block_start(mr.start()); | |
577 mr = mr.intersection(used_region()); | |
578 if (mr.is_empty()) return NULL; | |
579 // Otherwise, find the obj that extends onto mr.start(). | |
580 | |
581 assert(cur <= mr.start() | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
582 && (oop(cur)->klass_or_null() == NULL || |
342 | 583 cur + oop(cur)->size() > mr.start()), |
584 "postcondition of block_start"); | |
585 oop obj; | |
586 while (cur < mr.end()) { | |
587 obj = oop(cur); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
588 if (obj->klass_or_null() == NULL) { |
342 | 589 // Ran into an unparseable point. |
590 return cur; | |
591 } else if (!g1h->is_obj_dead(obj)) { | |
592 cl->do_object(obj); | |
593 } | |
594 if (cl->abort()) return cur; | |
595 // The check above must occur before the operation below, since an | |
596 // abort might invalidate the "size" operation. | |
597 cur += obj->size(); | |
598 } | |
599 return NULL; | |
600 } | |
601 | |
602 HeapWord* | |
603 HeapRegion:: | |
604 oops_on_card_seq_iterate_careful(MemRegion mr, | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
605 FilterOutOfRegionClosure* cl, |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
606 bool filter_young, |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
607 jbyte* card_ptr) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
608 // Currently, we should only have to clean the card if filter_young |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
609 // is true and vice versa. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
610 if (filter_young) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
611 assert(card_ptr != NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
612 } else { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
613 assert(card_ptr == NULL, "pre-condition"); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
614 } |
342 | 615 G1CollectedHeap* g1h = G1CollectedHeap::heap(); |
616 | |
617 // If we're within a stop-world GC, then we might look at a card in a | |
618 // GC alloc region that extends onto a GC LAB, which may not be | |
619 // parseable. Stop such at the "saved_mark" of the region. | |
620 if (G1CollectedHeap::heap()->is_gc_active()) { | |
621 mr = mr.intersection(used_region_at_save_marks()); | |
622 } else { | |
623 mr = mr.intersection(used_region()); | |
624 } | |
625 if (mr.is_empty()) return NULL; | |
626 // Otherwise, find the obj that extends onto mr.start(). | |
627 | |
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
628 // The intersection of the incoming mr (for the card) and the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
629 // allocated part of the region is non-empty. This implies that |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
630 // we have actually allocated into this region. The code in |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
631 // G1CollectedHeap.cpp that allocates a new region sets the |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
632 // is_young tag on the region before allocating. Thus we |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
633 // safely know if this region is young. |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
634 if (is_young() && filter_young) { |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
635 return NULL; |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
636 } |
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1552
diff
changeset
|
637 |
1705 | 638 assert(!is_young(), "check value of filter_young"); |
639 | |
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
640 // We can only clean the card here, after we make the decision that |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
641 // the card is not young. And we only clean the card if we have been |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
642 // asked to (i.e., card_ptr != NULL). |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
643 if (card_ptr != NULL) { |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
644 *card_ptr = CardTableModRefBS::clean_card_val(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
645 // We must complete this write before we do any of the reads below. |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
646 OrderAccess::storeload(); |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
647 } |
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2433
diff
changeset
|
648 |
342 | 649 // We used to use "block_start_careful" here. But we're actually happy |
650 // to update the BOT while we do this... | |
651 HeapWord* cur = block_start(mr.start()); | |
652 assert(cur <= mr.start(), "Postcondition"); | |
653 | |
654 while (cur <= mr.start()) { | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
655 if (oop(cur)->klass_or_null() == NULL) { |
342 | 656 // Ran into an unparseable point. |
657 return cur; | |
658 } | |
659 // Otherwise... | |
660 int sz = oop(cur)->size(); | |
661 if (cur + sz > mr.start()) break; | |
662 // Otherwise, go on. | |
663 cur = cur + sz; | |
664 } | |
665 oop obj; | |
666 obj = oop(cur); | |
667 // If we finish this loop... | |
668 assert(cur <= mr.start() | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
669 && obj->klass_or_null() != NULL |
342 | 670 && cur + obj->size() > mr.start(), |
671 "Loop postcondition"); | |
672 if (!g1h->is_obj_dead(obj)) { | |
673 obj->oop_iterate(cl, mr); | |
674 } | |
675 | |
676 HeapWord* next; | |
677 while (cur < mr.end()) { | |
678 obj = oop(cur); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
679 if (obj->klass_or_null() == NULL) { |
342 | 680 // Ran into an unparseable point. |
681 return cur; | |
682 }; | |
683 // Otherwise: | |
684 next = (cur + obj->size()); | |
685 if (!g1h->is_obj_dead(obj)) { | |
686 if (next < mr.end()) { | |
687 obj->oop_iterate(cl); | |
688 } else { | |
689 // this obj spans the boundary. If it's an array, stop at the | |
690 // boundary. | |
691 if (obj->is_objArray()) { | |
692 obj->oop_iterate(cl, mr); | |
693 } else { | |
694 obj->oop_iterate(cl); | |
695 } | |
696 } | |
697 } | |
698 cur = next; | |
699 } | |
700 return NULL; | |
701 } | |
702 | |
703 void HeapRegion::print() const { print_on(gclog_or_tty); } | |
704 void HeapRegion::print_on(outputStream* st) const { | |
705 if (isHumongous()) { | |
706 if (startsHumongous()) | |
707 st->print(" HS"); | |
708 else | |
709 st->print(" HC"); | |
710 } else { | |
711 st->print(" "); | |
712 } | |
713 if (in_collection_set()) | |
714 st->print(" CS"); | |
715 else | |
716 st->print(" "); | |
717 if (is_young()) | |
1394
1316cec51b4d
6819061: G1: eliminate serial Other times that are proportional to the collection set length
johnc
parents:
1388
diff
changeset
|
718 st->print(is_survivor() ? " SU" : " Y "); |
342 | 719 else |
720 st->print(" "); | |
721 if (is_empty()) | |
722 st->print(" F"); | |
723 else | |
724 st->print(" "); | |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
725 st->print(" %5d", _gc_time_stamp); |
1388 | 726 st->print(" PTAMS "PTR_FORMAT" NTAMS "PTR_FORMAT, |
727 prev_top_at_mark_start(), next_top_at_mark_start()); | |
342 | 728 G1OffsetTableContigSpace::print_on(st); |
729 } | |
730 | |
811 | 731 void HeapRegion::verify(bool allow_dirty) const { |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
732 bool dummy = false; |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
733 verify(allow_dirty, VerifyOption_G1UsePrevMarking, /* failures */ &dummy); |
811 | 734 } |
735 | |
342 | 736 // This really ought to be commoned up into OffsetTableContigSpace somehow. |
737 // We would need a mechanism to make that code skip dead objects. | |
738 | |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
739 void HeapRegion::verify(bool allow_dirty, |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
740 VerifyOption vo, |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
741 bool* failures) const { |
342 | 742 G1CollectedHeap* g1 = G1CollectedHeap::heap(); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
743 *failures = false; |
342 | 744 HeapWord* p = bottom(); |
745 HeapWord* prev_p = NULL; | |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
746 VerifyLiveClosure vl_cl(g1, vo); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
747 bool is_humongous = isHumongous(); |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
748 bool do_bot_verify = !is_young(); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
749 size_t object_num = 0; |
342 | 750 while (p < top()) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
751 oop obj = oop(p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
752 size_t obj_size = obj->size(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
753 object_num += 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
754 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
755 if (is_humongous != g1->isHumongous(obj_size)) { |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
756 gclog_or_tty->print_cr("obj "PTR_FORMAT" is of %shumongous size (" |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
757 SIZE_FORMAT" words) in a %shumongous region", |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
758 p, g1->isHumongous(obj_size) ? "" : "non-", |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
759 obj_size, is_humongous ? "" : "non-"); |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
760 *failures = true; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
761 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
762 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
763 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
764 // If it returns false, verify_for_object() will output the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
765 // appropriate messasge. |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
766 if (do_bot_verify && !_offsets.verify_for_object(p, obj_size)) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
767 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
768 return; |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
769 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
770 |
3772
6747fd0512e0
7004681: G1: Extend marking verification to Full GCs
johnc
parents:
3766
diff
changeset
|
771 if (!g1->is_obj_dead_cond(obj, this, vo)) { |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
772 if (obj->is_oop()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
773 klassOop klass = obj->klass(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
774 if (!klass->is_perm()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
775 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
776 "not in perm", klass, obj); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
777 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
778 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
779 } else if (!klass->is_klass()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
780 gclog_or_tty->print_cr("klass "PTR_FORMAT" of object "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
781 "not a klass", klass, obj); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
782 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
783 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
784 } else { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
785 vl_cl.set_containing_obj(obj); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
786 obj->oop_iterate(&vl_cl); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
787 if (vl_cl.failures()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
788 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
789 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
790 if (G1MaxVerifyFailures >= 0 && |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
791 vl_cl.n_failures() >= G1MaxVerifyFailures) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
792 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
793 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
794 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
795 } else { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
796 gclog_or_tty->print_cr(PTR_FORMAT" no an oop", obj); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
797 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
798 return; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
799 } |
342 | 800 } |
801 prev_p = p; | |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
802 p += obj_size; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
803 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
804 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
805 if (p != top()) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
806 gclog_or_tty->print_cr("end of last object "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
807 "does not match top "PTR_FORMAT, p, top()); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
808 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
809 return; |
342 | 810 } |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
811 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
812 HeapWord* the_end = end(); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
813 assert(p == top(), "it should still hold"); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
814 // Do some extra BOT consistency checking for addresses in the |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
815 // range [top, end). BOT look-ups in this range should yield |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
816 // top. No point in doing that if top == end (there's nothing there). |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
817 if (p < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
818 // Look up top |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
819 HeapWord* addr_1 = p; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
820 HeapWord* b_start_1 = _offsets.block_start_const(addr_1); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
821 if (b_start_1 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
822 gclog_or_tty->print_cr("BOT look up for top: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
823 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
824 addr_1, b_start_1, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
825 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
826 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
827 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
828 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
829 // Look up top + 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
830 HeapWord* addr_2 = p + 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
831 if (addr_2 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
832 HeapWord* b_start_2 = _offsets.block_start_const(addr_2); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
833 if (b_start_2 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
834 gclog_or_tty->print_cr("BOT look up for top + 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
835 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
836 addr_2, b_start_2, p); |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
837 *failures = true; |
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
838 return; |
2133
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
839 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
840 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
841 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
842 // Look up an address between top and end |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
843 size_t diff = pointer_delta(the_end, p) / 2; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
844 HeapWord* addr_3 = p + diff; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
845 if (addr_3 < the_end) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
846 HeapWord* b_start_3 = _offsets.block_start_const(addr_3); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
847 if (b_start_3 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
848 gclog_or_tty->print_cr("BOT look up for top + diff: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
849 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
850 addr_3, b_start_3, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
851 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
852 return; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
853 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
854 } |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
855 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
856 // Loook up end - 1 |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
857 HeapWord* addr_4 = the_end - 1; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
858 HeapWord* b_start_4 = _offsets.block_start_const(addr_4); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
859 if (b_start_4 != p) { |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
860 gclog_or_tty->print_cr("BOT look up for end - 1: "PTR_FORMAT" " |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
861 " yielded "PTR_FORMAT", expecting "PTR_FORMAT, |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
862 addr_4, b_start_4, p); |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
863 *failures = true; |
2250ee17e258
7007068: G1: refine the BOT during evac failure handling
tonyp
parents:
1972
diff
changeset
|
864 return; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
865 } |
342 | 866 } |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
867 |
1718
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
868 if (is_humongous && object_num > 1) { |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
869 gclog_or_tty->print_cr("region ["PTR_FORMAT","PTR_FORMAT"] is humongous " |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
870 "but has "SIZE_FORMAT", objects", |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
871 bottom(), end(), object_num); |
bb847e31b836
6974928: G1: sometimes humongous objects are allocated in young regions
tonyp
parents:
1705
diff
changeset
|
872 *failures = true; |
1020
ff2402f6a50b
6882730: G1: parallel heap verification messes up region dump
tonyp
parents:
942
diff
changeset
|
873 return; |
342 | 874 } |
875 } | |
876 | |
877 // G1OffsetTableContigSpace code; copied from space.cpp. Hope this can go | |
878 // away eventually. | |
879 | |
356 | 880 void G1OffsetTableContigSpace::initialize(MemRegion mr, bool clear_space, bool mangle_space) { |
342 | 881 // false ==> we'll do the clearing if there's clearing to be done. |
356 | 882 ContiguousSpace::initialize(mr, false, mangle_space); |
342 | 883 _offsets.zero_bottom_entry(); |
884 _offsets.initialize_threshold(); | |
356 | 885 if (clear_space) clear(mangle_space); |
342 | 886 } |
887 | |
356 | 888 void G1OffsetTableContigSpace::clear(bool mangle_space) { |
889 ContiguousSpace::clear(mangle_space); | |
342 | 890 _offsets.zero_bottom_entry(); |
891 _offsets.initialize_threshold(); | |
892 } | |
893 | |
894 void G1OffsetTableContigSpace::set_bottom(HeapWord* new_bottom) { | |
895 Space::set_bottom(new_bottom); | |
896 _offsets.set_bottom(new_bottom); | |
897 } | |
898 | |
899 void G1OffsetTableContigSpace::set_end(HeapWord* new_end) { | |
900 Space::set_end(new_end); | |
901 _offsets.resize(new_end - bottom()); | |
902 } | |
903 | |
904 void G1OffsetTableContigSpace::print() const { | |
905 print_short(); | |
906 gclog_or_tty->print_cr(" [" INTPTR_FORMAT ", " INTPTR_FORMAT ", " | |
907 INTPTR_FORMAT ", " INTPTR_FORMAT ")", | |
908 bottom(), top(), _offsets.threshold(), end()); | |
909 } | |
910 | |
911 HeapWord* G1OffsetTableContigSpace::initialize_threshold() { | |
912 return _offsets.initialize_threshold(); | |
913 } | |
914 | |
915 HeapWord* G1OffsetTableContigSpace::cross_threshold(HeapWord* start, | |
916 HeapWord* end) { | |
917 _offsets.alloc_block(start, end); | |
918 return _offsets.threshold(); | |
919 } | |
920 | |
921 HeapWord* G1OffsetTableContigSpace::saved_mark_word() const { | |
922 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
923 assert( _gc_time_stamp <= g1h->get_gc_time_stamp(), "invariant" ); | |
924 if (_gc_time_stamp < g1h->get_gc_time_stamp()) | |
925 return top(); | |
926 else | |
927 return ContiguousSpace::saved_mark_word(); | |
928 } | |
929 | |
930 void G1OffsetTableContigSpace::set_saved_mark() { | |
931 G1CollectedHeap* g1h = G1CollectedHeap::heap(); | |
932 unsigned curr_gc_time_stamp = g1h->get_gc_time_stamp(); | |
933 | |
934 if (_gc_time_stamp < curr_gc_time_stamp) { | |
935 // The order of these is important, as another thread might be | |
936 // about to start scanning this region. If it does so after | |
937 // set_saved_mark and before _gc_time_stamp = ..., then the latter | |
938 // will be false, and it will pick up top() as the high water mark | |
939 // of region. If it does so after _gc_time_stamp = ..., then it | |
940 // will pick up the right saved_mark_word() as the high water mark | |
941 // of the region. Either way, the behaviour will be correct. | |
942 ContiguousSpace::set_saved_mark(); | |
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
838
diff
changeset
|
943 OrderAccess::storestore(); |
353
9bb2c10ac07b
6723570: G1: assertion failure: p == current_top or oop(p)->is_oop(),"p is not a block start" (revisited!)
iveresov
parents:
342
diff
changeset
|
944 _gc_time_stamp = curr_gc_time_stamp; |
2433
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
945 // No need to do another barrier to flush the writes above. If |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
946 // this is called in parallel with other threads trying to |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
947 // allocate into the region, the caller should call this while |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
948 // holding a lock and when the lock is released the writes will be |
abdfc822206f
7023069: G1: Introduce symmetric locking in the slow allocation path
tonyp
parents:
2152
diff
changeset
|
949 // flushed. |
342 | 950 } |
951 } | |
952 | |
953 G1OffsetTableContigSpace:: | |
954 G1OffsetTableContigSpace(G1BlockOffsetSharedArray* sharedOffsetArray, | |
955 MemRegion mr, bool is_zeroed) : | |
956 _offsets(sharedOffsetArray, mr), | |
957 _par_alloc_lock(Mutex::leaf, "OffsetTableContigSpace par alloc lock", true), | |
958 _gc_time_stamp(0) | |
959 { | |
960 _offsets.set_space(this); | |
356 | 961 initialize(mr, !is_zeroed, SpaceDecorator::Mangle); |
342 | 962 } |