annotate src/share/vm/gc_implementation/g1/ptrQueue.cpp @ 17635:cb7ec2423207

8027454: Do not traverse string table during G1 remark when treating them as strong roots during initial mark Summary: Do not try to unlink string table entries unconditionally during remark. This is without side effects as the preceding initial mark always uses the string table as strong roots. Needs to be fixed with class unloading during concurrent mark. Reviewed-by: brutisso, mgerdin
author tschatzl
date Mon, 20 Jan 2014 11:47:29 +0100
parents 55fb97c4c58d
children 63a4eb8bcd23 42c091d63c72
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
1 /*
17467
55fb97c4c58d 8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013
mikael
parents: 9060
diff changeset
2 * Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
4 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
7 * published by the Free Software Foundation.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
8 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
13 * accompanied this code).
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
14 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
21 * questions.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
22 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
23 */
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
25 #include "precompiled.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
26 #include "gc_implementation/g1/ptrQueue.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
27 #include "memory/allocation.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
28 #include "memory/allocation.inline.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
29 #include "runtime/mutex.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
30 #include "runtime/mutexLocker.hpp"
7180
f34d701e952e 8003935: Simplify the needed includes for using Thread::current()
stefank
parents: 6842
diff changeset
31 #include "runtime/thread.inline.hpp"
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
32
2149
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
33 PtrQueue::PtrQueue(PtrQueueSet* qset, bool perm, bool active) :
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
34 _qset(qset), _buf(NULL), _index(0), _active(active),
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
35 _perm(perm), _lock(NULL)
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
36 {}
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
37
441
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
38 void PtrQueue::flush() {
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
39 if (!_perm && _buf != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
40 if (_index == _sz) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
41 // No work to do.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
42 qset()->deallocate_buffer(_buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
43 } else {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
44 // We must NULL out the unused entries, then enqueue.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
45 for (size_t i = 0; i < _index; i += oopSize) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
46 _buf[byte_index_to_index((int)i)] = NULL;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
47 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
48 qset()->enqueue_complete_buffer(_buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
49 }
441
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
50 _buf = NULL;
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
51 _index = 0;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
52 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
53 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
54
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
55
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
56 void PtrQueue::enqueue_known_active(void* ptr) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
57 assert(0 <= _index && _index <= _sz, "Invariant.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
58 assert(_index == 0 || _buf != NULL, "invariant");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
59
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
60 while (_index == 0) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
61 handle_zero_index();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
62 }
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
63
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
64 assert(_index > 0, "postcondition");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
65 _index -= oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
66 _buf[byte_index_to_index((int)_index)] = ptr;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
67 assert(0 <= _index && _index <= _sz, "Invariant.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
68 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
69
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
70 void PtrQueue::locking_enqueue_completed_buffer(void** buf) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
71 assert(_lock->owned_by_self(), "Required.");
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
72
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
73 // We have to unlock _lock (which may be Shared_DirtyCardQ_lock) before
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
74 // we acquire DirtyCardQ_CBL_mon inside enqeue_complete_buffer as they
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
75 // have the same rank and we may get the "possible deadlock" message
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
76 _lock->unlock();
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
77
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
78 qset()->enqueue_complete_buffer(buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
79 // We must relock only because the caller will unlock, for the normal
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
80 // case.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
81 _lock->lock_without_safepoint_check();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
82 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
83
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
84
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
85 PtrQueueSet::PtrQueueSet(bool notify_when_complete) :
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
86 _max_completed_queue(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
87 _cbl_mon(NULL), _fl_lock(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
88 _notify_when_complete(notify_when_complete),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
89 _sz(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
90 _completed_buffers_head(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
91 _completed_buffers_tail(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
92 _n_completed_buffers(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
93 _process_completed_threshold(0), _process_completed(false),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
94 _buf_free_list(NULL), _buf_free_list_sz(0)
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
95 {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
96 _fl_owner = this;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
97 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
98
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
99 void** PtrQueueSet::allocate_buffer() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
100 assert(_sz > 0, "Didn't set a buffer size.");
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
101 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
102 if (_fl_owner->_buf_free_list != NULL) {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
103 void** res = BufferNode::make_buffer_from_node(_fl_owner->_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
104 _fl_owner->_buf_free_list = _fl_owner->_buf_free_list->next();
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
105 _fl_owner->_buf_free_list_sz--;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
106 return res;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
107 } else {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
108 // Allocate space for the BufferNode in front of the buffer.
6197
d2a62e0f25eb 6995781: Native Memory Tracking (Phase 1)
zgu
parents: 3960
diff changeset
109 char *b = NEW_C_HEAP_ARRAY(char, _sz + BufferNode::aligned_size(), mtGC);
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
110 return BufferNode::make_buffer_from_block(b);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
111 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
112 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
113
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
114 void PtrQueueSet::deallocate_buffer(void** buf) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
115 assert(_sz > 0, "Didn't set a buffer size.");
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
116 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
117 BufferNode *node = BufferNode::make_node_from_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
118 node->set_next(_fl_owner->_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
119 _fl_owner->_buf_free_list = node;
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
120 _fl_owner->_buf_free_list_sz++;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
121 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
122
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
123 void PtrQueueSet::reduce_free_list() {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
124 assert(_fl_owner == this, "Free list reduction is allowed only for the owner");
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
125 // For now we'll adopt the strategy of deleting half.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
126 MutexLockerEx x(_fl_lock, Mutex::_no_safepoint_check_flag);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
127 size_t n = _buf_free_list_sz / 2;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
128 while (n > 0) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
129 assert(_buf_free_list != NULL, "_buf_free_list_sz must be wrong.");
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
130 void* b = BufferNode::make_block_from_node(_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
131 _buf_free_list = _buf_free_list->next();
6197
d2a62e0f25eb 6995781: Native Memory Tracking (Phase 1)
zgu
parents: 3960
diff changeset
132 FREE_C_HEAP_ARRAY(char, b, mtGC);
1084
5f932a151fd4 6895788: G1: SATB and update buffer allocation code allocates too much space
johnc
parents: 844
diff changeset
133 _buf_free_list_sz --;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
134 n--;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
135 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
136 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
137
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
138 void PtrQueue::handle_zero_index() {
2149
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
139 assert(_index == 0, "Precondition.");
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
140
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
141 // This thread records the full buffer and allocates a new one (while
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
142 // holding the lock if there is one).
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
143 if (_buf != NULL) {
2149
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
144 if (!should_enqueue_buffer()) {
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
145 assert(_index > 0, "the buffer can only be re-used if it's not full");
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
146 return;
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
147 }
7e37af9d69ef 7011379: G1: overly long concurrent marking cycles
tonyp
parents: 1972
diff changeset
148
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
149 if (_lock) {
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
150 assert(_lock->owned_by_self(), "Required.");
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
151
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
152 // The current PtrQ may be the shared dirty card queue and
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
153 // may be being manipulated by more than one worker thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
154 // during a pause. Since the enqueuing of the completed
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
155 // buffer unlocks the Shared_DirtyCardQ_lock more than one
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
156 // worker thread can 'race' on reading the shared queue attributes
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
157 // (_buf and _index) and multiple threads can call into this
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
158 // routine for the same buffer. This will cause the completed
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
159 // buffer to be added to the CBL multiple times.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
160
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
161 // We "claim" the current buffer by caching value of _buf in
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
162 // a local and clearing the field while holding _lock. When
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
163 // _lock is released (while enqueueing the completed buffer)
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
164 // the thread that acquires _lock will skip this code,
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
165 // preventing the subsequent the multiple enqueue, and
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
166 // install a newly allocated buffer below.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
167
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
168 void** buf = _buf; // local pointer to completed buffer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
169 _buf = NULL; // clear shared _buf field
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
170
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
171 locking_enqueue_completed_buffer(buf); // enqueue completed buffer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
172
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
173 // While the current thread was enqueuing the buffer another thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
174 // may have a allocated a new buffer and inserted it into this pointer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
175 // queue. If that happens then we just return so that the current
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
176 // thread doesn't overwrite the buffer allocated by the other thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
177 // and potentially losing some dirtied cards.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
178
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
179 if (_buf != NULL) return;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
180 } else {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
181 if (qset()->process_or_enqueue_complete_buffer(_buf)) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
182 // Recycle the buffer. No allocation.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
183 _sz = qset()->buffer_size();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
184 _index = _sz;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
185 return;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
186 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
187 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
188 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
189 // Reallocate the buffer
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
190 _buf = qset()->allocate_buffer();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
191 _sz = qset()->buffer_size();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
192 _index = _sz;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
193 assert(0 <= _index && _index <= _sz, "Invariant.");
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
194 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
195
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
196 bool PtrQueueSet::process_or_enqueue_complete_buffer(void** buf) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
197 if (Thread::current()->is_Java_thread()) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
198 // We don't lock. It is fine to be epsilon-precise here.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
199 if (_max_completed_queue == 0 || _max_completed_queue > 0 &&
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
200 _n_completed_buffers >= _max_completed_queue + _completed_queue_padding) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
201 bool b = mut_process_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
202 if (b) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
203 // True here means that the buffer hasn't been deallocated and the caller may reuse it.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
204 return true;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
205 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
206 }
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
207 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
208 // The buffer will be enqueued. The caller will have to get a new one.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
209 enqueue_complete_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
210 return false;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
211 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
212
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
213 void PtrQueueSet::enqueue_complete_buffer(void** buf, size_t index) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
214 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
215 BufferNode* cbn = BufferNode::new_from_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
216 cbn->set_index(index);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
217 if (_completed_buffers_tail == NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
218 assert(_completed_buffers_head == NULL, "Well-formedness");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
219 _completed_buffers_head = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
220 _completed_buffers_tail = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
221 } else {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
222 _completed_buffers_tail->set_next(cbn);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
223 _completed_buffers_tail = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
224 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
225 _n_completed_buffers++;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
226
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
227 if (!_process_completed && _process_completed_threshold >= 0 &&
794
315a5d70b295 6484957: G1: parallel concurrent refinement
iveresov
parents: 616
diff changeset
228 _n_completed_buffers >= _process_completed_threshold) {
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
229 _process_completed = true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
230 if (_notify_when_complete)
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
231 _cbl_mon->notify();
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
232 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
233 debug_only(assert_completed_buffer_list_len_correct_locked());
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
234 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
235
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
236 int PtrQueueSet::completed_buffers_list_length() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
237 int n = 0;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
238 BufferNode* cbn = _completed_buffers_head;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
239 while (cbn != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
240 n++;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
241 cbn = cbn->next();
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
242 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
243 return n;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
244 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
245
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
246 void PtrQueueSet::assert_completed_buffer_list_len_correct() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
247 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
248 assert_completed_buffer_list_len_correct_locked();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
249 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
250
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
251 void PtrQueueSet::assert_completed_buffer_list_len_correct_locked() {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
252 guarantee(completed_buffers_list_length() == _n_completed_buffers,
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
253 "Completed buffer length is wrong.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
254 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
255
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
256 void PtrQueueSet::set_buffer_size(size_t sz) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
257 assert(_sz == 0 && sz > 0, "Should be called only once.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
258 _sz = sz * oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
259 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
260
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
261 // Merge lists of buffers. Notify the processing threads.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
262 // The source queue is emptied as a result. The queues
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
263 // must share the monitor.
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
264 void PtrQueueSet::merge_bufferlists(PtrQueueSet *src) {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
265 assert(_cbl_mon == src->_cbl_mon, "Should share the same lock");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
266 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
267 if (_completed_buffers_tail == NULL) {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
268 assert(_completed_buffers_head == NULL, "Well-formedness");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
269 _completed_buffers_head = src->_completed_buffers_head;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
270 _completed_buffers_tail = src->_completed_buffers_tail;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
271 } else {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
272 assert(_completed_buffers_head != NULL, "Well formedness");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
273 if (src->_completed_buffers_head != NULL) {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
274 _completed_buffers_tail->set_next(src->_completed_buffers_head);
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
275 _completed_buffers_tail = src->_completed_buffers_tail;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
276 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
277 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
278 _n_completed_buffers += src->_n_completed_buffers;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
279
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
280 src->_n_completed_buffers = 0;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
281 src->_completed_buffers_head = NULL;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
282 src->_completed_buffers_tail = NULL;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
283
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
284 assert(_completed_buffers_head == NULL && _completed_buffers_tail == NULL ||
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
285 _completed_buffers_head != NULL && _completed_buffers_tail != NULL,
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
286 "Sanity");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
287 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
288
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
289 void PtrQueueSet::notify_if_necessary() {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
290 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
291 if (_n_completed_buffers >= _process_completed_threshold || _max_completed_queue == 0) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
292 _process_completed = true;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
293 if (_notify_when_complete)
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
294 _cbl_mon->notify();
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
295 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
296 }