Mercurial > hg > truffle
annotate src/cpu/x86/vm/icache_x86.cpp @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
| author | minqi |
|---|---|
| date | Wed, 26 Feb 2014 15:20:41 -0800 |
| parents | cd3d6a6b95d9 |
| children |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1972 | 2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
337
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
337
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
337
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
|
7199
cd3d6a6b95d9
8003240: x86: move MacroAssembler into separate file
twisti
parents:
1972
diff
changeset
|
26 #include "asm/macroAssembler.hpp" |
| 1972 | 27 #include "runtime/icache.hpp" |
| 0 | 28 |
| 29 #define __ _masm-> | |
| 30 | |
| 31 void ICacheStubGenerator::generate_icache_flush(ICache::flush_icache_stub_t* flush_icache_stub) { | |
| 32 StubCodeMark mark(this, "ICache", "flush_icache_stub"); | |
| 33 | |
| 34 address start = __ pc(); | |
| 35 #ifdef AMD64 | |
| 36 | |
| 37 const Register addr = c_rarg0; | |
| 38 const Register lines = c_rarg1; | |
| 39 const Register magic = c_rarg2; | |
| 40 | |
| 41 Label flush_line, done; | |
| 42 | |
| 43 __ testl(lines, lines); | |
| 44 __ jcc(Assembler::zero, done); | |
| 45 | |
| 46 // Force ordering wrt cflush. | |
| 47 // Other fence and sync instructions won't do the job. | |
| 48 __ mfence(); | |
| 49 | |
| 50 __ bind(flush_line); | |
| 51 __ clflush(Address(addr, 0)); | |
| 304 | 52 __ addptr(addr, ICache::line_size); |
| 0 | 53 __ decrementl(lines); |
| 54 __ jcc(Assembler::notZero, flush_line); | |
| 55 | |
| 56 __ mfence(); | |
| 57 | |
| 58 __ bind(done); | |
| 59 | |
| 60 #else | |
| 61 const Address magic(rsp, 3*wordSize); | |
| 62 __ lock(); __ addl(Address(rsp, 0), 0); | |
| 63 #endif // AMD64 | |
| 304 | 64 __ movptr(rax, magic); // Handshake with caller to make sure it happened! |
| 0 | 65 __ ret(0); |
| 66 | |
| 67 // Must be set here so StubCodeMark destructor can call the flush stub. | |
| 68 *flush_icache_stub = (ICache::flush_icache_stub_t)start; | |
| 69 } | |
| 70 | |
| 71 #undef __ |