Mercurial > hg > truffle
annotate src/os/linux/vm/threadCritical_linux.cpp @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
| author | minqi |
|---|---|
| date | Wed, 26 Feb 2014 15:20:41 -0800 |
| parents | f34d701e952e |
| children |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1972 | 2 * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
|
7180
f34d701e952e
8003935: Simplify the needed includes for using Thread::current()
stefank
parents:
1972
diff
changeset
|
26 #include "runtime/thread.inline.hpp" |
| 1972 | 27 #include "runtime/threadCritical.hpp" |
| 0 | 28 |
| 29 // put OS-includes here | |
| 30 # include <pthread.h> | |
| 31 | |
| 32 // | |
| 33 // See threadCritical.hpp for details of this class. | |
| 34 // | |
| 35 | |
| 36 static pthread_t tc_owner = 0; | |
| 37 static pthread_mutex_t tc_mutex = PTHREAD_MUTEX_INITIALIZER; | |
| 38 static int tc_count = 0; | |
| 39 | |
| 40 void ThreadCritical::initialize() { | |
| 41 } | |
| 42 | |
| 43 void ThreadCritical::release() { | |
| 44 } | |
| 45 | |
| 46 ThreadCritical::ThreadCritical() { | |
| 47 pthread_t self = pthread_self(); | |
| 48 if (self != tc_owner) { | |
| 49 int ret = pthread_mutex_lock(&tc_mutex); | |
| 50 guarantee(ret == 0, "fatal error with pthread_mutex_lock()"); | |
| 51 assert(tc_count == 0, "Lock acquired with illegal reentry count."); | |
| 52 tc_owner = self; | |
| 53 } | |
| 54 tc_count++; | |
| 55 } | |
| 56 | |
| 57 ThreadCritical::~ThreadCritical() { | |
| 58 assert(tc_owner == pthread_self(), "must have correct owner"); | |
| 59 assert(tc_count > 0, "must have correct count"); | |
| 60 | |
| 61 tc_count--; | |
| 62 if (tc_count == 0) { | |
| 63 tc_owner = 0; | |
| 64 int ret = pthread_mutex_unlock(&tc_mutex); | |
| 65 guarantee(ret == 0, "fatal error with pthread_mutex_unlock()"); | |
| 66 } | |
| 67 } |