Mercurial > hg > truffle
annotate src/os/windows/vm/osThread_windows.hpp @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
| author | minqi |
|---|---|
| date | Wed, 26 Feb 2014 15:20:41 -0800 |
| parents | 960a442eae91 |
| children |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
6006
0105f367a14c
7160570: Intrinsification support for tracing framework
rbackman
parents:
1972
diff
changeset
|
2 * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #ifndef OS_WINDOWS_VM_OSTHREAD_WINDOWS_HPP |
| 26 #define OS_WINDOWS_VM_OSTHREAD_WINDOWS_HPP | |
| 27 | |
|
6093
960a442eae91
7161732: Improve handling of thread_id in OSThread
rbackman
parents:
6006
diff
changeset
|
28 typedef void* HANDLE; |
|
960a442eae91
7161732: Improve handling of thread_id in OSThread
rbackman
parents:
6006
diff
changeset
|
29 public: |
|
960a442eae91
7161732: Improve handling of thread_id in OSThread
rbackman
parents:
6006
diff
changeset
|
30 typedef unsigned long thread_id_t; |
| 0 | 31 |
| 32 private: | |
| 33 // Win32-specific thread information | |
| 34 HANDLE _thread_handle; // Win32 thread handle | |
| 35 HANDLE _interrupt_event; // Event signalled on thread interrupt | |
| 36 ThreadState _last_state; | |
| 37 | |
| 38 public: | |
| 39 // The following will only apply in the Win32 implementation, and should only | |
| 40 // be visible in the concrete class, not this which should be an abstract base class | |
| 41 HANDLE thread_handle() const { return _thread_handle; } | |
| 42 void set_thread_handle(HANDLE handle) { _thread_handle = handle; } | |
| 43 HANDLE interrupt_event() const { return _interrupt_event; } | |
| 44 void set_interrupt_event(HANDLE interrupt_event) { _interrupt_event = interrupt_event; } | |
| 45 | |
| 46 #ifndef PRODUCT | |
| 47 // Used for debugging, return a unique integer for each thread. | |
| 48 int thread_identifier() const { return _thread_id; } | |
| 49 #endif | |
| 50 #ifdef ASSERT | |
| 51 // We expect no reposition failures so kill vm if we get one | |
| 52 // | |
| 53 bool valid_reposition_failure() { | |
| 54 return false; | |
| 55 } | |
| 56 #endif // ASSERT | |
| 57 bool is_try_mutex_enter() { return false; } | |
| 58 | |
| 59 // This is a temporary fix for the thread states during | |
| 60 // suspend/resume until we throw away OSThread completely. | |
| 61 // NEEDS_CLEANUP | |
| 62 void set_last_state(ThreadState state) { _last_state = state; } | |
| 63 ThreadState get_last_state() { return _last_state; } | |
| 64 | |
| 65 private: | |
| 66 void pd_initialize(); | |
| 67 void pd_destroy(); | |
| 1972 | 68 |
| 69 #endif // OS_WINDOWS_VM_OSTHREAD_WINDOWS_HPP |