Mercurial > hg > truffle
annotate src/os/windows/vm/os_windows.inline.hpp @ 14649:f6301b007a16
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | 6c9332549827 |
children | 4ca6dc0799b6 |
rev | line source |
---|---|
0 | 1 /* |
14475
6c9332549827
6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris due to race with signal handler
fparain
parents:
11092
diff
changeset
|
2 * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #ifndef OS_WINDOWS_VM_OS_WINDOWS_INLINE_HPP |
26 #define OS_WINDOWS_VM_OS_WINDOWS_INLINE_HPP | |
27 | |
7199
cd3d6a6b95d9
8003240: x86: move MacroAssembler into separate file
twisti
parents:
1980
diff
changeset
|
28 #include "runtime/atomic.inline.hpp" |
1972 | 29 #include "runtime/os.hpp" |
7199
cd3d6a6b95d9
8003240: x86: move MacroAssembler into separate file
twisti
parents:
1980
diff
changeset
|
30 |
1972 | 31 #ifdef TARGET_OS_ARCH_windows_x86 |
32 # include "orderAccess_windows_x86.inline.hpp" | |
33 #endif | |
34 | |
0 | 35 inline const char* os::file_separator() { return "\\"; } |
36 inline const char* os::line_separator() { return "\r\n"; } | |
37 inline const char* os::path_separator() { return ";"; } | |
1980
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
38 inline const char* os::dll_file_extension() { return ".dll"; } |
0 | 39 |
1980
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
40 inline const int os::default_file_open_flags() { return O_BINARY | O_NOINHERIT;} |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
41 |
0 | 42 // File names are case-insensitive on windows only |
43 inline int os::file_name_strcmp(const char* s, const char* t) { | |
44 return _stricmp(s, t); | |
45 } | |
46 | |
1980
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
47 inline void os::dll_unload(void *lib) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
48 ::FreeLibrary((HMODULE)lib); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
49 } |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
50 |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
51 inline void* os::dll_lookup(void *lib, const char *name) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
52 return (void*)::GetProcAddress((HMODULE)lib, name); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
53 } |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
54 |
0 | 55 // Used to improve time-sharing on some systems |
56 inline void os::loop_breaker(int attempts) {} | |
57 | |
58 inline bool os::obsolete_option(const JavaVMOption *option) { | |
59 return false; | |
60 } | |
61 | |
62 inline bool os::uses_stack_guard_pages() { | |
63 return os::win32::is_nt(); | |
64 } | |
65 | |
66 inline bool os::allocate_stack_guard_pages() { | |
67 assert(uses_stack_guard_pages(), "sanity check"); | |
68 return true; | |
69 } | |
70 | |
71 inline int os::readdir_buf_size(const char *path) | |
72 { | |
73 /* As Windows doesn't use the directory entry buffer passed to | |
74 os::readdir() this can be as short as possible */ | |
75 | |
76 return 1; | |
77 } | |
78 | |
79 // Bang the shadow pages if they need to be touched to be mapped. | |
80 inline void os::bang_stack_shadow_pages() { | |
81 // Write to each page of our new frame to force OS mapping. | |
82 // If we decrement stack pointer more than one page | |
83 // the OS may not map an intervening page into our space | |
84 // and may fault on a memory access to interior of our frame. | |
85 address sp = current_stack_pointer(); | |
86 for (int pages = 1; pages <= StackShadowPages; pages++) { | |
87 *((int *)(sp - (pages * vm_page_size()))) = 0; | |
88 } | |
89 } | |
141 | 90 |
91 inline bool os::numa_has_static_binding() { return true; } | |
92 inline bool os::numa_has_group_homing() { return false; } | |
1972 | 93 |
1980
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
94 inline size_t os::read(int fd, void *buf, unsigned int nBytes) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
95 return ::read(fd, buf, nBytes); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
96 } |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
97 |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
98 inline size_t os::restartable_read(int fd, void *buf, unsigned int nBytes) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
99 return ::read(fd, buf, nBytes); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
100 } |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
101 |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
102 inline size_t os::write(int fd, const void *buf, unsigned int nBytes) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
103 return ::write(fd, buf, nBytes); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
104 } |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
105 |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
106 inline int os::close(int fd) { |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
107 return ::close(fd); |
828eafbd85cc
6348631: remove the use of the HPI library from Hotspot
ikrylov
parents:
1972
diff
changeset
|
108 } |
11092
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
109 |
14475
6c9332549827
6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris due to race with signal handler
fparain
parents:
11092
diff
changeset
|
110 inline bool os::supports_monotonic_clock() { |
6c9332549827
6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris due to race with signal handler
fparain
parents:
11092
diff
changeset
|
111 return win32::_has_performance_count; |
6c9332549827
6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris due to race with signal handler
fparain
parents:
11092
diff
changeset
|
112 } |
6c9332549827
6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris due to race with signal handler
fparain
parents:
11092
diff
changeset
|
113 |
11092
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
114 #ifndef PRODUCT |
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
115 #define CALL_TEST_FUNC_WITH_WRAPPER_IF_NEEDED(f) \ |
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
116 os::win32::call_test_func_with_wrapper(f) |
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
117 #endif |
59b052799158
8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace
dcubed
parents:
8675
diff
changeset
|
118 |
1972 | 119 #endif // OS_WINDOWS_VM_OS_WINDOWS_INLINE_HPP |