Mercurial > hg > truffle
comparison src/share/vm/gc_interface/collectedHeap.cpp @ 1548:15190cbcabe9
6953483: Typo related to ReduceInitialCardMarks leaves concurrent collectors vulnerable to heap corruption
Summary: Corrected mis-spelling of COMPILER2 in #ifdef, which could cause heap corruption in CMS due to precleaning when +ReduceInitialCardMarks. Thanks to ChenGuang Sun <suncg03@gmail.com> for bringing this typo to our attention.
Reviewed-by: tonyp, jmasa, jcoomes, kvn
author | ysr |
---|---|
date | Wed, 19 May 2010 10:37:05 -0700 |
parents | 34fb2662f6c2 |
children | 1634cec09505 |
comparison
equal
deleted
inserted
replaced
1547:fb1a39993f69 | 1548:15190cbcabe9 |
---|---|
63 } | 63 } |
64 | 64 |
65 void CollectedHeap::pre_initialize() { | 65 void CollectedHeap::pre_initialize() { |
66 // Used for ReduceInitialCardMarks (when COMPILER2 is used); | 66 // Used for ReduceInitialCardMarks (when COMPILER2 is used); |
67 // otherwise remains unused. | 67 // otherwise remains unused. |
68 #ifdef COMPLER2 | 68 #ifdef COMPILER2 |
69 _defer_initial_card_mark = ReduceInitialCardMarks && can_elide_tlab_store_barriers() | 69 _defer_initial_card_mark = ReduceInitialCardMarks && can_elide_tlab_store_barriers() |
70 && (DeferInitialCardMark || card_mark_must_follow_store()); | 70 && (DeferInitialCardMark || card_mark_must_follow_store()); |
71 #else | 71 #else |
72 assert(_defer_initial_card_mark == false, "Who would set it?"); | 72 assert(_defer_initial_card_mark == false, "Who would set it?"); |
73 #endif | 73 #endif |