Mercurial > hg > truffle
comparison src/share/vm/runtime/vmThread.cpp @ 3293:1f4413413144
7039089: G1: changeset for 7037276 broke heap verification, and related cleanups
Summary: In G1 heap verification, we no longer scan perm to G1-collected heap refs as part of process_strong_roots() but rather in a separate explicit oop iteration over the perm gen. This preserves the original perm card-marks. Added a new assertion in younger_refs_iterate() to catch a simple subcase where the user may have forgotten a prior save_marks() call, as happened in the case of G1's attempt to iterate perm to G1 refs when verifying the heap before exit. The assert was deliberately weakened for ParNew+CMS and will be fixed for that combination in a future CR. Also made some (non-G1) cleanups related to code and comments obsoleted by the migration of Symbols to the native heap.
Reviewed-by: iveresov, jmasa, tonyp
| author | ysr |
|---|---|
| date | Tue, 26 Apr 2011 21:17:24 -0700 |
| parents | f95d63e2154a |
| children | f08d439fab8c |
comparison
equal
deleted
inserted
replaced
| 3292:c303b3532d4a | 3293:1f4413413144 |
|---|---|
| 289 if (VerifyBeforeExit) { | 289 if (VerifyBeforeExit) { |
| 290 HandleMark hm(VMThread::vm_thread()); | 290 HandleMark hm(VMThread::vm_thread()); |
| 291 // Among other things, this ensures that Eden top is correct. | 291 // Among other things, this ensures that Eden top is correct. |
| 292 Universe::heap()->prepare_for_verify(); | 292 Universe::heap()->prepare_for_verify(); |
| 293 os::check_heap(); | 293 os::check_heap(); |
| 294 Universe::verify(true, true); // Silent verification to not polute normal output | 294 // Silent verification so as not to pollute normal output, |
| 295 // unless we really asked for it. | |
| 296 Universe::verify(true, !(PrintGCDetails || Verbose)); | |
| 295 } | 297 } |
| 296 | 298 |
| 297 CompileBroker::set_should_block(); | 299 CompileBroker::set_should_block(); |
| 298 | 300 |
| 299 // wait for threads (compiler threads or daemon threads) in the | 301 // wait for threads (compiler threads or daemon threads) in the |