truffle: mxtool/mx.py comparison

comparison mxtool/mx.py @ 5217:70777e50f1e6

replace monkey patch with subclassing instead

author	Doug Simon <doug.simon@oracle.com>
date	Sun, 08 Apr 2012 00:09:10 +0200
parents	887b45f6aa02
children	ddccd4abdb09

comparison

equal deleted inserted replaced

-:887b45f6aa02
+:70777e50f1e6
 existing = _libs.get(l.name)
 if existing is not None:
 abort('cannot redefine library  ' + l.name)
 _libs[l.name] = l
+class XMLElement(xml.dom.minidom.Element):
-class XML(xml.dom.minidom.Document):
+def writexml(self, writer, indent="", addindent="", newl=""):
+writer.write(indent+"<" + self.tagName)
+attrs = self._get_attributes()
+a_names = attrs.keys()
+a_names.sort()
+for a_name in a_names:
+writer.write(" %s=\"" % a_name)
+xml.dom.minidom._write_data(writer, attrs[a_name].value)
+writer.write("\"")
+if self.childNodes:
+if not self.ownerDocument.padTextNodeWithoutSiblings and len(self.childNodes) == 1 and isinstance(self.childNodes[0], xml.dom.minidom.Text):
+# if the only child of an Element node is a Text node, then the
+# text is printed without any indentation or new line padding
+writer.write(">")
+self.childNodes[0].writexml(writer)
+writer.write("</%s>%s" % (self.tagName,newl))
+else:
+writer.write(">%s"%(newl))
+for node in self.childNodes:
+node.writexml(writer,indent+addindent,addindent,newl)
+writer.write("%s</%s>%s" % (indent,self.tagName,newl))
+else:
+writer.write("/>%s"%(newl))
+class XMLDoc(xml.dom.minidom.Document):
 def __init__(self):
 xml.dom.minidom.Document.__init__(self)
 self.current = self
 self.padTextNodeWithoutSiblings = False
+def createElement(self, tagName):
+# overwritten to create XMLElement
+e = XMLElement(tagName)
+e.ownerDocument = self
+return e
 def open(self, tag, attributes={}, data=None):
 element = self.createElement(tag)
 for key, value in attributes.items():
 element.setAttribute(key, value)
 self.current.appendChild(element)
 if escape:
 entities = { '"':  "&quot;", "'":  "&apos;", '\n': '&#10;' }
 result = xml.sax.saxutils.escape(result, entities)
 return result
-@staticmethod
-def _Element_writexml(self, writer, indent="", addindent="", newl=""):
-# Monkey patch: if the only child of an Element node is a Text node, then the
-# text is printed without any indentation or new line padding
-writer.write(indent+"<" + self.tagName)
-attrs = self._get_attributes()
-a_names = attrs.keys()
-a_names.sort()
-for a_name in a_names:
-writer.write(" %s=\"" % a_name)
-xml.dom.minidom._write_data(writer, attrs[a_name].value)
-writer.write("\"")
-if self.childNodes:
-if not self.ownerDocument.padTextNodeWithoutSiblings and len(self.childNodes) == 1 and isinstance(self.childNodes[0], xml.dom.minidom.Text):
-writer.write(">")
-self.childNodes[0].writexml(writer)
-writer.write("</%s>%s" % (self.tagName,newl))
-else:
-writer.write(">%s"%(newl))
-for node in self.childNodes:
-node.writexml(writer,indent+addindent,addindent,newl)
-writer.write("%s</%s>%s" % (indent,self.tagName,newl))
-else:
-writer.write("/>%s"%(newl))
-xml.dom.minidom.Element.writexml = XML._Element_writexml
 def get_os():
 """
 Get a canonical form of sys.platform.
 """
 if sys.platform.startswith('darwin'):
 print '"' + p.name + '"->"' + dep + '"'
 print '}'
 def _source_locator_memento(deps):
-slm = XML()
+slm = XMLDoc()
 slm.open('sourceLookupDirector')
 slm.open('sourceContainers', {'duplicates' : 'false'})
 for dep in deps:
 if dep.isLibrary():
 if hasattr(dep, 'eclipse.container'):
-memento = XML().element('classpathContainer', {'path' : getattr(dep, 'eclipse.container')}).xml()
+memento = XMLDoc().element('classpathContainer', {'path' : getattr(dep, 'eclipse.container')}).xml()
 slm.element('classpathContainer', {'memento' : memento, 'typeId':'org.eclipse.jdt.launching.sourceContainer.classpathContainer'})
 else:
-memento = XML().element('javaProject', {'name' : dep.name}).xml()
+memento = XMLDoc().element('javaProject', {'name' : dep.name}).xml()
 slm.element('container', {'memento' : memento, 'typeId':'org.eclipse.jdt.launching.sourceContainer.javaProject'})
 slm.close('sourceContainers')
 slm.close('sourceLookupDirector')
 return slm
 def make_eclipse_attach(hostname, port, name=None, deps=[]):
 """
 Creates an Eclipse launch configuration file for attaching to a Java process.
 """
 slm = _source_locator_memento(deps)
-launch = XML()
+launch = XMLDoc()
 launch.open('launchConfiguration', {'type' : 'org.eclipse.jdt.launching.remoteJavaApplication'})
 launch.element('stringAttribute', {'key' : 'org.eclipse.debug.core.source_locator_id', 'value' : 'org.eclipse.jdt.launching.sourceLocator.JavaSourceLookupDirector'})
 launch.element('stringAttribute', {'key' : 'org.eclipse.debug.core.source_locator_memento', 'value' : '%s'})
 launch.element('booleanAttribute', {'key' : 'org.eclipse.jdt.launching.ALLOW_TERMINATE', 'value' : 'true'})
 launch.open('mapAttribute', {'key' : 'org.eclipse.jdt.launching.CONNECT_MAP'})
 deps += [p for p in s.projects if e == p.output_dir()]
 deps += [l for l in s.libs if e == l.get_path(False)]
 slm = _source_locator_memento(deps)
-launch = XML()
+launch = XMLDoc()
 launch.open('launchConfiguration', {'type' : 'org.eclipse.jdt.launching.localJavaApplication'})
 launch.element('stringAttribute', {'key' : 'org.eclipse.debug.core.source_locator_id', 'value' : 'org.eclipse.jdt.launching.sourceLocator.JavaSourceLookupDirector'})
 launch.element('stringAttribute', {'key' : 'org.eclipse.debug.core.source_locator_memento', 'value' : '%s'})
 launch.element('stringAttribute', {'key' : 'org.eclipse.jdt.launching.JRE_CONTAINER', 'value' : 'org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/' + jre})
 launch.element('stringAttribute', {'key' : 'org.eclipse.jdt.launching.MAIN_TYPE', 'value' : mainClass})
 continue
 if not exists(p.dir):
 os.makedirs(p.dir)
-out = XML()
+out = XMLDoc()
 out.open('classpath')
 for src in p.srcDirs:
 srcDir = join(p.dir, src)
 if not exists(srcDir):
 out.close('classpath')
 update_file(join(p.dir, '.classpath'), out.xml(indent='\t', newl='\n'))
 csConfig = join(project(p.checkstyleProj).dir, '.checkstyle_checks.xml')
 if exists(csConfig):
-out = XML()
+out = XMLDoc()
 dotCheckstyle = join(p.dir, ".checkstyle")
 checkstyleConfigPath = '/' + p.checkstyleProj + '/.checkstyle_checks.xml'
 out.open('fileset-config', {'file-format-version' : '1.2.0', 'simple-config' : 'true'})
 out.open('local-check-config', {'name' : 'Checks', 'location' : checkstyleConfigPath, 'type' : 'project', 'description' : ''})
 out.close('filter')
 out.close('fileset-config')
 update_file(dotCheckstyle, out.xml(indent='\t', newl='\n'))
-out = XML()
+out = XMLDoc()
 out.open('projectDescription')
 out.element('name', data=p.name)
 out.element('comment', data='')
 out.element('projects', data='')
 out.open('buildSpec')
 continue
 if not exists(join(p.dir, 'nbproject')):
 os.makedirs(join(p.dir, 'nbproject'))
-out = XML()
+out = XMLDoc()
 out.open('project', {'name' : p.name, 'default' : 'default', 'basedir' : '.'})
 out.element('description', data='Builds, tests, and runs the project ' + p.name + '.')
 out.element('import', {'file' : 'nbproject/build-impl.xml'})
 out.close('project')
 updated = update_file(join(p.dir, 'build.xml'), out.xml(indent='\t', newl='\n')) or updated
-out = XML()
+out = XMLDoc()
 out.open('project', {'xmlns' : 'http://www.netbeans.org/ns/project/1'})
 out.element('type', data='org.netbeans.modules.java.j2seproject')
 out.open('configuration')
 out.open('data', {'xmlns' : 'http://www.netbeans.org/ns/j2se-project/3'})
 out.element('name', data=p.name)

Mercurial > hg > truffle

comparison mxtool/mx.py @ 5217:70777e50f1e6