Mercurial > hg > truffle

comparison src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp @ 3256:c69b1043dfb1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
7036482: clear argument is redundant and unused in cardtable methods Summary: Removed the unused clear argument to various cardtbale methods and unused mod_oop_in_space_iterate method. Unrelated to synopsis, added a pair of clarifying parens in AllocationStats constructor. Reviewed-by: brutisso, jcoomes
author ysr
date Thu, 14 Apr 2011 12:10:15 -0700
parents f95d63e2154a
children c48ad6ab8bdf
comparison
equal deleted inserted replaced
3254:59766fd005ff 3256:c69b1043dfb1
1 /* 1 /*
2 * Copyright (c) 2007, 2010 Oracle and/or its affiliates. All rights reserved. 2 * Copyright (c) 2007, 2011 Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 * 4 *
5 * This code is free software; you can redistribute it and/or modify it 5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as 6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
34 #include "runtime/virtualspace.hpp" 34 #include "runtime/virtualspace.hpp"
35 35
36 void CardTableModRefBS::par_non_clean_card_iterate_work(Space* sp, MemRegion mr, 36 void CardTableModRefBS::par_non_clean_card_iterate_work(Space* sp, MemRegion mr,
37 DirtyCardToOopClosure* dcto_cl, 37 DirtyCardToOopClosure* dcto_cl,
38 MemRegionClosure* cl, 38 MemRegionClosure* cl,
39 bool clear,
40 int n_threads) { 39 int n_threads) {
41 if (n_threads > 0) { 40 if (n_threads > 0) {
42 assert((n_threads == 1 && ParallelGCThreads == 0) || 41 assert((n_threads == 1 && ParallelGCThreads == 0) ||
43 n_threads <= (int)ParallelGCThreads, 42 n_threads <= (int)ParallelGCThreads,
44 "# worker threads != # requested!"); 43 "# worker threads != # requested!");
55 pst->set_n_threads(n_threads); 54 pst->set_n_threads(n_threads);
56 pst->set_n_tasks(n_strides); 55 pst->set_n_tasks(n_strides);
57 56
58 int stride = 0; 57 int stride = 0;
59 while (!pst->is_task_claimed(/* reference */ stride)) { 58 while (!pst->is_task_claimed(/* reference */ stride)) {
60 process_stride(sp, mr, stride, n_strides, dcto_cl, cl, clear, 59 process_stride(sp, mr, stride, n_strides, dcto_cl, cl,
61 lowest_non_clean, 60 lowest_non_clean,
62 lowest_non_clean_base_chunk_index, 61 lowest_non_clean_base_chunk_index,
63 lowest_non_clean_chunk_size); 62 lowest_non_clean_chunk_size);
64 } 63 }
65 if (pst->all_tasks_completed()) { 64 if (pst->all_tasks_completed()) {
81 process_stride(Space* sp, 80 process_stride(Space* sp,
82 MemRegion used, 81 MemRegion used,
83 jint stride, int n_strides, 82 jint stride, int n_strides,
84 DirtyCardToOopClosure* dcto_cl, 83 DirtyCardToOopClosure* dcto_cl,
85 MemRegionClosure* cl, 84 MemRegionClosure* cl,
86 bool clear,
87 jbyte** lowest_non_clean, 85 jbyte** lowest_non_clean,
88 uintptr_t lowest_non_clean_base_chunk_index, 86 uintptr_t lowest_non_clean_base_chunk_index,
89 size_t lowest_non_clean_chunk_size) { 87 size_t lowest_non_clean_chunk_size) {
90 // We don't have to go downwards here; it wouldn't help anyway, 88 // We don't have to go downwards here; it wouldn't help anyway,
91 // because of parallelism. 89 // because of parallelism.
127 used, 125 used,
128 lowest_non_clean, 126 lowest_non_clean,
129 lowest_non_clean_base_chunk_index, 127 lowest_non_clean_base_chunk_index,
130 lowest_non_clean_chunk_size); 128 lowest_non_clean_chunk_size);
131 129
132 non_clean_card_iterate_work(chunk_mr, cl, clear); 130 non_clean_card_iterate_work(chunk_mr, cl);
133 131
134 // Find the next chunk of the stride. 132 // Find the next chunk of the stride.
135 chunk_card_start += CardsPerStrideChunk * n_strides; 133 chunk_card_start += CardsPerStrideChunk * n_strides;
136 } 134 }
137 } 135 }