Mercurial > hg > truffle

diff src/share/vm/runtime/jniHandles.hpp @ 917:1760a1cbed36

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6862945: 4/3 conversion of jmethodID to methodOop in JVMTI is too expensive Summary: Refactor JNIHandles::checked_resolve_jmethod_id() into fast and paranoid parts. Reviewed-by: never, alanb
author dcubed
date Tue, 11 Aug 2009 11:57:51 -0600
parents a61af66fc99e
children 354d3184f6b2 d3562366cbfd
line wrap: on
line diff
--- a/src/share/vm/runtime/jniHandles.hpp	Tue Jul 28 13:50:07 2009 -0600
+++ b/src/share/vm/runtime/jniHandles.hpp	Tue Aug 11 11:57:51 2009 -0600
@@ -1,5 +1,5 @@
 /*
- * Copyright 1998-2007 Sun Microsystems, Inc.  All Rights Reserved.
+ * Copyright 1998-2009 Sun Microsystems, Inc.  All Rights Reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -196,12 +196,16 @@
 };
 
 inline methodOop JNIHandles::checked_resolve_jmethod_id(jmethodID mid) {
-  jobject handle = (jobject)mid;
-  if (is_weak_global_handle(handle)) {
-    return (methodOop) resolve_non_null(handle);
-  } else {
+  if (mid == NULL) {
     return (methodOop) NULL;
   }
+
+  oop o = resolve_non_null((jobject) mid);
+  if (!o->is_method()) {
+    return (methodOop) NULL;
+  }
+
+  return (methodOop) o;
 };