Mercurial > hg > truffle
diff src/share/vm/opto/lcm.cpp @ 1693:6c9cc03d8726
6973329: C2 with Zero based COOP produces code with broken anti-dependency on x86
Summary: Recompile without subsuming loads if RA try to clone a node with anti_dependence.
Reviewed-by: never
author | kvn |
---|---|
date | Wed, 11 Aug 2010 10:48:20 -0700 |
parents | 0e35fa8ebccd |
children | 3e8fbc61cee8 |
line wrap: on
line diff
--- a/src/share/vm/opto/lcm.cpp Wed Aug 11 05:51:21 2010 -0700 +++ b/src/share/vm/opto/lcm.cpp Wed Aug 11 10:48:20 2010 -0700 @@ -113,7 +113,8 @@ if( !m->is_Mach() ) continue; MachNode *mach = m->as_Mach(); was_store = false; - switch( mach->ideal_Opcode() ) { + int iop = mach->ideal_Opcode(); + switch( iop ) { case Op_LoadB: case Op_LoadUS: case Op_LoadD: @@ -155,6 +156,12 @@ default: // Also check for embedded loads if( !mach->needs_anti_dependence_check() ) continue; // Not an memory op; skip it + if( must_clone[iop] ) { + // Do not move nodes which produce flags because + // RA will try to clone it to place near branch and + // it will cause recompilation, see clone_node(). + continue; + } { // Check that value is used in memory address in // instructions with embedded load (CmpP val1,(val2+off)). @@ -957,6 +964,8 @@ Block *sb = _succs[i]; // Clone the entire area; ignoring the edge fixup for now. for( uint j = end; j > beg; j-- ) { + // It is safe here to clone a node with anti_dependence + // since clones dominate on each path. Node *clone = _nodes[j-1]->clone(); sb->_nodes.insert( 1, clone ); bbs.map(clone->_idx,sb);