Mercurial > hg > truffle

diff src/share/vm/runtime/mutexLocker.hpp @ 1358:72f725c5a7be

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6940310: G1: MT-unsafe calls to CM::region_stack_push() / CM::region_stack_pop() Summary: Calling the methods region_stack_push() and region_stack_pop() concurrent is not MT-safe. The assumption is that we will only call region_stack_push() during a GC pause and region_stack_pop() during marking. Unfortunately, we also call region_stack_push() during marking which seems to be introducing subtle marking failures. This change introduces lock-based methods for pushing / popping to be called during marking. Reviewed-by: iveresov, johnc
author tonyp
date Mon, 05 Apr 2010 12:19:22 -0400
parents bd02caa94611
children c18cbe5936b8
line wrap: on
line diff
--- a/src/share/vm/runtime/mutexLocker.hpp	Fri Apr 02 12:10:08 2010 -0400
+++ b/src/share/vm/runtime/mutexLocker.hpp	Mon Apr 05 12:19:22 2010 -0400
@@ -63,6 +63,7 @@
 extern Monitor* CMark_lock;                      // used for concurrent mark thread coordination
 extern Monitor* ZF_mon;                          // used for G1 conc zero-fill.
 extern Monitor* Cleanup_mon;                     // used for G1 conc cleanup.
+extern Mutex*   CMRegionStack_lock;              // used for protecting accesses to the CM region stack
 extern Mutex*   SATB_Q_FL_lock;                  // Protects SATB Q
                                                  // buffer free list.
 extern Monitor* SATB_Q_CBL_mon;                  // Protects SATB Q