Mercurial > hg > truffle

diff src/os/solaris/vm/os_solaris.cpp @ 1117:95e9083cf4a7

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6822370: ReentrantReadWriteLock: threads hung when there are no threads holding onto the lock (Netra x4450) Summary: This day one bug is caused by missing memory barriers in various Parker::park() paths that can result in lost wakeups and hangs. Reviewed-by: dice, acorn
author dholmes
date Tue, 01 Dec 2009 22:29:02 -0500
parents 665be97e8704
children 167c2986d91b
line wrap: on
line diff
--- a/src/os/solaris/vm/os_solaris.cpp	Wed Nov 25 08:37:04 2009 -0800
+++ b/src/os/solaris/vm/os_solaris.cpp	Tue Dec 01 22:29:02 2009 -0500
@@ -5803,6 +5803,7 @@
   // Return immediately if a permit is available.
   if (_counter > 0) {
       _counter = 0 ;
+      OrderAccess::fence();
       return ;
   }
 
@@ -5846,6 +5847,7 @@
     _counter = 0;
     status = os::Solaris::mutex_unlock(_mutex);
     assert (status == 0, "invariant") ;
+    OrderAccess::fence();
     return;
   }
 
@@ -5892,6 +5894,7 @@
     jt->java_suspend_self();
   }
 
+  OrderAccess::fence();
 }
 
 void Parker::unpark() {