Mercurial > hg > truffle
view src/share/vm/services/runtimeService.hpp @ 12301:2c022e432e10
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
author | stefank |
---|---|
date | Fri, 20 Sep 2013 10:53:28 +0200 |
parents | fb19af007ffc |
children | 6f06ebb09080 |
line wrap: on
line source
/* * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ #ifndef SHARE_VM_SERVICES_RUNTIMESERVICE_HPP #define SHARE_VM_SERVICES_RUNTIMESERVICE_HPP #include "runtime/perfData.hpp" #include "runtime/timer.hpp" class RuntimeService : public AllStatic { private: static PerfCounter* _sync_time_ticks; // Accumulated time spent getting to safepoints static PerfCounter* _total_safepoints; static PerfCounter* _safepoint_time_ticks; // Accumulated time at safepoints static PerfCounter* _application_time_ticks; // Accumulated time not at safepoints static PerfCounter* _thread_interrupt_signaled_count;// os:interrupt thr_kill static PerfCounter* _interrupted_before_count; // _INTERRUPTIBLE OS_INTRPT static PerfCounter* _interrupted_during_count; // _INTERRUPTIBLE OS_INTRPT static TimeStamp _safepoint_timer; static TimeStamp _app_timer; public: static void init(); static jlong safepoint_sync_time_ms(); static jlong safepoint_count(); static jlong safepoint_time_ms(); static jlong application_time_ms(); static double last_safepoint_time_sec() { return _safepoint_timer.seconds(); } static double last_application_time_sec() { return _app_timer.seconds(); } // callbacks static void record_safepoint_begin() NOT_MANAGEMENT_RETURN; static void record_safepoint_synchronized() NOT_MANAGEMENT_RETURN; static void record_safepoint_end() NOT_MANAGEMENT_RETURN; static void record_application_start() NOT_MANAGEMENT_RETURN; // interruption events static void record_interrupted_before_count() NOT_MANAGEMENT_RETURN; static void record_interrupted_during_count() NOT_MANAGEMENT_RETURN; static void record_thread_interrupt_signaled_count() NOT_MANAGEMENT_RETURN; }; #endif // SHARE_VM_SERVICES_RUNTIMESERVICE_HPP