Mercurial > hg > truffle
view agent/src/share/classes/sun/jvm/hotspot/debugger/ThreadProxy.java @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | c18cbe5936b8 |
children |
line wrap: on
line source
/* * Copyright (c) 2000, 2002, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package sun.jvm.hotspot.debugger; /** <P> This interface abstracts raw access to operating system-level threads. In a debugging environment these methods map to, for example, thread_db calls on Solaris (see /usr/include/thread_db.h) or the Win32 debugging API calls. In a runtime environment these might map directly to pthread calls. </P> <P> Implementors of this interface must provide equals() and hashCode() methods which work properly regardless of how the ThreadProxy is obtained, in particular either through {@link sun.jvm.hotspot.debugger.ThreadAccess} or the thread list provided by {@link sun.jvm.hotspot.debugger.cdbg.CDebugger}. This allows matching up of the OS's notion of the thread list of the target process with any user-level lists that may be present (i.e., the JavaThread list in the HotSpot VM). </P> <P> Implementors of this interface should also provide a toString() which converts the ThreadProxy to a value easily recognizable in the platform's debugger. (For example, on Solaris, "t@<id>".) </P> <P> FIXME: had to be renamed from "Thread" to avoid numerous clashes with java.lang.Thread -- would be nice to pick a more consistent name with the rest of the system. </P> */ public interface ThreadProxy { /** Retrieves the context for the given thread. It is only valid to call this method if the thread is suspended (i.e., the process has not been resumed via ProcessControl); throws an IllegalThreadStateException if it is not. */ public ThreadContext getContext() throws IllegalThreadStateException; /** Indicates whether calls to setContext() are valid. */ public boolean canSetContext() throws DebuggerException; /** Sets the context for the given thread. The passed ThreadContext must be a modified version of one returned from a previous call to getContext(). It is only valid to call this method if the thread is suspended (i.e., the process has not been resumed via ProcessControl); throws an IllegalThreadStateException if it is not. Throws a DebuggerException if the target process can not be modified, for example because it is a core file. */ public void setContext(ThreadContext context) throws IllegalThreadStateException, DebuggerException; }