Mercurial > hg > truffle
view agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeJsr.java @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | c18cbe5936b8 |
children |
line wrap: on
line source
/* * Copyright (c) 2002, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package sun.jvm.hotspot.interpreter; import sun.jvm.hotspot.oops.*; import sun.jvm.hotspot.utilities.*; public class BytecodeJsr extends BytecodeJmp { BytecodeJsr(Method method, int bci) { super(method, bci); } public int getTargetBCI() { return bci() + javaShortAt(1); } public void verify() { if (Assert.ASSERTS_ENABLED) { Assert.that(isValid(), "check jsr"); } } public boolean isValid() { return javaCode() == Bytecodes._jsr; } public static BytecodeJsr at(Method method, int bci) { BytecodeJsr b = new BytecodeJsr(method, bci); if (Assert.ASSERTS_ENABLED) { b.verify(); } return b; } /** Like at, but returns null if the BCI is not at jsr */ public static BytecodeJsr atCheck(Method method, int bci) { BytecodeJsr b = new BytecodeJsr(method, bci); return (b.isValid() ? b : null); } public static BytecodeJsr at(BytecodeStream bcs) { return new BytecodeJsr(bcs.method(), bcs.bci()); } }