Mercurial > hg > truffle
view agent/src/share/classes/sun/jvm/hotspot/jdi/ClassLoaderReferenceImpl.java @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | c18cbe5936b8 |
children |
line wrap: on
line source
/* * Copyright (c) 2002, 2003, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package sun.jvm.hotspot.jdi; import sun.jvm.hotspot.oops.Oop; import sun.jvm.hotspot.oops.Instance; import sun.jvm.hotspot.oops.Klass; import sun.jvm.hotspot.memory.SystemDictionary; import sun.jvm.hotspot.memory.Universe; import sun.jvm.hotspot.runtime.VM; import com.sun.jdi.*; import java.util.*; public class ClassLoaderReferenceImpl extends ObjectReferenceImpl implements ClassLoaderReference { // because we work on process snapshot or core we can // cache visibleClasses & definedClasses always (i.e., no suspension) private List visibleClassesCache; private List definedClassesCache; ClassLoaderReferenceImpl(VirtualMachine aVm, Instance oRef) { super(aVm, oRef); } protected String description() { return "ClassLoaderReference " + uniqueID(); } public List definedClasses() { if (definedClassesCache == null) { definedClassesCache = new ArrayList(); Iterator iter = vm.allClasses().iterator(); while (iter.hasNext()) { ReferenceType type = (ReferenceType)iter.next(); if (equals(type.classLoader())) { /* thanks OTI */ definedClassesCache.add(type); } } } return definedClassesCache; } private SystemDictionary getSystemDictionary() { return vm.saSystemDictionary(); } private Universe getUniverse() { return vm.saUniverse(); } public List visibleClasses() { if (visibleClassesCache != null) return visibleClassesCache; visibleClassesCache = new ArrayList(); // refer to getClassLoaderClasses in jvmtiGetLoadedClasses.cpp // a. SystemDictionary::classes_do doesn't include arrays of primitive types (any dimensions) SystemDictionary sysDict = getSystemDictionary(); sysDict.classesDo( new SystemDictionary.ClassAndLoaderVisitor() { public void visit(Klass k, Oop loader) { if (ref().equals(loader)) { for (Klass l = k; l != null; l = l.arrayKlassOrNull()) { visibleClassesCache.add(vm.referenceType(l)); } } } } ); // b. multi dimensional arrays of primitive types sysDict.primArrayClassesDo( new SystemDictionary.ClassAndLoaderVisitor() { public void visit(Klass k, Oop loader) { if (ref().equals(loader)) { visibleClassesCache.add(vm.referenceType(k)); } } } ); // c. single dimensional primitive array klasses from Universe // these are not added to SystemDictionary getUniverse().basicTypeClassesDo( new SystemDictionary.ClassVisitor() { public void visit(Klass k) { visibleClassesCache.add(vm.referenceType(k)); } } ); return visibleClassesCache; } Type findType(String signature) throws ClassNotLoadedException { List types = visibleClasses(); Iterator iter = types.iterator(); while (iter.hasNext()) { ReferenceType type = (ReferenceType)iter.next(); if (type.signature().equals(signature)) { return type; } } JNITypeParser parser = new JNITypeParser(signature); throw new ClassNotLoadedException(parser.typeName(), "Class " + parser.typeName() + " not loaded"); } }