Mercurial > hg > truffle
view agent/src/share/classes/sun/jvm/hotspot/jdi/LongValueImpl.java @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | 37be97a58393 |
children |
line wrap: on
line source
/* * Copyright (c) 2002, 2011, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package sun.jvm.hotspot.jdi; import com.sun.jdi.*; public class LongValueImpl extends PrimitiveValueImpl implements LongValue { private long value; LongValueImpl(VirtualMachine aVm,long aValue) { super(aVm); value = aValue; } public boolean equals(Object obj) { if ((obj != null) && (obj instanceof LongValue)) { return (value == ((LongValue)obj).value()) && super.equals(obj); } else { return false; } } public int hashCode() { /* * TO DO: Better hash code */ return intValue(); } public int compareTo(LongValue longVal) { long other = longVal.value(); if (value() < other) { return -1; } else if (value() == other) { return 0; } else { return 1; } } public Type type() { return vm.theLongType(); } public long value() { return value; } public boolean booleanValue() { return(value == 0)?false:true; } public byte byteValue() { return(byte)value; } public char charValue() { return(char)value; } public short shortValue() { return(short)value; } public int intValue() { return(int)value; } public long longValue() { return(long)value; } public float floatValue() { return(float)value; } public double doubleValue() { return(double)value; } byte checkedByteValue() throws InvalidTypeException { if ((value > Byte.MAX_VALUE) || (value < Byte.MIN_VALUE)) { throw new InvalidTypeException("Can't convert " + value + " to byte"); } else { return super.checkedByteValue(); } } char checkedCharValue() throws InvalidTypeException { if ((value > Character.MAX_VALUE) || (value < Character.MIN_VALUE)) { throw new InvalidTypeException("Can't convert " + value + " to char"); } else { return super.checkedCharValue(); } } short checkedShortValue() throws InvalidTypeException { if ((value > Short.MAX_VALUE) || (value < Short.MIN_VALUE)) { throw new InvalidTypeException("Can't convert " + value + " to short"); } else { return super.checkedShortValue(); } } int checkedIntValue() throws InvalidTypeException { if ((value > Integer.MAX_VALUE) || (value < Integer.MIN_VALUE)) { throw new InvalidTypeException("Can't convert " + value + " to int"); } else { return super.checkedIntValue(); } } public String toString() { return "" + value; } }