Mercurial > hg > truffle
view agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java @ 17716:cdb71841f4bc
6498581: ThreadInterruptTest3 produces wrong output on Windows
Summary: There is race condition between os::interrupt and os::is_interrupted on Windows. In JVM_Sleep(Thread.sleep), check if thread gets interrupted, it may see interrupted but not really interrupted so cause spurious waking up (early return from sleep). Fix by checking if interrupt event really gets set thus prevent false return. For intrinsic of _isInterrupted, on Windows, go fastpath only on bit not set.
Reviewed-by: acorn, kvn
Contributed-by: david.holmes@oracle.com, yumin.qi@oracle.com
author | minqi |
---|---|
date | Wed, 26 Feb 2014 15:20:41 -0800 |
parents | 55fb97c4c58d |
children | 4ca6dc0799b6 |
line wrap: on
line source
/* * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package sun.jvm.hotspot.memory; import java.util.*; import sun.jvm.hotspot.classfile.ClassLoaderData; import sun.jvm.hotspot.debugger.*; import sun.jvm.hotspot.oops.*; import sun.jvm.hotspot.types.*; import sun.jvm.hotspot.runtime.*; import sun.jvm.hotspot.utilities.*; public class DictionaryEntry extends sun.jvm.hotspot.utilities.HashtableEntry { static { VM.registerVMInitializedObserver(new Observer() { public void update(Observable o, Object data) { initialize(VM.getVM().getTypeDataBase()); } }); } private static synchronized void initialize(TypeDataBase db) { Type type = db.lookupType("DictionaryEntry"); pdSetField = type.getAddressField("_pd_set"); loaderDataField = type.getAddressField("_loader_data"); } // Fields private static AddressField pdSetField; private static AddressField loaderDataField; // Accessors public ProtectionDomainEntry pdSet() { Address tmp = pdSetField.getValue(addr); return (ProtectionDomainEntry) VMObjectFactory.newObject( ProtectionDomainEntry.class, tmp); } public Oop loader() { return loaderData().getClassLoader(); } public ClassLoaderData loaderData() { return ClassLoaderData.instantiateWrapperFor(loaderDataField.getValue(addr)); } public Klass klass() { return (Klass)Metadata.instantiateWrapperFor(literalValue()); } public DictionaryEntry(Address addr) { super(addr); } public boolean equals(Symbol className, Oop classLoader) { InstanceKlass ik = (InstanceKlass) klass(); Oop loader = loader(); if (! ik.getName().equals(className)) { return false; } else { return (loader == null)? (classLoader == null) : (loader.equals(classLoader)); } } public boolean isValidProtectionDomain(Oop protectionDomain) { if (protectionDomain == null) { return true; } else { return containsProtectionDomain(protectionDomain); } } public boolean containsProtectionDomain(Oop protectionDomain) { InstanceKlass ik = (InstanceKlass) klass(); // Currently unimplemented and not used. // if (protectionDomain.equals(ik.getJavaMirror().getProtectionDomain())) { // return true; // Succeeds trivially // } for (ProtectionDomainEntry current = pdSet(); current != null; current = current.next()) { if (protectionDomain.equals(current.protectionDomain())) { return true; } } return false; } /* covariant return type :-( public DictionaryEntry next() { return (DictionaryEntry) super.next(); } For now, let the caller cast it .. */ }