Mercurial > hg > truffle
view src/os_cpu/solaris_x86/vm/copy_solaris_x86.inline.hpp @ 10185:d50cc62e94ff
8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr@sap.com>
author | johnc |
---|---|
date | Wed, 24 Apr 2013 14:48:43 -0700 |
parents | f95d63e2154a |
children |
line wrap: on
line source
/* * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ #ifndef OS_CPU_SOLARIS_X86_VM_COPY_SOLARIS_X86_INLINE_HPP #define OS_CPU_SOLARIS_X86_VM_COPY_SOLARIS_X86_INLINE_HPP static void pd_conjoint_words(HeapWord* from, HeapWord* to, size_t count) { (void)memmove(to, from, count * HeapWordSize); } static void pd_disjoint_words(HeapWord* from, HeapWord* to, size_t count) { #ifndef AMD64 (void)memcpy(to, from, count * HeapWordSize); #else switch (count) { case 8: to[7] = from[7]; case 7: to[6] = from[6]; case 6: to[5] = from[5]; case 5: to[4] = from[4]; case 4: to[3] = from[3]; case 3: to[2] = from[2]; case 2: to[1] = from[1]; case 1: to[0] = from[0]; case 0: break; default: (void)memcpy(to, from, count * HeapWordSize); break; } #endif // AMD64 } static void pd_disjoint_words_atomic(HeapWord* from, HeapWord* to, size_t count) { switch (count) { case 8: to[7] = from[7]; case 7: to[6] = from[6]; case 6: to[5] = from[5]; case 5: to[4] = from[4]; case 4: to[3] = from[3]; case 3: to[2] = from[2]; case 2: to[1] = from[1]; case 1: to[0] = from[0]; case 0: break; default: while (count-- > 0) { *to++ = *from++; } break; } } static void pd_aligned_conjoint_words(HeapWord* from, HeapWord* to, size_t count) { (void)memmove(to, from, count * HeapWordSize); } static void pd_aligned_disjoint_words(HeapWord* from, HeapWord* to, size_t count) { pd_disjoint_words(from, to, count); } static void pd_conjoint_bytes(void* from, void* to, size_t count) { #ifdef AMD64 (void)memmove(to, from, count); #else _Copy_conjoint_bytes(from, to, count); #endif // AMD64 } static void pd_conjoint_bytes_atomic(void* from, void* to, size_t count) { pd_conjoint_bytes(from, to, count); } static void pd_conjoint_jshorts_atomic(jshort* from, jshort* to, size_t count) { _Copy_conjoint_jshorts_atomic(from, to, count); } static void pd_conjoint_jints_atomic(jint* from, jint* to, size_t count) { _Copy_conjoint_jints_atomic(from, to, count); } static void pd_conjoint_jlongs_atomic(jlong* from, jlong* to, size_t count) { // Guarantee use of fild/fistp or xmm regs via some asm code, because compilers won't. _Copy_conjoint_jlongs_atomic(from, to, count); } static void pd_conjoint_oops_atomic(oop* from, oop* to, size_t count) { #ifdef AMD64 assert(BytesPerLong == BytesPerOop, "jlongs and oops must be the same size"); _Copy_conjoint_jlongs_atomic((jlong*)from, (jlong*)to, count); #else _Copy_conjoint_jints_atomic((jint*)from, (jint*)to, count); #endif // AMD64 } static void pd_arrayof_conjoint_bytes(HeapWord* from, HeapWord* to, size_t count) { _Copy_arrayof_conjoint_bytes(from, to, count); } static void pd_arrayof_conjoint_jshorts(HeapWord* from, HeapWord* to, size_t count) { _Copy_arrayof_conjoint_jshorts(from, to, count); } static void pd_arrayof_conjoint_jints(HeapWord* from, HeapWord* to, size_t count) { _Copy_arrayof_conjoint_jints(from, to, count); } static void pd_arrayof_conjoint_jlongs(HeapWord* from, HeapWord* to, size_t count) { #ifdef AMD64 _Copy_arrayof_conjoint_jlongs(from, to, count); #else pd_conjoint_jlongs_atomic((jlong*)from, (jlong*)to, count); #endif // AMD64 } static void pd_arrayof_conjoint_oops(HeapWord* from, HeapWord* to, size_t count) { #ifdef AMD64 assert(BytesPerLong == BytesPerOop, "jlongs and oops must be the same size"); _Copy_arrayof_conjoint_jlongs(from, to, count); #else assert(BytesPerInt == BytesPerOop, "jints and oops must be the same size"); _Copy_arrayof_conjoint_jints(from, to, count); #endif // AMD64 } #endif // OS_CPU_SOLARIS_X86_VM_COPY_SOLARIS_X86_INLINE_HPP