Mercurial > hg > truffle
view test/compiler/8011706/Test8011706.java @ 20228:f72d8917322a
8050978: Fix bad field access check in C1 and C2
Summary: JCK8 test vm/constantpool/accessControl/accessControl004/accessControl00402m3/accessControl00402m3.html fails with -Xbatch -Xcomp due to bad field access check in C1 and C2. Fix: In ciField::ciField(), just before the canonical holder is stored into the _holder variable (and which is used by ciField::will_link()) perform an additional access check with the holder declared in the class file. If this check fails, store the declared holder instead and ciField::will_link() will bail out compilation for this field later on. Then, the interpreter will throw an PrivilegedAccessException at runtime.
Reviewed-by: kvn, vlivanov
Contributed-by: andreas.schoesser@sap.com
author | goetz |
---|---|
date | Fri, 18 Jul 2014 09:04:01 +0200 |
parents | 84ab5667f290 |
children |
line wrap: on
line source
/* * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ /* * @test * @bug 8011706 * @summary loop invariant code motion may move load before store to the same field * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation Test8011706 * */ public class Test8011706 { int[] array; void m(boolean test, int[] array1, int[] array2) { int i = 0; if (test) { array = array1; } else { array = array2; } while(true) { int v = array[i]; i++; if (i >= 10) return; } } static public void main(String[] args) { int[] new_array = new int[10]; Test8011706 ti = new Test8011706(); boolean failed = false; try { for (int i = 0; i < 10000; i++) { ti.array = null; ti.m(true, new_array, new_array); } } catch(NullPointerException ex) { throw new RuntimeException("TEST FAILED", ex); } System.out.println("TEST PASSED"); } }