Mercurial > hg > truffle
view test/serviceability/jvmti/UnresolvedClassAgent.java @ 20228:f72d8917322a
8050978: Fix bad field access check in C1 and C2
Summary: JCK8 test vm/constantpool/accessControl/accessControl004/accessControl00402m3/accessControl00402m3.html fails with -Xbatch -Xcomp due to bad field access check in C1 and C2. Fix: In ciField::ciField(), just before the canonical holder is stored into the _holder variable (and which is used by ciField::will_link()) perform an additional access check with the holder declared in the class file. If this check fails, store the declared holder instead and ciField::will_link() will bail out compilation for this field later on. Then, the interpreter will throw an PrivilegedAccessException at runtime.
Reviewed-by: kvn, vlivanov
Contributed-by: andreas.schoesser@sap.com
author | goetz |
---|---|
date | Fri, 18 Jul 2014 09:04:01 +0200 |
parents | 53094b350323 |
children |
line wrap: on
line source
/* * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ import java.io.DataInputStream; import java.io.File; import java.io.FileInputStream; import java.lang.instrument.ClassDefinition; import java.lang.instrument.Instrumentation; /* * This class is present during compilation, but will be deleted before execution. */ class MyUnresolvedClass { static void bar() { } } class MyRedefinedClass { static void foo() { MyUnresolvedClass.bar(); } } public class UnresolvedClassAgent { public static void main(String... args) { } public static void premain(String args, Instrumentation inst) throws Exception { try { MyRedefinedClass.foo(); } catch(NoClassDefFoundError err) { System.out.println("NoClassDefFoundError (expected)"); } File f = new File(System.getProperty("test.classes"), "MyRedefinedClass.class"); byte[] buf = new byte[(int)f.length()]; try (DataInputStream dis = new DataInputStream(new FileInputStream(f))) { dis.readFully(buf); } ClassDefinition cd = new ClassDefinition(MyRedefinedClass.class, buf); inst.redefineClasses(new ClassDefinition[] {cd}); try { MyRedefinedClass.foo(); } catch(NoClassDefFoundError err) { System.out.println("NoClassDefFoundError (expected again)"); } } }