# HG changeset patch # User Doug Simon # Date 1423658948 -3600 # Node ID 131fb3dd493b2d7d33d3b70de7d99a51d6de0999 # Parent 835e950b38b987fe9269f7820978faa43d63ac83 removed unnecessary use of an Assumptions object diff -r 835e950b38b9 -r 131fb3dd493b graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/Assumptions.java --- a/graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/Assumptions.java Wed Feb 11 13:39:33 2015 +0100 +++ b/graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/Assumptions.java Wed Feb 11 13:49:08 2015 +0100 @@ -385,7 +385,7 @@ /** * Gets a copy of the assumptions recorded in this object as an array. */ - public Assumption[] getAssumptionsCopy() { + public Assumption[] toArray() { return assumptions.toArray(new Assumption[assumptions.size()]); } diff -r 835e950b38b9 -r 131fb3dd493b graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/CompilationResult.java --- a/graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/CompilationResult.java Wed Feb 11 13:39:33 2015 +0100 +++ b/graal/com.oracle.graal.api.code/src/com/oracle/graal/api/code/CompilationResult.java Wed Feb 11 13:49:08 2015 +0100 @@ -607,8 +607,8 @@ this.entryBCI = entryBCI; } - public void setAssumptions(Assumptions assumptions) { - this.assumptions = assumptions.getAssumptionsCopy(); + public void setAssumptions(Assumption[] assumptions) { + this.assumptions = assumptions; } /** diff -r 835e950b38b9 -r 131fb3dd493b graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/GraalCompiler.java --- a/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/GraalCompiler.java Wed Feb 11 13:39:33 2015 +0100 +++ b/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/GraalCompiler.java Wed Feb 11 13:49:08 2015 +0100 @@ -370,7 +370,7 @@ backend.emitCode(crb, lirGenRes.getLIR(), installedCodeOwner); crb.finish(); if (!assumptions.isEmpty()) { - compilationResult.setAssumptions(assumptions); + compilationResult.setAssumptions(assumptions.toArray()); } if (Debug.isMeterEnabled()) { diff -r 835e950b38b9 -r 131fb3dd493b graal/com.oracle.graal.truffle/src/com/oracle/graal/truffle/TruffleCompilerImpl.java --- a/graal/com.oracle.graal.truffle/src/com/oracle/graal/truffle/TruffleCompilerImpl.java Wed Feb 11 13:39:33 2015 +0100 +++ b/graal/com.oracle.graal.truffle/src/com/oracle/graal/truffle/TruffleCompilerImpl.java Wed Feb 11 13:49:08 2015 +0100 @@ -167,7 +167,7 @@ compilationNotify.notifyCompilationGraalTierFinished((OptimizedCallTarget) predefinedInstalledCode, graph); List validAssumptions = new ArrayList<>(); - Assumptions newAssumptions = new Assumptions(true); + Set newAssumptions = new HashSet<>(); for (Assumption assumption : graph.getAssumptions()) { processAssumption(newAssumptions, assumption, validAssumptions); } @@ -178,7 +178,7 @@ } } - result.setAssumptions(newAssumptions); + result.setAssumptions(newAssumptions.toArray(new Assumption[newAssumptions.size()])); InstalledCode installedCode; try (Scope s = Debug.scope("CodeInstall", providers.getCodeCache()); TimerCloseable a = CodeInstallationTime.start(); Closeable c = CodeInstallationMemUse.start()) { @@ -217,13 +217,13 @@ return new GraphBuilderSuiteInfo(suite, plugins); } - public void processAssumption(Assumptions newAssumptions, Assumption assumption, List manual) { + public void processAssumption(Set newAssumptions, Assumption assumption, List manual) { if (assumption != null) { if (assumption instanceof AssumptionValidAssumption) { AssumptionValidAssumption assumptionValidAssumption = (AssumptionValidAssumption) assumption; manual.add(assumptionValidAssumption); } else { - newAssumptions.record(assumption); + newAssumptions.add(assumption); } } }