# HG changeset patch
# User stefank
# Date 1355348473 -3600
# Node ID 1b1e16471e46d7da9cf13cfa1e600390e7e5dae4
# Parent  a70c88896791345753b541ec3bc023003cfea0f5
8005002: Crash because of a raw oop in ClassLoaderData::add_dependency
Summary: Move the handelization of 'last' to a point before the GC might enter.
Reviewed-by: dholmes, sspitsyn, coleenp

diff -r a70c88896791 -r 1b1e16471e46 src/share/vm/classfile/classLoaderData.cpp
--- a/src/share/vm/classfile/classLoaderData.cpp	Thu Dec 13 17:27:55 2012 -0800
+++ b/src/share/vm/classfile/classLoaderData.cpp	Wed Dec 12 22:41:13 2012 +0100
@@ -167,16 +167,18 @@
     ok = (objArrayOop)ok->obj_at(1);
   }
 
+  // Must handle over GC points
+  assert (last != NULL, "dependencies should be initialized");
+  objArrayHandle last_handle(THREAD, last);
+
   // Create a new dependency node with fields for (class_loader or mirror, next)
   objArrayOop deps = oopFactory::new_objectArray(2, CHECK);
   deps->obj_at_put(0, dependency());
 
-  // Must handle over more GC points
+  // Must handle over GC points
   objArrayHandle new_dependency(THREAD, deps);
 
   // Add the dependency under lock
-  assert (last != NULL, "dependencies should be initialized");
-  objArrayHandle last_handle(THREAD, last);
   locked_add_dependency(last_handle, new_dependency);
 }