# HG changeset patch # User ehelin # Date 1385995384 -3600 # Node ID 9fc985481d7898ea55be4ebe251d3d8108821533 # Parent 55a0da3d420b4d64d337d9a7dbf2964033d063b5# Parent 3fbb71fdc6e5cab6b6dec7295d95ddd957e1aa81 Merge diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/gc_implementation/shared/markSweep.cpp --- a/src/share/vm/gc_implementation/shared/markSweep.cpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/gc_implementation/shared/markSweep.cpp Mon Dec 02 15:43:04 2013 +0100 @@ -66,29 +66,10 @@ klass->oops_do(&MarkSweep::adjust_pointer_closure); } -void MarkSweep::follow_klass(Klass* klass) { - ClassLoaderData* cld = klass->class_loader_data(); - // The actual processing of the klass is done when we - // traverse the list of Klasses in the class loader data. - MarkSweep::follow_class_loader(cld); -} - -void MarkSweep::adjust_klass(Klass* klass) { - ClassLoaderData* cld = klass->class_loader_data(); - // The actual processing of the klass is done when we - // traverse the list of Klasses in the class loader data. - MarkSweep::adjust_class_loader(cld); -} - void MarkSweep::follow_class_loader(ClassLoaderData* cld) { cld->oops_do(&MarkSweep::mark_and_push_closure, &MarkSweep::follow_klass_closure, true); } -void MarkSweep::adjust_class_loader(ClassLoaderData* cld) { - cld->oops_do(&MarkSweep::adjust_pointer_closure, &MarkSweep::adjust_klass_closure, true); -} - - void MarkSweep::follow_stack() { do { while (!_marking_stack.is_empty()) { diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/gc_implementation/shared/markSweep.hpp --- a/src/share/vm/gc_implementation/shared/markSweep.hpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/gc_implementation/shared/markSweep.hpp Mon Dec 02 15:43:04 2013 +0100 @@ -172,10 +172,8 @@ static void follow_stack(); // Empty marking stack. static void follow_klass(Klass* klass); - static void adjust_klass(Klass* klass); static void follow_class_loader(ClassLoaderData* cld); - static void adjust_class_loader(ClassLoaderData* cld); static void preserve_mark(oop p, markOop mark); // Save the mark word so it can be restored later diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/gc_implementation/shared/markSweep.inline.hpp --- a/src/share/vm/gc_implementation/shared/markSweep.inline.hpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/gc_implementation/shared/markSweep.inline.hpp Mon Dec 02 15:43:04 2013 +0100 @@ -44,6 +44,11 @@ } } +inline void MarkSweep::follow_klass(Klass* klass) { + oop op = klass->klass_holder(); + MarkSweep::mark_and_push(&op); +} + template inline void MarkSweep::follow_root(T* p) { assert(!Universe::heap()->is_in_reserved(p), "roots shouldn't be things within the heap"); diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/oops/instanceKlass.cpp --- a/src/share/vm/oops/instanceKlass.cpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/oops/instanceKlass.cpp Mon Dec 02 15:43:04 2013 +0100 @@ -2169,7 +2169,6 @@ obj, \ MarkSweep::adjust_pointer(p), \ assert_is_in) - MarkSweep::adjust_klass(obj->klass()); return size; } diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/oops/instanceMirrorKlass.cpp --- a/src/share/vm/oops/instanceMirrorKlass.cpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/oops/instanceMirrorKlass.cpp Mon Dec 02 15:43:04 2013 +0100 @@ -155,7 +155,13 @@ // Follow the klass field in the mirror. Klass* klass = java_lang_Class::as_Klass(obj); if (klass != NULL) { - MarkSweep::follow_klass(klass); + // For anonymous classes we need to handle the class loader data, + // otherwise it won't be claimed and can be unloaded. + if (klass->oop_is_instance() && InstanceKlass::cast(klass)->is_anonymous()) { + MarkSweep::follow_class_loader(klass->class_loader_data()); + } else { + MarkSweep::follow_klass(klass); + } } else { // If klass is NULL then this a mirror for a primitive type. // We don't have to follow them, since they are handled as strong @@ -196,17 +202,6 @@ int size = oop_size(obj); InstanceKlass::oop_adjust_pointers(obj); - // Follow the klass field in the mirror. - Klass* klass = java_lang_Class::as_Klass(obj); - if (klass != NULL) { - MarkSweep::adjust_klass(klass); - } else { - // If klass is NULL then this a mirror for a primitive type. - // We don't have to follow them, since they are handled as strong - // roots in Universe::oops_do. - assert(java_lang_Class::is_primitive(obj), "Sanity check"); - } - InstanceMirrorKlass_OOP_ITERATE( \ start_of_static_fields(obj), java_lang_Class::static_oop_field_count(obj), \ MarkSweep::adjust_pointer(p), \ diff -r 3fbb71fdc6e5 -r 9fc985481d78 src/share/vm/oops/objArrayKlass.cpp --- a/src/share/vm/oops/objArrayKlass.cpp Sun Dec 01 22:35:15 2013 -0500 +++ b/src/share/vm/oops/objArrayKlass.cpp Mon Dec 02 15:43:04 2013 +0100 @@ -569,7 +569,6 @@ // Get size before changing pointers. // Don't call size() or oop_size() since that is a virtual call. int size = a->object_size(); - MarkSweep::adjust_klass(a->klass()); ObjArrayKlass_OOP_ITERATE(a, p, MarkSweep::adjust_pointer(p)) return size; }