# HG changeset patch # User dcubed # Date 1337357715 25200 # Node ID 4b37c0dafe3aadfbc55d922b3733cd23e2948292 # Parent 198dcc84088c95abc155a98446d5974ed7751bee 7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Summary: Always disable ZIP_DEBUGINFO_FILES on Windows. Reviewed-by: acorn diff -r 198dcc84088c -r 4b37c0dafe3a make/windows/makefiles/defs.make --- a/make/windows/makefiles/defs.make Wed May 16 12:47:27 2012 -0700 +++ b/make/windows/makefiles/defs.make Fri May 18 09:15:15 2012 -0700 @@ -145,7 +145,12 @@ ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) # Disable ZIP_DEBUGINFO_FILES by default because various tests are # failing in nightly when the debug info files are ZIP'ed. - ZIP_DEBUGINFO_FILES ?= 0 + #ZIP_DEBUGINFO_FILES ?= 0 + # The above conditional setting logic is unreliable on Windows for + # unknown reasons. We force ZIP_DEBUGINFO_FILES to be disabled on + # Windows until we figure out why the various tests are failing + # AND why the conditional setting logic is unreliable. + ZIP_DEBUGINFO_FILES=0 else ZIP_DEBUGINFO_FILES=0 endif