# HG changeset patch # User Doug Simon # Date 1426165863 -3600 # Node ID 73dddd2d87104b1f01de45cabf30dc7668de91e7 # Parent ad32fd810c838275d424f602cb40e7d03510febd moved bytecode paring options to AbstractBytecodeParser.Options diff -r ad32fd810c83 -r 73dddd2d8710 graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/GraalOptions.java --- a/graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/GraalOptions.java Thu Mar 12 12:45:04 2015 +0100 +++ b/graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/GraalOptions.java Thu Mar 12 14:11:03 2015 +0100 @@ -134,9 +134,6 @@ @Option(help = "", type = OptionType.Debug) public static final OptionValue PrintFilter = new OptionValue<>(null); - @Option(help = "", type = OptionType.Debug) - public static final StableOptionValue DumpDuringGraphBuilding = new StableOptionValue<>(false); - // Debug settings: @Option(help = "", type = OptionType.Debug) public static final OptionValue BootstrapReplacements = new OptionValue<>(false); @@ -324,13 +321,6 @@ @Option(help = "Mark well-known stable fields as such.", type = OptionType.Debug) public static final OptionValue ImplicitStableValues = new OptionValue<>(true); - - @Option(help = "Max number of loop explosions per method.", type = OptionType.Debug) - public static final OptionValue MaximumLoopExplosionCount = new OptionValue<>(10000); - - @Option(help = "Do not bail out but throw an exception on failed loop explosion.", type = OptionType.Debug) - public static final OptionValue FailedLoopExplosionIsFatal = new OptionValue<>(false); - /** * Counts the various paths taken through snippets. */ diff -r ad32fd810c83 -r 73dddd2d8710 graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractBytecodeParser.java --- a/graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractBytecodeParser.java Thu Mar 12 12:45:04 2015 +0100 +++ b/graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractBytecodeParser.java Thu Mar 12 14:11:03 2015 +0100 @@ -27,6 +27,7 @@ import static com.oracle.graal.api.meta.DeoptimizationReason.*; import static com.oracle.graal.bytecode.Bytecodes.*; import static com.oracle.graal.java.AbstractBytecodeParser.Options.*; + import java.util.*; import com.oracle.graal.api.code.*; @@ -51,18 +52,27 @@ @Option(help = "The trace level for the bytecode parser used when building a graph from bytecode", type = OptionType.Debug) public static final OptionValue TraceBytecodeParserLevel = new OptionValue<>(0); - @Option(help = "Inlines trivial methods during parsing of the bytecodes.", type = OptionType.Expert) + @Option(help = "Inlines trivial methods during bytecode parsing.", type = OptionType.Expert) public static final StableOptionValue InlineDuringParsing = new StableOptionValue<>(false); - @Option(help = "Traces inlining eagerly performed during bytecode parsing", type = OptionType.Debug) + @Option(help = "Traces inlining performed during bytecode parsing.", type = OptionType.Debug) public static final StableOptionValue TraceInlineDuringParsing = new StableOptionValue<>(false); - @Option(help = "Traces use of bytecode parser plugins", type = OptionType.Debug) + @Option(help = "Traces use of plugins during bytecode parsing.", type = OptionType.Debug) public static final StableOptionValue TraceParserPlugins = new StableOptionValue<>(false); - @Option(help = "Maximum depth when inlining during parsing.", type = OptionType.Debug) + @Option(help = "Maximum depth when inlining during bytecode parsing.", type = OptionType.Debug) public static final StableOptionValue InlineDuringParsingMaxDepth = new StableOptionValue<>(10); + @Option(help = "Dump graphs after non-trivial changes during bytecode parsing.", type = OptionType.Debug) + public static final StableOptionValue DumpDuringGraphBuilding = new StableOptionValue<>(false); + + @Option(help = "Max number of loop explosions per method.", type = OptionType.Debug) + public static final OptionValue MaximumLoopExplosionCount = new OptionValue<>(10000); + + @Option(help = "Do not bail out but throw an exception on failed loop explosion.", type = OptionType.Debug) + public static final OptionValue FailedLoopExplosionIsFatal = new OptionValue<>(false); + // @formatter:on } diff -r ad32fd810c83 -r 73dddd2d8710 graal/com.oracle.graal.java/src/com/oracle/graal/java/GraphBuilderPhase.java --- a/graal/com.oracle.graal.java/src/com/oracle/graal/java/GraphBuilderPhase.java Thu Mar 12 12:45:04 2015 +0100 +++ b/graal/com.oracle.graal.java/src/com/oracle/graal/java/GraphBuilderPhase.java Thu Mar 12 14:11:03 2015 +0100 @@ -461,7 +461,7 @@ for (int i = loopBegins.size() - 1; i >= 0; --i) { LoopBeginNode loopBegin = loopBegins.get(i); insertLoopExits(loopBegin, innerLoopsMap); - if (GraalOptions.DumpDuringGraphBuilding.getValue()) { + if (DumpDuringGraphBuilding.getValue()) { Debug.dump(currentGraph, "After building loop exits for %s.", loopBegin); } } @@ -527,7 +527,7 @@ for (LoopBeginNode inner : innerLoopBegins) { addLoopExits(loopBegin, inner, innerLoopsMap, visited); - if (GraalOptions.DumpDuringGraphBuilding.getValue()) { + if (DumpDuringGraphBuilding.getValue()) { Debug.dump(currentGraph, "After adding loop exits for %s.", inner); } }