# HG changeset patch # User Doug Simon # Date 1377007766 -7200 # Node ID 7e297d001c30381fc73870ee8319431ef6f07631 # Parent 0fbc1e418c88c57f9f2f4f8313d07bb41a7beb83 option annotation processor ensures that a non-empty help message starts with a capital letter diff -r 0fbc1e418c88 -r 7e297d001c30 graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionProcessor.java --- a/graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionProcessor.java Tue Aug 20 15:33:39 2013 +0200 +++ b/graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionProcessor.java Tue Aug 20 16:09:26 2013 +0200 @@ -87,6 +87,15 @@ return; } + String help = annotation.help(); + if (help.length() != 0) { + char firstChar = help.charAt(0); + if (!Character.isUpperCase(firstChar)) { + processingEnv.getMessager().printMessage(Kind.ERROR, "Option help text must start with upper case letter", element); + return; + } + } + String optionName = annotation.name(); if (optionName.equals("")) { optionName = fieldName; @@ -118,7 +127,7 @@ enclosing = enclosing.getEnclosingElement(); } - info.options.add(new OptionInfo(optionName, annotation.help(), optionType, declaringClass, field)); + info.options.add(new OptionInfo(optionName, help, optionType, declaringClass, field)); } private void createFiles(OptionsInfo info) {