# HG changeset patch # User Bernhard Urban # Date 1368455877 -7200 # Node ID 843dde5a83afd79a68ce9675a884b7d108d2c6cd # Parent 822adbb2ee7b38a95078a067172bc49c6a247820 VerifyValueUsage: move String creation to assert diff -r 822adbb2ee7b -r 843dde5a83af graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java --- a/graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java Mon May 13 15:55:41 2013 +0200 +++ b/graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java Mon May 13 16:37:57 2013 +0200 @@ -51,9 +51,9 @@ @Override protected boolean verify(StructuredGraph graph) { for (ObjectEqualsNode cn : graph.getNodes().filter(ObjectEqualsNode.class)) { - String desc = "VerifyValueUsage: " + cn.x() + " or " + cn.y() + " in " + graph.method() + " uses object identity. Should use equals() instead."; if (!graph.method().toString().endsWith("equals(Object)>")) { - assert !((checkType(cn.x()) && !(cn.y() instanceof ConstantNode)) || (checkType(cn.y()) && !(cn.x() instanceof ConstantNode))) : desc; + assert !((checkType(cn.x()) && !(cn.y() instanceof ConstantNode)) || (checkType(cn.y()) && !(cn.x() instanceof ConstantNode))) : "VerifyValueUsage: " + cn.x() + " or " + cn.y() + + " in " + graph.method() + " uses object identity. Should use equals() instead."; } } return true;