# HG changeset patch # User Doug Simon # Date 1358976465 -3600 # Node ID a0298e142ea83831000cf23d07669bf208010742 # Parent aee6ce29fb177e7751b9052db94896f2d3882395 factored out common code shared by InstanceOfSnippets and CheckCastSnippets diff -r aee6ce29fb17 -r a0298e142ea8 graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/CheckCastSnippets.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/CheckCastSnippets.java Wed Jan 23 21:56:28 2013 +0100 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/CheckCastSnippets.java Wed Jan 23 22:27:45 2013 +0100 @@ -22,7 +22,10 @@ */ package com.oracle.graal.hotspot.snippets; +import static com.oracle.graal.api.code.DeoptimizationAction.*; +import static com.oracle.graal.api.meta.DeoptimizationReason.*; import static com.oracle.graal.hotspot.snippets.HotSpotSnippetUtils.*; +import static com.oracle.graal.hotspot.snippets.TypeCheckSnippetUtils.*; import static com.oracle.graal.snippets.SnippetTemplate.*; import static com.oracle.graal.snippets.SnippetTemplate.Arguments.*; import static com.oracle.graal.snippets.nodes.BranchProbabilityNode.*; @@ -30,7 +33,6 @@ import com.oracle.graal.api.code.*; import com.oracle.graal.api.meta.*; import com.oracle.graal.debug.*; -import com.oracle.graal.graph.*; import com.oracle.graal.graph.Node.NodeIntrinsic; import com.oracle.graal.hotspot.meta.*; import com.oracle.graal.nodes.*; @@ -81,7 +83,7 @@ probability(0.01); exactMiss.inc(); //bkpt(object, exactHub, objectHub); - DeoptimizeNode.deopt(DeoptimizationAction.InvalidateReprofile, DeoptimizationReason.ClassCastException); + DeoptimizeNode.deopt(InvalidateReprofile, ClassCastException); } exactHit.inc(); return object; @@ -107,7 +109,7 @@ Word objectHub = loadHub(object); if (objectHub.readWord(superCheckOffset) != hub) { displayMiss.inc(); - DeoptimizeNode.deopt(DeoptimizationAction.InvalidateReprofile, DeoptimizationReason.ClassCastException); + DeoptimizeNode.deopt(InvalidateReprofile, ClassCastException); } displayHit.inc(); return object; @@ -137,7 +139,7 @@ } } if (!checkSecondarySubType(hub, objectHub)) { - DeoptimizeNode.deopt(DeoptimizationAction.InvalidateReprofile, DeoptimizationReason.ClassCastException); + DeoptimizeNode.deopt(InvalidateReprofile, ClassCastException); } return object; } @@ -157,84 +159,11 @@ } Word objectHub = loadHub(object); if (!checkUnknownSubType(hub, objectHub)) { - DeoptimizeNode.deopt(DeoptimizationAction.InvalidateReprofile, DeoptimizationReason.ClassCastException); + DeoptimizeNode.deopt(InvalidateReprofile, ClassCastException); } return object; } - static Word loadWordElement(Word metaspaceArray, int index) { - return metaspaceArray.readWord(metaspaceArrayBaseOffset() + index * wordSize()); - } - - static boolean checkSecondarySubType(Word t, Word s) { - // if (S.cache == T) return true - if (s.readWord(secondarySuperCacheOffset()) == t) { - cacheHit.inc(); - return true; - } - - // if (T == S) return true - if (s == t) { - T_equals_S.inc(); - return true; - } - - // if (S.scan_s_s_array(T)) { S.cache = T; return true; } - Word secondarySupers = s.readWord(secondarySupersOffset()); - int length = secondarySupers.readInt(metaspaceArrayLengthOffset()); - for (int i = 0; i < length; i++) { - if (t == loadWordElement(secondarySupers, i)) { - s.writeWord(secondarySuperCacheOffset(), t); - secondariesHit.inc(); - return true; - } - } - secondariesMiss.inc(); - return false; - } - - static boolean checkUnknownSubType(Word t, Word s) { - // int off = T.offset - int superCheckOffset = t.readInt(superCheckOffsetOffset()); - boolean primary = superCheckOffset != secondarySuperCacheOffset(); - - // if (T = S[off]) return true - if (s.readWord(superCheckOffset) == t) { - if (primary) { - cacheHit.inc(); - } else { - displayHit.inc(); - } - return true; - } - - // if (off != &cache) return false - if (primary) { - displayMiss.inc(); - return false; - } - - // if (T == S) return true - if (s == t) { - T_equals_S.inc(); - return true; - } - - // if (S.scan_s_s_array(T)) { S.cache = T; return true; } - Word secondarySupers = s.readWord(secondarySupersOffset()); - int length = secondarySupers.readInt(metaspaceArrayLengthOffset()); - for (int i = 0; i < length; i++) { - if (t == loadWordElement(secondarySupers, i)) { - s.writeWord(secondarySuperCacheOffset(), t); - secondariesHit.inc(); - return true; - } - } - - secondariesMiss.inc(); - return false; - } - // @formatter:on public static class Templates extends AbstractTemplates { @@ -301,25 +230,5 @@ Debug.log("Lowering dynamic checkcast in %s: node=%s, template=%s, arguments=%s", graph, checkcast, template, arguments); template.instantiate(runtime, checkcast, DEFAULT_REPLACER, arguments); } - - static ConstantNode[] createHints(TypeCheckHints hints, MetaAccessProvider runtime, Graph graph) { - ConstantNode[] hintHubs = new ConstantNode[hints.types.length]; - for (int i = 0; i < hintHubs.length; i++) { - hintHubs[i] = ConstantNode.forConstant(((HotSpotResolvedObjectType) hints.types[i]).klass(), runtime, graph); - } - return hintHubs; - } } - - private static final SnippetCounter.Group counters = GraalOptions.SnippetCounters ? new SnippetCounter.Group("Checkcast") : null; - private static final SnippetCounter hintsHit = new SnippetCounter(counters, "hintsHit", "hit a hint type"); - private static final SnippetCounter exactHit = new SnippetCounter(counters, "exactHit", "exact type test succeeded"); - private static final SnippetCounter exactMiss = new SnippetCounter(counters, "exactMiss", "exact type test failed"); - private static final SnippetCounter isNull = new SnippetCounter(counters, "isNull", "object tested was null"); - private static final SnippetCounter cacheHit = new SnippetCounter(counters, "cacheHit", "secondary type cache hit"); - private static final SnippetCounter secondariesHit = new SnippetCounter(counters, "secondariesHit", "secondaries scan succeeded"); - private static final SnippetCounter secondariesMiss = new SnippetCounter(counters, "secondariesMiss", "secondaries scan failed"); - private static final SnippetCounter displayHit = new SnippetCounter(counters, "displayHit", "primary type test succeeded"); - private static final SnippetCounter displayMiss = new SnippetCounter(counters, "displayMiss", "primary type test failed"); - private static final SnippetCounter T_equals_S = new SnippetCounter(counters, "T_equals_S", "object type was equal to secondary type"); } diff -r aee6ce29fb17 -r a0298e142ea8 graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/InstanceOfSnippets.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/InstanceOfSnippets.java Wed Jan 23 21:56:28 2013 +0100 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/InstanceOfSnippets.java Wed Jan 23 22:27:45 2013 +0100 @@ -22,9 +22,8 @@ */ package com.oracle.graal.hotspot.snippets; -import static com.oracle.graal.hotspot.snippets.CheckCastSnippets.*; -import static com.oracle.graal.hotspot.snippets.CheckCastSnippets.Templates.*; import static com.oracle.graal.hotspot.snippets.HotSpotSnippetUtils.*; +import static com.oracle.graal.hotspot.snippets.TypeCheckSnippetUtils.*; import static com.oracle.graal.snippets.SnippetTemplate.Arguments.*; import static com.oracle.graal.snippets.nodes.BranchProbabilityNode.*; @@ -142,34 +141,6 @@ return trueValue; } - static boolean checkSecondarySubType(Word t, Word s) { - // if (S.cache == T) return true - if (s.readWord(secondarySuperCacheOffset()) == t) { - cacheHit.inc(); - return true; - } - - // if (T == S) return true - if (s == t) { - T_equals_S.inc(); - return true; - } - - // if (S.scan_s_s_array(T)) { S.cache = T; return true; } - Word secondarySupers = s.readWord(secondarySupersOffset()); - int length = secondarySupers.readInt(metaspaceArrayLengthOffset()); - for (int i = 0; i < length; i++) { - if (t == loadWordElement(secondarySupers, i)) { - probability(0.01); - s.writeWord(secondarySuperCacheOffset(), t); - secondariesHit.inc(); - return true; - } - } - secondariesMiss.inc(); - return false; - } - /** * Type test used when the type being tested against is not known at compile time. */ @@ -252,16 +223,4 @@ } } } - - private static final SnippetCounter.Group counters = GraalOptions.SnippetCounters ? new SnippetCounter.Group("InstanceOf") : null; - private static final SnippetCounter hintsHit = new SnippetCounter(counters, "hintsHit", "hit a hint type"); - private static final SnippetCounter exactHit = new SnippetCounter(counters, "exactHit", "exact type test succeeded"); - private static final SnippetCounter exactMiss = new SnippetCounter(counters, "exactMiss", "exact type test failed"); - private static final SnippetCounter isNull = new SnippetCounter(counters, "isNull", "object tested was null"); - private static final SnippetCounter cacheHit = new SnippetCounter(counters, "cacheHit", "secondary type cache hit"); - private static final SnippetCounter secondariesHit = new SnippetCounter(counters, "secondariesHit", "secondaries scan succeeded"); - private static final SnippetCounter secondariesMiss = new SnippetCounter(counters, "secondariesMiss", "secondaries scan failed"); - private static final SnippetCounter displayHit = new SnippetCounter(counters, "displayHit", "primary type test succeeded"); - private static final SnippetCounter displayMiss = new SnippetCounter(counters, "displayMiss", "primary type test failed"); - private static final SnippetCounter T_equals_S = new SnippetCounter(counters, "T_equals_S", "object type was equal to secondary type"); } diff -r aee6ce29fb17 -r a0298e142ea8 graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/TypeCheckSnippetUtils.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/snippets/TypeCheckSnippetUtils.java Wed Jan 23 22:27:45 2013 +0100 @@ -0,0 +1,122 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +package com.oracle.graal.hotspot.snippets; + +import static com.oracle.graal.hotspot.snippets.HotSpotSnippetUtils.*; +import static com.oracle.graal.snippets.nodes.BranchProbabilityNode.*; + +import com.oracle.graal.api.code.*; +import com.oracle.graal.api.meta.*; +import com.oracle.graal.graph.*; +import com.oracle.graal.hotspot.meta.*; +import com.oracle.graal.nodes.*; +import com.oracle.graal.phases.*; +import com.oracle.graal.snippets.*; +import com.oracle.graal.word.*; + +/** + * Utilities and common code paths used by the type check snippets. + */ +public class TypeCheckSnippetUtils { + + static boolean checkSecondarySubType(Word t, Word s) { + // if (S.cache == T) return true + if (s.readWord(secondarySuperCacheOffset()) == t) { + cacheHit.inc(); + return true; + } + + return checkSelfAndSupers(t, s); + } + + static boolean checkUnknownSubType(Word t, Word s) { + // int off = T.offset + int superCheckOffset = t.readInt(superCheckOffsetOffset()); + boolean primary = superCheckOffset != secondarySuperCacheOffset(); + + // if (T = S[off]) return true + if (s.readWord(superCheckOffset) == t) { + if (primary) { + cacheHit.inc(); + } else { + displayHit.inc(); + } + return true; + } + + // if (off != &cache) return false + if (primary) { + displayMiss.inc(); + return false; + } + + return checkSelfAndSupers(t, s); + } + + private static boolean checkSelfAndSupers(Word t, Word s) { + // if (T == S) return true + if (s == t) { + T_equals_S.inc(); + return true; + } + + // if (S.scan_s_s_array(T)) { S.cache = T; return true; } + Word secondarySupers = s.readWord(secondarySupersOffset()); + int length = secondarySupers.readInt(metaspaceArrayLengthOffset()); + for (int i = 0; i < length; i++) { + if (t == loadWordElement(secondarySupers, i)) { + probability(0.01); + s.writeWord(secondarySuperCacheOffset(), t); + secondariesHit.inc(); + return true; + } + } + secondariesMiss.inc(); + return false; + } + + static ConstantNode[] createHints(TypeCheckHints hints, MetaAccessProvider runtime, Graph graph) { + ConstantNode[] hintHubs = new ConstantNode[hints.types.length]; + for (int i = 0; i < hintHubs.length; i++) { + hintHubs[i] = ConstantNode.forConstant(((HotSpotResolvedObjectType) hints.types[i]).klass(), runtime, graph); + } + return hintHubs; + } + + static Word loadWordElement(Word metaspaceArray, int index) { + return metaspaceArray.readWord(metaspaceArrayBaseOffset() + index * wordSize()); + } + + private static final SnippetCounter.Group counters = GraalOptions.SnippetCounters ? new SnippetCounter.Group("TypeCheck") : null; + static final SnippetCounter hintsHit = new SnippetCounter(counters, "hintsHit", "hit a hint type"); + static final SnippetCounter exactHit = new SnippetCounter(counters, "exactHit", "exact type test succeeded"); + static final SnippetCounter exactMiss = new SnippetCounter(counters, "exactMiss", "exact type test failed"); + static final SnippetCounter isNull = new SnippetCounter(counters, "isNull", "object tested was null"); + static final SnippetCounter cacheHit = new SnippetCounter(counters, "cacheHit", "secondary type cache hit"); + static final SnippetCounter secondariesHit = new SnippetCounter(counters, "secondariesHit", "secondaries scan succeeded"); + static final SnippetCounter secondariesMiss = new SnippetCounter(counters, "secondariesMiss", "secondaries scan failed"); + static final SnippetCounter displayHit = new SnippetCounter(counters, "displayHit", "primary type test succeeded"); + static final SnippetCounter displayMiss = new SnippetCounter(counters, "displayMiss", "primary type test failed"); + static final SnippetCounter T_equals_S = new SnippetCounter(counters, "T_equals_S", "object type was equal to secondary type"); + +}